* [PATCH qemu] scripts: Detect git worktrees for get_maintainer.pl --git
@ 2019-11-12 3:45 Alexey Kardashevskiy
2019-11-12 8:50 ` Stefano Garzarella
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Alexey Kardashevskiy @ 2019-11-12 3:45 UTC (permalink / raw)
To: qemu-devel; +Cc: Alexey Kardashevskiy, qemu-trivial, qemu-ppc, Paolo Bonzini
Recent git versions support worktrees where .git is not a directory but
a file with a path to the .git repository; however the get_maintainer.pl
script only recognises the .git directory, let's fix it.
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
scripts/get_maintainer.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 71415e3c7061..27991eb1cfb4 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -81,7 +81,7 @@ my %VCS_cmds;
my %VCS_cmds_git = (
"execute_cmd" => \&git_execute_cmd,
- "available" => '(which("git") ne "") && (-d ".git")',
+ "available" => '(which("git") ne "") && (-e ".git")',
"find_signers_cmd" =>
"git log --no-color --follow --since=\$email_git_since " .
'--format="GitCommit: %H%n' .
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH qemu] scripts: Detect git worktrees for get_maintainer.pl --git
2019-11-12 3:45 [PATCH qemu] scripts: Detect git worktrees for get_maintainer.pl --git Alexey Kardashevskiy
@ 2019-11-12 8:50 ` Stefano Garzarella
2019-11-12 8:53 ` Greg Kurz
2019-11-12 9:15 ` Paolo Bonzini
2 siblings, 0 replies; 4+ messages in thread
From: Stefano Garzarella @ 2019-11-12 8:50 UTC (permalink / raw)
To: Alexey Kardashevskiy; +Cc: qemu-trivial, Paolo Bonzini, qemu-ppc, qemu-devel
On Tue, Nov 12, 2019 at 02:45:32PM +1100, Alexey Kardashevskiy wrote:
> Recent git versions support worktrees where .git is not a directory but
> a file with a path to the .git repository; however the get_maintainer.pl
> script only recognises the .git directory, let's fix it.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
> scripts/get_maintainer.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Tested-by: Stefano Garzarella <sgarzare@redhat.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Thanks,
Stefano
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index 71415e3c7061..27991eb1cfb4 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -81,7 +81,7 @@ my %VCS_cmds;
>
> my %VCS_cmds_git = (
> "execute_cmd" => \&git_execute_cmd,
> - "available" => '(which("git") ne "") && (-d ".git")',
> + "available" => '(which("git") ne "") && (-e ".git")',
> "find_signers_cmd" =>
> "git log --no-color --follow --since=\$email_git_since " .
> '--format="GitCommit: %H%n' .
> --
> 2.17.1
>
>
--
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH qemu] scripts: Detect git worktrees for get_maintainer.pl --git
2019-11-12 3:45 [PATCH qemu] scripts: Detect git worktrees for get_maintainer.pl --git Alexey Kardashevskiy
2019-11-12 8:50 ` Stefano Garzarella
@ 2019-11-12 8:53 ` Greg Kurz
2019-11-12 9:15 ` Paolo Bonzini
2 siblings, 0 replies; 4+ messages in thread
From: Greg Kurz @ 2019-11-12 8:53 UTC (permalink / raw)
To: Alexey Kardashevskiy; +Cc: qemu-trivial, Paolo Bonzini, qemu-ppc, qemu-devel
On Tue, 12 Nov 2019 14:45:32 +1100
Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
> Recent git versions support worktrees where .git is not a directory but
> a file with a path to the .git repository; however the get_maintainer.pl
> script only recognises the .git directory, let's fix it.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
Makes sense. The script in the linux kernel tree has this since 2014 BTW :)
Reviewed-by: Greg Kurz <groug@kaod.org>
> scripts/get_maintainer.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index 71415e3c7061..27991eb1cfb4 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -81,7 +81,7 @@ my %VCS_cmds;
>
> my %VCS_cmds_git = (
> "execute_cmd" => \&git_execute_cmd,
> - "available" => '(which("git") ne "") && (-d ".git")',
> + "available" => '(which("git") ne "") && (-e ".git")',
> "find_signers_cmd" =>
> "git log --no-color --follow --since=\$email_git_since " .
> '--format="GitCommit: %H%n' .
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH qemu] scripts: Detect git worktrees for get_maintainer.pl --git
2019-11-12 3:45 [PATCH qemu] scripts: Detect git worktrees for get_maintainer.pl --git Alexey Kardashevskiy
2019-11-12 8:50 ` Stefano Garzarella
2019-11-12 8:53 ` Greg Kurz
@ 2019-11-12 9:15 ` Paolo Bonzini
2 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2019-11-12 9:15 UTC (permalink / raw)
To: Alexey Kardashevskiy, qemu-devel; +Cc: qemu-trivial, qemu-ppc
On 12/11/19 04:45, Alexey Kardashevskiy wrote:
> Recent git versions support worktrees where .git is not a directory but
> a file with a path to the .git repository; however the get_maintainer.pl
> script only recognises the .git directory, let's fix it.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
> scripts/get_maintainer.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index 71415e3c7061..27991eb1cfb4 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -81,7 +81,7 @@ my %VCS_cmds;
>
> my %VCS_cmds_git = (
> "execute_cmd" => \&git_execute_cmd,
> - "available" => '(which("git") ne "") && (-d ".git")',
> + "available" => '(which("git") ne "") && (-e ".git")',
> "find_signers_cmd" =>
> "git log --no-color --follow --since=\$email_git_since " .
> '--format="GitCommit: %H%n' .
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-12 9:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-12 3:45 [PATCH qemu] scripts: Detect git worktrees for get_maintainer.pl --git Alexey Kardashevskiy
2019-11-12 8:50 ` Stefano Garzarella
2019-11-12 8:53 ` Greg Kurz
2019-11-12 9:15 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).