* [PATCH] hw/s390x/css: Remove double initialization
@ 2020-09-07 2:40 Philippe Mathieu-Daudé
2020-09-07 11:43 ` Thomas Huth
2020-09-09 10:01 ` Cornelia Huck
0 siblings, 2 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-09-07 2:40 UTC (permalink / raw)
To: qemu-devel
Cc: Thomas Huth, David Hildenbrand, qemu-trivial, Cornelia Huck,
Halil Pasic, Christian Borntraeger, qemu-s390x,
Philippe Mathieu-Daudé,
Richard Henderson
Fix eventual copy/paste mistake introduced in commit bc994b74ea
("s390x/css: Use static initialization for channel_subsys fields").
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/s390x/css.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/s390x/css.c b/hw/s390x/css.c
index 519dc91316d..9961cfe7bf6 100644
--- a/hw/s390x/css.c
+++ b/hw/s390x/css.c
@@ -353,7 +353,6 @@ static ChannelSubSys channel_subsys = {
.pending_crws = QTAILQ_HEAD_INITIALIZER(channel_subsys.pending_crws),
.do_crw_mchk = true,
.sei_pending = false,
- .do_crw_mchk = true,
.crws_lost = false,
.chnmon_active = false,
.indicator_addresses =
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/s390x/css: Remove double initialization
2020-09-07 2:40 [PATCH] hw/s390x/css: Remove double initialization Philippe Mathieu-Daudé
@ 2020-09-07 11:43 ` Thomas Huth
2020-09-09 10:01 ` Cornelia Huck
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2020-09-07 11:43 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: David Hildenbrand, qemu-trivial, Cornelia Huck, Halil Pasic,
Christian Borntraeger, qemu-s390x, Richard Henderson
On 07/09/2020 04.40, Philippe Mathieu-Daudé wrote:
> Fix eventual copy/paste mistake introduced in commit bc994b74ea
> ("s390x/css: Use static initialization for channel_subsys fields").
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/s390x/css.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/s390x/css.c b/hw/s390x/css.c
> index 519dc91316d..9961cfe7bf6 100644
> --- a/hw/s390x/css.c
> +++ b/hw/s390x/css.c
> @@ -353,7 +353,6 @@ static ChannelSubSys channel_subsys = {
> .pending_crws = QTAILQ_HEAD_INITIALIZER(channel_subsys.pending_crws),
> .do_crw_mchk = true,
> .sei_pending = false,
> - .do_crw_mchk = true,
> .crws_lost = false,
> .chnmon_active = false,
> .indicator_addresses =
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/s390x/css: Remove double initialization
2020-09-07 2:40 [PATCH] hw/s390x/css: Remove double initialization Philippe Mathieu-Daudé
2020-09-07 11:43 ` Thomas Huth
@ 2020-09-09 10:01 ` Cornelia Huck
1 sibling, 0 replies; 3+ messages in thread
From: Cornelia Huck @ 2020-09-09 10:01 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Thomas Huth, David Hildenbrand, qemu-trivial, qemu-devel,
Halil Pasic, Christian Borntraeger, qemu-s390x,
Richard Henderson
On Mon, 7 Sep 2020 04:40:20 +0200
Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> Fix eventual copy/paste mistake introduced in commit bc994b74ea
> ("s390x/css: Use static initialization for channel_subsys fields").
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/s390x/css.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/s390x/css.c b/hw/s390x/css.c
> index 519dc91316d..9961cfe7bf6 100644
> --- a/hw/s390x/css.c
> +++ b/hw/s390x/css.c
> @@ -353,7 +353,6 @@ static ChannelSubSys channel_subsys = {
> .pending_crws = QTAILQ_HEAD_INITIALIZER(channel_subsys.pending_crws),
> .do_crw_mchk = true,
> .sei_pending = false,
> - .do_crw_mchk = true,
> .crws_lost = false,
> .chnmon_active = false,
> .indicator_addresses =
Thanks, applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-09 10:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-07 2:40 [PATCH] hw/s390x/css: Remove double initialization Philippe Mathieu-Daudé
2020-09-07 11:43 ` Thomas Huth
2020-09-09 10:01 ` Cornelia Huck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).