From: Wainer dos Santos Moschetta <wainersm@redhat.com>
To: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Cc: "Thomas Huth" <thuth@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Willian Rampazzo" <willianr@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH 01/11] python: expose typing information via PEP 561
Date: Mon, 28 Jun 2021 17:11:51 -0300 [thread overview]
Message-ID: <0550dc79-de0a-f6e4-8e85-38a22a0e19da@redhat.com> (raw)
In-Reply-To: <20210625154540.783306-2-jsnow@redhat.com>
Hi,
On 6/25/21 12:45 PM, John Snow wrote:
> https://www.python.org/dev/peps/pep-0561/#specification
> Create 'py.typed' files in each subpackage that indicate to mypy that
> this is a typed module, so that users of any of these packages can use
> mypy to check their code as well.
>
> Note: Theoretically it's possible to ditch MANIFEST.in in favor of using
> package_data in setup.cfg, but I genuinely could not figure out how to
> get it to include things from the *source root* into the *package root*;
> only how to include things from each subpackage. I tried!
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> python/qemu/machine/py.typed | 0
> python/qemu/qmp/py.typed | 0
> python/qemu/utils/py.typed | 0
> python/setup.cfg | 4 ++++
> 4 files changed, 4 insertions(+)
> create mode 100644 python/qemu/machine/py.typed
> create mode 100644 python/qemu/qmp/py.typed
> create mode 100644 python/qemu/utils/py.typed
Just double-checking that you did not add a single py.typed on the root
"python" dir, so that all modules inherit from it, because this is a
namespace package. Right?
Anyway,
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
>
> diff --git a/python/qemu/machine/py.typed b/python/qemu/machine/py.typed
> new file mode 100644
> index 0000000000..e69de29bb2
> diff --git a/python/qemu/qmp/py.typed b/python/qemu/qmp/py.typed
> new file mode 100644
> index 0000000000..e69de29bb2
> diff --git a/python/qemu/utils/py.typed b/python/qemu/utils/py.typed
> new file mode 100644
> index 0000000000..e69de29bb2
> diff --git a/python/setup.cfg b/python/setup.cfg
> index 85cecbb41b..db1639c1f2 100644
> --- a/python/setup.cfg
> +++ b/python/setup.cfg
> @@ -19,6 +19,7 @@ classifiers =
> Programming Language :: Python :: 3.8
> Programming Language :: Python :: 3.9
> Programming Language :: Python :: 3.10
> + Typing :: Typed
>
> [options]
> python_requires = >= 3.6
> @@ -27,6 +28,9 @@ packages =
> qemu.machine
> qemu.utils
>
> +[options.package_data]
> +* = py.typed
> +
> [options.extras_require]
> # Run `pipenv lock --dev` when changing these requirements.
> devel =
next prev parent reply other threads:[~2021-06-28 20:12 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 15:45 [PATCH 00/11] Python: packaging cleanups John Snow
2021-06-25 15:45 ` [PATCH 01/11] python: expose typing information via PEP 561 John Snow
2021-06-25 18:16 ` Willian Rampazzo
2021-06-28 20:11 ` Wainer dos Santos Moschetta [this message]
2021-06-28 20:28 ` John Snow
2021-06-25 15:45 ` [PATCH 02/11] python: Remove global pylint suppressions John Snow
2021-06-25 18:18 ` Willian Rampazzo
2021-06-28 20:14 ` Wainer dos Santos Moschetta
2021-06-25 15:45 ` [PATCH 03/11] python: Re-lock pipenv at *oldest* supported versions John Snow
2021-06-25 18:28 ` Willian Rampazzo
2021-06-28 20:30 ` Wainer dos Santos Moschetta
2021-06-28 20:38 ` John Snow
2021-06-29 16:44 ` Wainer dos Santos Moschetta
2021-06-25 15:45 ` [PATCH 04/11] python: README.rst touchups John Snow
2021-06-25 18:23 ` Willian Rampazzo
2021-06-25 18:26 ` John Snow
2021-06-28 20:35 ` Wainer dos Santos Moschetta
2021-06-25 15:45 ` [PATCH 05/11] python: Add no-install usage instructions John Snow
2021-06-25 18:25 ` Willian Rampazzo
2021-06-28 20:56 ` Wainer dos Santos Moschetta
2021-06-25 15:45 ` [PATCH 06/11] python: rename 'venv-check' target to 'check-pipenv' John Snow
2021-06-25 18:27 ` Willian Rampazzo
2021-06-28 21:09 ` Wainer dos Santos Moschetta
2021-06-25 15:45 ` [PATCH 07/11] python: update help text for check-tox John Snow
2021-06-25 18:29 ` Willian Rampazzo
2021-06-28 21:16 ` Wainer dos Santos Moschetta
2021-06-29 15:40 ` John Snow
2021-06-29 16:45 ` Wainer dos Santos Moschetta
2021-06-25 15:45 ` [PATCH 08/11] python: add 'make check-venv' invocation John Snow
2021-06-25 18:36 ` Willian Rampazzo
2021-06-25 18:38 ` John Snow
2021-06-25 19:01 ` Willian Rampazzo
2021-06-25 19:12 ` John Snow
2021-06-28 21:40 ` Wainer dos Santos Moschetta
2021-06-29 15:45 ` John Snow
2021-06-25 15:45 ` [PATCH 09/11] python: Update help text on 'make check', 'make develop' John Snow
2021-06-25 18:37 ` Willian Rampazzo
2021-06-28 21:41 ` Wainer dos Santos Moschetta
2021-06-25 15:45 ` [PATCH 10/11] python: Update help text on 'make clean', 'make distclean' John Snow
2021-06-25 18:37 ` Willian Rampazzo
2021-06-28 21:44 ` Wainer dos Santos Moschetta
2021-06-25 15:45 ` [PATCH 11/11] python: remove auto-generated pyproject.toml file John Snow
2021-06-25 18:40 ` Willian Rampazzo
2021-06-28 21:48 ` Wainer dos Santos Moschetta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0550dc79-de0a-f6e4-8e85-38a22a0e19da@redhat.com \
--to=wainersm@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=willianr@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).