From: Wainer dos Santos Moschetta <wainersm@redhat.com>
To: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Cc: "Thomas Huth" <thuth@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Willian Rampazzo" <willianr@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH 02/11] python: Remove global pylint suppressions
Date: Mon, 28 Jun 2021 17:14:19 -0300 [thread overview]
Message-ID: <5c828d11-f5de-ffc6-e8e9-5b97be9bdb97@redhat.com> (raw)
In-Reply-To: <20210625154540.783306-3-jsnow@redhat.com>
On 6/25/21 12:45 PM, John Snow wrote:
> These suppressions only apply to a small handful of places. Instead of
> disabling them globally, disable them just in the cases where we
> need. The design of the machine class grew quite organically with tons
> of constructor and class instance variables -- there's little chance of
> meaningfully refactoring it in the near term, so just suppress the
> warnings for that class.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> python/qemu/machine/machine.py | 3 +++
> python/qemu/machine/qtest.py | 2 ++
> python/setup.cfg | 4 +---
> 3 files changed, 6 insertions(+), 3 deletions(-)
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
>
> diff --git a/python/qemu/machine/machine.py b/python/qemu/machine/machine.py
> index b62435528e..e3345dfa1b 100644
> --- a/python/qemu/machine/machine.py
> +++ b/python/qemu/machine/machine.py
> @@ -84,6 +84,7 @@ class QEMUMachine:
> ...
> # vm is guaranteed to be shut down here
> """
> + # pylint: disable=too-many-instance-attributes, too-many-public-methods
>
> def __init__(self,
> binary: str,
> @@ -111,6 +112,8 @@ def __init__(self,
> @param console_log: (optional) path to console log file
> @note: Qemu process is not started until launch() is used.
> '''
> + # pylint: disable=too-many-arguments
> +
> # Direct user configuration
>
> self._binary = binary
> diff --git a/python/qemu/machine/qtest.py b/python/qemu/machine/qtest.py
> index 93700684d1..d6d9c6a34a 100644
> --- a/python/qemu/machine/qtest.py
> +++ b/python/qemu/machine/qtest.py
> @@ -116,6 +116,8 @@ def __init__(self,
> base_temp_dir: str = "/var/tmp",
> socket_scm_helper: Optional[str] = None,
> sock_dir: Optional[str] = None):
> + # pylint: disable=too-many-arguments
> +
> if name is None:
> name = "qemu-%d" % os.getpid()
> if sock_dir is None:
> diff --git a/python/setup.cfg b/python/setup.cfg
> index db1639c1f2..524789d6e0 100644
> --- a/python/setup.cfg
> +++ b/python/setup.cfg
> @@ -87,9 +87,7 @@ ignore_missing_imports = True
> # --enable=similarities". If you want to run only the classes checker, but have
> # no Warning level messages displayed, use "--disable=all --enable=classes
> # --disable=W".
> -disable=too-many-arguments,
> - too-many-instance-attributes,
> - too-many-public-methods,
> +disable=
>
> [pylint.basic]
> # Good variable names which should always be accepted, separated by a comma.
next prev parent reply other threads:[~2021-06-28 20:15 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 15:45 [PATCH 00/11] Python: packaging cleanups John Snow
2021-06-25 15:45 ` [PATCH 01/11] python: expose typing information via PEP 561 John Snow
2021-06-25 18:16 ` Willian Rampazzo
2021-06-28 20:11 ` Wainer dos Santos Moschetta
2021-06-28 20:28 ` John Snow
2021-06-25 15:45 ` [PATCH 02/11] python: Remove global pylint suppressions John Snow
2021-06-25 18:18 ` Willian Rampazzo
2021-06-28 20:14 ` Wainer dos Santos Moschetta [this message]
2021-06-25 15:45 ` [PATCH 03/11] python: Re-lock pipenv at *oldest* supported versions John Snow
2021-06-25 18:28 ` Willian Rampazzo
2021-06-28 20:30 ` Wainer dos Santos Moschetta
2021-06-28 20:38 ` John Snow
2021-06-29 16:44 ` Wainer dos Santos Moschetta
2021-06-25 15:45 ` [PATCH 04/11] python: README.rst touchups John Snow
2021-06-25 18:23 ` Willian Rampazzo
2021-06-25 18:26 ` John Snow
2021-06-28 20:35 ` Wainer dos Santos Moschetta
2021-06-25 15:45 ` [PATCH 05/11] python: Add no-install usage instructions John Snow
2021-06-25 18:25 ` Willian Rampazzo
2021-06-28 20:56 ` Wainer dos Santos Moschetta
2021-06-25 15:45 ` [PATCH 06/11] python: rename 'venv-check' target to 'check-pipenv' John Snow
2021-06-25 18:27 ` Willian Rampazzo
2021-06-28 21:09 ` Wainer dos Santos Moschetta
2021-06-25 15:45 ` [PATCH 07/11] python: update help text for check-tox John Snow
2021-06-25 18:29 ` Willian Rampazzo
2021-06-28 21:16 ` Wainer dos Santos Moschetta
2021-06-29 15:40 ` John Snow
2021-06-29 16:45 ` Wainer dos Santos Moschetta
2021-06-25 15:45 ` [PATCH 08/11] python: add 'make check-venv' invocation John Snow
2021-06-25 18:36 ` Willian Rampazzo
2021-06-25 18:38 ` John Snow
2021-06-25 19:01 ` Willian Rampazzo
2021-06-25 19:12 ` John Snow
2021-06-28 21:40 ` Wainer dos Santos Moschetta
2021-06-29 15:45 ` John Snow
2021-06-25 15:45 ` [PATCH 09/11] python: Update help text on 'make check', 'make develop' John Snow
2021-06-25 18:37 ` Willian Rampazzo
2021-06-28 21:41 ` Wainer dos Santos Moschetta
2021-06-25 15:45 ` [PATCH 10/11] python: Update help text on 'make clean', 'make distclean' John Snow
2021-06-25 18:37 ` Willian Rampazzo
2021-06-28 21:44 ` Wainer dos Santos Moschetta
2021-06-25 15:45 ` [PATCH 11/11] python: remove auto-generated pyproject.toml file John Snow
2021-06-25 18:40 ` Willian Rampazzo
2021-06-28 21:48 ` Wainer dos Santos Moschetta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c828d11-f5de-ffc6-e8e9-5b97be9bdb97@redhat.com \
--to=wainersm@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=willianr@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).