From: "Cédric Le Goater" <clg@kaod.org>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: philmd@redhat.com, mark.cave-ayland@ilande.co.uk,
berrange@redhat.com, ehabkost@redhat.com, pbonzini@redhat.com
Subject: Re: [PATCH 1/2] qom: Constify object_get_canonical_path{, _component}()'s parameter
Date: Wed, 27 May 2020 11:02:39 +0200 [thread overview]
Message-ID: <05a17baa-c076-77d7-8eab-cf54d97e3798@kaod.org> (raw)
In-Reply-To: <20200527084754.7531-2-armbru@redhat.com>
On 5/27/20 10:47 AM, Markus Armbruster wrote:
> Suggested-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
> ---
> include/qom/object.h | 4 ++--
> qom/object.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/include/qom/object.h b/include/qom/object.h
> index fd453dc8d6..b3eb05d65d 100644
> --- a/include/qom/object.h
> +++ b/include/qom/object.h
> @@ -1406,7 +1406,7 @@ Object *object_get_internal_root(void);
> * path is the path within the composition tree starting from the root.
> * %NULL if the object doesn't have a parent (and thus a canonical path).
> */
> -char *object_get_canonical_path_component(Object *obj);
> +char *object_get_canonical_path_component(const Object *obj);
>
> /**
> * object_get_canonical_path:
> @@ -1414,7 +1414,7 @@ char *object_get_canonical_path_component(Object *obj);
> * Returns: The canonical path for a object. This is the path within the
> * composition tree starting from the root.
> */
> -char *object_get_canonical_path(Object *obj);
> +char *object_get_canonical_path(const Object *obj);
>
> /**
> * object_resolve_path:
> diff --git a/qom/object.c b/qom/object.c
> index d0be42c8d6..c02487ec1a 100644
> --- a/qom/object.c
> +++ b/qom/object.c
> @@ -1883,7 +1883,7 @@ object_property_add_const_link(Object *obj, const char *name,
> NULL, OBJ_PROP_LINK_DIRECT);
> }
>
> -char *object_get_canonical_path_component(Object *obj)
> +char *object_get_canonical_path_component(const Object *obj)
> {
> ObjectProperty *prop = NULL;
> GHashTableIter iter;
> @@ -1908,7 +1908,7 @@ char *object_get_canonical_path_component(Object *obj)
> return NULL;
> }
>
> -char *object_get_canonical_path(Object *obj)
> +char *object_get_canonical_path(const Object *obj)
> {
> Object *root = object_get_root();
> char *newpath, *path = NULL;
>
next prev parent reply other threads:[~2020-05-27 9:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 8:47 [PATCH 0/2] qom: Make "info qom-tree" show children sorted Markus Armbruster
2020-05-27 8:47 ` [PATCH 1/2] qom: Constify object_get_canonical_path{, _component}()'s parameter Markus Armbruster
2020-05-27 9:02 ` Cédric Le Goater [this message]
2020-05-27 9:49 ` [PATCH 1/2] qom: Constify object_get_canonical_path{,_component}()'s parameter Philippe Mathieu-Daudé
2020-05-27 8:47 ` [PATCH 2/2] qom: Make "info qom-tree" show children sorted Markus Armbruster
2020-05-27 9:04 ` Cédric Le Goater
2020-05-27 10:31 ` Philippe Mathieu-Daudé
2020-07-07 4:45 ` Slow down with: 'Make "info qom-tree" show children sorted' Thomas Huth
2020-07-07 4:58 ` Philippe Mathieu-Daudé
2020-07-07 5:33 ` Markus Armbruster
2020-07-07 8:00 ` Paolo Bonzini
2020-07-07 12:00 ` Markus Armbruster
2020-07-07 12:04 ` Daniel P. Berrangé
2020-07-13 1:13 ` David Gibson
2020-07-13 16:13 ` Markus Armbruster
2020-07-15 23:59 ` David Gibson
2020-07-16 5:37 ` Markus Armbruster
2020-07-17 6:00 ` David Gibson
2020-07-07 8:46 ` Daniel P. Berrangé
2020-07-07 9:06 ` Paolo Bonzini
2020-07-07 9:40 ` Daniel P. Berrangé
2020-07-07 9:49 ` Paolo Bonzini
2020-07-08 9:24 ` Markus Armbruster
2020-06-08 12:09 ` [PATCH 0/2] qom: Make "info qom-tree" show children sorted Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05a17baa-c076-77d7-8eab-cf54d97e3798@kaod.org \
--to=clg@kaod.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).