From: Klaus Heinrich Kiwi <klaus@linux.vnet.ibm.com>
To: "Cédric Le Goater" <clg@kaod.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Thomas Huth <thuth@redhat.com>, Andrew Jeffery <andrew@aj.id.au>,
Joel Stanley <joel@jms.id.au>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 2/3] aspeed: Add Scater-Gather support for HACE Hash
Date: Fri, 26 Mar 2021 13:51:33 -0300 [thread overview]
Message-ID: <069b1ad4-1b4b-99f6-9719-308e24674bc5@linux.vnet.ibm.com> (raw)
In-Reply-To: <329648d7-9f30-2a58-be89-d157c446e927@kaod.org>
On 3/25/2021 4:55 AM, Cédric Le Goater wrote:
> On 3/24/21 11:38 PM, Klaus Heinrich Kiwi wrote:
>> Complement the Aspeed HACE support with Scatter-Gather hash support for
>> sha256 and sha512. Scatter-Gather is only supported on AST2600-series.
>>
>> Signed-off-by: Klaus Heinrich Kiwi <klaus@linux.vnet.ibm.com>
>
> this looks good. A few extra comments,
>
>
>> @@ -129,6 +133,117 @@ static int do_hash_operation(AspeedHACEState *s, int algo)
>> return 0;
>> }
>>
>> +static int do_hash_sg_operation(AspeedHACEState *s, int algo)
>
> Do we really care about the return value ?
I'm keeping it consistent with do_hash_operation() above it. Maybe the underlying
Qemu layers could use it?
>> + sgList = (struct aspeed_sg_list *) address_space_map(&s->dram_as,
>> + src,
>> + (hwaddr *) &len,
>> + false,
>> + MEMTXATTRS_UNSPECIFIED);
>
> This should be doing LE loads.
ack. I'm using address_space_ldl_le() now.
>> - do_hash_operation(s, algo);
>> + if (data & HASH_SG_EN) {
>> + s->regs[(R_HASH_SRC >> 2)] &= 0x7FFFFFF8;
>
> I think Joel introduced a class mask for this value.
Turns out that the hardware doesn't do any additional masking on the src
register for the HASH_SG_EN operation, so I'll just remove it.
>>
>> +#define ASPEED_HACE_MAX_SG 256
>> +struct aspeed_sg_list {
>> + uint32_t len;
>> + uint32_t phy_addr;
>> +} __attribute__ ((__packed__));
>> +>
> May be keep the definition in the .c file
I actually opted to use #define offsets now that I'm using ldl_le
Thanks,
-Klaus
--
Klaus Heinrich Kiwi <klaus@linux.vnet.ibm.com>
next prev parent reply other threads:[~2021-03-26 16:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 22:38 [PATCH 0/3] aspeed: HACE hash Scatter-Gather support Klaus Heinrich Kiwi
2021-03-24 22:38 ` [PATCH 1/3] aspeed: Coding Style cleanups on do_hash_operation Klaus Heinrich Kiwi
2021-03-24 22:57 ` Cédric Le Goater
2021-03-25 0:15 ` Klaus Heinrich Kiwi
2021-03-24 22:38 ` [PATCH 2/3] aspeed: Add Scater-Gather support for HACE Hash Klaus Heinrich Kiwi
2021-03-25 3:40 ` Joel Stanley
2021-03-26 16:47 ` Klaus Heinrich Kiwi
2021-03-25 7:55 ` Cédric Le Goater
2021-03-26 16:51 ` Klaus Heinrich Kiwi [this message]
2021-03-24 22:38 ` [PATCH 3/3] tests: Aspeed HACE Scatter-Gather tests Klaus Heinrich Kiwi
2021-03-25 2:18 ` Joel Stanley
2021-03-26 17:00 ` Klaus Heinrich Kiwi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=069b1ad4-1b4b-99f6-9719-308e24674bc5@linux.vnet.ibm.com \
--to=klaus@linux.vnet.ibm.com \
--cc=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).