From: "Cédric Le Goater" <clg@kaod.org>
To: Klaus Heinrich Kiwi <klaus@linux.vnet.ibm.com>,
<qemu-arm@nongnu.org>, <qemu-devel@nongnu.org>
Cc: Laurent Vivier <lvivier@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Thomas Huth <thuth@redhat.com>, Andrew Jeffery <andrew@aj.id.au>,
Joel Stanley <joel@jms.id.au>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 1/3] aspeed: Coding Style cleanups on do_hash_operation
Date: Wed, 24 Mar 2021 23:57:55 +0100 [thread overview]
Message-ID: <d3274402-58e2-c7ca-f808-7e2d51f29d89@kaod.org> (raw)
In-Reply-To: <20210324223846.17407-2-klaus@linux.vnet.ibm.com>
On 3/24/21 11:38 PM, Klaus Heinrich Kiwi wrote:
> Basically using camelCase for some variables...
I don't think CamelCase applies to variables, only types.
https://qemu.readthedocs.io/en/latest/devel/style.html#variable-naming-conventions
C.
>
> Signed-off-by: Klaus Heinrich Kiwi <klaus@linux.vnet.ibm.com>
> ---
> hw/misc/aspeed_hace.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/hw/misc/aspeed_hace.c b/hw/misc/aspeed_hace.c
> index 6e5b447a48..93313d2b80 100644
> --- a/hw/misc/aspeed_hace.c
> +++ b/hw/misc/aspeed_hace.c
> @@ -86,24 +86,24 @@ static int hash_algo_lookup(uint32_t mask)
>
> static int do_hash_operation(AspeedHACEState *s, int algo)
> {
> - hwaddr src, len, dest;
> - uint8_t *digest_buf = NULL;
> - size_t digest_len = 0;
> - char *src_buf;
> + uint32_t src, len, dest;
> + uint8_t *digestBuf = NULL;
> + size_t digestLen = 0;
> + char *srcBuf;
> int rc;
>
> src = s->regs[R_HASH_SRC];
> len = s->regs[R_HASH_SRC_LEN];
> dest = s->regs[R_HASH_DEST];
>
> - src_buf = address_space_map(&s->dram_as, src, &len, false,
> - MEMTXATTRS_UNSPECIFIED);
> - if (!src_buf) {
> + srcBuf = address_space_map(&s->dram_as, src, (hwaddr *) &len,
> + false, MEMTXATTRS_UNSPECIFIED);
> + if (!srcBuf) {
> qemu_log_mask(LOG_GUEST_ERROR, "%s: failed to map dram\n", __func__);
> return -EACCES;
> }
>
> - rc = qcrypto_hash_bytes(algo, src_buf, len, &digest_buf, &digest_len,
> + rc = qcrypto_hash_bytes(algo, srcBuf, len, &digestBuf, &digestLen,
> &error_fatal);
> if (rc < 0) {
> qemu_log_mask(LOG_GUEST_ERROR, "%s: qcrypto failed\n", __func__);
> @@ -111,14 +111,14 @@ static int do_hash_operation(AspeedHACEState *s, int algo)
> }
>
> rc = address_space_write(&s->dram_as, dest, MEMTXATTRS_UNSPECIFIED,
> - digest_buf, digest_len);
> + digestBuf, digestLen);
> if (rc) {
> qemu_log_mask(LOG_GUEST_ERROR,
> "%s: address space write failed\n", __func__);
> }
> - g_free(digest_buf);
> + g_free(digestBuf);
>
> - address_space_unmap(&s->dram_as, src_buf, len, false, len);
> + address_space_unmap(&s->dram_as, srcBuf, len, false, len);
>
> /*
> * Set status bits to indicate completion. Testing shows hardware sets
>
next prev parent reply other threads:[~2021-03-24 23:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 22:38 [PATCH 0/3] aspeed: HACE hash Scatter-Gather support Klaus Heinrich Kiwi
2021-03-24 22:38 ` [PATCH 1/3] aspeed: Coding Style cleanups on do_hash_operation Klaus Heinrich Kiwi
2021-03-24 22:57 ` Cédric Le Goater [this message]
2021-03-25 0:15 ` Klaus Heinrich Kiwi
2021-03-24 22:38 ` [PATCH 2/3] aspeed: Add Scater-Gather support for HACE Hash Klaus Heinrich Kiwi
2021-03-25 3:40 ` Joel Stanley
2021-03-26 16:47 ` Klaus Heinrich Kiwi
2021-03-25 7:55 ` Cédric Le Goater
2021-03-26 16:51 ` Klaus Heinrich Kiwi
2021-03-24 22:38 ` [PATCH 3/3] tests: Aspeed HACE Scatter-Gather tests Klaus Heinrich Kiwi
2021-03-25 2:18 ` Joel Stanley
2021-03-26 17:00 ` Klaus Heinrich Kiwi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3274402-58e2-c7ca-f808-7e2d51f29d89@kaod.org \
--to=clg@kaod.org \
--cc=andrew@aj.id.au \
--cc=joel@jms.id.au \
--cc=klaus@linux.vnet.ibm.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).