From: Pierre Morel <pmorel@linux.ibm.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: thuth@redhat.com, ehabkost@redhat.com, david@redhat.com,
cohuck@redhat.com, richard.henderson@linaro.org,
qemu-devel@nongnu.org, pasic@linux.ibm.com,
borntraeger@de.ibm.com, qemu-s390x@nongnu.org,
pbonzini@redhat.com, eblake@redhat.com
Subject: Re: [PATCH v1 2/9] s390x: toplogy: adding drawers and books to smp parsing
Date: Thu, 15 Jul 2021 10:19:08 +0200 [thread overview]
Message-ID: <0801e122-0e9c-e266-42e8-d5cddb16c237@linux.ibm.com> (raw)
In-Reply-To: <87y2a8cda7.fsf@dusky.pond.sub.org>
On 7/15/21 8:16 AM, Markus Armbruster wrote:
> Pierre Morel <pmorel@linux.ibm.com> writes:
>
>> Drawers and Books are levels 4 and 3 of the S390 CPU
>> topology.
>> We allow the user to define these levels and we will
>> store the values inside the S390CcwMachineState.
>
> Double-checking: are these members specific to S390?
Yes AFAIK
>
>>
>> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
>> ---
>
> [...]
>
>> diff --git a/qapi/machine.json b/qapi/machine.json
>> index c3210ee1fb..98aff804c6 100644
>> --- a/qapi/machine.json
>> +++ b/qapi/machine.json
>> @@ -883,6 +883,8 @@
> ##
> # @CpuInstanceProperties:
> #
> # List of properties to be used for hotplugging a CPU instance,
> # it should be passed by management with device_add command when
> # a CPU is being hotplugged.
> #
> # @node-id: NUMA node ID the CPU belongs to
> # @socket-id: socket number within node/board the CPU belongs to
>
> Missing: documentation for your new members.
Oh yes, right forgot these, thanks.
>
> # @die-id: die number within node/board the CPU belongs to (Since 4.1)
> # @core-id: core number within die the CPU belongs to
> # @thread-id: thread number within core the CPU belongs to
> #
> # Note: currently there are 5 properties that could be present
> # but management should be prepared to pass through other
> # properties with device_add command to allow for future
> # interface extension. This also requires the filed names to be kept in
> # sync with the properties passed to -device/device_add.
> #
> # Since: 2.7
> ##
> { 'struct': 'CpuInstanceProperties',
>> 'data': { '*node-id': 'int',
>> '*socket-id': 'int',
>> '*die-id': 'int',
>> + '*drawer-id': 'int',
>> + '*book-id': 'int',
>> '*core-id': 'int',
>> '*thread-id': 'int'
>> }
>
> [...]
>
>
--
Pierre Morel
IBM Lab Boeblingen
next prev parent reply other threads:[~2021-07-15 8:20 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 16:53 [PATCH v1 0/9] s390x: CPU Topology Pierre Morel
2021-07-14 16:53 ` [PATCH v1 1/9] s390x: smp: s390x dedicated smp parsing Pierre Morel
2021-07-16 8:54 ` Cornelia Huck
2021-07-16 9:14 ` Daniel P. Berrangé
2021-07-16 10:59 ` Pierre Morel
[not found] ` <e4865ad6-f8ec-e7ba-66ef-9c95334ba9b3@linux.ibm.com>
2021-07-19 15:43 ` Cornelia Huck
2021-07-19 15:52 ` Daniel P. Berrangé
2021-07-20 7:37 ` Pierre Morel
2021-07-20 8:33 ` Pierre Morel
2021-07-16 10:47 ` Pierre Morel
2021-07-14 16:53 ` [PATCH v1 2/9] s390x: toplogy: adding drawers and books to " Pierre Morel
2021-07-15 6:16 ` Markus Armbruster
2021-07-15 8:19 ` Pierre Morel [this message]
2021-07-15 10:48 ` Markus Armbruster
2021-07-16 9:10 ` Cornelia Huck
2021-07-16 9:18 ` Daniel P. Berrangé
2021-07-16 10:44 ` Cornelia Huck
2021-07-16 10:49 ` Daniel P. Berrangé
2021-07-19 15:50 ` Cornelia Huck
2021-07-20 7:52 ` Pierre Morel
2021-07-20 8:20 ` Cornelia Huck
2021-07-20 8:46 ` Pierre Morel
2021-07-20 9:00 ` Cornelia Huck
2021-07-20 9:19 ` Daniel P. Berrangé
2021-07-20 12:29 ` Pierre Morel
2021-07-16 9:23 ` Daniel P. Berrangé
2021-07-16 11:08 ` Pierre Morel
2021-07-14 16:53 ` [PATCH v1 3/9] s390x: cpu topology: CPU topology objects and structures Pierre Morel
2021-07-14 16:53 ` [PATCH v1 4/9] s390x: Topology list entries and SYSIB 15.x.x Pierre Morel
2021-07-14 16:53 ` [PATCH v1 5/9] s390x: topology: implementating Store Topology System Information Pierre Morel
2021-07-14 16:53 ` [PATCH v1 6/9] s390x: kvm: topology: interception of PTF instruction Pierre Morel
2021-07-16 9:22 ` Cornelia Huck
2021-07-16 11:23 ` Pierre Morel
2021-07-16 11:56 ` Cornelia Huck
2021-07-14 16:53 ` [PATCH v1 7/9] s390x: SCLP: reporting the maximum nested topology entries Pierre Morel
2021-07-16 9:24 ` Cornelia Huck
2021-07-16 11:12 ` Pierre Morel
2021-07-14 16:53 ` [PATCH v1 8/9] s390x: numa: define drawers and books for NUMA Pierre Morel
2021-07-14 16:53 ` [PATCH v1 9/9] s390x: numa: implement NUMA for S390x Pierre Morel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0801e122-0e9c-e266-42e8-d5cddb16c237@linux.ibm.com \
--to=pmorel@linux.ibm.com \
--cc=armbru@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).