From: Cornelia Huck <cohuck@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: thuth@redhat.com, ehabkost@redhat.com,
Pierre Morel <pmorel@linux.ibm.com>,
david@redhat.com, richard.henderson@linaro.org,
Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org, pasic@linux.ibm.com,
borntraeger@de.ibm.com, qemu-s390x@nongnu.org,
pbonzini@redhat.com, eblake@redhat.com
Subject: Re: [PATCH v1 2/9] s390x: toplogy: adding drawers and books to smp parsing
Date: Fri, 16 Jul 2021 12:44:49 +0200 [thread overview]
Message-ID: <87pmvibkri.fsf@redhat.com> (raw)
In-Reply-To: <YPFO/NPdyHjf1Cyu@redhat.com>
On Fri, Jul 16 2021, Daniel P. Berrangé <berrange@redhat.com> wrote:
> On Fri, Jul 16, 2021 at 11:10:04AM +0200, Cornelia Huck wrote:
>> On Thu, Jul 15 2021, Markus Armbruster <armbru@redhat.com> wrote:
>>
>> > Pierre Morel <pmorel@linux.ibm.com> writes:
>> >
>> >> On 7/15/21 8:16 AM, Markus Armbruster wrote:
>> >>> Pierre Morel <pmorel@linux.ibm.com> writes:
>> >>>
>> >>>> Drawers and Books are levels 4 and 3 of the S390 CPU
>> >>>> topology.
>> >>>> We allow the user to define these levels and we will
>> >>>> store the values inside the S390CcwMachineState.
>> >>>
>> >>> Double-checking: are these members specific to S390?
>> >>
>> >> Yes AFAIK
>> >
>> > Makes me wonder whether they should be conditional on TARGET_S390X.
>> >
>> > What happens when you specify them for another target? Silently
>> > ignored, or error?
>>
>> I'm wondering whether we should include them in the base machine state
>> and treat them as we treat 'dies' (i.e. the standard parser errors out
>> if they are set, and only the s390x parser supports them.)
>
> To repeat what i just wrote in my reply to patch 1, I think we ought to
> think about a different approach to handling the usage constraints,
> which doesn't require full re-implementation of the smp_parse method
> each time. There should be a way for each target to report topology
> constraints, such the the single smp_parse method can do the right
> thing, especially wrt error reporting for unsupported values.
That would mean that all possible fields would need to go into common
code, right?
I'm wondering whether there are more architecture/cpu specific values
lurking in the corner, it would get unwieldy if we need to go beyond the
existing fields and drawers/books.
next prev parent reply other threads:[~2021-07-16 10:46 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 16:53 [PATCH v1 0/9] s390x: CPU Topology Pierre Morel
2021-07-14 16:53 ` [PATCH v1 1/9] s390x: smp: s390x dedicated smp parsing Pierre Morel
2021-07-16 8:54 ` Cornelia Huck
2021-07-16 9:14 ` Daniel P. Berrangé
2021-07-16 10:59 ` Pierre Morel
[not found] ` <e4865ad6-f8ec-e7ba-66ef-9c95334ba9b3@linux.ibm.com>
2021-07-19 15:43 ` Cornelia Huck
2021-07-19 15:52 ` Daniel P. Berrangé
2021-07-20 7:37 ` Pierre Morel
2021-07-20 8:33 ` Pierre Morel
2021-07-16 10:47 ` Pierre Morel
2021-07-14 16:53 ` [PATCH v1 2/9] s390x: toplogy: adding drawers and books to " Pierre Morel
2021-07-15 6:16 ` Markus Armbruster
2021-07-15 8:19 ` Pierre Morel
2021-07-15 10:48 ` Markus Armbruster
2021-07-16 9:10 ` Cornelia Huck
2021-07-16 9:18 ` Daniel P. Berrangé
2021-07-16 10:44 ` Cornelia Huck [this message]
2021-07-16 10:49 ` Daniel P. Berrangé
2021-07-19 15:50 ` Cornelia Huck
2021-07-20 7:52 ` Pierre Morel
2021-07-20 8:20 ` Cornelia Huck
2021-07-20 8:46 ` Pierre Morel
2021-07-20 9:00 ` Cornelia Huck
2021-07-20 9:19 ` Daniel P. Berrangé
2021-07-20 12:29 ` Pierre Morel
2021-07-16 9:23 ` Daniel P. Berrangé
2021-07-16 11:08 ` Pierre Morel
2021-07-14 16:53 ` [PATCH v1 3/9] s390x: cpu topology: CPU topology objects and structures Pierre Morel
2021-07-14 16:53 ` [PATCH v1 4/9] s390x: Topology list entries and SYSIB 15.x.x Pierre Morel
2021-07-14 16:53 ` [PATCH v1 5/9] s390x: topology: implementating Store Topology System Information Pierre Morel
2021-07-14 16:53 ` [PATCH v1 6/9] s390x: kvm: topology: interception of PTF instruction Pierre Morel
2021-07-16 9:22 ` Cornelia Huck
2021-07-16 11:23 ` Pierre Morel
2021-07-16 11:56 ` Cornelia Huck
2021-07-14 16:53 ` [PATCH v1 7/9] s390x: SCLP: reporting the maximum nested topology entries Pierre Morel
2021-07-16 9:24 ` Cornelia Huck
2021-07-16 11:12 ` Pierre Morel
2021-07-14 16:53 ` [PATCH v1 8/9] s390x: numa: define drawers and books for NUMA Pierre Morel
2021-07-14 16:53 ` [PATCH v1 9/9] s390x: numa: implement NUMA for S390x Pierre Morel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmvibkri.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=pmorel@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).