From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, John Snow <jsnow@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org,
Stefan Hajnoczi <stefanha@redhat.com>
Cc: Fam Zheng <fam@euphon.net>,
Shaju Abraham <shaju.abraham@nutanix.com>,
qemu-stable <qemu-stable@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] Revert "ide/ahci: Check for -ECANCELED in aio callbacks"
Date: Tue, 30 Jul 2019 14:47:12 +0200 [thread overview]
Message-ID: <084951ee-2837-6396-84eb-1b5c5fcf8bd6@redhat.com> (raw)
In-Reply-To: <075eaba0-7e50-b240-7679-825c5bd03e0f@redhat.com>
On 7/30/19 1:37 PM, Paolo Bonzini wrote:
> On 30/07/19 11:54, Philippe Mathieu-Daudé wrote:
>> Hi John,
>>
>> On 7/30/19 12:36 AM, John Snow wrote:
>>> This reverts commit 0d910cfeaf2076b116b4517166d5deb0fea76394.
>>>
>>> It's not correct to just ignore an error code in a callback; we need to
>>> handle that error and possible report failure to the guest so that they
>>> don't wait indefinitely for an operation that will now never finish.
>>
>> Is this 4.1 material? It looks so.
>
> Perhaps could have been last week, but now I suggest Cc qemu-stable and
> delaying it to 4.2.
I was wondering because Kevin was preparing a block@ pull request.
Anyway this seems fair because the reverted commit is dated from 2014.
Thanks,
Phil.
next prev parent reply other threads:[~2019-07-30 12:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 22:36 [Qemu-devel] [PATCH] Revert "ide/ahci: Check for -ECANCELED in aio callbacks" John Snow
2019-07-30 9:54 ` Philippe Mathieu-Daudé
2019-07-30 11:37 ` Paolo Bonzini
2019-07-30 12:47 ` Philippe Mathieu-Daudé [this message]
2019-07-30 12:50 ` John Snow
2019-08-13 22:48 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=084951ee-2837-6396-84eb-1b5c5fcf8bd6@redhat.com \
--to=philmd@redhat.com \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=shaju.abraham@nutanix.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).