From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: John Snow <jsnow@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org,
Stefan Hajnoczi <stefanha@redhat.com>
Cc: Fam Zheng <fam@euphon.net>, Paolo Bonzini <pbonzini@redhat.com>,
Shaju Abraham <shaju.abraham@nutanix.com>,
qemu-stable <qemu-stable@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] Revert "ide/ahci: Check for -ECANCELED in aio callbacks"
Date: Tue, 30 Jul 2019 11:54:03 +0200 [thread overview]
Message-ID: <7324bc78-1d7b-7b7f-272d-c2932651b007@redhat.com> (raw)
In-Reply-To: <20190729223605.7163-1-jsnow@redhat.com>
Hi John,
On 7/30/19 12:36 AM, John Snow wrote:
> This reverts commit 0d910cfeaf2076b116b4517166d5deb0fea76394.
>
> It's not correct to just ignore an error code in a callback; we need to
> handle that error and possible report failure to the guest so that they
> don't wait indefinitely for an operation that will now never finish.
Is this 4.1 material? It looks so.
> This ought to help cases reported by Nutanix where iSCSI returns a
> legitimate -ECANCELED for certain operations which should be propagated
> normally.
>
> Reported-by: Shaju Abraham <shaju.abraham@nutanix.com>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> hw/ide/ahci.c | 3 ---
> hw/ide/core.c | 14 --------------
> 2 files changed, 17 deletions(-)
>
> diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
> index 00ba422a48..6aaf66534a 100644
> --- a/hw/ide/ahci.c
> +++ b/hw/ide/ahci.c
> @@ -1023,9 +1023,6 @@ static void ncq_cb(void *opaque, int ret)
> IDEState *ide_state = &ncq_tfs->drive->port.ifs[0];
>
> ncq_tfs->aiocb = NULL;
> - if (ret == -ECANCELED) {
> - return;
> - }
>
> if (ret < 0) {
> bool is_read = ncq_tfs->cmd == READ_FPDMA_QUEUED;
> diff --git a/hw/ide/core.c b/hw/ide/core.c
> index 6afadf894f..8e1624f7ce 100644
> --- a/hw/ide/core.c
> +++ b/hw/ide/core.c
> @@ -722,9 +722,6 @@ static void ide_sector_read_cb(void *opaque, int ret)
> s->pio_aiocb = NULL;
> s->status &= ~BUSY_STAT;
>
> - if (ret == -ECANCELED) {
> - return;
> - }
> if (ret != 0) {
> if (ide_handle_rw_error(s, -ret, IDE_RETRY_PIO |
> IDE_RETRY_READ)) {
> @@ -840,10 +837,6 @@ static void ide_dma_cb(void *opaque, int ret)
> uint64_t offset;
> bool stay_active = false;
>
> - if (ret == -ECANCELED) {
> - return;
> - }
> -
> if (ret == -EINVAL) {
> ide_dma_error(s);
> return;
> @@ -975,10 +968,6 @@ static void ide_sector_write_cb(void *opaque, int ret)
> IDEState *s = opaque;
> int n;
>
> - if (ret == -ECANCELED) {
> - return;
> - }
> -
> s->pio_aiocb = NULL;
> s->status &= ~BUSY_STAT;
>
> @@ -1058,9 +1047,6 @@ static void ide_flush_cb(void *opaque, int ret)
>
> s->pio_aiocb = NULL;
>
> - if (ret == -ECANCELED) {
> - return;
> - }
> if (ret < 0) {
> /* XXX: What sector number to set here? */
> if (ide_handle_rw_error(s, -ret, IDE_RETRY_FLUSH)) {
>
next prev parent reply other threads:[~2019-07-30 9:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 22:36 [Qemu-devel] [PATCH] Revert "ide/ahci: Check for -ECANCELED in aio callbacks" John Snow
2019-07-30 9:54 ` Philippe Mathieu-Daudé [this message]
2019-07-30 11:37 ` Paolo Bonzini
2019-07-30 12:47 ` Philippe Mathieu-Daudé
2019-07-30 12:50 ` John Snow
2019-08-13 22:48 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7324bc78-1d7b-7b7f-272d-c2932651b007@redhat.com \
--to=philmd@redhat.com \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=shaju.abraham@nutanix.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).