From: BALATON Zoltan <balaton@eik.bme.hu>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Richard Henderson <richard.henderson@linaro.org>,
Magnus Damm <magnus.damm@gmail.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>
Subject: [PATCH v3 18/18] hw/intc/sh_intc: Simplify allocating sources array
Date: Wed, 27 Oct 2021 23:54:31 +0200 [thread overview]
Message-ID: <09bae4fbe771f45c70bf586942ed9324ffb20183.1635371671.git.balaton@eik.bme.hu> (raw)
In-Reply-To: <cover.1635371671.git.balaton@eik.bme.hu>
Use g_new0 instead of g_malloc0 and avoid some unneeded temporary
variable assignments.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
hw/intc/sh_intc.c | 13 +++----------
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/hw/intc/sh_intc.c b/hw/intc/sh_intc.c
index eb58707e83..ed0a5f87cc 100644
--- a/hw/intc/sh_intc.c
+++ b/hw/intc/sh_intc.c
@@ -400,21 +400,14 @@ int sh_intc_init(MemoryRegion *sysmem,
/* Allocate 4 MemoryRegions per register (2 actions * 2 aliases) */
desc->iomem_aliases = g_new0(MemoryRegion,
(nr_mask_regs + nr_prio_regs) * 4);
-
- j = 0;
- i = sizeof(struct intc_source) * nr_sources;
- desc->sources = g_malloc0(i);
-
+ desc->sources = g_new0(struct intc_source, nr_sources);
for (i = 0; i < desc->nr_sources; i++) {
- struct intc_source *source = &desc->sources[i];
-
- source->parent = desc;
+ desc->sources[i].parent = desc;
}
-
desc->irqs = qemu_allocate_irqs(sh_intc_set_irq, desc, nr_sources);
memory_region_init_io(&desc->iomem, NULL, &sh_intc_ops, desc, "intc",
0x100000000ULL);
-
+ j = 0;
if (desc->mask_regs) {
for (i = 0; i < desc->nr_mask_regs; i++) {
struct intc_mask_reg *mr = &desc->mask_regs[i];
--
2.21.4
next prev parent reply other threads:[~2021-10-27 22:50 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 21:54 [PATCH v3 00/18] More SH4 clean ups BALATON Zoltan
2021-10-27 21:54 ` BALATON Zoltan [this message]
2021-10-27 21:54 ` [PATCH v3 03/18] hw/sh4: Change debug printfs to traces BALATON Zoltan
2021-10-28 0:31 ` Richard Henderson
2021-10-27 21:54 ` [PATCH v3 16/18] hw/intc/sh_intc: Replace abort() with g_assert_not_reached() BALATON Zoltan
2021-10-28 0:57 ` Richard Henderson
2021-10-27 21:54 ` [PATCH v3 01/18] hw/sh4: Fix typos in a comment BALATON Zoltan
2021-10-27 21:54 ` [PATCH v3 14/18] hw/intc/sh_intc: Use array index instead of pointer arithmetics BALATON Zoltan
2021-10-28 0:55 ` Richard Henderson
2021-10-27 21:54 ` [PATCH v3 13/18] hw/intc/sh_intc: Remove excessive parenthesis BALATON Zoltan
2021-10-28 0:54 ` Richard Henderson
2021-10-27 21:54 ` [PATCH v3 06/18] hw/char/sh_serial: QOM-ify BALATON Zoltan
2021-10-27 21:54 ` [PATCH v3 11/18] hw/intc/sh_intc: Drop another useless macro BALATON Zoltan
2021-10-28 0:52 ` Richard Henderson
2021-10-27 21:54 ` [PATCH v3 10/18] hw/intc/sh_intc: Rename iomem region BALATON Zoltan
2021-10-28 0:39 ` Richard Henderson
2021-10-27 21:54 ` [PATCH v3 17/18] hw/intc/sh_intc: Avoid using continue in loops BALATON Zoltan
2021-10-28 0:58 ` Richard Henderson
2021-10-27 21:54 ` [PATCH v3 05/18] hw/char/sh_serial: Rename type sh_serial_state to SHSerialState BALATON Zoltan
2021-10-28 0:31 ` Richard Henderson
2021-10-27 21:54 ` [PATCH v3 08/18] hw/intc/sh_intc: Use existing macro instead of local one BALATON Zoltan
2021-10-28 0:37 ` Richard Henderson
2021-10-27 21:54 ` [PATCH v3 02/18] hw//sh4: Use qemu_log instead of fprintf to stderr BALATON Zoltan
2021-10-27 21:54 ` [PATCH v3 15/18] hw/sh4/sh_intc: Inline and drop sh_intc_source() function BALATON Zoltan
2021-10-27 21:54 ` [PATCH v3 04/18] hw/sh4/r2d: Use error_report instead of fprintf to stderr BALATON Zoltan
2021-10-27 21:54 ` [PATCH v3 09/18] hw/intc/sh_intc: Turn some defines into an enum BALATON Zoltan
2021-10-27 21:54 ` [PATCH v3 07/18] hw/char/sh_serial: Add device id to trace output BALATON Zoltan
2021-10-28 0:36 ` Richard Henderson
2021-10-27 21:54 ` [PATCH v3 12/18] hw/intc/sh_intc: Move sh_intc_register() closer to its only user BALATON Zoltan
2021-10-28 0:52 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09bae4fbe771f45c70bf586942ed9324ffb20183.1635371671.git.balaton@eik.bme.hu \
--to=balaton@eik.bme.hu \
--cc=magnus.damm@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).