qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: BALATON Zoltan <balaton@eik.bme.hu>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Magnus Damm <magnus.damm@gmail.com>,
	Yoshinori Sato <ysato@users.sourceforge.jp>
Subject: Re: [PATCH v3 16/18] hw/intc/sh_intc: Replace abort() with g_assert_not_reached()
Date: Wed, 27 Oct 2021 17:57:34 -0700	[thread overview]
Message-ID: <b6418977-2399-a4cc-cde9-e16c84cca7ed@linaro.org> (raw)
In-Reply-To: <7552416b2ce900eb7abeba1b97ed959bd9b51284.1635371671.git.balaton@eik.bme.hu>

On 10/27/21 2:54 PM, BALATON Zoltan wrote:
> All the places that call abort should not happen which is better
> marked by g_assert_not_reached.
> 
> Signed-off-by: BALATON Zoltan<balaton@eik.bme.hu>
> ---
>   hw/intc/sh_intc.c | 8 +++-----
>   1 file changed, 3 insertions(+), 5 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~


  reply	other threads:[~2021-10-28  1:01 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-27 21:54 [PATCH v3 00/18] More SH4 clean ups BALATON Zoltan
2021-10-27 21:54 ` [PATCH v3 18/18] hw/intc/sh_intc: Simplify allocating sources array BALATON Zoltan
2021-10-27 21:54 ` [PATCH v3 03/18] hw/sh4: Change debug printfs to traces BALATON Zoltan
2021-10-28  0:31   ` Richard Henderson
2021-10-27 21:54 ` [PATCH v3 16/18] hw/intc/sh_intc: Replace abort() with g_assert_not_reached() BALATON Zoltan
2021-10-28  0:57   ` Richard Henderson [this message]
2021-10-27 21:54 ` [PATCH v3 01/18] hw/sh4: Fix typos in a comment BALATON Zoltan
2021-10-27 21:54 ` [PATCH v3 14/18] hw/intc/sh_intc: Use array index instead of pointer arithmetics BALATON Zoltan
2021-10-28  0:55   ` Richard Henderson
2021-10-27 21:54 ` [PATCH v3 13/18] hw/intc/sh_intc: Remove excessive parenthesis BALATON Zoltan
2021-10-28  0:54   ` Richard Henderson
2021-10-27 21:54 ` [PATCH v3 06/18] hw/char/sh_serial: QOM-ify BALATON Zoltan
2021-10-27 21:54 ` [PATCH v3 11/18] hw/intc/sh_intc: Drop another useless macro BALATON Zoltan
2021-10-28  0:52   ` Richard Henderson
2021-10-27 21:54 ` [PATCH v3 10/18] hw/intc/sh_intc: Rename iomem region BALATON Zoltan
2021-10-28  0:39   ` Richard Henderson
2021-10-27 21:54 ` [PATCH v3 17/18] hw/intc/sh_intc: Avoid using continue in loops BALATON Zoltan
2021-10-28  0:58   ` Richard Henderson
2021-10-27 21:54 ` [PATCH v3 05/18] hw/char/sh_serial: Rename type sh_serial_state to SHSerialState BALATON Zoltan
2021-10-28  0:31   ` Richard Henderson
2021-10-27 21:54 ` [PATCH v3 08/18] hw/intc/sh_intc: Use existing macro instead of local one BALATON Zoltan
2021-10-28  0:37   ` Richard Henderson
2021-10-27 21:54 ` [PATCH v3 02/18] hw//sh4: Use qemu_log instead of fprintf to stderr BALATON Zoltan
2021-10-27 21:54 ` [PATCH v3 15/18] hw/sh4/sh_intc: Inline and drop sh_intc_source() function BALATON Zoltan
2021-10-27 21:54 ` [PATCH v3 04/18] hw/sh4/r2d: Use error_report instead of fprintf to stderr BALATON Zoltan
2021-10-27 21:54 ` [PATCH v3 09/18] hw/intc/sh_intc: Turn some defines into an enum BALATON Zoltan
2021-10-27 21:54 ` [PATCH v3 07/18] hw/char/sh_serial: Add device id to trace output BALATON Zoltan
2021-10-28  0:36   ` Richard Henderson
2021-10-27 21:54 ` [PATCH v3 12/18] hw/intc/sh_intc: Move sh_intc_register() closer to its only user BALATON Zoltan
2021-10-28  0:52   ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b6418977-2399-a4cc-cde9-e16c84cca7ed@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=balaton@eik.bme.hu \
    --cc=magnus.damm@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).