From: David Hildenbrand <david@redhat.com>
To: Jonah Palmer <jonah.palmer@oracle.com>,
Laurent Vivier <lvivier@redhat.com>,
qemu-devel@nongnu.org
Cc: kwolf@redhat.com, thuth@redhat.com, mathieu.poirier@linaro.org,
qemu-block@nongnu.org, mst@redhat.com, armbru@redhat.com,
pbonzini@redhat.com, qemu_oss@crudebyte.com, groug@kaod.org,
dgilbert@redhat.com, eric.auger@redhat.com,
arei.gonglei@huawei.com, kraxel@redhat.com, stefanha@redhat.com,
michael.roth@amd.com, si-wei.liu@oracle.com,
marcandre.lureau@redhat.com, boris.ostrovsky@oracle.com,
raphael.norwitz@nutanix.com, eblake@redhat.com,
joao.m.martins@oracle.com
Subject: Re: [PATCH v8 5/8] qmp: decode feature & status bits in virtio-status
Date: Thu, 28 Oct 2021 09:57:53 +0200 [thread overview]
Message-ID: <0a61172e-0dd4-e740-68c9-d608fac32d4c@redhat.com> (raw)
In-Reply-To: <06347f30-203c-2dad-77d7-5d3dccdd8b3f@oracle.com>
On 28.10.21 09:56, Jonah Palmer wrote:
> On 10/27/21 08:18, Laurent Vivier wrote:
>> On 27/10/2021 13:59, David Hildenbrand wrote:
>>> On 27.10.21 13:41, Jonah Palmer wrote:
>>>> From: Laurent Vivier <lvivier@redhat.com>
>>>>
>>>> Display feature names instead of bitmaps for host, guest, and
>>>> backend for VirtIODevice.
>>>>
>>>> Display status names instead of bitmaps for VirtIODevice.
>>>>
>>>> Display feature names instead of bitmaps for backend, protocol,
>>>> acked, and features (hdev->features) for vhost devices.
>>>>
>>>> Decode features according to device type. Decode status
>>>> according to configuration status bitmap (config_status_map).
>>>> Decode vhost user protocol features according to vhost user
>>>> protocol bitmap (vhost_user_protocol_map).
>>>>
>>>> Transport features are on the first line. Undecoded bits
>>>> (if any) are stored in a separate field. Vhost device field
>>>> wont show if there's no vhost active for a given VirtIODevice.
>>>>
>>>> Signed-off-by: Jonah Palmer <jonah.palmer@oracle.com>
>>>> ---
>>>> hw/block/virtio-blk.c | 28 ++
>>>> hw/char/virtio-serial-bus.c | 11 +
>>>> hw/display/virtio-gpu-base.c | 18 +-
>>>> hw/input/virtio-input.c | 11 +-
>>>> hw/net/virtio-net.c | 47 ++++
>>>> hw/scsi/virtio-scsi.c | 17 ++
>>>> hw/virtio/vhost-user-fs.c | 10 +
>>>> hw/virtio/vhost-vsock-common.c | 10 +
>>>> hw/virtio/virtio-balloon.c | 14 +
>>>> hw/virtio/virtio-crypto.c | 10 +
>>>> hw/virtio/virtio-iommu.c | 14 +
>>>> hw/virtio/virtio.c | 273 ++++++++++++++++++-
>>>> include/hw/virtio/vhost.h | 3 +
>>>> include/hw/virtio/virtio.h | 17 ++
>>>> qapi/virtio.json | 577
>>>> ++++++++++++++++++++++++++++++++++++++---
>>>
>>> Any particular reason we're not handling virtio-mem?
>>>
>>> (there is only a single feature bit so far, a second one to be
>>> introduced soon)
>>>
>>
>> I think this is because the v1 of the series has been written in March
>> 2020 and it has not been update when virtio-mem has been added (June
>> 2020).
>>
>> Thanks,
>> Laurent
>
> Oops, I think I just might've missed this device. I can add in support for virtio-mem
> in the next revision!
Cool, thanks! I consider the introspection interface very valuable!
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2021-10-28 8:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 11:41 [PATCH v8 0/8] hmp,qmp: Add commands to introspect virtio devices Jonah Palmer
2021-10-27 11:41 ` [PATCH v8 1/8] virtio: drop name parameter for virtio_init() Jonah Palmer
2021-10-27 11:41 ` [PATCH v8 2/8] virtio: add vhost support for virtio devices Jonah Palmer
2021-10-27 11:41 ` [PATCH v8 3/8] qmp: add QMP command x-debug-query-virtio Jonah Palmer
2021-11-04 15:15 ` Markus Armbruster
2021-11-05 8:24 ` Jonah Palmer
2021-10-27 11:41 ` [PATCH v8 4/8] qmp: add QMP command x-debug-virtio-status Jonah Palmer
2021-11-04 15:37 ` Markus Armbruster
2021-11-05 8:36 ` Jonah Palmer
2021-10-27 11:41 ` [PATCH v8 5/8] qmp: decode feature & status bits in virtio-status Jonah Palmer
2021-10-27 11:59 ` David Hildenbrand
2021-10-27 12:18 ` Laurent Vivier
2021-10-28 7:56 ` Jonah Palmer
2021-10-28 7:57 ` David Hildenbrand [this message]
2021-10-27 11:41 ` [PATCH v8 6/8] qmp: add QMP commands for virtio/vhost queue-status Jonah Palmer
2021-10-27 11:41 ` [PATCH v8 7/8] qmp: add QMP command x-debug-virtio-queue-element Jonah Palmer
2021-10-27 11:41 ` [PATCH v8 8/8] hmp: add virtio commands Jonah Palmer
2021-11-05 7:23 ` Markus Armbruster
2021-11-05 8:40 ` Jonah Palmer
2021-10-27 11:55 ` [PATCH v8 0/8] hmp, qmp: Add commands to introspect virtio devices Daniel P. Berrangé
2021-10-28 7:54 ` Jonah Palmer
2021-10-28 9:04 ` Dr. David Alan Gilbert
2021-11-05 7:26 ` Markus Armbruster
2021-11-05 8:58 ` Jonah Palmer
2021-11-05 8:50 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a61172e-0dd4-e740-68c9-d608fac32d4c@redhat.com \
--to=david@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=boris.ostrovsky@oracle.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=eric.auger@redhat.com \
--cc=groug@kaod.org \
--cc=joao.m.martins@oracle.com \
--cc=jonah.palmer@oracle.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mathieu.poirier@linaro.org \
--cc=michael.roth@amd.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
--cc=raphael.norwitz@nutanix.com \
--cc=si-wei.liu@oracle.com \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).