From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Jonah Palmer <jonah.palmer@oracle.com>
Cc: mst@redhat.com, qemu_oss@crudebyte.com, qemu-devel@nongnu.org,
kraxel@redhat.com, si-wei.liu@oracle.com,
joao.m.martins@oracle.com, eblake@redhat.com,
qemu-block@nongnu.org, david@redhat.com, armbru@redhat.com,
arei.gonglei@huawei.com, marcandre.lureau@redhat.com,
lvivier@redhat.com, thuth@redhat.com, michael.roth@amd.com,
groug@kaod.org, eric.auger@redhat.com, stefanha@redhat.com,
boris.ostrovsky@oracle.com, kwolf@redhat.com,
"Daniel P. Berrangé" <berrange@redhat.com>,
mathieu.poirier@linaro.org, raphael.norwitz@nutanix.com,
pbonzini@redhat.com
Subject: Re: [PATCH v8 0/8] hmp, qmp: Add commands to introspect virtio devices
Date: Thu, 28 Oct 2021 10:04:47 +0100 [thread overview]
Message-ID: <YXpnrxnAdK9oEcLm@work-vm> (raw)
In-Reply-To: <4ee63834-cc75-ca3a-6333-ebbfc77f445a@oracle.com>
* Jonah Palmer (jonah.palmer@oracle.com) wrote:
>
> On 10/27/21 07:55, Daniel P. Berrangé wrote:
> > On Wed, Oct 27, 2021 at 07:41:41AM -0400, Jonah Palmer wrote:
> > > This series introduces new QMP/HMP commands to dump the status of a
> > > virtio device at different levels.
> > >
> > > [Jonah: Rebasing previous patchset from Oct. 5 (v7). Original patches
> > > are from Laurent Vivier from May 2020.
> > >
> > > Rebase from v7 to v8 includes an additional assert to make sure
> > > we're not returning NULL in virtio_id_to_name(). Rebase also
> > > includes minor additions/edits to qapi/virtio.json.]
> > >
> > > 1. Main command
> > >
> > > HMP Only:
> > >
> > > virtio [subcommand]
> > >
> > > Example:
> > >
> > > List all sub-commands:
> > >
> > > (qemu) virtio
> > > virtio query -- List all available virtio devices
> > > virtio status path -- Display status of a given virtio device
> > > virtio queue-status path queue -- Display status of a given virtio queue
> > > virtio vhost-queue-status path queue -- Display status of a given vhost queue
> > > virtio queue-element path queue [index] -- Display element of a given virtio queue
> > I don't see a compelling reason why these are setup as sub-commands
> > under a new "virtio" top level. This HMP approach and the QMP 'x-debug-query'
> > naming just feels needlessly different from the current QEMU practices.
> >
> > IMHO they should just be "info" subcommands for HMP. ie
> >
> > info virtio -- List all available virtio devices
> > info virtio-status path -- Display status of a given virtio device
> > info virtio-queue-status path queue -- Display status of a given virtio queue
> > info virtio-vhost-queue-status path queue -- Display status of a given vhost queue
> > info virtio-queue-element path queue [index] -- Display element of a given virtio queue
> >
> > While the corresponding QMP commands ought to be
> >
> > x-query-virtio
> > x-query-virtio-status
> > x-query-virtio-queue-status
> > x-query-virtio-vhost-queue-status
> > x-query-virtio-queue-element
> >
> >
> > Regards,
> > Daniel
>
> Sure, I don't mind changing it to this if this is what others would prefer.
> If there aren't any objections, I'll switch it to this in the next revision.
I agree with Dan that there's no need for the extra level; however
you could do it all in one HMP command I think:
info virtio -- list all available virtio devices
info virtio path -- Display status of a given virtio device
info virtio path queue -- Display status of a given virtio queue
info virtio -h path queue -- Display status of a given vhost queue
info virtio -e path queue [index] -- Display element of a given virtio
queue
It wouldn't need to change the qmp commands underneath unless it made
sense.
Dave
> Jonah
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2021-10-28 9:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 11:41 [PATCH v8 0/8] hmp,qmp: Add commands to introspect virtio devices Jonah Palmer
2021-10-27 11:41 ` [PATCH v8 1/8] virtio: drop name parameter for virtio_init() Jonah Palmer
2021-10-27 11:41 ` [PATCH v8 2/8] virtio: add vhost support for virtio devices Jonah Palmer
2021-10-27 11:41 ` [PATCH v8 3/8] qmp: add QMP command x-debug-query-virtio Jonah Palmer
2021-11-04 15:15 ` Markus Armbruster
2021-11-05 8:24 ` Jonah Palmer
2021-10-27 11:41 ` [PATCH v8 4/8] qmp: add QMP command x-debug-virtio-status Jonah Palmer
2021-11-04 15:37 ` Markus Armbruster
2021-11-05 8:36 ` Jonah Palmer
2021-10-27 11:41 ` [PATCH v8 5/8] qmp: decode feature & status bits in virtio-status Jonah Palmer
2021-10-27 11:59 ` David Hildenbrand
2021-10-27 12:18 ` Laurent Vivier
2021-10-28 7:56 ` Jonah Palmer
2021-10-28 7:57 ` David Hildenbrand
2021-10-27 11:41 ` [PATCH v8 6/8] qmp: add QMP commands for virtio/vhost queue-status Jonah Palmer
2021-10-27 11:41 ` [PATCH v8 7/8] qmp: add QMP command x-debug-virtio-queue-element Jonah Palmer
2021-10-27 11:41 ` [PATCH v8 8/8] hmp: add virtio commands Jonah Palmer
2021-11-05 7:23 ` Markus Armbruster
2021-11-05 8:40 ` Jonah Palmer
2021-10-27 11:55 ` [PATCH v8 0/8] hmp, qmp: Add commands to introspect virtio devices Daniel P. Berrangé
2021-10-28 7:54 ` Jonah Palmer
2021-10-28 9:04 ` Dr. David Alan Gilbert [this message]
2021-11-05 7:26 ` Markus Armbruster
2021-11-05 8:58 ` Jonah Palmer
2021-11-05 8:50 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXpnrxnAdK9oEcLm@work-vm \
--to=dgilbert@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david@redhat.com \
--cc=eblake@redhat.com \
--cc=eric.auger@redhat.com \
--cc=groug@kaod.org \
--cc=joao.m.martins@oracle.com \
--cc=jonah.palmer@oracle.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mathieu.poirier@linaro.org \
--cc=michael.roth@amd.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
--cc=raphael.norwitz@nutanix.com \
--cc=si-wei.liu@oracle.com \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).