* [PULL 00/33] Trivial branch patches
@ 2020-03-09 15:08 Laurent Vivier
2020-03-09 15:08 ` [PULL 01/33] dp8393x: Mask EOL bit from descriptor addresses, take 2 Laurent Vivier
` (35 more replies)
0 siblings, 36 replies; 45+ messages in thread
From: Laurent Vivier @ 2020-03-09 15:08 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Christian Schoenebeck, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Philippe Mathieu-Daudé,
Eduardo Habkost, Michael Tokarev, Alistair Francis, Greg Kurz,
Dr. David Alan Gilbert, qemu-arm, Paolo Bonzini, John Snow,
Richard Henderson, Kevin Wolf, Daniel P. Berrangé,
Igor Mitsyanko, Laurent Vivier, Max Reitz, Aleksandar Markovic,
Igor Mammedov, Aurelien Jarno
The following changes since commit 7a5853cec479a448edae0fb2aaf4e2f78c9c774d:
Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2020-03-09 10:32:53 +0000)
are available in the Git repository at:
git://github.com/vivier/qemu.git tags/trivial-branch-pull-request
for you to fetch changes up to 916c92503bd5348a33e561db600d8894bde636bb:
monitor/hmp-cmds: Remove redundant statement in hmp_rocker_of_dpa_groups() (2020-03-09 15:59:31 +0100)
----------------------------------------------------------------
- includes cleanup
- reduce .data footprint
- fix warnings reported by Clang static code analyzer
- fix dp8393x part lost in merge
- update git.orderfile and rules.mak
----------------------------------------------------------------
Chen Qun (7):
block/stream: Remove redundant statement in stream_run()
block/file-posix: Remove redundant statement in raw_handle_perm_lock()
dma/xlnx-zdma: Remove redundant statement in zdma_write_dst()
scsi/scsi-disk: Remove redundant statement in
scsi_disk_emulate_command()
display/pxa2xx_lcd: Remove redundant statement in
pxa2xx_palette_parse()
display/exynos4210_fimd: Remove redundant statement in
exynos4210_fimd_update()
monitor/hmp-cmds: Remove redundant statement in
hmp_rocker_of_dpa_groups()
Eric Blake (1):
maint: Include top-level *.rst files early in git diff
Finn Thain (1):
dp8393x: Mask EOL bit from descriptor addresses, take 2
Pan Nengyuan (1):
core/qdev: fix memleak in qdev_get_gpio_out_connector()
Philippe Mathieu-Daudé (23):
build-sys: Move the print-variable rule to rules.mak
hw/audio/fmopl: Fix a typo twice
hw/net/e1000: Add readops/writeops typedefs
hw/net/e1000: Move macreg[] arrays to .rodata to save 1MiB of .data
virtfs-proxy-helper: Make the helper_opts[] array const
vl: Add missing "hw/boards.h" include
hw/southbridge/ich9: Removed unused headers
hw/i386/ioapic_internal: Remove unused "hw/i386/ioapic.h" header
hw/timer: Remove unused "ui/console.h" header
hw/usb/dev-storage: Remove unused "ui/console.h" header
hw/i386/intel_iommu: Remove unused includes
hw/alpha/alpha_sys: Remove unused "hw/ide.h" header
hw/alpha/dp264: Include "net/net.h"
hw/hppa/machine: Include "net/net.h"
hw/acpi/cpu_hotplug: Include "hw/pci/pci.h"
hw/timer/hpet: Include "exec/address-spaces.h"
hw/pci-host/q35: Include "qemu/range.h"
hw/i2c/smbus_ich9: Include "qemu/range.h"
hw/pci-host/piix: Include "qemu/range.h"
hw/acpi: Include "hw/mem/nvdimm.h"
hw/i386: Include "hw/mem/nvdimm.h"
hw/pci-host/q35: Remove unused includes
hw/i386/pc: Clean up includes
Makefile | 3 ---
block/file-posix.c | 1 -
block/stream.c | 3 +--
fsdev/virtfs-proxy-helper.c | 2 +-
hw/acpi/cpu_hotplug.c | 1 +
hw/acpi/ich9.c | 2 +-
hw/acpi/piix4.c | 1 +
hw/alpha/alpha_sys.h | 1 -
hw/alpha/dp264.c | 1 +
hw/audio/fmopl.c | 4 ++--
hw/core/qdev.c | 2 +-
hw/display/exynos4210_fimd.c | 1 -
hw/display/pxa2xx_lcd.c | 1 -
hw/dma/xlnx-zdma.c | 10 +++++-----
hw/hppa/machine.c | 1 +
hw/i2c/smbus_ich9.c | 1 +
hw/i386/acpi-build.c | 1 +
hw/i386/pc.c | 1 +
hw/i386/pc_piix.c | 1 +
hw/i386/pc_q35.c | 1 +
hw/isa/lpc_ich9.c | 1 -
hw/net/dp8393x.c | 4 ++--
hw/net/e1000.c | 6 ++++--
hw/net/e1000e_core.c | 6 ++++--
hw/pci-host/i440fx.c | 1 +
hw/pci-host/q35.c | 1 +
hw/rtc/twl92230.c | 1 -
hw/scsi/scsi-disk.c | 1 -
hw/timer/hpet.c | 2 +-
hw/usb/dev-storage.c | 1 -
include/hw/i386/ich9.h | 1 -
include/hw/i386/intel_iommu.h | 4 ----
include/hw/i386/ioapic_internal.h | 1 -
include/hw/i386/pc.h | 11 +++--------
include/hw/pci-host/q35.h | 8 +-------
monitor/hmp-cmds.c | 5 +----
rules.mak | 3 +++
scripts/git.orderfile | 1 +
softmmu/vl.c | 1 +
39 files changed, 43 insertions(+), 55 deletions(-)
--
2.24.1
^ permalink raw reply [flat|nested] 45+ messages in thread
* [PULL 01/33] dp8393x: Mask EOL bit from descriptor addresses, take 2
2020-03-09 15:08 [PULL 00/33] Trivial branch patches Laurent Vivier
@ 2020-03-09 15:08 ` Laurent Vivier
2020-03-09 15:08 ` [PULL 02/33] maint: Include top-level *.rst files early in git diff Laurent Vivier
` (34 subsequent siblings)
35 siblings, 0 replies; 45+ messages in thread
From: Laurent Vivier @ 2020-03-09 15:08 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Christian Schoenebeck, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Finn Thain, Philippe Mathieu-Daudé,
Eduardo Habkost, Michael Tokarev, Alistair Francis, Greg Kurz,
Dr. David Alan Gilbert, qemu-arm, Paolo Bonzini, John Snow,
Richard Henderson, Kevin Wolf, Daniel P. Berrangé,
Igor Mitsyanko, Laurent Vivier, Max Reitz, Aleksandar Markovic,
Igor Mammedov, Aurelien Jarno
From: Finn Thain <fthain@telegraphics.com.au>
A portion of a recent patch got lost due to a merge snafu. That patch is
now commit 88f632fbb1 ("dp8393x: Mask EOL bit from descriptor addresses").
This patch restores the portion that got lost.
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <alpine.LNX.2.22.394.2003041421280.12@nippy.intranet>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
hw/net/dp8393x.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c
index 8a3504d9628e..81fc13ee9fa7 100644
--- a/hw/net/dp8393x.c
+++ b/hw/net/dp8393x.c
@@ -525,8 +525,8 @@ static void dp8393x_do_transmit_packets(dp8393xState *s)
* (4 + 3 * s->regs[SONIC_TFC]),
MEMTXATTRS_UNSPECIFIED, s->data,
size);
- s->regs[SONIC_CTDA] = dp8393x_get(s, width, 0) & ~0x1;
- if (dp8393x_get(s, width, 0) & SONIC_DESC_EOL) {
+ s->regs[SONIC_CTDA] = dp8393x_get(s, width, 0);
+ if (s->regs[SONIC_CTDA] & SONIC_DESC_EOL) {
/* EOL detected */
break;
}
--
2.24.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PULL 02/33] maint: Include top-level *.rst files early in git diff
2020-03-09 15:08 [PULL 00/33] Trivial branch patches Laurent Vivier
2020-03-09 15:08 ` [PULL 01/33] dp8393x: Mask EOL bit from descriptor addresses, take 2 Laurent Vivier
@ 2020-03-09 15:08 ` Laurent Vivier
2020-03-09 15:08 ` [PULL 03/33] build-sys: Move the print-variable rule to rules.mak Laurent Vivier
` (33 subsequent siblings)
35 siblings, 0 replies; 45+ messages in thread
From: Laurent Vivier @ 2020-03-09 15:08 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Christian Schoenebeck, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Philippe Mathieu-Daudé,
Stefano Garzarella, Eduardo Habkost, Michael Tokarev,
Alistair Francis, Greg Kurz, Dr. David Alan Gilbert, qemu-arm,
Paolo Bonzini, John Snow, Richard Henderson, Kevin Wolf,
Daniel P. Berrangé,
Igor Mitsyanko, Laurent Vivier, Max Reitz, Aleksandar Markovic,
Igor Mammedov, Aurelien Jarno
From: Eric Blake <eblake@redhat.com>
We are converting more doc files to *.rst rather than *.texi. Most
doc files are already listed early in diffs due to our catchall
docs/*, but a few top-level files get missed by that glob.
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Message-Id: <20200220162214.3474280-1-eblake@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
scripts/git.orderfile | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/git.orderfile b/scripts/git.orderfile
index 7cf22e0bf546..73fd818d7f3e 100644
--- a/scripts/git.orderfile
+++ b/scripts/git.orderfile
@@ -11,6 +11,7 @@
# Documentation
docs/*
+*.rst
*.texi
# build system
--
2.24.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PULL 03/33] build-sys: Move the print-variable rule to rules.mak
2020-03-09 15:08 [PULL 00/33] Trivial branch patches Laurent Vivier
2020-03-09 15:08 ` [PULL 01/33] dp8393x: Mask EOL bit from descriptor addresses, take 2 Laurent Vivier
2020-03-09 15:08 ` [PULL 02/33] maint: Include top-level *.rst files early in git diff Laurent Vivier
@ 2020-03-09 15:08 ` Laurent Vivier
2020-03-09 15:08 ` [PULL 04/33] hw/audio/fmopl: Fix a typo twice Laurent Vivier
` (32 subsequent siblings)
35 siblings, 0 replies; 45+ messages in thread
From: Laurent Vivier @ 2020-03-09 15:08 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Christian Schoenebeck, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Marc-André Lureau, Philippe Mathieu-Daudé,
Eduardo Habkost, Michael Tokarev, Alistair Francis, Greg Kurz,
Dr. David Alan Gilbert, qemu-arm, Paolo Bonzini, John Snow,
Richard Henderson, Kevin Wolf, Daniel P. Berrangé,
Igor Mitsyanko, Laurent Vivier, Max Reitz, Aleksandar Markovic,
Igor Mammedov, Aurelien Jarno
From: Philippe Mathieu-Daudé <philmd@redhat.com>
Currently the print-variable rule can only be used in the
root directory:
$ make print-vhost-user-json-y
vhost-user-json-y= contrib/vhost-user-gpu/50-qemu-gpu.json tools/virtiofsd/50-qemu-virtiofsd.json
$ make -C i386-softmmu print-obj-y
make: Entering directory 'build/i386-softmmu'
make: *** No rule to make target 'print-obj-y'. Stop.
make: Leaving directory 'build/i386-softmmu'
Move it to rules.mak so we can use it from other directories:
$ make -C i386-softmmu print-obj-y
make: Entering directory 'build/i386-softmmu'
obj-y=qapi-introspect.o qapi-types-machine-target.o qapi-types-misc-target.o qapi-types.o qapi-visit-machine-target.o qapi-visit-misc-target.o qapi-visit.o qapi-events-machine-target.o qapi-events-misc-target.o qapi-events.o qapi-commands-machine-target.o qapi-commands-misc-target.o qapi-commands.o qapi-init-commands.o
make: Leaving directory 'build/i386-softmmu'
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20200306170456.21977-1-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
Makefile | 3 ---
rules.mak | 3 +++
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/Makefile b/Makefile
index 2e930688942b..37aed4a24422 100644
--- a/Makefile
+++ b/Makefile
@@ -15,9 +15,6 @@ UNCHECKED_GOALS := %clean TAGS cscope ctags dist \
help check-help print-% \
docker docker-% vm-help vm-test vm-build-%
-print-%:
- @echo '$*=$($*)'
-
# All following code might depend on configuration variables
ifneq ($(wildcard config-host.mak),)
# Put the all: rule here so that config-host.mak can contain dependencies.
diff --git a/rules.mak b/rules.mak
index e39b073d4648..694865b63ee8 100644
--- a/rules.mak
+++ b/rules.mak
@@ -435,3 +435,6 @@ sentinel = .$(subst $(SPACE),_,$(subst /,_,$1)).sentinel.
atomic = $(eval $1: $(call sentinel,$1) ; @:) \
$(call sentinel,$1) : $2 ; @touch $$@ \
$(foreach t,$1,$(if $(wildcard $t),,$(shell rm -f $(call sentinel,$1))))
+
+print-%:
+ @echo '$*=$($*)'
--
2.24.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PULL 04/33] hw/audio/fmopl: Fix a typo twice
2020-03-09 15:08 [PULL 00/33] Trivial branch patches Laurent Vivier
` (2 preceding siblings ...)
2020-03-09 15:08 ` [PULL 03/33] build-sys: Move the print-variable rule to rules.mak Laurent Vivier
@ 2020-03-09 15:08 ` Laurent Vivier
2020-03-09 15:08 ` [PULL 05/33] hw/net/e1000: Add readops/writeops typedefs Laurent Vivier
` (31 subsequent siblings)
35 siblings, 0 replies; 45+ messages in thread
From: Laurent Vivier @ 2020-03-09 15:08 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Christian Schoenebeck, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Philippe Mathieu-Daudé,
Stefano Garzarella, Eduardo Habkost, Michael Tokarev,
Alistair Francis, Greg Kurz, Dr. David Alan Gilbert, qemu-arm,
Paolo Bonzini, John Snow, Richard Henderson, Kevin Wolf,
Daniel P. Berrangé,
Igor Mitsyanko, Laurent Vivier, Max Reitz, Aleksandar Markovic,
Igor Mammedov, Aurelien Jarno
From: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Message-Id: <20200305124525.14555-2-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
hw/audio/fmopl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/audio/fmopl.c b/hw/audio/fmopl.c
index 9f50a89b4a88..173a7521f2a7 100644
--- a/hw/audio/fmopl.c
+++ b/hw/audio/fmopl.c
@@ -1066,7 +1066,7 @@ static void OPLResetChip(FM_OPL *OPL)
}
}
-/* ---------- Create one of vietual YM3812 ---------- */
+/* ---------- Create one of virtual YM3812 ---------- */
/* 'rate' is sampling rate and 'bufsiz' is the size of the */
FM_OPL *OPLCreate(int clock, int rate)
{
@@ -1115,7 +1115,7 @@ FM_OPL *OPLCreate(int clock, int rate)
return OPL;
}
-/* ---------- Destroy one of vietual YM3812 ---------- */
+/* ---------- Destroy one of virtual YM3812 ---------- */
void OPLDestroy(FM_OPL *OPL)
{
#ifdef OPL_OUTPUT_LOG
--
2.24.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PULL 05/33] hw/net/e1000: Add readops/writeops typedefs
2020-03-09 15:08 [PULL 00/33] Trivial branch patches Laurent Vivier
` (3 preceding siblings ...)
2020-03-09 15:08 ` [PULL 04/33] hw/audio/fmopl: Fix a typo twice Laurent Vivier
@ 2020-03-09 15:08 ` Laurent Vivier
2020-03-09 15:08 ` [PULL 06/33] hw/net/e1000: Move macreg[] arrays to .rodata to save 1MiB of .data Laurent Vivier
` (30 subsequent siblings)
35 siblings, 0 replies; 45+ messages in thread
From: Laurent Vivier @ 2020-03-09 15:08 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Christian Schoenebeck, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Philippe Mathieu-Daudé,
Stefano Garzarella, Eduardo Habkost, Michael Tokarev,
Alistair Francis, Greg Kurz, Dr. David Alan Gilbert, qemu-arm,
Paolo Bonzini, John Snow, Richard Henderson, Kevin Wolf,
Daniel P. Berrangé,
Igor Mitsyanko, Laurent Vivier, Max Reitz, Aleksandar Markovic,
Igor Mammedov, Aurelien Jarno
From: Philippe Mathieu-Daudé <philmd@redhat.com>
Express the macreg[] arrays using typedefs.
No logical changes introduced here.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Dmitry Fleytman <dmitry.fleytman@gmail.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Message-Id: <20200305010446.17029-2-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
hw/net/e1000.c | 6 ++++--
hw/net/e1000e_core.c | 6 ++++--
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/hw/net/e1000.c b/hw/net/e1000.c
index 0b833d5a152e..972d9b508399 100644
--- a/hw/net/e1000.c
+++ b/hw/net/e1000.c
@@ -1150,7 +1150,8 @@ set_ims(E1000State *s, int index, uint32_t val)
}
#define getreg(x) [x] = mac_readreg
-static uint32_t (*macreg_readops[])(E1000State *, int) = {
+typedef uint32_t (*readops)(E1000State *, int);
+static readops macreg_readops[] = {
getreg(PBA), getreg(RCTL), getreg(TDH), getreg(TXDCTL),
getreg(WUFC), getreg(TDT), getreg(CTRL), getreg(LEDCTL),
getreg(MANC), getreg(MDIC), getreg(SWSM), getreg(STATUS),
@@ -1205,7 +1206,8 @@ static uint32_t (*macreg_readops[])(E1000State *, int) = {
enum { NREADOPS = ARRAY_SIZE(macreg_readops) };
#define putreg(x) [x] = mac_writereg
-static void (*macreg_writeops[])(E1000State *, int, uint32_t) = {
+typedef void (*writeops)(E1000State *, int, uint32_t);
+static writeops macreg_writeops[] = {
putreg(PBA), putreg(EERD), putreg(SWSM), putreg(WUFC),
putreg(TDBAL), putreg(TDBAH), putreg(TXDCTL), putreg(RDBAH),
putreg(RDBAL), putreg(LEDCTL), putreg(VET), putreg(FCRUC),
diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c
index 94ea34dca56d..38bdb90114c6 100644
--- a/hw/net/e1000e_core.c
+++ b/hw/net/e1000e_core.c
@@ -2855,7 +2855,8 @@ e1000e_set_gcr(E1000ECore *core, int index, uint32_t val)
}
#define e1000e_getreg(x) [x] = e1000e_mac_readreg
-static uint32_t (*e1000e_macreg_readops[])(E1000ECore *, int) = {
+typedef uint32_t (*readops)(E1000ECore *, int);
+static readops e1000e_macreg_readops[] = {
e1000e_getreg(PBA),
e1000e_getreg(WUFC),
e1000e_getreg(MANC),
@@ -3061,7 +3062,8 @@ static uint32_t (*e1000e_macreg_readops[])(E1000ECore *, int) = {
enum { E1000E_NREADOPS = ARRAY_SIZE(e1000e_macreg_readops) };
#define e1000e_putreg(x) [x] = e1000e_mac_writereg
-static void (*e1000e_macreg_writeops[])(E1000ECore *, int, uint32_t) = {
+typedef void (*writeops)(E1000ECore *, int, uint32_t);
+static writeops e1000e_macreg_writeops[] = {
e1000e_putreg(PBA),
e1000e_putreg(SWSM),
e1000e_putreg(WUFC),
--
2.24.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PULL 06/33] hw/net/e1000: Move macreg[] arrays to .rodata to save 1MiB of .data
2020-03-09 15:08 [PULL 00/33] Trivial branch patches Laurent Vivier
` (4 preceding siblings ...)
2020-03-09 15:08 ` [PULL 05/33] hw/net/e1000: Add readops/writeops typedefs Laurent Vivier
@ 2020-03-09 15:08 ` Laurent Vivier
2020-03-09 15:08 ` [PULL 07/33] virtfs-proxy-helper: Make the helper_opts[] array const Laurent Vivier
` (29 subsequent siblings)
35 siblings, 0 replies; 45+ messages in thread
From: Laurent Vivier @ 2020-03-09 15:08 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Christian Schoenebeck, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Philippe Mathieu-Daudé,
Stefano Garzarella, Eduardo Habkost, Michael Tokarev,
Alistair Francis, Greg Kurz, Dr. David Alan Gilbert, qemu-arm,
Paolo Bonzini, John Snow, Richard Henderson, Kevin Wolf,
Daniel P. Berrangé,
Igor Mitsyanko, Laurent Vivier, Max Reitz, Aleksandar Markovic,
Igor Mammedov, Aurelien Jarno
From: Philippe Mathieu-Daudé <philmd@redhat.com>
Each array consumes 256KiB of .data. As we do not reassign entries,
we can move it to the .rodata section, and save a total of 1MiB of
.data (size reported on x86_64 host).
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Dmitry Fleytman <dmitry.fleytman@gmail.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Message-Id: <20200305010446.17029-3-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
hw/net/e1000.c | 4 ++--
hw/net/e1000e_core.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/net/e1000.c b/hw/net/e1000.c
index 972d9b508399..9233248c9af0 100644
--- a/hw/net/e1000.c
+++ b/hw/net/e1000.c
@@ -1151,7 +1151,7 @@ set_ims(E1000State *s, int index, uint32_t val)
#define getreg(x) [x] = mac_readreg
typedef uint32_t (*readops)(E1000State *, int);
-static readops macreg_readops[] = {
+static const readops macreg_readops[] = {
getreg(PBA), getreg(RCTL), getreg(TDH), getreg(TXDCTL),
getreg(WUFC), getreg(TDT), getreg(CTRL), getreg(LEDCTL),
getreg(MANC), getreg(MDIC), getreg(SWSM), getreg(STATUS),
@@ -1207,7 +1207,7 @@ enum { NREADOPS = ARRAY_SIZE(macreg_readops) };
#define putreg(x) [x] = mac_writereg
typedef void (*writeops)(E1000State *, int, uint32_t);
-static writeops macreg_writeops[] = {
+static const writeops macreg_writeops[] = {
putreg(PBA), putreg(EERD), putreg(SWSM), putreg(WUFC),
putreg(TDBAL), putreg(TDBAH), putreg(TXDCTL), putreg(RDBAH),
putreg(RDBAL), putreg(LEDCTL), putreg(VET), putreg(FCRUC),
diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c
index 38bdb90114c6..df957e0c1a09 100644
--- a/hw/net/e1000e_core.c
+++ b/hw/net/e1000e_core.c
@@ -2856,7 +2856,7 @@ e1000e_set_gcr(E1000ECore *core, int index, uint32_t val)
#define e1000e_getreg(x) [x] = e1000e_mac_readreg
typedef uint32_t (*readops)(E1000ECore *, int);
-static readops e1000e_macreg_readops[] = {
+static const readops e1000e_macreg_readops[] = {
e1000e_getreg(PBA),
e1000e_getreg(WUFC),
e1000e_getreg(MANC),
@@ -3063,7 +3063,7 @@ enum { E1000E_NREADOPS = ARRAY_SIZE(e1000e_macreg_readops) };
#define e1000e_putreg(x) [x] = e1000e_mac_writereg
typedef void (*writeops)(E1000ECore *, int, uint32_t);
-static writeops e1000e_macreg_writeops[] = {
+static const writeops e1000e_macreg_writeops[] = {
e1000e_putreg(PBA),
e1000e_putreg(SWSM),
e1000e_putreg(WUFC),
--
2.24.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PULL 07/33] virtfs-proxy-helper: Make the helper_opts[] array const
2020-03-09 15:08 [PULL 00/33] Trivial branch patches Laurent Vivier
` (5 preceding siblings ...)
2020-03-09 15:08 ` [PULL 06/33] hw/net/e1000: Move macreg[] arrays to .rodata to save 1MiB of .data Laurent Vivier
@ 2020-03-09 15:08 ` Laurent Vivier
2020-03-09 15:08 ` [PULL 08/33] vl: Add missing "hw/boards.h" include Laurent Vivier
` (28 subsequent siblings)
35 siblings, 0 replies; 45+ messages in thread
From: Laurent Vivier @ 2020-03-09 15:08 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Christian Schoenebeck, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Philippe Mathieu-Daudé,
Stefano Garzarella, Eduardo Habkost, Michael Tokarev,
Alistair Francis, Greg Kurz, Dr. David Alan Gilbert, qemu-arm,
Paolo Bonzini, John Snow, Richard Henderson, Kevin Wolf,
Daniel P. Berrangé,
Igor Mitsyanko, Laurent Vivier, Max Reitz, Aleksandar Markovic,
Igor Mammedov, Aurelien Jarno
From: Philippe Mathieu-Daudé <philmd@redhat.com>
Reduce a bit the memory footprint by making the helper_opts[]
array const.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: Greg Kurz <groug@kaod.org>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Message-Id: <20200305010446.17029-4-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
fsdev/virtfs-proxy-helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c
index aa1ab2590d42..de061a8a0eaa 100644
--- a/fsdev/virtfs-proxy-helper.c
+++ b/fsdev/virtfs-proxy-helper.c
@@ -43,7 +43,7 @@
#define BTRFS_SUPER_MAGIC 0x9123683E
#endif
-static struct option helper_opts[] = {
+static const struct option helper_opts[] = {
{"fd", required_argument, NULL, 'f'},
{"path", required_argument, NULL, 'p'},
{"nodaemon", no_argument, NULL, 'n'},
--
2.24.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PULL 08/33] vl: Add missing "hw/boards.h" include
2020-03-09 15:08 [PULL 00/33] Trivial branch patches Laurent Vivier
` (6 preceding siblings ...)
2020-03-09 15:08 ` [PULL 07/33] virtfs-proxy-helper: Make the helper_opts[] array const Laurent Vivier
@ 2020-03-09 15:08 ` Laurent Vivier
2020-03-09 15:08 ` [PULL 09/33] hw/southbridge/ich9: Removed unused headers Laurent Vivier
` (27 subsequent siblings)
35 siblings, 0 replies; 45+ messages in thread
From: Laurent Vivier @ 2020-03-09 15:08 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Christian Schoenebeck, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Philippe Mathieu-Daudé,
Eduardo Habkost, Michael Tokarev, Alistair Francis,
Richard Henderson, Greg Kurz, Dr. David Alan Gilbert, qemu-arm,
Paolo Bonzini, John Snow, Richard Henderson, Kevin Wolf,
Daniel P. Berrangé,
Igor Mitsyanko, Laurent Vivier, Max Reitz, Aleksandar Markovic,
Igor Mammedov, Aurelien Jarno
From: Philippe Mathieu-Daudé <philmd@redhat.com>
vl.c calls machine_usb() declared in "hw/boards.h". Include it.
This fixes (when modifying unrelated headers):
vl.c:1283:10: error: implicit declaration of function 'machine_usb' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
if (!machine_usb(current_machine)) {
^
vl.c:1283:10: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes]
vl.c:1283:22: error: use of undeclared identifier 'current_machine'
if (!machine_usb(current_machine)) {
^
Acked-by: John Snow <jsnow@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200228114649.12818-2-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
softmmu/vl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/softmmu/vl.c b/softmmu/vl.c
index 5549f4b61986..ff2685dff845 100644
--- a/softmmu/vl.c
+++ b/softmmu/vl.c
@@ -25,6 +25,7 @@
#include "qemu/osdep.h"
#include "qemu-common.h"
#include "qemu/units.h"
+#include "hw/boards.h"
#include "hw/qdev-properties.h"
#include "qapi/error.h"
#include "qemu-version.h"
--
2.24.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PULL 09/33] hw/southbridge/ich9: Removed unused headers
2020-03-09 15:08 [PULL 00/33] Trivial branch patches Laurent Vivier
` (7 preceding siblings ...)
2020-03-09 15:08 ` [PULL 08/33] vl: Add missing "hw/boards.h" include Laurent Vivier
@ 2020-03-09 15:08 ` Laurent Vivier
2020-03-09 15:08 ` [PULL 10/33] hw/i386/ioapic_internal: Remove unused "hw/i386/ioapic.h" header Laurent Vivier
` (26 subsequent siblings)
35 siblings, 0 replies; 45+ messages in thread
From: Laurent Vivier @ 2020-03-09 15:08 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Christian Schoenebeck, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Philippe Mathieu-Daudé,
Eduardo Habkost, Michael Tokarev, Alistair Francis,
Richard Henderson, Greg Kurz, Dr. David Alan Gilbert, qemu-arm,
Paolo Bonzini, John Snow, Richard Henderson, Kevin Wolf,
Daniel P. Berrangé,
Igor Mitsyanko, Laurent Vivier, Max Reitz, Aleksandar Markovic,
Igor Mammedov, Aurelien Jarno
From: Philippe Mathieu-Daudé <philmd@redhat.com>
The ICH9 chipset is not X86/PC specific.
These files don't use anything declared by the "hw/i386/pc.h"
or "hw/i386/ioapic.h" headers. Remove them.
Reviewed-by: John Snow <jsnow@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200228114649.12818-3-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
hw/acpi/ich9.c | 1 -
hw/isa/lpc_ich9.c | 1 -
include/hw/i386/ich9.h | 1 -
3 files changed, 3 deletions(-)
diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c
index 2034dd749edc..fdd0a6c79e11 100644
--- a/hw/acpi/ich9.c
+++ b/hw/acpi/ich9.c
@@ -27,7 +27,6 @@
#include "qemu/osdep.h"
#include "qapi/error.h"
#include "qapi/visitor.h"
-#include "hw/i386/pc.h"
#include "hw/pci/pci.h"
#include "migration/vmstate.h"
#include "qemu/timer.h"
diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c
index f85b484eac63..cb79616cede8 100644
--- a/hw/isa/lpc_ich9.c
+++ b/hw/isa/lpc_ich9.c
@@ -37,7 +37,6 @@
#include "migration/vmstate.h"
#include "hw/irq.h"
#include "hw/isa/apm.h"
-#include "hw/i386/ioapic.h"
#include "hw/pci/pci.h"
#include "hw/pci/pci_bridge.h"
#include "hw/i386/ich9.h"
diff --git a/include/hw/i386/ich9.h b/include/hw/i386/ich9.h
index 72e803f6e2e0..a98d10b252df 100644
--- a/include/hw/i386/ich9.h
+++ b/include/hw/i386/ich9.h
@@ -5,7 +5,6 @@
#include "hw/sysbus.h"
#include "hw/i386/pc.h"
#include "hw/isa/apm.h"
-#include "hw/i386/ioapic.h"
#include "hw/pci/pci.h"
#include "hw/pci/pcie_host.h"
#include "hw/pci/pci_bridge.h"
--
2.24.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PULL 10/33] hw/i386/ioapic_internal: Remove unused "hw/i386/ioapic.h" header
2020-03-09 15:08 [PULL 00/33] Trivial branch patches Laurent Vivier
` (8 preceding siblings ...)
2020-03-09 15:08 ` [PULL 09/33] hw/southbridge/ich9: Removed unused headers Laurent Vivier
@ 2020-03-09 15:08 ` Laurent Vivier
2020-03-09 15:08 ` [PULL 11/33] hw/timer: Remove unused "ui/console.h" header Laurent Vivier
` (25 subsequent siblings)
35 siblings, 0 replies; 45+ messages in thread
From: Laurent Vivier @ 2020-03-09 15:08 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Christian Schoenebeck, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Philippe Mathieu-Daudé,
Eduardo Habkost, Michael Tokarev, Alistair Francis,
Richard Henderson, Greg Kurz, Dr. David Alan Gilbert, qemu-arm,
Paolo Bonzini, John Snow, Richard Henderson, Kevin Wolf,
Daniel P. Berrangé,
Igor Mitsyanko, Laurent Vivier, Max Reitz, Aleksandar Markovic,
Igor Mammedov, Aurelien Jarno
From: Philippe Mathieu-Daudé <philmd@redhat.com>
The "ioapic_internal.h" does not use anything from
"hw/i386/ioapic.h", remove it.
Acked-by: John Snow <jsnow@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200228114649.12818-4-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
include/hw/i386/ioapic_internal.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/hw/i386/ioapic_internal.h b/include/hw/i386/ioapic_internal.h
index d46c87c51030..fe06938bda47 100644
--- a/include/hw/i386/ioapic_internal.h
+++ b/include/hw/i386/ioapic_internal.h
@@ -23,7 +23,6 @@
#define QEMU_IOAPIC_INTERNAL_H
#include "exec/memory.h"
-#include "hw/i386/ioapic.h"
#include "hw/sysbus.h"
#include "qemu/notify.h"
--
2.24.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PULL 11/33] hw/timer: Remove unused "ui/console.h" header
2020-03-09 15:08 [PULL 00/33] Trivial branch patches Laurent Vivier
` (9 preceding siblings ...)
2020-03-09 15:08 ` [PULL 10/33] hw/i386/ioapic_internal: Remove unused "hw/i386/ioapic.h" header Laurent Vivier
@ 2020-03-09 15:08 ` Laurent Vivier
2020-03-09 15:08 ` [PULL 12/33] hw/usb/dev-storage: " Laurent Vivier
` (24 subsequent siblings)
35 siblings, 0 replies; 45+ messages in thread
From: Laurent Vivier @ 2020-03-09 15:08 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Christian Schoenebeck, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Philippe Mathieu-Daudé,
Eduardo Habkost, Michael Tokarev, Alistair Francis,
Richard Henderson, Greg Kurz, Dr. David Alan Gilbert, qemu-arm,
Paolo Bonzini, John Snow, Richard Henderson, Kevin Wolf,
Daniel P. Berrangé,
Igor Mitsyanko, Laurent Vivier, Max Reitz, Aleksandar Markovic,
Igor Mammedov, Aurelien Jarno
From: Philippe Mathieu-Daudé <philmd@redhat.com>
The timer models don't need anything from "ui/console.h".
Remove it.
Acked-by: John Snow <jsnow@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200228114649.12818-5-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
hw/rtc/twl92230.c | 1 -
hw/timer/hpet.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/hw/rtc/twl92230.c b/hw/rtc/twl92230.c
index 63bd13d2caa4..d0011be89eef 100644
--- a/hw/rtc/twl92230.c
+++ b/hw/rtc/twl92230.c
@@ -27,7 +27,6 @@
#include "migration/qemu-file-types.h"
#include "migration/vmstate.h"
#include "sysemu/sysemu.h"
-#include "ui/console.h"
#include "qemu/bcd.h"
#include "qemu/module.h"
diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c
index 8dbcbdca16a6..4f30dd50a40a 100644
--- a/hw/timer/hpet.c
+++ b/hw/timer/hpet.c
@@ -27,7 +27,6 @@
#include "qemu/osdep.h"
#include "hw/i386/pc.h"
#include "hw/irq.h"
-#include "ui/console.h"
#include "qapi/error.h"
#include "qemu/error-report.h"
#include "qemu/timer.h"
--
2.24.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PULL 12/33] hw/usb/dev-storage: Remove unused "ui/console.h" header
2020-03-09 15:08 [PULL 00/33] Trivial branch patches Laurent Vivier
` (10 preceding siblings ...)
2020-03-09 15:08 ` [PULL 11/33] hw/timer: Remove unused "ui/console.h" header Laurent Vivier
@ 2020-03-09 15:08 ` Laurent Vivier
2020-03-09 15:08 ` [PULL 13/33] hw/i386/intel_iommu: Remove unused includes Laurent Vivier
` (23 subsequent siblings)
35 siblings, 0 replies; 45+ messages in thread
From: Laurent Vivier @ 2020-03-09 15:08 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Christian Schoenebeck, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Philippe Mathieu-Daudé,
Eduardo Habkost, Michael Tokarev, Alistair Francis,
Richard Henderson, Greg Kurz, Dr. David Alan Gilbert, qemu-arm,
Paolo Bonzini, John Snow, Richard Henderson, Kevin Wolf,
Daniel P. Berrangé,
Igor Mitsyanko, Laurent Vivier, Max Reitz, Aleksandar Markovic,
Igor Mammedov, Aurelien Jarno
From: Philippe Mathieu-Daudé <philmd@redhat.com>
The USB models related to storage don't need anything from
"ui/console.h". Remove it.
Acked-by: John Snow <jsnow@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200228114649.12818-6-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
hw/usb/dev-storage.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c
index 90da008df18c..4883c1d89e0c 100644
--- a/hw/usb/dev-storage.c
+++ b/hw/usb/dev-storage.c
@@ -17,7 +17,6 @@
#include "desc.h"
#include "hw/qdev-properties.h"
#include "hw/scsi/scsi.h"
-#include "ui/console.h"
#include "migration/vmstate.h"
#include "monitor/monitor.h"
#include "sysemu/sysemu.h"
--
2.24.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PULL 13/33] hw/i386/intel_iommu: Remove unused includes
2020-03-09 15:08 [PULL 00/33] Trivial branch patches Laurent Vivier
` (11 preceding siblings ...)
2020-03-09 15:08 ` [PULL 12/33] hw/usb/dev-storage: " Laurent Vivier
@ 2020-03-09 15:08 ` Laurent Vivier
2020-03-09 15:08 ` [PULL 14/33] hw/alpha/alpha_sys: Remove unused "hw/ide.h" header Laurent Vivier
` (22 subsequent siblings)
35 siblings, 0 replies; 45+ messages in thread
From: Laurent Vivier @ 2020-03-09 15:08 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Christian Schoenebeck, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Philippe Mathieu-Daudé,
Eduardo Habkost, Michael Tokarev, Alistair Francis,
Richard Henderson, Greg Kurz, Dr. David Alan Gilbert, qemu-arm,
Paolo Bonzini, John Snow, Richard Henderson, Kevin Wolf,
Daniel P. Berrangé,
Igor Mitsyanko, Laurent Vivier, Max Reitz, Aleksandar Markovic,
Igor Mammedov, Aurelien Jarno
From: Philippe Mathieu-Daudé <philmd@redhat.com>
intel_iommu.h does not use any of these includes, remove them.
Acked-by: John Snow <jsnow@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200228114649.12818-7-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
include/hw/i386/intel_iommu.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/include/hw/i386/intel_iommu.h b/include/hw/i386/intel_iommu.h
index 66b931e52628..a1c4afcda5c9 100644
--- a/include/hw/i386/intel_iommu.h
+++ b/include/hw/i386/intel_iommu.h
@@ -22,11 +22,7 @@
#ifndef INTEL_IOMMU_H
#define INTEL_IOMMU_H
-#include "sysemu/dma.h"
#include "hw/i386/x86-iommu.h"
-#include "hw/i386/ioapic.h"
-#include "hw/pci/msi.h"
-#include "hw/sysbus.h"
#include "qemu/iova-tree.h"
#define TYPE_INTEL_IOMMU_DEVICE "intel-iommu"
--
2.24.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PULL 14/33] hw/alpha/alpha_sys: Remove unused "hw/ide.h" header
2020-03-09 15:08 [PULL 00/33] Trivial branch patches Laurent Vivier
` (12 preceding siblings ...)
2020-03-09 15:08 ` [PULL 13/33] hw/i386/intel_iommu: Remove unused includes Laurent Vivier
@ 2020-03-09 15:08 ` Laurent Vivier
2020-03-09 15:08 ` [PULL 15/33] hw/alpha/dp264: Include "net/net.h" Laurent Vivier
` (21 subsequent siblings)
35 siblings, 0 replies; 45+ messages in thread
From: Laurent Vivier @ 2020-03-09 15:08 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Christian Schoenebeck, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Philippe Mathieu-Daudé,
Eduardo Habkost, Michael Tokarev, Alistair Francis,
Richard Henderson, Greg Kurz, Dr. David Alan Gilbert, qemu-arm,
Paolo Bonzini, John Snow, Richard Henderson, Kevin Wolf,
Daniel P. Berrangé,
Igor Mitsyanko, Laurent Vivier, Max Reitz, Aleksandar Markovic,
Igor Mammedov, Aurelien Jarno
From: Philippe Mathieu-Daudé <philmd@redhat.com>
alpha_sys.h does not use anything from the "hw/ide.h" header.
Remove it.
Acked-by: John Snow <jsnow@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200228114649.12818-8-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
hw/alpha/alpha_sys.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/alpha/alpha_sys.h b/hw/alpha/alpha_sys.h
index bc0a286226f1..e2c02e2bbe1d 100644
--- a/hw/alpha/alpha_sys.h
+++ b/hw/alpha/alpha_sys.h
@@ -6,7 +6,6 @@
#include "target/alpha/cpu-qom.h"
#include "hw/pci/pci.h"
#include "hw/pci/pci_host.h"
-#include "hw/ide.h"
#include "hw/boards.h"
#include "hw/intc/i8259.h"
--
2.24.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PULL 15/33] hw/alpha/dp264: Include "net/net.h"
2020-03-09 15:08 [PULL 00/33] Trivial branch patches Laurent Vivier
` (13 preceding siblings ...)
2020-03-09 15:08 ` [PULL 14/33] hw/alpha/alpha_sys: Remove unused "hw/ide.h" header Laurent Vivier
@ 2020-03-09 15:08 ` Laurent Vivier
2020-03-09 15:08 ` [PULL 16/33] hw/hppa/machine: " Laurent Vivier
` (20 subsequent siblings)
35 siblings, 0 replies; 45+ messages in thread
From: Laurent Vivier @ 2020-03-09 15:08 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Christian Schoenebeck, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Philippe Mathieu-Daudé,
Eduardo Habkost, Michael Tokarev, Alistair Francis,
Richard Henderson, Greg Kurz, Dr. David Alan Gilbert, qemu-arm,
Paolo Bonzini, John Snow, Richard Henderson, Kevin Wolf,
Daniel P. Berrangé,
Igor Mitsyanko, Laurent Vivier, Max Reitz, Aleksandar Markovic,
Igor Mammedov, Aurelien Jarno
From: Philippe Mathieu-Daudé <philmd@redhat.com>
hw/alpha/dp264.c uses NICInfo variables which are declared in
"net/net.h". Include it.
This fixes (when modifying unrelated headers):
hw/alpha/dp264.c:89:21: error: use of undeclared identifier 'nb_nics'
for (i = 0; i < nb_nics; i++) {
^
hw/alpha/dp264.c:90:30: error: use of undeclared identifier 'nd_table'
pci_nic_init_nofail(&nd_table[i], pci_bus, "e1000", NULL);
^
Acked-by: John Snow <jsnow@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200228114649.12818-9-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
hw/alpha/dp264.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/alpha/dp264.c b/hw/alpha/dp264.c
index d28f57199fa1..e5350a287f73 100644
--- a/hw/alpha/dp264.c
+++ b/hw/alpha/dp264.c
@@ -21,6 +21,7 @@
#include "hw/dma/i8257.h"
#include "net/net.h"
#include "qemu/cutils.h"
+#include "net/net.h"
#define MAX_IDE_BUS 2
--
2.24.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PULL 16/33] hw/hppa/machine: Include "net/net.h"
2020-03-09 15:08 [PULL 00/33] Trivial branch patches Laurent Vivier
` (14 preceding siblings ...)
2020-03-09 15:08 ` [PULL 15/33] hw/alpha/dp264: Include "net/net.h" Laurent Vivier
@ 2020-03-09 15:08 ` Laurent Vivier
2020-03-09 15:08 ` [PULL 17/33] hw/acpi/cpu_hotplug: Include "hw/pci/pci.h" Laurent Vivier
` (19 subsequent siblings)
35 siblings, 0 replies; 45+ messages in thread
From: Laurent Vivier @ 2020-03-09 15:08 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Christian Schoenebeck, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Philippe Mathieu-Daudé,
Eduardo Habkost, Michael Tokarev, Alistair Francis,
Richard Henderson, Greg Kurz, Dr. David Alan Gilbert, qemu-arm,
Paolo Bonzini, John Snow, Richard Henderson, Kevin Wolf,
Daniel P. Berrangé,
Igor Mitsyanko, Laurent Vivier, Max Reitz, Aleksandar Markovic,
Igor Mammedov, Aurelien Jarno
From: Philippe Mathieu-Daudé <philmd@redhat.com>
hw/hppa/machine.c uses NICInfo variables which are declared in
"net/net.h". Include it.
This fixes (when modifying unrelated headers):
hw/hppa/machine.c:126:21: error: use of undeclared identifier 'nb_nics'
for (i = 0; i < nb_nics; i++) {
^
hw/hppa/machine.c:127:30: error: use of undeclared identifier 'nd_table'
pci_nic_init_nofail(&nd_table[i], pci_bus, "e1000", NULL);
^
Acked-by: John Snow <jsnow@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200228114649.12818-10-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
hw/hppa/machine.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c
index bf18767e2494..9175f4b790f5 100644
--- a/hw/hppa/machine.c
+++ b/hw/hppa/machine.c
@@ -22,6 +22,7 @@
#include "qapi/error.h"
#include "net/net.h"
#include "qemu/log.h"
+#include "net/net.h"
#define MAX_IDE_BUS 2
--
2.24.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PULL 17/33] hw/acpi/cpu_hotplug: Include "hw/pci/pci.h"
2020-03-09 15:08 [PULL 00/33] Trivial branch patches Laurent Vivier
` (15 preceding siblings ...)
2020-03-09 15:08 ` [PULL 16/33] hw/hppa/machine: " Laurent Vivier
@ 2020-03-09 15:08 ` Laurent Vivier
2020-03-09 15:08 ` [PULL 18/33] hw/timer/hpet: Include "exec/address-spaces.h" Laurent Vivier
` (18 subsequent siblings)
35 siblings, 0 replies; 45+ messages in thread
From: Laurent Vivier @ 2020-03-09 15:08 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Christian Schoenebeck, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Philippe Mathieu-Daudé,
Eduardo Habkost, Michael Tokarev, Alistair Francis,
Richard Henderson, Greg Kurz, Dr. David Alan Gilbert, qemu-arm,
Paolo Bonzini, John Snow, Richard Henderson, Kevin Wolf,
Daniel P. Berrangé,
Igor Mitsyanko, Laurent Vivier, Max Reitz, Aleksandar Markovic,
Igor Mammedov, Aurelien Jarno
From: Philippe Mathieu-Daudé <philmd@redhat.com>
hw/acpi/cpu_hotplug.c calls pci_address_space_io(). Include
"hw/pci/pci.h" which declares it.
This fixes (when modifying unrelated headers):
hw/acpi/cpu_hotplug.c:103:28: error: implicit declaration of function 'pci_address_space_io' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
MemoryRegion *parent = pci_address_space_io(PCI_DEVICE(gpe_cpu->device));
^
Acked-by: John Snow <jsnow@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200228114649.12818-11-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
hw/acpi/cpu_hotplug.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/acpi/cpu_hotplug.c b/hw/acpi/cpu_hotplug.c
index 9c3bcc84de56..3e687d227a65 100644
--- a/hw/acpi/cpu_hotplug.c
+++ b/hw/acpi/cpu_hotplug.c
@@ -14,6 +14,7 @@
#include "qapi/error.h"
#include "hw/core/cpu.h"
#include "hw/i386/pc.h"
+#include "hw/pci/pci.h"
#include "qemu/error-report.h"
#define CPU_EJECT_METHOD "CPEJ"
--
2.24.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PULL 18/33] hw/timer/hpet: Include "exec/address-spaces.h"
2020-03-09 15:08 [PULL 00/33] Trivial branch patches Laurent Vivier
` (16 preceding siblings ...)
2020-03-09 15:08 ` [PULL 17/33] hw/acpi/cpu_hotplug: Include "hw/pci/pci.h" Laurent Vivier
@ 2020-03-09 15:08 ` Laurent Vivier
2020-03-09 15:08 ` [PULL 19/33] hw/pci-host/q35: Include "qemu/range.h" Laurent Vivier
` (17 subsequent siblings)
35 siblings, 0 replies; 45+ messages in thread
From: Laurent Vivier @ 2020-03-09 15:08 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Christian Schoenebeck, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Philippe Mathieu-Daudé,
Eduardo Habkost, Michael Tokarev, Alistair Francis,
Richard Henderson, Greg Kurz, Dr. David Alan Gilbert, qemu-arm,
Paolo Bonzini, John Snow, Richard Henderson, Kevin Wolf,
Daniel P. Berrangé,
Igor Mitsyanko, Laurent Vivier, Max Reitz, Aleksandar Markovic,
Igor Mammedov, Aurelien Jarno
From: Philippe Mathieu-Daudé <philmd@redhat.com>
hw/timer/hpet.c calls address_space_stl_le() declared in
"exec/address-spaces.h". Include it.
This fixes (when modifying unrelated headers):
hw/timer/hpet.c:210:31: error: use of undeclared identifier 'address_space_memory'
address_space_stl_le(&address_space_memory, timer->fsb >> 32,
^~~~~~~~~~~~~~~~~~~~
Acked-by: John Snow <jsnow@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200228114649.12818-12-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
hw/timer/hpet.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c
index 4f30dd50a40a..380acfa7c8a5 100644
--- a/hw/timer/hpet.c
+++ b/hw/timer/hpet.c
@@ -36,6 +36,7 @@
#include "hw/rtc/mc146818rtc_regs.h"
#include "migration/vmstate.h"
#include "hw/timer/i8254.h"
+#include "exec/address-spaces.h"
//#define HPET_DEBUG
#ifdef HPET_DEBUG
--
2.24.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PULL 19/33] hw/pci-host/q35: Include "qemu/range.h"
2020-03-09 15:08 [PULL 00/33] Trivial branch patches Laurent Vivier
` (17 preceding siblings ...)
2020-03-09 15:08 ` [PULL 18/33] hw/timer/hpet: Include "exec/address-spaces.h" Laurent Vivier
@ 2020-03-09 15:08 ` Laurent Vivier
2020-03-09 15:08 ` [PULL 20/33] hw/i2c/smbus_ich9: " Laurent Vivier
` (16 subsequent siblings)
35 siblings, 0 replies; 45+ messages in thread
From: Laurent Vivier @ 2020-03-09 15:08 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Christian Schoenebeck, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Philippe Mathieu-Daudé,
Eduardo Habkost, Michael Tokarev, Alistair Francis,
Richard Henderson, Greg Kurz, Dr. David Alan Gilbert, qemu-arm,
Paolo Bonzini, John Snow, Richard Henderson, Kevin Wolf,
Daniel P. Berrangé,
Igor Mitsyanko, Laurent Vivier, Max Reitz, Aleksandar Markovic,
Igor Mammedov, Aurelien Jarno
From: Philippe Mathieu-Daudé <philmd@redhat.com>
The MCHPCIState structure uses the Range type which is declared in
"qemu/range.h". Include it.
This fixes (when modifying unrelated headers):
In file included from hw/pci-host/q35.c:32:
include/hw/pci-host/q35.h:57:11: error: field has incomplete type 'Range' (aka 'struct Range')
Range pci_hole;
^
include/qemu/typedefs.h:116:16: note: forward declaration of 'struct Range'
typedef struct Range Range;
^
Acked-by: John Snow <jsnow@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200228114649.12818-13-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
include/hw/pci-host/q35.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/hw/pci-host/q35.h b/include/hw/pci-host/q35.h
index 976fbae5996b..47086c645e9f 100644
--- a/include/hw/pci-host/q35.h
+++ b/include/hw/pci-host/q35.h
@@ -33,6 +33,7 @@
#include "hw/pci-host/pam.h"
#include "hw/i386/intel_iommu.h"
#include "qemu/units.h"
+#include "qemu/range.h"
#define TYPE_Q35_HOST_DEVICE "q35-pcihost"
#define Q35_HOST_DEVICE(obj) \
--
2.24.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PULL 20/33] hw/i2c/smbus_ich9: Include "qemu/range.h"
2020-03-09 15:08 [PULL 00/33] Trivial branch patches Laurent Vivier
` (18 preceding siblings ...)
2020-03-09 15:08 ` [PULL 19/33] hw/pci-host/q35: Include "qemu/range.h" Laurent Vivier
@ 2020-03-09 15:08 ` Laurent Vivier
2020-03-09 15:08 ` [PULL 21/33] hw/pci-host/piix: " Laurent Vivier
` (15 subsequent siblings)
35 siblings, 0 replies; 45+ messages in thread
From: Laurent Vivier @ 2020-03-09 15:08 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Christian Schoenebeck, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Philippe Mathieu-Daudé,
Eduardo Habkost, Michael Tokarev, Alistair Francis,
Richard Henderson, Greg Kurz, Dr. David Alan Gilbert, qemu-arm,
Paolo Bonzini, John Snow, Richard Henderson, Kevin Wolf,
Daniel P. Berrangé,
Igor Mitsyanko, Laurent Vivier, Max Reitz, Aleksandar Markovic,
Igor Mammedov, Aurelien Jarno
From: Philippe Mathieu-Daudé <philmd@redhat.com>
hw/i2c/smbus_ich9.c calls range_covers_byte(). Include "qemu/range.h"
which declares it.
This fixes (when modifying unrelated headers):
hw/i2c/smbus_ich9.c:66:9: error: implicit declaration of function 'range_covers_byte' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
if (range_covers_byte(address, len, ICH9_SMB_HOSTC)) {
^
Acked-by: John Snow <jsnow@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200228114649.12818-14-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
hw/i2c/smbus_ich9.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/i2c/smbus_ich9.c b/hw/i2c/smbus_ich9.c
index fd50fb851af4..48f1ff419174 100644
--- a/hw/i2c/smbus_ich9.c
+++ b/hw/i2c/smbus_ich9.c
@@ -21,6 +21,7 @@
*/
#include "qemu/osdep.h"
+#include "qemu/range.h"
#include "hw/i2c/pm_smbus.h"
#include "hw/pci/pci.h"
#include "migration/vmstate.h"
--
2.24.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PULL 21/33] hw/pci-host/piix: Include "qemu/range.h"
2020-03-09 15:08 [PULL 00/33] Trivial branch patches Laurent Vivier
` (19 preceding siblings ...)
2020-03-09 15:08 ` [PULL 20/33] hw/i2c/smbus_ich9: " Laurent Vivier
@ 2020-03-09 15:08 ` Laurent Vivier
2020-03-09 15:08 ` [PULL 22/33] hw/acpi: Include "hw/mem/nvdimm.h" Laurent Vivier
` (14 subsequent siblings)
35 siblings, 0 replies; 45+ messages in thread
From: Laurent Vivier @ 2020-03-09 15:08 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Christian Schoenebeck, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Philippe Mathieu-Daudé,
Eduardo Habkost, Michael Tokarev, Alistair Francis,
Richard Henderson, Greg Kurz, Dr. David Alan Gilbert, qemu-arm,
Paolo Bonzini, John Snow, Richard Henderson, Kevin Wolf,
Daniel P. Berrangé,
Igor Mitsyanko, Laurent Vivier, Max Reitz, Aleksandar Markovic,
Igor Mammedov, Aurelien Jarno
From: Philippe Mathieu-Daudé <philmd@redhat.com>
hw/pci-host/piix.c calls various functions from the Range API.
Include "qemu/range.h" which declares them.
This fixes (when modifying unrelated headers):
hw/pci-host/i440fx.c:54:11: error: field has incomplete type 'Range' (aka 'struct Range')
Range pci_hole;
^
include/qemu/typedefs.h:116:16: note: forward declaration of 'struct Range'
typedef struct Range Range;
^
hw/pci-host/i440fx.c:126:9: error: implicit declaration of function 'ranges_overlap' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
if (ranges_overlap(address, len, I440FX_PAM, I440FX_PAM_SIZE) ||
^
hw/pci-host/i440fx.c:126:9: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes]
hw/pci-host/i440fx.c:127:9: error: implicit declaration of function 'range_covers_byte' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
range_covers_byte(address, len, I440FX_SMRAM)) {
^
hw/pci-host/i440fx.c:127:9: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes]
hw/pci-host/i440fx.c:189:13: error: implicit declaration of function 'range_is_empty' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
val64 = range_is_empty(&s->pci_hole) ? 0 : range_lob(&s->pci_hole);
^
Acked-by: John Snow <jsnow@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200228114649.12818-15-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
hw/pci-host/i440fx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/pci-host/i440fx.c b/hw/pci-host/i440fx.c
index 11050a0f8bb9..d980c9704906 100644
--- a/hw/pci-host/i440fx.c
+++ b/hw/pci-host/i440fx.c
@@ -23,6 +23,7 @@
*/
#include "qemu/osdep.h"
+#include "qemu/range.h"
#include "hw/i386/pc.h"
#include "hw/pci/pci.h"
#include "hw/pci/pci_host.h"
--
2.24.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PULL 22/33] hw/acpi: Include "hw/mem/nvdimm.h"
2020-03-09 15:08 [PULL 00/33] Trivial branch patches Laurent Vivier
` (20 preceding siblings ...)
2020-03-09 15:08 ` [PULL 21/33] hw/pci-host/piix: " Laurent Vivier
@ 2020-03-09 15:08 ` Laurent Vivier
2020-03-09 15:08 ` [PULL 23/33] hw/i386: " Laurent Vivier
` (13 subsequent siblings)
35 siblings, 0 replies; 45+ messages in thread
From: Laurent Vivier @ 2020-03-09 15:08 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Christian Schoenebeck, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Philippe Mathieu-Daudé,
Eduardo Habkost, Michael Tokarev, Alistair Francis,
Richard Henderson, Greg Kurz, Dr. David Alan Gilbert, qemu-arm,
Paolo Bonzini, John Snow, Richard Henderson, Kevin Wolf,
Daniel P. Berrangé,
Igor Mitsyanko, Laurent Vivier, Max Reitz, Aleksandar Markovic,
Igor Mammedov, Aurelien Jarno
From: Philippe Mathieu-Daudé <philmd@redhat.com>
Both ich9.c and piix4.c use methods/definitions declared in the
NVDIMM device header. Include it.
This fixes (when modifying unrelated headers):
hw/acpi/ich9.c:507:46: error: use of undeclared identifier 'TYPE_NVDIMM'
if (object_dynamic_cast(OBJECT(dev), TYPE_NVDIMM)) {
^
hw/acpi/ich9.c:508:13: error: implicit declaration of function 'nvdimm_acpi_plug_cb' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
nvdimm_acpi_plug_cb(hotplug_dev, dev);
^
hw/acpi/piix4.c:403:46: error: use of undeclared identifier 'TYPE_NVDIMM'
if (object_dynamic_cast(OBJECT(dev), TYPE_NVDIMM)) {
^
hw/acpi/piix4.c:404:13: error: implicit declaration of function 'nvdimm_acpi_plug_cb' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
nvdimm_acpi_plug_cb(hotplug_dev, dev);
^
Acked-by: John Snow <jsnow@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200228114649.12818-16-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
hw/acpi/ich9.c | 1 +
hw/acpi/piix4.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c
index fdd0a6c79e11..4e74284b65b7 100644
--- a/hw/acpi/ich9.c
+++ b/hw/acpi/ich9.c
@@ -39,6 +39,7 @@
#include "hw/i386/ich9.h"
#include "hw/mem/pc-dimm.h"
+#include "hw/mem/nvdimm.h"
//#define DEBUG
diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c
index 6d621c31e751..b84dbba2c3e8 100644
--- a/hw/acpi/piix4.c
+++ b/hw/acpi/piix4.c
@@ -38,6 +38,7 @@
#include "hw/acpi/cpu.h"
#include "hw/hotplug.h"
#include "hw/mem/pc-dimm.h"
+#include "hw/mem/nvdimm.h"
#include "hw/acpi/memory_hotplug.h"
#include "hw/acpi/acpi_dev_interface.h"
#include "hw/xen/xen.h"
--
2.24.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PULL 23/33] hw/i386: Include "hw/mem/nvdimm.h"
2020-03-09 15:08 [PULL 00/33] Trivial branch patches Laurent Vivier
` (21 preceding siblings ...)
2020-03-09 15:08 ` [PULL 22/33] hw/acpi: Include "hw/mem/nvdimm.h" Laurent Vivier
@ 2020-03-09 15:08 ` Laurent Vivier
2020-03-09 15:08 ` [PULL 24/33] hw/pci-host/q35: Remove unused includes Laurent Vivier
` (12 subsequent siblings)
35 siblings, 0 replies; 45+ messages in thread
From: Laurent Vivier @ 2020-03-09 15:08 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Christian Schoenebeck, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Philippe Mathieu-Daudé,
Eduardo Habkost, Michael Tokarev, Alistair Francis,
Richard Henderson, Greg Kurz, Dr. David Alan Gilbert, qemu-arm,
Paolo Bonzini, John Snow, Richard Henderson, Kevin Wolf,
Daniel P. Berrangé,
Igor Mitsyanko, Laurent Vivier, Max Reitz, Aleksandar Markovic,
Igor Mammedov, Aurelien Jarno
From: Philippe Mathieu-Daudé <philmd@redhat.com>
All this files use methods/definitions declared in the NVDIMM
device header. Include it.
This fixes (when modifying unrelated headers):
hw/i386/acpi-build.c:2733:9: error: implicit declaration of function 'nvdimm_build_acpi' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
nvdimm_build_acpi(table_offsets, tables_blob, tables->linker,
^
hw/i386/pc.c:1996:61: error: use of undeclared identifier 'TYPE_NVDIMM'
const bool is_nvdimm = object_dynamic_cast(OBJECT(dev), TYPE_NVDIMM);
^
hw/i386/pc.c:2032:55: error: use of undeclared identifier 'TYPE_NVDIMM'
bool is_nvdimm = object_dynamic_cast(OBJECT(dev), TYPE_NVDIMM);
^
hw/i386/pc.c:2040:9: error: implicit declaration of function 'nvdimm_plug' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
nvdimm_plug(ms->nvdimms_state);
^
hw/i386/pc.c:2040:9: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes]
nvdimm_plug(ms->nvdimms_state);
^
hw/i386/pc.c:2065:42: error: use of undeclared identifier 'TYPE_NVDIMM'
if (object_dynamic_cast(OBJECT(dev), TYPE_NVDIMM)) {
^
hw/i386/pc_i440fx.c:307:9: error: implicit declaration of function 'nvdimm_init_acpi_state' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
nvdimm_init_acpi_state(machine->nvdimms_state, system_io,
^
hw/i386/pc_q35.c:332:9: error: implicit declaration of function 'nvdimm_init_acpi_state' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
nvdimm_init_acpi_state(machine->nvdimms_state, system_io,
^
Acked-by: John Snow <jsnow@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200228114649.12818-17-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
hw/i386/acpi-build.c | 1 +
hw/i386/pc.c | 1 +
hw/i386/pc_piix.c | 1 +
hw/i386/pc_q35.c | 1 +
4 files changed, 4 insertions(+)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 26777f882844..9a19c14e661b 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -47,6 +47,7 @@
#include "hw/rtc/mc146818rtc_regs.h"
#include "migration/vmstate.h"
#include "hw/mem/memory-device.h"
+#include "hw/mem/nvdimm.h"
#include "sysemu/numa.h"
#include "sysemu/reset.h"
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 6ab4acb0c62e..362eb2a180ff 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -76,6 +76,7 @@
#include "hw/boards.h"
#include "acpi-build.h"
#include "hw/mem/pc-dimm.h"
+#include "hw/mem/nvdimm.h"
#include "qapi/error.h"
#include "qapi/qapi-visit-common.h"
#include "qapi/visitor.h"
diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index 9088db8fb601..e2d98243bc64 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -60,6 +60,7 @@
#include "migration/global_state.h"
#include "migration/misc.h"
#include "sysemu/numa.h"
+#include "hw/mem/nvdimm.h"
#define MAX_IDE_BUS 2
diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
index 84cf925cf43a..d37c425e2236 100644
--- a/hw/i386/pc_q35.c
+++ b/hw/i386/pc_q35.c
@@ -53,6 +53,7 @@
#include "qapi/error.h"
#include "qemu/error-report.h"
#include "sysemu/numa.h"
+#include "hw/mem/nvdimm.h"
/* ICH9 AHCI has 6 ports */
#define MAX_SATA_PORTS 6
--
2.24.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PULL 24/33] hw/pci-host/q35: Remove unused includes
2020-03-09 15:08 [PULL 00/33] Trivial branch patches Laurent Vivier
` (22 preceding siblings ...)
2020-03-09 15:08 ` [PULL 23/33] hw/i386: " Laurent Vivier
@ 2020-03-09 15:08 ` Laurent Vivier
2020-03-09 15:08 ` [PULL 25/33] hw/i386/pc: Clean up includes Laurent Vivier
` (11 subsequent siblings)
35 siblings, 0 replies; 45+ messages in thread
From: Laurent Vivier @ 2020-03-09 15:08 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Christian Schoenebeck, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Philippe Mathieu-Daudé,
Eduardo Habkost, Michael Tokarev, Alistair Francis,
Richard Henderson, Greg Kurz, Dr. David Alan Gilbert, qemu-arm,
Paolo Bonzini, John Snow, Richard Henderson, Kevin Wolf,
Daniel P. Berrangé,
Igor Mitsyanko, Laurent Vivier, Max Reitz, Aleksandar Markovic,
Igor Mammedov, Aurelien Jarno
From: Philippe Mathieu-Daudé <philmd@redhat.com>
Only q35.c requires declarations from "hw/i386/pc.h", move it there.
Remove all the includes not used by "q35.h".
Acked-by: John Snow <jsnow@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200228114649.12818-18-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
hw/pci-host/q35.c | 1 +
include/hw/pci-host/q35.h | 7 -------
2 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c
index a9b9ccc87657..993f467668dc 100644
--- a/hw/pci-host/q35.c
+++ b/hw/pci-host/q35.c
@@ -29,6 +29,7 @@
*/
#include "qemu/osdep.h"
+#include "hw/i386/pc.h"
#include "hw/pci-host/q35.h"
#include "hw/qdev-properties.h"
#include "migration/vmstate.h"
diff --git a/include/hw/pci-host/q35.h b/include/hw/pci-host/q35.h
index 47086c645e9f..070305f83dfd 100644
--- a/include/hw/pci-host/q35.h
+++ b/include/hw/pci-host/q35.h
@@ -22,16 +22,9 @@
#ifndef HW_Q35_H
#define HW_Q35_H
-#include "hw/isa/isa.h"
-#include "hw/sysbus.h"
-#include "hw/i386/pc.h"
-#include "hw/isa/apm.h"
#include "hw/pci/pci.h"
#include "hw/pci/pcie_host.h"
-#include "hw/acpi/acpi.h"
-#include "hw/acpi/ich9.h"
#include "hw/pci-host/pam.h"
-#include "hw/i386/intel_iommu.h"
#include "qemu/units.h"
#include "qemu/range.h"
--
2.24.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PULL 25/33] hw/i386/pc: Clean up includes
2020-03-09 15:08 [PULL 00/33] Trivial branch patches Laurent Vivier
` (23 preceding siblings ...)
2020-03-09 15:08 ` [PULL 24/33] hw/pci-host/q35: Remove unused includes Laurent Vivier
@ 2020-03-09 15:08 ` Laurent Vivier
2020-03-09 15:08 ` [PULL 26/33] core/qdev: fix memleak in qdev_get_gpio_out_connector() Laurent Vivier
` (10 subsequent siblings)
35 siblings, 0 replies; 45+ messages in thread
From: Laurent Vivier @ 2020-03-09 15:08 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Christian Schoenebeck, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Philippe Mathieu-Daudé,
Eduardo Habkost, Michael Tokarev, Alistair Francis,
Richard Henderson, Greg Kurz, Dr. David Alan Gilbert, qemu-arm,
Paolo Bonzini, John Snow, Richard Henderson, Kevin Wolf,
Daniel P. Berrangé,
Igor Mitsyanko, Laurent Vivier, Max Reitz, Aleksandar Markovic,
Igor Mammedov, Aurelien Jarno
From: Philippe Mathieu-Daudé <philmd@redhat.com>
Various headers are not required by hw/i386/pc.h:
- "qemu/range.h"
- "qemu/bitmap.h"
- "qemu/module.h"
- "exec/memory.h"
- "hw/pci/pci.h"
- "hw/mem/pc-dimm.h"
- "hw/mem/nvdimm.h"
- "net/net.h"
Remove them.
Add 3 headers that were missing:
- "hw/hotplug.h"
PCMachineState::acpi_dev is of type HotplugHandler
- "qemu/notify.h"
PCMachineState::machine_done is of type Notifier
- "qapi/qapi-types-common.h"
PCMachineState::vmport/smm is of type OnOffAuto
Acked-by: John Snow <jsnow@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200228114649.12818-19-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
include/hw/i386/pc.h | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index d5ac76d54e1f..6ab6eda046fd 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -1,20 +1,15 @@
#ifndef HW_PC_H
#define HW_PC_H
-#include "exec/memory.h"
+#include "qemu/notify.h"
+#include "qapi/qapi-types-common.h"
#include "hw/boards.h"
#include "hw/block/fdc.h"
#include "hw/block/flash.h"
-#include "net/net.h"
#include "hw/i386/x86.h"
-#include "qemu/range.h"
-#include "qemu/bitmap.h"
-#include "qemu/module.h"
-#include "hw/pci/pci.h"
-#include "hw/mem/pc-dimm.h"
-#include "hw/mem/nvdimm.h"
#include "hw/acpi/acpi_dev_interface.h"
+#include "hw/hotplug.h"
#define HPET_INTCAP "hpet-intcap"
--
2.24.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PULL 26/33] core/qdev: fix memleak in qdev_get_gpio_out_connector()
2020-03-09 15:08 [PULL 00/33] Trivial branch patches Laurent Vivier
` (24 preceding siblings ...)
2020-03-09 15:08 ` [PULL 25/33] hw/i386/pc: Clean up includes Laurent Vivier
@ 2020-03-09 15:08 ` Laurent Vivier
2020-03-09 15:08 ` [PULL 27/33] block/stream: Remove redundant statement in stream_run() Laurent Vivier
` (9 subsequent siblings)
35 siblings, 0 replies; 45+ messages in thread
From: Laurent Vivier @ 2020-03-09 15:08 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Christian Schoenebeck, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Marc-André Lureau, Philippe Mathieu-Daudé,
Eduardo Habkost, Michael Tokarev, Alistair Francis, Greg Kurz,
Dr. David Alan Gilbert, qemu-arm, Paolo Bonzini, John Snow,
Richard Henderson, Kevin Wolf, Daniel P. Berrangé,
Igor Mitsyanko, Pan Nengyuan, Laurent Vivier, Max Reitz,
Aleksandar Markovic, Euler Robot, Igor Mammedov, Aurelien Jarno
From: Pan Nengyuan <pannengyuan@huawei.com>
Fix a memory leak in qdev_get_gpio_out_connector().
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20200307030756.5913-1-pannengyuan@huawei.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
hw/core/qdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/core/qdev.c b/hw/core/qdev.c
index 3937d1eb1a5f..85f062def72b 100644
--- a/hw/core/qdev.c
+++ b/hw/core/qdev.c
@@ -557,7 +557,7 @@ void qdev_connect_gpio_out_named(DeviceState *dev, const char *name, int n,
qemu_irq qdev_get_gpio_out_connector(DeviceState *dev, const char *name, int n)
{
- char *propname = g_strdup_printf("%s[%d]",
+ g_autofree char *propname = g_strdup_printf("%s[%d]",
name ? name : "unnamed-gpio-out", n);
qemu_irq ret = (qemu_irq)object_property_get_link(OBJECT(dev), propname,
--
2.24.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PULL 27/33] block/stream: Remove redundant statement in stream_run()
2020-03-09 15:08 [PULL 00/33] Trivial branch patches Laurent Vivier
` (25 preceding siblings ...)
2020-03-09 15:08 ` [PULL 26/33] core/qdev: fix memleak in qdev_get_gpio_out_connector() Laurent Vivier
@ 2020-03-09 15:08 ` Laurent Vivier
2020-03-09 15:08 ` [PULL 28/33] block/file-posix: Remove redundant statement in raw_handle_perm_lock() Laurent Vivier
` (8 subsequent siblings)
35 siblings, 0 replies; 45+ messages in thread
From: Laurent Vivier @ 2020-03-09 15:08 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Christian Schoenebeck, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Philippe Mathieu-Daudé,
Eduardo Habkost, Michael Tokarev, Alistair Francis, Greg Kurz,
Dr. David Alan Gilbert, qemu-arm, Paolo Bonzini, Chen Qun,
John Snow, Richard Henderson, Kevin Wolf, Daniel P. Berrangé,
Igor Mitsyanko, Laurent Vivier, Max Reitz, Aleksandar Markovic,
Euler Robot, Igor Mammedov, Aurelien Jarno
From: Chen Qun <kuhn.chenqun@huawei.com>
Clang static code analyzer show warning:
block/stream.c:186:9: warning: Value stored to 'ret' is never read
ret = 0;
^ ~
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20200302130715.29440-3-kuhn.chenqun@huawei.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
block/stream.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/block/stream.c b/block/stream.c
index 5562ccbf577a..aa2e7af98e37 100644
--- a/block/stream.c
+++ b/block/stream.c
@@ -114,7 +114,6 @@ static int coroutine_fn stream_run(Job *job, Error **errp)
int64_t offset = 0;
uint64_t delay_ns = 0;
int error = 0;
- int ret = 0;
int64_t n = 0; /* bytes */
if (bs == s->bottom) {
@@ -139,6 +138,7 @@ static int coroutine_fn stream_run(Job *job, Error **errp)
for ( ; offset < len; offset += n) {
bool copy;
+ int ret;
/* Note that even when no rate limit is applied we need to yield
* with no pending I/O here so that bdrv_drain_all() returns.
@@ -183,7 +183,6 @@ static int coroutine_fn stream_run(Job *job, Error **errp)
break;
}
}
- ret = 0;
/* Publish progress */
job_progress_update(&s->common.job, n);
--
2.24.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PULL 28/33] block/file-posix: Remove redundant statement in raw_handle_perm_lock()
2020-03-09 15:08 [PULL 00/33] Trivial branch patches Laurent Vivier
` (26 preceding siblings ...)
2020-03-09 15:08 ` [PULL 27/33] block/stream: Remove redundant statement in stream_run() Laurent Vivier
@ 2020-03-09 15:08 ` Laurent Vivier
2020-03-09 15:08 ` [PULL 29/33] dma/xlnx-zdma: Remove redundant statement in zdma_write_dst() Laurent Vivier
` (7 subsequent siblings)
35 siblings, 0 replies; 45+ messages in thread
From: Laurent Vivier @ 2020-03-09 15:08 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Christian Schoenebeck, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Philippe Mathieu-Daudé,
Eduardo Habkost, Michael Tokarev, Alistair Francis, Greg Kurz,
Dr. David Alan Gilbert, qemu-arm, Paolo Bonzini, Chen Qun,
John Snow, Richard Henderson, Kevin Wolf, Daniel P. Berrangé,
Igor Mitsyanko, Laurent Vivier, Max Reitz, Aleksandar Markovic,
Euler Robot, Igor Mammedov, Aurelien Jarno
From: Chen Qun <kuhn.chenqun@huawei.com>
Clang static code analyzer show warning:
block/file-posix.c:891:9: warning: Value stored to 'op' is never read
op = RAW_PL_ABORT;
^ ~~~~~~~~~~~~
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20200302130715.29440-5-kuhn.chenqun@huawei.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
block/file-posix.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/block/file-posix.c b/block/file-posix.c
index 634547711297..0f77447a25df 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -888,7 +888,6 @@ static int raw_handle_perm_lock(BlockDriverState *bs,
"Is another process using the image [%s]?\n",
bs->filename);
}
- op = RAW_PL_ABORT;
/* fall through to unlock bytes. */
case RAW_PL_ABORT:
raw_apply_lock_bytes(s, s->fd, s->perm, ~s->shared_perm,
--
2.24.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PULL 29/33] dma/xlnx-zdma: Remove redundant statement in zdma_write_dst()
2020-03-09 15:08 [PULL 00/33] Trivial branch patches Laurent Vivier
` (27 preceding siblings ...)
2020-03-09 15:08 ` [PULL 28/33] block/file-posix: Remove redundant statement in raw_handle_perm_lock() Laurent Vivier
@ 2020-03-09 15:08 ` Laurent Vivier
2020-03-09 15:08 ` [PULL 30/33] scsi/scsi-disk: Remove redundant statement in scsi_disk_emulate_command() Laurent Vivier
` (6 subsequent siblings)
35 siblings, 0 replies; 45+ messages in thread
From: Laurent Vivier @ 2020-03-09 15:08 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Christian Schoenebeck, Alistair Francis,
Gerd Hoffmann, Edgar E. Iglesias, Edgar E . Iglesias, qemu-block,
qemu-trivial, Francisco Iglesias, Helge Deller,
Philippe Mathieu-Daudé,
Eduardo Habkost, Michael Tokarev, Alistair Francis, Greg Kurz,
Dr. David Alan Gilbert, qemu-arm, Paolo Bonzini, Chen Qun,
John Snow, Richard Henderson, Kevin Wolf, Daniel P. Berrangé,
Igor Mitsyanko, Laurent Vivier, Max Reitz, Aleksandar Markovic,
Euler Robot, Igor Mammedov, Aurelien Jarno
From: Chen Qun <kuhn.chenqun@huawei.com>
Clang static code analyzer show warning:
hw/dma/xlnx-zdma.c:399:13: warning: Value stored to 'dst_type' is never read
dst_type = FIELD_EX32(s->dsc_dst.words[3], ZDMA_CH_DST_DSCR_WORD3,
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Francisco Iglesias <frasse.iglesias@gmail.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Message-Id: <20200302130715.29440-11-kuhn.chenqun@huawei.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
hw/dma/xlnx-zdma.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/dma/xlnx-zdma.c b/hw/dma/xlnx-zdma.c
index 1c1b142293a6..2d9c0a0d5e19 100644
--- a/hw/dma/xlnx-zdma.c
+++ b/hw/dma/xlnx-zdma.c
@@ -372,7 +372,7 @@ static uint64_t zdma_update_descr_addr(XlnxZDMA *s, bool type,
static void zdma_write_dst(XlnxZDMA *s, uint8_t *buf, uint32_t len)
{
uint32_t dst_size, dlen;
- bool dst_intr, dst_type;
+ bool dst_intr;
unsigned int ptype = ARRAY_FIELD_EX32(s->regs, ZDMA_CH_CTRL0, POINT_TYPE);
unsigned int rw_mode = ARRAY_FIELD_EX32(s->regs, ZDMA_CH_CTRL0, MODE);
unsigned int burst_type = ARRAY_FIELD_EX32(s->regs, ZDMA_CH_DATA_ATTR,
@@ -386,17 +386,17 @@ static void zdma_write_dst(XlnxZDMA *s, uint8_t *buf, uint32_t len)
while (len) {
dst_size = FIELD_EX32(s->dsc_dst.words[2], ZDMA_CH_DST_DSCR_WORD2,
SIZE);
- dst_type = FIELD_EX32(s->dsc_dst.words[3], ZDMA_CH_DST_DSCR_WORD3,
- TYPE);
if (dst_size == 0 && ptype == PT_MEM) {
uint64_t next;
+ bool dst_type = FIELD_EX32(s->dsc_dst.words[3],
+ ZDMA_CH_DST_DSCR_WORD3,
+ TYPE);
+
next = zdma_update_descr_addr(s, dst_type,
R_ZDMA_CH_DST_CUR_DSCR_LSB);
zdma_load_descriptor(s, next, &s->dsc_dst);
dst_size = FIELD_EX32(s->dsc_dst.words[2], ZDMA_CH_DST_DSCR_WORD2,
SIZE);
- dst_type = FIELD_EX32(s->dsc_dst.words[3], ZDMA_CH_DST_DSCR_WORD3,
- TYPE);
}
/* Match what hardware does by ignoring the dst_size and only using
--
2.24.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PULL 30/33] scsi/scsi-disk: Remove redundant statement in scsi_disk_emulate_command()
2020-03-09 15:08 [PULL 00/33] Trivial branch patches Laurent Vivier
` (28 preceding siblings ...)
2020-03-09 15:08 ` [PULL 29/33] dma/xlnx-zdma: Remove redundant statement in zdma_write_dst() Laurent Vivier
@ 2020-03-09 15:08 ` Laurent Vivier
2020-03-09 15:08 ` [PULL 31/33] display/pxa2xx_lcd: Remove redundant statement in pxa2xx_palette_parse() Laurent Vivier
` (5 subsequent siblings)
35 siblings, 0 replies; 45+ messages in thread
From: Laurent Vivier @ 2020-03-09 15:08 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Christian Schoenebeck, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Philippe Mathieu-Daudé,
Eduardo Habkost, Michael Tokarev, Alistair Francis, Greg Kurz,
Dr. David Alan Gilbert, qemu-arm, Paolo Bonzini, Chen Qun,
John Snow, Richard Henderson, Kevin Wolf, Daniel P. Berrangé,
Igor Mitsyanko, Laurent Vivier, Max Reitz, Aleksandar Markovic,
Euler Robot, Igor Mammedov, Aurelien Jarno
From: Chen Qun <kuhn.chenqun@huawei.com>
Clang static code analyzer show warning:
scsi/scsi-disk.c:1918:5: warning: Value stored to 'buflen' is never read
buflen = req->cmd.xfer;
^ ~~~~~~~~~~~~~
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20200302130715.29440-7-kuhn.chenqun@huawei.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
hw/scsi/scsi-disk.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
index 10d0794d60f1..1c0cb63a6fe0 100644
--- a/hw/scsi/scsi-disk.c
+++ b/hw/scsi/scsi-disk.c
@@ -1915,7 +1915,6 @@ static int32_t scsi_disk_emulate_command(SCSIRequest *req, uint8_t *buf)
r->iov.iov_base = blk_blockalign(s->qdev.conf.blk, r->buflen);
}
- buflen = req->cmd.xfer;
outbuf = r->iov.iov_base;
memset(outbuf, 0, r->buflen);
switch (req->cmd.buf[0]) {
--
2.24.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PULL 31/33] display/pxa2xx_lcd: Remove redundant statement in pxa2xx_palette_parse()
2020-03-09 15:08 [PULL 00/33] Trivial branch patches Laurent Vivier
` (29 preceding siblings ...)
2020-03-09 15:08 ` [PULL 30/33] scsi/scsi-disk: Remove redundant statement in scsi_disk_emulate_command() Laurent Vivier
@ 2020-03-09 15:08 ` Laurent Vivier
2020-03-09 15:08 ` [PULL 32/33] display/exynos4210_fimd: Remove redundant statement in exynos4210_fimd_update() Laurent Vivier
` (4 subsequent siblings)
35 siblings, 0 replies; 45+ messages in thread
From: Laurent Vivier @ 2020-03-09 15:08 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Christian Schoenebeck, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Philippe Mathieu-Daudé,
Eduardo Habkost, Michael Tokarev, Alistair Francis, Greg Kurz,
Dr. David Alan Gilbert, qemu-arm, Paolo Bonzini, Chen Qun,
John Snow, Richard Henderson, Kevin Wolf, Daniel P. Berrangé,
Igor Mitsyanko, Laurent Vivier, Max Reitz, Aleksandar Markovic,
Euler Robot, Igor Mammedov, Aurelien Jarno
From: Chen Qun <kuhn.chenqun@huawei.com>
Clang static code analyzer show warning:
hw/display/pxa2xx_lcd.c:596:9: warning: Value stored to 'format' is never read
format = 0;
^ ~
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20200302130715.29440-8-kuhn.chenqun@huawei.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
hw/display/pxa2xx_lcd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/display/pxa2xx_lcd.c b/hw/display/pxa2xx_lcd.c
index 05f5f8467123..464e93161a21 100644
--- a/hw/display/pxa2xx_lcd.c
+++ b/hw/display/pxa2xx_lcd.c
@@ -593,7 +593,6 @@ static void pxa2xx_palette_parse(PXA2xxLCDState *s, int ch, int bpp)
n = 256;
break;
default:
- format = 0;
return;
}
--
2.24.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PULL 32/33] display/exynos4210_fimd: Remove redundant statement in exynos4210_fimd_update()
2020-03-09 15:08 [PULL 00/33] Trivial branch patches Laurent Vivier
` (30 preceding siblings ...)
2020-03-09 15:08 ` [PULL 31/33] display/pxa2xx_lcd: Remove redundant statement in pxa2xx_palette_parse() Laurent Vivier
@ 2020-03-09 15:08 ` Laurent Vivier
2020-03-09 15:08 ` [PULL 33/33] monitor/hmp-cmds: Remove redundant statement in hmp_rocker_of_dpa_groups() Laurent Vivier
` (3 subsequent siblings)
35 siblings, 0 replies; 45+ messages in thread
From: Laurent Vivier @ 2020-03-09 15:08 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Christian Schoenebeck, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Philippe Mathieu-Daudé,
Eduardo Habkost, Michael Tokarev, Alistair Francis, Greg Kurz,
Dr. David Alan Gilbert, qemu-arm, Paolo Bonzini, Chen Qun,
John Snow, Richard Henderson, Kevin Wolf, Daniel P. Berrangé,
Igor Mitsyanko, Laurent Vivier, Max Reitz, Aleksandar Markovic,
Euler Robot, Igor Mammedov, Aurelien Jarno
From: Chen Qun <kuhn.chenqun@huawei.com>
Clang static code analyzer show warning:
hw/display/exynos4210_fimd.c:1313:17: warning: Value stored to 'is_dirty' is never read
is_dirty = false;
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20200302130715.29440-9-kuhn.chenqun@huawei.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
hw/display/exynos4210_fimd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/display/exynos4210_fimd.c b/hw/display/exynos4210_fimd.c
index ec6776680e41..1c0266ce9f2d 100644
--- a/hw/display/exynos4210_fimd.c
+++ b/hw/display/exynos4210_fimd.c
@@ -1311,7 +1311,6 @@ static void exynos4210_fimd_update(void *opaque)
}
host_fb_addr += inc_size;
fb_line_addr += inc_size;
- is_dirty = false;
}
g_free(snap);
blend = true;
--
2.24.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PULL 33/33] monitor/hmp-cmds: Remove redundant statement in hmp_rocker_of_dpa_groups()
2020-03-09 15:08 [PULL 00/33] Trivial branch patches Laurent Vivier
` (31 preceding siblings ...)
2020-03-09 15:08 ` [PULL 32/33] display/exynos4210_fimd: Remove redundant statement in exynos4210_fimd_update() Laurent Vivier
@ 2020-03-09 15:08 ` Laurent Vivier
2020-03-09 16:31 ` [PULL 00/33] Trivial branch patches no-reply
` (2 subsequent siblings)
35 siblings, 0 replies; 45+ messages in thread
From: Laurent Vivier @ 2020-03-09 15:08 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Christian Schoenebeck, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Philippe Mathieu-Daudé,
Eduardo Habkost, Michael Tokarev, Alistair Francis, Greg Kurz,
Dr. David Alan Gilbert, qemu-arm, Paolo Bonzini, Chen Qun,
John Snow, Richard Henderson, Kevin Wolf, Daniel P. Berrangé,
Igor Mitsyanko, Laurent Vivier, Max Reitz, Aleksandar Markovic,
Euler Robot, Igor Mammedov, Aurelien Jarno
From: Chen Qun <kuhn.chenqun@huawei.com>
Clang static code analyzer show warning:
monitor/hmp-cmds.c:2867:17: warning: Value stored to 'set' is never read
set = true;
^ ~~~~
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20200302130715.29440-14-kuhn.chenqun@huawei.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
monitor/hmp-cmds.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
index fb4c2fd2a875..6fd7aca5007b 100644
--- a/monitor/hmp-cmds.c
+++ b/monitor/hmp-cmds.c
@@ -2842,7 +2842,6 @@ void hmp_rocker_of_dpa_groups(Monitor *mon, const QDict *qdict)
const char *name = qdict_get_str(qdict, "name");
uint8_t type = qdict_get_try_int(qdict, "type", 9);
Error *err = NULL;
- bool set = false;
list = qmp_query_rocker_of_dpa_groups(name, type != 9, type, &err);
if (err != NULL) {
@@ -2854,6 +2853,7 @@ void hmp_rocker_of_dpa_groups(Monitor *mon, const QDict *qdict)
for (g = list; g; g = g->next) {
RockerOfDpaGroup *group = g->value;
+ bool set = false;
monitor_printf(mon, "0x%08x", group->id);
@@ -2898,14 +2898,11 @@ void hmp_rocker_of_dpa_groups(Monitor *mon, const QDict *qdict)
if (group->has_set_eth_dst) {
if (!set) {
- set = true;
monitor_printf(mon, " set");
}
monitor_printf(mon, " dst %s", group->set_eth_dst);
}
- set = false;
-
if (group->has_ttl_check && group->ttl_check) {
monitor_printf(mon, " check TTL");
}
--
2.24.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* Re: [PULL 00/33] Trivial branch patches
2020-03-09 15:08 [PULL 00/33] Trivial branch patches Laurent Vivier
` (32 preceding siblings ...)
2020-03-09 15:08 ` [PULL 33/33] monitor/hmp-cmds: Remove redundant statement in hmp_rocker_of_dpa_groups() Laurent Vivier
@ 2020-03-09 16:31 ` no-reply
2020-03-09 16:44 ` Peter Maydell
2020-03-09 19:17 ` Michael S. Tsirkin
35 siblings, 0 replies; 45+ messages in thread
From: no-reply @ 2020-03-09 16:31 UTC (permalink / raw)
To: laurent
Cc: fam, peter.maydell, dmitry.fleytman, mst, jasowang, mjt,
qemu-devel, kraxel, edgar.iglesias, qemu-block, qemu-trivial,
deller, philmd, ehabkost, qemu_oss, alistair, groug, dgilbert,
qemu-arm, imammedo, jsnow, rth, kwolf, berrange, i.mitsyanko,
laurent, mreitz, amarkovic, pbonzini, aurelien
Patchew URL: https://patchew.org/QEMU/20200309150837.3193387-1-laurent@vivier.eu/
Hi,
This series failed the docker-clang@ubuntu build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-ubuntu V=1 NETWORK=1
time make docker-test-clang@ubuntu SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===
LINK qemu-bridge-helper
LINK virtiofsd
LINK vhost-user-input
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
GEN cris-softmmu/hmp-commands.h
GEN lm32-softmmu/hmp-commands.h
GEN m68k-softmmu/hmp-commands.h
---
CC mips64-softmmu/hw/misc/mips_cmgcr.o
CC mips64-softmmu/hw/misc/mips_cpc.o
CC mips64-softmmu/hw/misc/mips_itu.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC mips64-softmmu/hw/net/virtio-net.o
CC mips64-softmmu/hw/net/rocker/qmp-norocker.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC arm-softmmu/hw/arm/integratorcp.o
CC mips64el-softmmu/hw/block/virtio-blk.o
CC i386-softmmu/hw/virtio/vhost-user-fs-pci.o
---
CC mips64-softmmu/hw/scsi/virtio-scsi-dataplane.o
CC i386-softmmu/hw/virtio/virtio-iommu.o
CC i386-softmmu/hw/virtio/vhost-vsock.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC aarch64-softmmu/hw/arm/integratorcp.o
CC aarch64-softmmu/hw/arm/mainstone.o
CC mips64el-softmmu/hw/block/dataplane/virtio-blk.o
---
CC i386-softmmu/hw/virtio/vhost-user-scsi-pci.o
CC aarch64-softmmu/hw/arm/netduino2.o
CC aarch64-softmmu/hw/arm/netduinoplus2.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC aarch64-softmmu/hw/arm/nseries.o
CC i386-softmmu/hw/virtio/vhost-scsi-pci.o
CC mipsel-softmmu/disas.o
---
CC mips64el-softmmu/qapi/qapi-events-machine-target.o
CC mips-softmmu/target/mips/dsp_helper.o
CC mips-softmmu/target/mips/lmi_helper.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC arm-softmmu/softmmu/vl.o
CC nios2-softmmu/tcg/tcg-op-vec.o
CC mips64el-softmmu/qapi/qapi-events-misc-target.o
---
CC moxie-softmmu/accel/tcg/cpu-exec.o
CC mipsel-softmmu/hw/virtio/virtio-balloon-pci.o
CC moxie-softmmu/accel/tcg/cpu-exec-common.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC moxie-softmmu/accel/tcg/translate-all.o
CC mips64-softmmu/target/mips/dsp_helper.o
CC arm-softmmu/target/arm/cpu.o
---
CC nios2-softmmu/accel/stubs/whpx-stub.o
CC mipsel-softmmu/hw/virtio/virtio-scsi-pci.o
CC or1k-softmmu/accel/tcg/cputlb.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC mips64-softmmu/target/mips/mips-semi.o
CC ppc-softmmu/accel/qtest.o
CC i386-softmmu/hw/i386/vmport.o
---
CC or1k-softmmu/softmmu/vl.o
CC arm-softmmu/trace/generated-helpers.o
CC i386-softmmu/hw/i386/kvm/clock.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC ppc64-softmmu/exec-vary.o
CC ppc64-softmmu/tcg/tcg.o
CC i386-softmmu/hw/i386/kvm/apic.o
---
CC moxie-softmmu/trace/generated-helpers.o
CC ppc64-softmmu/balloon.o
CC ppc64-softmmu/ioport.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
GEN or1k-softmmu/target/openrisc/decode.inc.c
CC riscv64-softmmu/fpu/softfloat.o
CC mipsel-softmmu/target/mips/op_helper.o
---
CC ppc64-softmmu/migration/ram.o
GEN riscv64-softmmu/gdbstub-xml.c
LINK aarch64-softmmu/qemu-system-aarch64
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC riscv32-softmmu/arch_init.o
CC nios2-softmmu/target/nios2/op_helper.o
CC riscv64-softmmu/arch_init.o
---
CC sh4-softmmu/fpu/softfloat.o
CC riscv32-softmmu/accel/tcg/tcg-runtime-gvec.o
CC ppc64-softmmu/hw/block/vhost-user-blk.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC s390x-softmmu/fpu/softfloat.o
CC s390x-softmmu/disas.o
CC riscv64-softmmu/accel/tcg/cputlb.o
---
CC ppc64-softmmu/hw/block/dataplane/virtio-blk.o
CC ppc-softmmu/hw/virtio/virtio-iommu-pci.o
GEN s390x-softmmu/gdbstub-xml.c
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC riscv64-softmmu/accel/tcg/tcg-runtime.o
CC sh4-softmmu/arch_init.o
CC ppc-softmmu/hw/virtio/virtio-9p-pci.o
---
CC riscv32-softmmu/hw/9pfs/virtio-9p-device.o
CC riscv32-softmmu/hw/block/virtio-blk.o
CC ppc64-softmmu/hw/display/virtio-gpu.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC s390x-softmmu/memory.o
CC s390x-softmmu/memory_mapping.o
CC riscv32-softmmu/hw/block/vhost-user-blk.o
---
GEN unicore32-softmmu/hmp-commands.h
GEN unicore32-softmmu/hmp-commands-info.h
GEN unicore32-softmmu/config-devices.h
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
GEN unicore32-softmmu/config-target.h
CC unicore32-softmmu/exec.o
CC tricore-softmmu/qapi/qapi-introspect.o
CC ppc64-softmmu/hw/ppc/spapr_rtas_ddw.o
CC s390x-softmmu/qapi/qapi-events-misc-target.o
CC sparc64-softmmu/hw/block/virtio-blk.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC s390x-softmmu/qapi/qapi-events.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC sparc64-softmmu/hw/block/vhost-user-blk.o
CC s390x-softmmu/qapi/qapi-commands-machine-target.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC tricore-softmmu/qapi/qapi-types-machine-target.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC ppc64-softmmu/hw/ppc/ppc405_boards.o
CC tricore-softmmu/qapi/qapi-types-misc-target.o
CC sparc64-softmmu/hw/block/dataplane/virtio-blk.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC unicore32-softmmu/exec-vary.o
CC s390x-softmmu/qapi/qapi-commands-misc-target.o
CC unicore32-softmmu/tcg/tcg.o
---
CC ppc64-softmmu/hw/ppc/prep.o
CC sparc64-softmmu/hw/display/virtio-gpu-3d.o
CC tricore-softmmu/qapi/qapi-commands-misc-target.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC ppc64-softmmu/hw/ppc/prep_systemio.o
CC sh4eb-softmmu/target/sh4/cpu.o
CC s390x-softmmu/target/s390x/cpu_models.o
---
CC sparc64-softmmu/hw/vfio/spapr.o
CC unicore32-softmmu/accel/qtest.o
CC tricore-softmmu/target/tricore/translate.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC s390x-softmmu/target/s390x/fpu_helper.o
CC xtensa-softmmu/disas.o
CC x86_64-softmmu/fpu/softfloat.o
---
CC sparc64-softmmu/hw/virtio/virtio-iommu.o
CC unicore32-softmmu/qapi/qapi-types.o
CC sparc64-softmmu/hw/virtio/vhost-vsock.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC xtensaeb-softmmu/memory_mapping.o
CC unicore32-softmmu/qapi/qapi-visit-machine-target.o
CC xtensa-softmmu/accel/tcg/tcg-runtime-gvec.o
---
CC sparc64-softmmu/qapi/qapi-types-machine-target.o
CC alpha-linux-user/accel/tcg/tcg-runtime.o
CC aarch64_be-linux-user/accel/stubs/whpx-stub.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC aarch64_be-linux-user/accel/stubs/kvm-stub.o
CC x86_64-softmmu/hw/display/virtio-gpu-base.o
CC ppc64-softmmu/target/ppc/mmu-book3s-v3.o
---
CC x86_64-softmmu/hw/display/virtio-vga.o
CC ppc64-softmmu/target/ppc/fpu_helper.o
CC xtensa-softmmu/hw/semihosting/config.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC ppc64-softmmu/target/ppc/int_helper.o
CC ppc64-softmmu/target/ppc/timebase_helper.o
CC xtensaeb-softmmu/hw/scsi/virtio-scsi-dataplane.o
---
CC i386-linux-user/accel/tcg/tcg-runtime.o
CC armeb-linux-user/linux-user/uaccess.o
CC i386-linux-user/accel/tcg/tcg-runtime-gvec.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC hppa-linux-user/linux-user/main.o
CC xtensa-softmmu/qapi/qapi-commands-misc-target.o
CC cris-linux-user/linux-user/signal.o
---
CC i386-linux-user/target/i386/cpu.o
CC m68k-linux-user/tcg/tcg-op-vec.o
CC x86_64-softmmu/hw/xen/xen_pt_load_rom.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC hppa-linux-user/trace/generated-helpers.o
CC aarch64-linux-user/target/arm/translate-sve.o
CC m68k-linux-user/tcg/tcg-op-gvec.o
---
CC m68k-linux-user/target/m68k/op_helper.o
CC mips64el-linux-user/linux-user/elfload.o
CCAS microblazeel-linux-user/linux-user/safe-syscall.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC mips64el-linux-user/linux-user/linuxload.o
CC microblaze-linux-user/linux-user/uname.o
CC microblazeel-linux-user/linux-user/microblaze/signal.o
---
CC mips64-linux-user/linux-user/signal.o
CC microblaze-linux-user/linux-user/microblaze/cpu_loop.o
CC m68k-linux-user/target/m68k/fpu_helper.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC microblazeel-linux-user/linux-user/fd-trans.o
CC microblazeel-linux-user/linux-user/flatload.o
CC microblazeel-linux-user/target/microblaze/translate.o
---
CC tilegx-linux-user/linux-user/tilegx/signal.o
CC tilegx-linux-user/linux-user/tilegx/cpu_loop.o
CC xtensa-linux-user/accel/tcg/cpu-exec.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
CC xtensa-linux-user/accel/tcg/cpu-exec-common.o
CC xtensa-linux-user/accel/tcg/translate-all.o
CC xtensaeb-linux-user/thunk.o
---
LINK fp-test
LINK tests/test-iov
LINK tests/test-bitmap
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
LINK tests/test-aio
LINK tests/test-aio-multithread
LINK tests/test-throttle
LINK tests/test-thread-pool
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
LINK tests/test-hbitmap
LINK tests/test-bdrv-drain
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
LINK tests/test-bdrv-graph-mod
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
LINK tests/test-blockjob
LINK tests/test-blockjob-txn
LINK tests/test-block-backend
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
LINK tests/test-block-iothread
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
LINK tests/test-image-locking
LINK tests/test-x86-cpuid
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
LINK tests/test-xbzrle
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
LINK tests/test-vmstate
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
LINK tests/test-cutils
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
LINK tests/test-shift128
LINK tests/test-mul64
LINK tests/test-int128
---
LINK tests/test-write-threshold
LINK tests/test-crypto-hash
LINK tests/test-crypto-hmac
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
LINK tests/test-crypto-cipher
LINK tests/test-crypto-secret
LINK tests/test-crypto-tlscredsx509
---
FLOAT TEST lt_quiet
FLOAT TEST add
FLOAT TEST sub
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
FLOAT TEST mul
FLOAT TEST mulAdd
FLOAT TEST uint-to-float
---
dbus-daemon[8262]: Could not get password database information for UID of current process: User "???" unknown or no memory to allocate password entry
**
ERROR:/tmp/qemu-test/src/tests/qtest/dbus-vmstate-test.c:114:get_connection: assertion failed (err == NULL): The connection is closed (g-io-error-quark, 18)
ERROR - Bail out! ERROR:/tmp/qemu-test/src/tests/qtest/dbus-vmstate-test.c:114:get_connection: assertion failed (err == NULL): The connection is closed (g-io-error-quark, 18)
Aborted (core dumped)
cleaning up pid 8262
make: *** [/tmp/qemu-test/src/tests/Makefile.include:632: check-qtest-i386] Error 1
make: *** Waiting for unfinished jobs....
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: -accel kvm: failed to initialize kvm: No such file or directory
---
dbus-daemon[9590]: Could not get password database information for UID of current process: User "???" unknown or no memory to allocate password entry
**
ERROR:/tmp/qemu-test/src/tests/qtest/dbus-vmstate-test.c:114:get_connection: assertion failed (err == NULL): The connection is closed (g-io-error-quark, 18)
Aborted (core dumped)
cleaning up pid 9590
ERROR - Bail out! ERROR:/tmp/qemu-test/src/tests/qtest/dbus-vmstate-test.c:114:get_connection: assertion failed (err == NULL): The connection is closed (g-io-error-quark, 18)
make: *** [/tmp/qemu-test/src/tests/Makefile.include:632: check-qtest-x86_64] Error 1
TEST check-qtest-arm: tests/qtest/test-hmp
TEST check-qtest-arm: tests/qtest/qos-test
TEST check-qtest-aarch64: tests/qtest/test-hmp
---
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=47cb3ce1218347808c17d0936a1a5f53', '-u', '1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-oy1xpz1h/src/docker-src.2020-03-09-12.12.34.28747:/var/tmp/qemu:z,ro', 'qemu:ubuntu', '/var/tmp/qemu/run', 'test-clang']' returned non-zero exit status 2.
filter=--filter=label=com.qemu.instance.uuid=47cb3ce1218347808c17d0936a1a5f53
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-oy1xpz1h/src'
make: *** [docker-run-test-clang@ubuntu] Error 2
real 19m16.345s
user 0m9.023s
The full log is available at
http://patchew.org/logs/20200309150837.3193387-1-laurent@vivier.eu/testing.docker-clang@ubuntu/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PULL 00/33] Trivial branch patches
2020-03-09 15:08 [PULL 00/33] Trivial branch patches Laurent Vivier
` (33 preceding siblings ...)
2020-03-09 16:31 ` [PULL 00/33] Trivial branch patches no-reply
@ 2020-03-09 16:44 ` Peter Maydell
2020-03-09 19:17 ` Michael S. Tsirkin
35 siblings, 0 replies; 45+ messages in thread
From: Peter Maydell @ 2020-03-09 16:44 UTC (permalink / raw)
To: Laurent Vivier
Cc: Fam Zheng, Dmitry Fleytman, Michael S. Tsirkin, Jason Wang,
Christian Schoenebeck, QEMU Developers, Gerd Hoffmann,
Edgar E. Iglesias, Qemu-block, QEMU Trivial, Helge Deller,
Philippe Mathieu-Daudé,
Eduardo Habkost, Michael Tokarev, Alistair Francis, Greg Kurz,
Dr. David Alan Gilbert, qemu-arm, Paolo Bonzini, John Snow,
Richard Henderson, Kevin Wolf, Daniel P. Berrangé,
Igor Mitsyanko, Max Reitz, Aleksandar Markovic, Igor Mammedov,
Aurelien Jarno
On Mon, 9 Mar 2020 at 15:09, Laurent Vivier <laurent@vivier.eu> wrote:
>
> The following changes since commit 7a5853cec479a448edae0fb2aaf4e2f78c9c774d:
>
> Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2020-03-09 10:32:53 +0000)
>
> are available in the Git repository at:
>
> git://github.com/vivier/qemu.git tags/trivial-branch-pull-request
>
> for you to fetch changes up to 916c92503bd5348a33e561db600d8894bde636bb:
>
> monitor/hmp-cmds: Remove redundant statement in hmp_rocker_of_dpa_groups() (2020-03-09 15:59:31 +0100)
>
> ----------------------------------------------------------------
> - includes cleanup
> - reduce .data footprint
> - fix warnings reported by Clang static code analyzer
> - fix dp8393x part lost in merge
> - update git.orderfile and rules.mak
>
> ----------------------------------------------------------------
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/5.0
for any user-visible changes.
-- PMM
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PULL 00/33] Trivial branch patches
2020-03-09 15:08 [PULL 00/33] Trivial branch patches Laurent Vivier
` (34 preceding siblings ...)
2020-03-09 16:44 ` Peter Maydell
@ 2020-03-09 19:17 ` Michael S. Tsirkin
2020-03-09 19:30 ` Philippe Mathieu-Daudé
35 siblings, 1 reply; 45+ messages in thread
From: Michael S. Tsirkin @ 2020-03-09 19:17 UTC (permalink / raw)
To: Laurent Vivier
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Jason Wang,
Christian Schoenebeck, qemu-devel, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Philippe Mathieu-Daudé,
Eduardo Habkost, Michael Tokarev, Alistair Francis, Greg Kurz,
Dr. David Alan Gilbert, qemu-arm, Paolo Bonzini, John Snow,
Richard Henderson, Kevin Wolf, Daniel P. Berrangé,
Igor Mitsyanko, Max Reitz, Aleksandar Markovic, Igor Mammedov,
Aurelien Jarno
On Mon, Mar 09, 2020 at 04:08:04PM +0100, Laurent Vivier wrote:
> The following changes since commit 7a5853cec479a448edae0fb2aaf4e2f78c9c774d:
>
> Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2020-03-09 10:32:53 +0000)
>
> are available in the Git repository at:
>
> git://github.com/vivier/qemu.git tags/trivial-branch-pull-request
>
> for you to fetch changes up to 916c92503bd5348a33e561db600d8894bde636bb:
>
> monitor/hmp-cmds: Remove redundant statement in hmp_rocker_of_dpa_groups() (2020-03-09 15:59:31 +0100)
Could you avoid CC everyone involved on the whole PULL req?
I was involved in a patch or two and don't really need to see
the whole series. Just the cover and the relevant patches
would be enough - if I do want it there's always lore.
> ----------------------------------------------------------------
> - includes cleanup
> - reduce .data footprint
> - fix warnings reported by Clang static code analyzer
> - fix dp8393x part lost in merge
> - update git.orderfile and rules.mak
>
> ----------------------------------------------------------------
>
> Chen Qun (7):
> block/stream: Remove redundant statement in stream_run()
> block/file-posix: Remove redundant statement in raw_handle_perm_lock()
> dma/xlnx-zdma: Remove redundant statement in zdma_write_dst()
> scsi/scsi-disk: Remove redundant statement in
> scsi_disk_emulate_command()
> display/pxa2xx_lcd: Remove redundant statement in
> pxa2xx_palette_parse()
> display/exynos4210_fimd: Remove redundant statement in
> exynos4210_fimd_update()
> monitor/hmp-cmds: Remove redundant statement in
> hmp_rocker_of_dpa_groups()
>
> Eric Blake (1):
> maint: Include top-level *.rst files early in git diff
>
> Finn Thain (1):
> dp8393x: Mask EOL bit from descriptor addresses, take 2
>
> Pan Nengyuan (1):
> core/qdev: fix memleak in qdev_get_gpio_out_connector()
>
> Philippe Mathieu-Daudé (23):
> build-sys: Move the print-variable rule to rules.mak
> hw/audio/fmopl: Fix a typo twice
> hw/net/e1000: Add readops/writeops typedefs
> hw/net/e1000: Move macreg[] arrays to .rodata to save 1MiB of .data
> virtfs-proxy-helper: Make the helper_opts[] array const
> vl: Add missing "hw/boards.h" include
> hw/southbridge/ich9: Removed unused headers
> hw/i386/ioapic_internal: Remove unused "hw/i386/ioapic.h" header
> hw/timer: Remove unused "ui/console.h" header
> hw/usb/dev-storage: Remove unused "ui/console.h" header
> hw/i386/intel_iommu: Remove unused includes
> hw/alpha/alpha_sys: Remove unused "hw/ide.h" header
> hw/alpha/dp264: Include "net/net.h"
> hw/hppa/machine: Include "net/net.h"
> hw/acpi/cpu_hotplug: Include "hw/pci/pci.h"
> hw/timer/hpet: Include "exec/address-spaces.h"
> hw/pci-host/q35: Include "qemu/range.h"
> hw/i2c/smbus_ich9: Include "qemu/range.h"
> hw/pci-host/piix: Include "qemu/range.h"
> hw/acpi: Include "hw/mem/nvdimm.h"
> hw/i386: Include "hw/mem/nvdimm.h"
> hw/pci-host/q35: Remove unused includes
> hw/i386/pc: Clean up includes
>
> Makefile | 3 ---
> block/file-posix.c | 1 -
> block/stream.c | 3 +--
> fsdev/virtfs-proxy-helper.c | 2 +-
> hw/acpi/cpu_hotplug.c | 1 +
> hw/acpi/ich9.c | 2 +-
> hw/acpi/piix4.c | 1 +
> hw/alpha/alpha_sys.h | 1 -
> hw/alpha/dp264.c | 1 +
> hw/audio/fmopl.c | 4 ++--
> hw/core/qdev.c | 2 +-
> hw/display/exynos4210_fimd.c | 1 -
> hw/display/pxa2xx_lcd.c | 1 -
> hw/dma/xlnx-zdma.c | 10 +++++-----
> hw/hppa/machine.c | 1 +
> hw/i2c/smbus_ich9.c | 1 +
> hw/i386/acpi-build.c | 1 +
> hw/i386/pc.c | 1 +
> hw/i386/pc_piix.c | 1 +
> hw/i386/pc_q35.c | 1 +
> hw/isa/lpc_ich9.c | 1 -
> hw/net/dp8393x.c | 4 ++--
> hw/net/e1000.c | 6 ++++--
> hw/net/e1000e_core.c | 6 ++++--
> hw/pci-host/i440fx.c | 1 +
> hw/pci-host/q35.c | 1 +
> hw/rtc/twl92230.c | 1 -
> hw/scsi/scsi-disk.c | 1 -
> hw/timer/hpet.c | 2 +-
> hw/usb/dev-storage.c | 1 -
> include/hw/i386/ich9.h | 1 -
> include/hw/i386/intel_iommu.h | 4 ----
> include/hw/i386/ioapic_internal.h | 1 -
> include/hw/i386/pc.h | 11 +++--------
> include/hw/pci-host/q35.h | 8 +-------
> monitor/hmp-cmds.c | 5 +----
> rules.mak | 3 +++
> scripts/git.orderfile | 1 +
> softmmu/vl.c | 1 +
> 39 files changed, 43 insertions(+), 55 deletions(-)
>
> --
> 2.24.1
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PULL 00/33] Trivial branch patches
2020-03-09 19:17 ` Michael S. Tsirkin
@ 2020-03-09 19:30 ` Philippe Mathieu-Daudé
2020-03-10 8:02 ` Laurent Vivier
0 siblings, 1 reply; 45+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-03-09 19:30 UTC (permalink / raw)
To: Michael S. Tsirkin, Laurent Vivier, Stefan Hajnoczi
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Jason Wang,
Christian Schoenebeck, qemu-devel, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Eduardo Habkost, Michael Tokarev, Alistair Francis, Greg Kurz,
Dr. David Alan Gilbert, qemu-arm, Paolo Bonzini, John Snow,
Richard Henderson, Kevin Wolf, Daniel P. Berrangé,
Igor Mitsyanko, Max Reitz, Aleksandar Markovic, Igor Mammedov,
Aurelien Jarno
On 3/9/20 8:17 PM, Michael S. Tsirkin wrote:
> On Mon, Mar 09, 2020 at 04:08:04PM +0100, Laurent Vivier wrote:
>> The following changes since commit 7a5853cec479a448edae0fb2aaf4e2f78c9c774d:
>>
>> Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2020-03-09 10:32:53 +0000)
>>
>> are available in the Git repository at:
>>
>> git://github.com/vivier/qemu.git tags/trivial-branch-pull-request
>>
>> for you to fetch changes up to 916c92503bd5348a33e561db600d8894bde636bb:
>>
>> monitor/hmp-cmds: Remove redundant statement in hmp_rocker_of_dpa_groups() (2020-03-09 15:59:31 +0100)
>
>
> Could you avoid CC everyone involved on the whole PULL req?
> I was involved in a patch or two and don't really need to see
> the whole series. Just the cover and the relevant patches
> would be enough - if I do want it there's always lore.
I suppose Laurent used git-publish, which has this limitation.
>
>> ----------------------------------------------------------------
>> - includes cleanup
>> - reduce .data footprint
>> - fix warnings reported by Clang static code analyzer
>> - fix dp8393x part lost in merge
>> - update git.orderfile and rules.mak
>>
>> ----------------------------------------------------------------
>>
>> Chen Qun (7):
>> block/stream: Remove redundant statement in stream_run()
>> block/file-posix: Remove redundant statement in raw_handle_perm_lock()
>> dma/xlnx-zdma: Remove redundant statement in zdma_write_dst()
>> scsi/scsi-disk: Remove redundant statement in
>> scsi_disk_emulate_command()
>> display/pxa2xx_lcd: Remove redundant statement in
>> pxa2xx_palette_parse()
>> display/exynos4210_fimd: Remove redundant statement in
>> exynos4210_fimd_update()
>> monitor/hmp-cmds: Remove redundant statement in
>> hmp_rocker_of_dpa_groups()
>>
>> Eric Blake (1):
>> maint: Include top-level *.rst files early in git diff
>>
>> Finn Thain (1):
>> dp8393x: Mask EOL bit from descriptor addresses, take 2
>>
>> Pan Nengyuan (1):
>> core/qdev: fix memleak in qdev_get_gpio_out_connector()
>>
>> Philippe Mathieu-Daudé (23):
>> build-sys: Move the print-variable rule to rules.mak
>> hw/audio/fmopl: Fix a typo twice
>> hw/net/e1000: Add readops/writeops typedefs
>> hw/net/e1000: Move macreg[] arrays to .rodata to save 1MiB of .data
>> virtfs-proxy-helper: Make the helper_opts[] array const
>> vl: Add missing "hw/boards.h" include
>> hw/southbridge/ich9: Removed unused headers
>> hw/i386/ioapic_internal: Remove unused "hw/i386/ioapic.h" header
>> hw/timer: Remove unused "ui/console.h" header
>> hw/usb/dev-storage: Remove unused "ui/console.h" header
>> hw/i386/intel_iommu: Remove unused includes
>> hw/alpha/alpha_sys: Remove unused "hw/ide.h" header
>> hw/alpha/dp264: Include "net/net.h"
>> hw/hppa/machine: Include "net/net.h"
>> hw/acpi/cpu_hotplug: Include "hw/pci/pci.h"
>> hw/timer/hpet: Include "exec/address-spaces.h"
>> hw/pci-host/q35: Include "qemu/range.h"
>> hw/i2c/smbus_ich9: Include "qemu/range.h"
>> hw/pci-host/piix: Include "qemu/range.h"
>> hw/acpi: Include "hw/mem/nvdimm.h"
>> hw/i386: Include "hw/mem/nvdimm.h"
>> hw/pci-host/q35: Remove unused includes
>> hw/i386/pc: Clean up includes
>>
>> Makefile | 3 ---
>> block/file-posix.c | 1 -
>> block/stream.c | 3 +--
>> fsdev/virtfs-proxy-helper.c | 2 +-
>> hw/acpi/cpu_hotplug.c | 1 +
>> hw/acpi/ich9.c | 2 +-
>> hw/acpi/piix4.c | 1 +
>> hw/alpha/alpha_sys.h | 1 -
>> hw/alpha/dp264.c | 1 +
>> hw/audio/fmopl.c | 4 ++--
>> hw/core/qdev.c | 2 +-
>> hw/display/exynos4210_fimd.c | 1 -
>> hw/display/pxa2xx_lcd.c | 1 -
>> hw/dma/xlnx-zdma.c | 10 +++++-----
>> hw/hppa/machine.c | 1 +
>> hw/i2c/smbus_ich9.c | 1 +
>> hw/i386/acpi-build.c | 1 +
>> hw/i386/pc.c | 1 +
>> hw/i386/pc_piix.c | 1 +
>> hw/i386/pc_q35.c | 1 +
>> hw/isa/lpc_ich9.c | 1 -
>> hw/net/dp8393x.c | 4 ++--
>> hw/net/e1000.c | 6 ++++--
>> hw/net/e1000e_core.c | 6 ++++--
>> hw/pci-host/i440fx.c | 1 +
>> hw/pci-host/q35.c | 1 +
>> hw/rtc/twl92230.c | 1 -
>> hw/scsi/scsi-disk.c | 1 -
>> hw/timer/hpet.c | 2 +-
>> hw/usb/dev-storage.c | 1 -
>> include/hw/i386/ich9.h | 1 -
>> include/hw/i386/intel_iommu.h | 4 ----
>> include/hw/i386/ioapic_internal.h | 1 -
>> include/hw/i386/pc.h | 11 +++--------
>> include/hw/pci-host/q35.h | 8 +-------
>> monitor/hmp-cmds.c | 5 +----
>> rules.mak | 3 +++
>> scripts/git.orderfile | 1 +
>> softmmu/vl.c | 1 +
>> 39 files changed, 43 insertions(+), 55 deletions(-)
>>
>> --
>> 2.24.1
>
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PULL 00/33] Trivial branch patches
2020-03-09 19:30 ` Philippe Mathieu-Daudé
@ 2020-03-10 8:02 ` Laurent Vivier
2020-03-10 11:45 ` Kevin Wolf
0 siblings, 1 reply; 45+ messages in thread
From: Laurent Vivier @ 2020-03-10 8:02 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, Michael S. Tsirkin, Stefan Hajnoczi
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Jason Wang,
Christian Schoenebeck, qemu-devel, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Eduardo Habkost, Michael Tokarev, Alistair Francis, Greg Kurz,
Dr. David Alan Gilbert, qemu-arm, Paolo Bonzini, John Snow,
Richard Henderson, Kevin Wolf, Daniel P. Berrangé,
Igor Mitsyanko, Max Reitz, Aleksandar Markovic, Igor Mammedov,
Aurelien Jarno
Le 09/03/2020 à 20:30, Philippe Mathieu-Daudé a écrit :
> On 3/9/20 8:17 PM, Michael S. Tsirkin wrote:
>> On Mon, Mar 09, 2020 at 04:08:04PM +0100, Laurent Vivier wrote:
>>> The following changes since commit
>>> 7a5853cec479a448edae0fb2aaf4e2f78c9c774d:
>>>
>>> Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into
>>> staging (2020-03-09 10:32:53 +0000)
>>>
>>> are available in the Git repository at:
>>>
>>> git://github.com/vivier/qemu.git tags/trivial-branch-pull-request
>>>
>>> for you to fetch changes up to 916c92503bd5348a33e561db600d8894bde636bb:
>>>
>>> monitor/hmp-cmds: Remove redundant statement in
>>> hmp_rocker_of_dpa_groups() (2020-03-09 15:59:31 +0100)
>>
>>
>> Could you avoid CC everyone involved on the whole PULL req?
>> I was involved in a patch or two and don't really need to see
>> the whole series. Just the cover and the relevant patches
>> would be enough - if I do want it there's always lore.
>
> I suppose Laurent used git-publish, which has this limitation.
>
Yes, I use git publish and CC are automatically added.
Philippe, you told me some time ago you have a patch to fix this
behaviour and only CC people on a patch base. Is it available?
Thanks,
Laurent
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PULL 00/33] Trivial branch patches
2020-03-10 8:02 ` Laurent Vivier
@ 2020-03-10 11:45 ` Kevin Wolf
2020-03-10 12:00 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 45+ messages in thread
From: Kevin Wolf @ 2020-03-10 11:45 UTC (permalink / raw)
To: Laurent Vivier
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Christian Schoenebeck, qemu-devel, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Philippe Mathieu-Daudé,
Eduardo Habkost, Michael Tokarev, Alistair Francis, Greg Kurz,
Dr. David Alan Gilbert, qemu-arm, Stefan Hajnoczi, Paolo Bonzini,
John Snow, Richard Henderson, Daniel P. Berrangé,
Igor Mitsyanko, Max Reitz, Aleksandar Markovic, Igor Mammedov,
Aurelien Jarno
Am 10.03.2020 um 09:02 hat Laurent Vivier geschrieben:
> Le 09/03/2020 à 20:30, Philippe Mathieu-Daudé a écrit :
> > On 3/9/20 8:17 PM, Michael S. Tsirkin wrote:
> >> On Mon, Mar 09, 2020 at 04:08:04PM +0100, Laurent Vivier wrote:
> >>> The following changes since commit
> >>> 7a5853cec479a448edae0fb2aaf4e2f78c9c774d:
> >>>
> >>> Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into
> >>> staging (2020-03-09 10:32:53 +0000)
> >>>
> >>> are available in the Git repository at:
> >>>
> >>> git://github.com/vivier/qemu.git tags/trivial-branch-pull-request
> >>>
> >>> for you to fetch changes up to 916c92503bd5348a33e561db600d8894bde636bb:
> >>>
> >>> monitor/hmp-cmds: Remove redundant statement in
> >>> hmp_rocker_of_dpa_groups() (2020-03-09 15:59:31 +0100)
> >>
> >>
> >> Could you avoid CC everyone involved on the whole PULL req?
> >> I was involved in a patch or two and don't really need to see
> >> the whole series. Just the cover and the relevant patches
> >> would be enough - if I do want it there's always lore.
> >
> > I suppose Laurent used git-publish, which has this limitation.
> >
>
> Yes, I use git publish and CC are automatically added.
>
> Philippe, you told me some time ago you have a patch to fix this
> behaviour and only CC people on a patch base. Is it available?
Actually, I don't think it's even necessary to CC anyone at all (except
the relevant lists) for pull requests. These patches were already
reviewed.
Kevin
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PULL 00/33] Trivial branch patches
2020-03-10 11:45 ` Kevin Wolf
@ 2020-03-10 12:00 ` Philippe Mathieu-Daudé
2020-03-10 12:11 ` Daniel P. Berrangé
2020-03-10 12:13 ` Kevin Wolf
0 siblings, 2 replies; 45+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-03-10 12:00 UTC (permalink / raw)
To: Kevin Wolf, Laurent Vivier, Paolo Bonzini
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Christian Schoenebeck, qemu-devel, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Eduardo Habkost, Michael Tokarev, Alistair Francis, Greg Kurz,
Dr. David Alan Gilbert, qemu-arm, Stefan Hajnoczi, John Snow,
Richard Henderson, Daniel P. Berrangé,
Igor Mitsyanko, Max Reitz, Aleksandar Markovic, Igor Mammedov,
Aurelien Jarno
On 3/10/20 12:45 PM, Kevin Wolf wrote:
> Am 10.03.2020 um 09:02 hat Laurent Vivier geschrieben:
>> Le 09/03/2020 à 20:30, Philippe Mathieu-Daudé a écrit :
>>> On 3/9/20 8:17 PM, Michael S. Tsirkin wrote:
>>>> On Mon, Mar 09, 2020 at 04:08:04PM +0100, Laurent Vivier wrote:
>>>>> The following changes since commit
>>>>> 7a5853cec479a448edae0fb2aaf4e2f78c9c774d:
>>>>>
>>>>> Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into
>>>>> staging (2020-03-09 10:32:53 +0000)
>>>>>
>>>>> are available in the Git repository at:
>>>>>
>>>>> git://github.com/vivier/qemu.git tags/trivial-branch-pull-request
>>>>>
>>>>> for you to fetch changes up to 916c92503bd5348a33e561db600d8894bde636bb:
>>>>>
>>>>> monitor/hmp-cmds: Remove redundant statement in
>>>>> hmp_rocker_of_dpa_groups() (2020-03-09 15:59:31 +0100)
>>>>
>>>>
>>>> Could you avoid CC everyone involved on the whole PULL req?
>>>> I was involved in a patch or two and don't really need to see
>>>> the whole series. Just the cover and the relevant patches
>>>> would be enough - if I do want it there's always lore.
>>>
>>> I suppose Laurent used git-publish, which has this limitation.
>>>
>>
>> Yes, I use git publish and CC are automatically added.
>>
>> Philippe, you told me some time ago you have a patch to fix this
>> behaviour and only CC people on a patch base. Is it available?
I guess you mean
https://github.com/philmd/git-publish/commit/5bab6e2cc77, I haven't
improved it but plan to spend time on it during my next holidays.
> Actually, I don't think it's even necessary to CC anyone at all (except
> the relevant lists) for pull requests. These patches were already
> reviewed.
Well as a contributor I find useful to get notified when patches are merged.
I guess remember some time ago patchew (or another bot?) was sending a
notification on pull request merged, this was even more useful than
Cc'ing ppl on pull-req. It is also helpful when you track someone else
patch on the list.
Since most of the maintainers now include the patch RFC822 Message-Id,
it is now easy for a bot to reply to patch taken from the last.
>
> Kevin
>
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PULL 00/33] Trivial branch patches
2020-03-10 12:00 ` Philippe Mathieu-Daudé
@ 2020-03-10 12:11 ` Daniel P. Berrangé
2020-03-10 12:13 ` Kevin Wolf
1 sibling, 0 replies; 45+ messages in thread
From: Daniel P. Berrangé @ 2020-03-10 12:11 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Christian Schoenebeck, qemu-devel, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Eduardo Habkost, Michael Tokarev, Alistair Francis, Greg Kurz,
Dr. David Alan Gilbert, qemu-arm, Stefan Hajnoczi, Igor Mammedov,
John Snow, Richard Henderson, Kevin Wolf, Igor Mitsyanko,
Laurent Vivier, Max Reitz, Aleksandar Markovic, Paolo Bonzini,
Aurelien Jarno
On Tue, Mar 10, 2020 at 01:00:12PM +0100, Philippe Mathieu-Daudé wrote:
> On 3/10/20 12:45 PM, Kevin Wolf wrote:
> > Am 10.03.2020 um 09:02 hat Laurent Vivier geschrieben:
> > > Le 09/03/2020 à 20:30, Philippe Mathieu-Daudé a écrit :
> > > > On 3/9/20 8:17 PM, Michael S. Tsirkin wrote:
> > > > > On Mon, Mar 09, 2020 at 04:08:04PM +0100, Laurent Vivier wrote:
> > > > > > The following changes since commit
> > > > > > 7a5853cec479a448edae0fb2aaf4e2f78c9c774d:
> > > > > >
> > > > > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into
> > > > > > staging (2020-03-09 10:32:53 +0000)
> > > > > >
> > > > > > are available in the Git repository at:
> > > > > >
> > > > > > git://github.com/vivier/qemu.git tags/trivial-branch-pull-request
> > > > > >
> > > > > > for you to fetch changes up to 916c92503bd5348a33e561db600d8894bde636bb:
> > > > > >
> > > > > > monitor/hmp-cmds: Remove redundant statement in
> > > > > > hmp_rocker_of_dpa_groups() (2020-03-09 15:59:31 +0100)
> > > > >
> > > > >
> > > > > Could you avoid CC everyone involved on the whole PULL req?
> > > > > I was involved in a patch or two and don't really need to see
> > > > > the whole series. Just the cover and the relevant patches
> > > > > would be enough - if I do want it there's always lore.
> > > >
> > > > I suppose Laurent used git-publish, which has this limitation.
> > > >
> > >
> > > Yes, I use git publish and CC are automatically added.
> > >
> > > Philippe, you told me some time ago you have a patch to fix this
> > > behaviour and only CC people on a patch base. Is it available?
>
> I guess you mean https://github.com/philmd/git-publish/commit/5bab6e2cc77, I
> haven't improved it but plan to spend time on it during my next holidays.
>
> > Actually, I don't think it's even necessary to CC anyone at all (except
> > the relevant lists) for pull requests. These patches were already
> > reviewed.
>
> Well as a contributor I find useful to get notified when patches are merged.
Yeah, I tend to agree with that - it is good to know when something is
merged, more so if you are an infrequent contributor to an area of code
or QEMU in general.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PULL 00/33] Trivial branch patches
2020-03-10 12:00 ` Philippe Mathieu-Daudé
2020-03-10 12:11 ` Daniel P. Berrangé
@ 2020-03-10 12:13 ` Kevin Wolf
2020-03-10 12:31 ` Philippe Mathieu-Daudé
2020-03-10 12:34 ` Laurent Vivier
1 sibling, 2 replies; 45+ messages in thread
From: Kevin Wolf @ 2020-03-10 12:13 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Christian Schoenebeck, qemu-devel, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Eduardo Habkost, Michael Tokarev, Alistair Francis, Greg Kurz,
Dr. David Alan Gilbert, qemu-arm, Stefan Hajnoczi, Igor Mammedov,
John Snow, Richard Henderson, Daniel P. Berrangé,
Igor Mitsyanko, Laurent Vivier, Max Reitz, Aleksandar Markovic,
Paolo Bonzini, Aurelien Jarno
Am 10.03.2020 um 13:00 hat Philippe Mathieu-Daudé geschrieben:
> On 3/10/20 12:45 PM, Kevin Wolf wrote:
> > Am 10.03.2020 um 09:02 hat Laurent Vivier geschrieben:
> > > Le 09/03/2020 à 20:30, Philippe Mathieu-Daudé a écrit :
> > > > On 3/9/20 8:17 PM, Michael S. Tsirkin wrote:
> > > > > On Mon, Mar 09, 2020 at 04:08:04PM +0100, Laurent Vivier wrote:
> > > > > > The following changes since commit
> > > > > > 7a5853cec479a448edae0fb2aaf4e2f78c9c774d:
> > > > > >
> > > > > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into
> > > > > > staging (2020-03-09 10:32:53 +0000)
> > > > > >
> > > > > > are available in the Git repository at:
> > > > > >
> > > > > > git://github.com/vivier/qemu.git tags/trivial-branch-pull-request
> > > > > >
> > > > > > for you to fetch changes up to 916c92503bd5348a33e561db600d8894bde636bb:
> > > > > >
> > > > > > monitor/hmp-cmds: Remove redundant statement in
> > > > > > hmp_rocker_of_dpa_groups() (2020-03-09 15:59:31 +0100)
> > > > >
> > > > >
> > > > > Could you avoid CC everyone involved on the whole PULL req?
> > > > > I was involved in a patch or two and don't really need to see
> > > > > the whole series. Just the cover and the relevant patches
> > > > > would be enough - if I do want it there's always lore.
> > > >
> > > > I suppose Laurent used git-publish, which has this limitation.
> > > >
> > >
> > > Yes, I use git publish and CC are automatically added.
> > >
> > > Philippe, you told me some time ago you have a patch to fix this
> > > behaviour and only CC people on a patch base. Is it available?
>
> I guess you mean https://github.com/philmd/git-publish/commit/5bab6e2cc77, I
> haven't improved it but plan to spend time on it during my next holidays.
>
> > Actually, I don't think it's even necessary to CC anyone at all (except
> > the relevant lists) for pull requests. These patches were already
> > reviewed.
>
> Well as a contributor I find useful to get notified when patches are merged.
Hm, I guess a matter of different preferences then.
> I guess remember some time ago patchew (or another bot?) was sending a
> notification on pull request merged, this was even more useful than Cc'ing
> ppl on pull-req. It is also helpful when you track someone else patch on the
> list.
> Since most of the maintainers now include the patch RFC822 Message-Id, it is
> now easy for a bot to reply to patch taken from the last.
I don't remember anything like this, but having an automatic reply to
the email thread of each merged patch series might be a good idea.
Kevin
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PULL 00/33] Trivial branch patches
2020-03-10 12:13 ` Kevin Wolf
@ 2020-03-10 12:31 ` Philippe Mathieu-Daudé
2020-03-10 12:34 ` Laurent Vivier
1 sibling, 0 replies; 45+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-03-10 12:31 UTC (permalink / raw)
To: Kevin Wolf
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Michael Tokarev, qemu-devel, Gerd Hoffmann,
qemu-block, qemu-trivial, Helge Deller, Eduardo Habkost,
Christian Schoenebeck, Alistair Francis, Greg Kurz,
Dr. David Alan Gilbert, qemu-arm, Stefan Hajnoczi, Paolo Bonzini,
John Snow, Richard Henderson, Daniel P. Berrangé,
Igor Mitsyanko, Laurent Vivier, Max Reitz, Aleksandar Markovic,
Igor Mammedov, Aurelien Jarno
On 3/10/20 1:13 PM, Kevin Wolf wrote:
> Am 10.03.2020 um 13:00 hat Philippe Mathieu-Daudé geschrieben:
>> On 3/10/20 12:45 PM, Kevin Wolf wrote:
>>> Am 10.03.2020 um 09:02 hat Laurent Vivier geschrieben:
>>>> Le 09/03/2020 à 20:30, Philippe Mathieu-Daudé a écrit :
>>>>> On 3/9/20 8:17 PM, Michael S. Tsirkin wrote:
>>>>>> On Mon, Mar 09, 2020 at 04:08:04PM +0100, Laurent Vivier wrote:
>>>>>>> The following changes since commit
>>>>>>> 7a5853cec479a448edae0fb2aaf4e2f78c9c774d:
>>>>>>>
>>>>>>> Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into
>>>>>>> staging (2020-03-09 10:32:53 +0000)
>>>>>>>
>>>>>>> are available in the Git repository at:
>>>>>>>
>>>>>>> git://github.com/vivier/qemu.git tags/trivial-branch-pull-request
>>>>>>>
>>>>>>> for you to fetch changes up to 916c92503bd5348a33e561db600d8894bde636bb:
>>>>>>>
>>>>>>> monitor/hmp-cmds: Remove redundant statement in
>>>>>>> hmp_rocker_of_dpa_groups() (2020-03-09 15:59:31 +0100)
>>>>>>
>>>>>>
>>>>>> Could you avoid CC everyone involved on the whole PULL req?
>>>>>> I was involved in a patch or two and don't really need to see
>>>>>> the whole series. Just the cover and the relevant patches
>>>>>> would be enough - if I do want it there's always lore.
>>>>>
>>>>> I suppose Laurent used git-publish, which has this limitation.
>>>>>
>>>>
>>>> Yes, I use git publish and CC are automatically added.
>>>>
>>>> Philippe, you told me some time ago you have a patch to fix this
>>>> behaviour and only CC people on a patch base. Is it available?
>>
>> I guess you mean https://github.com/philmd/git-publish/commit/5bab6e2cc77, I
>> haven't improved it but plan to spend time on it during my next holidays.
>>
>>> Actually, I don't think it's even necessary to CC anyone at all (except
>>> the relevant lists) for pull requests. These patches were already
>>> reviewed.
>>
>> Well as a contributor I find useful to get notified when patches are merged.
>
> Hm, I guess a matter of different preferences then.
>
>> I guess remember some time ago patchew (or another bot?) was sending a
>> notification on pull request merged, this was even more useful than Cc'ing
>> ppl on pull-req. It is also helpful when you track someone else patch on the
>> list.
>> Since most of the maintainers now include the patch RFC822 Message-Id, it is
>> now easy for a bot to reply to patch taken from the last.
>
> I don't remember anything like this, but having an automatic reply to
> the email thread of each merged patch series might be a good idea.
It was patchew:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg623861.html
From: no-reply@patchew.org
Subject: A patch has been merged in QEMU: $PatchSubject
Congratulations, $PatchSubject was merged by the QEMU maintainers.
>
> Kevin
>
>
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PULL 00/33] Trivial branch patches
2020-03-10 12:13 ` Kevin Wolf
2020-03-10 12:31 ` Philippe Mathieu-Daudé
@ 2020-03-10 12:34 ` Laurent Vivier
1 sibling, 0 replies; 45+ messages in thread
From: Laurent Vivier @ 2020-03-10 12:34 UTC (permalink / raw)
To: Kevin Wolf, Philippe Mathieu-Daudé
Cc: Fam Zheng, Peter Maydell, Dmitry Fleytman, Michael S. Tsirkin,
Jason Wang, Christian Schoenebeck, qemu-devel, Gerd Hoffmann,
Edgar E. Iglesias, qemu-block, qemu-trivial, Helge Deller,
Eduardo Habkost, Michael Tokarev, Alistair Francis, Greg Kurz,
Dr. David Alan Gilbert, qemu-arm, Stefan Hajnoczi, Igor Mammedov,
John Snow, Richard Henderson, Daniel P. Berrangé,
Igor Mitsyanko, Max Reitz, Aleksandar Markovic, Paolo Bonzini,
Aurelien Jarno
Le 10/03/2020 à 13:13, Kevin Wolf a écrit :
> Am 10.03.2020 um 13:00 hat Philippe Mathieu-Daudé geschrieben:
>> On 3/10/20 12:45 PM, Kevin Wolf wrote:
>>> Am 10.03.2020 um 09:02 hat Laurent Vivier geschrieben:
>>>> Le 09/03/2020 à 20:30, Philippe Mathieu-Daudé a écrit :
>>>>> On 3/9/20 8:17 PM, Michael S. Tsirkin wrote:
>>>>>> On Mon, Mar 09, 2020 at 04:08:04PM +0100, Laurent Vivier wrote:
>>>>>>> The following changes since commit
>>>>>>> 7a5853cec479a448edae0fb2aaf4e2f78c9c774d:
>>>>>>>
>>>>>>> Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into
>>>>>>> staging (2020-03-09 10:32:53 +0000)
>>>>>>>
>>>>>>> are available in the Git repository at:
>>>>>>>
>>>>>>> git://github.com/vivier/qemu.git tags/trivial-branch-pull-request
>>>>>>>
>>>>>>> for you to fetch changes up to 916c92503bd5348a33e561db600d8894bde636bb:
>>>>>>>
>>>>>>> monitor/hmp-cmds: Remove redundant statement in
>>>>>>> hmp_rocker_of_dpa_groups() (2020-03-09 15:59:31 +0100)
>>>>>>
>>>>>>
>>>>>> Could you avoid CC everyone involved on the whole PULL req?
>>>>>> I was involved in a patch or two and don't really need to see
>>>>>> the whole series. Just the cover and the relevant patches
>>>>>> would be enough - if I do want it there's always lore.
>>>>>
>>>>> I suppose Laurent used git-publish, which has this limitation.
>>>>>
>>>>
>>>> Yes, I use git publish and CC are automatically added.
>>>>
>>>> Philippe, you told me some time ago you have a patch to fix this
>>>> behaviour and only CC people on a patch base. Is it available?
>>
>> I guess you mean https://github.com/philmd/git-publish/commit/5bab6e2cc77, I
>> haven't improved it but plan to spend time on it during my next holidays.
>>
>>> Actually, I don't think it's even necessary to CC anyone at all (except
>>> the relevant lists) for pull requests. These patches were already
>>> reviewed.
>>
>> Well as a contributor I find useful to get notified when patches are merged.
>
> Hm, I guess a matter of different preferences then.
>
>> I guess remember some time ago patchew (or another bot?) was sending a
>> notification on pull request merged, this was even more useful than Cc'ing
>> ppl on pull-req. It is also helpful when you track someone else patch on the
>> list.
>> Since most of the maintainers now include the patch RFC822 Message-Id, it is
>> now easy for a bot to reply to patch taken from the last.
>
> I don't remember anything like this, but having an automatic reply to
> the email thread of each merged patch series might be a good idea.
I receive an email for each merge [1]
There is a mailing list for that:
https://lists.nongnu.org/mailman/listinfo/qemu-commits
Thanks,
Laurent
[1] https://lists.nongnu.org/archive/html/qemu-commits/2020-03/index.html
^ permalink raw reply [flat|nested] 45+ messages in thread
end of thread, other threads:[~2020-03-10 12:36 UTC | newest]
Thread overview: 45+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-09 15:08 [PULL 00/33] Trivial branch patches Laurent Vivier
2020-03-09 15:08 ` [PULL 01/33] dp8393x: Mask EOL bit from descriptor addresses, take 2 Laurent Vivier
2020-03-09 15:08 ` [PULL 02/33] maint: Include top-level *.rst files early in git diff Laurent Vivier
2020-03-09 15:08 ` [PULL 03/33] build-sys: Move the print-variable rule to rules.mak Laurent Vivier
2020-03-09 15:08 ` [PULL 04/33] hw/audio/fmopl: Fix a typo twice Laurent Vivier
2020-03-09 15:08 ` [PULL 05/33] hw/net/e1000: Add readops/writeops typedefs Laurent Vivier
2020-03-09 15:08 ` [PULL 06/33] hw/net/e1000: Move macreg[] arrays to .rodata to save 1MiB of .data Laurent Vivier
2020-03-09 15:08 ` [PULL 07/33] virtfs-proxy-helper: Make the helper_opts[] array const Laurent Vivier
2020-03-09 15:08 ` [PULL 08/33] vl: Add missing "hw/boards.h" include Laurent Vivier
2020-03-09 15:08 ` [PULL 09/33] hw/southbridge/ich9: Removed unused headers Laurent Vivier
2020-03-09 15:08 ` [PULL 10/33] hw/i386/ioapic_internal: Remove unused "hw/i386/ioapic.h" header Laurent Vivier
2020-03-09 15:08 ` [PULL 11/33] hw/timer: Remove unused "ui/console.h" header Laurent Vivier
2020-03-09 15:08 ` [PULL 12/33] hw/usb/dev-storage: " Laurent Vivier
2020-03-09 15:08 ` [PULL 13/33] hw/i386/intel_iommu: Remove unused includes Laurent Vivier
2020-03-09 15:08 ` [PULL 14/33] hw/alpha/alpha_sys: Remove unused "hw/ide.h" header Laurent Vivier
2020-03-09 15:08 ` [PULL 15/33] hw/alpha/dp264: Include "net/net.h" Laurent Vivier
2020-03-09 15:08 ` [PULL 16/33] hw/hppa/machine: " Laurent Vivier
2020-03-09 15:08 ` [PULL 17/33] hw/acpi/cpu_hotplug: Include "hw/pci/pci.h" Laurent Vivier
2020-03-09 15:08 ` [PULL 18/33] hw/timer/hpet: Include "exec/address-spaces.h" Laurent Vivier
2020-03-09 15:08 ` [PULL 19/33] hw/pci-host/q35: Include "qemu/range.h" Laurent Vivier
2020-03-09 15:08 ` [PULL 20/33] hw/i2c/smbus_ich9: " Laurent Vivier
2020-03-09 15:08 ` [PULL 21/33] hw/pci-host/piix: " Laurent Vivier
2020-03-09 15:08 ` [PULL 22/33] hw/acpi: Include "hw/mem/nvdimm.h" Laurent Vivier
2020-03-09 15:08 ` [PULL 23/33] hw/i386: " Laurent Vivier
2020-03-09 15:08 ` [PULL 24/33] hw/pci-host/q35: Remove unused includes Laurent Vivier
2020-03-09 15:08 ` [PULL 25/33] hw/i386/pc: Clean up includes Laurent Vivier
2020-03-09 15:08 ` [PULL 26/33] core/qdev: fix memleak in qdev_get_gpio_out_connector() Laurent Vivier
2020-03-09 15:08 ` [PULL 27/33] block/stream: Remove redundant statement in stream_run() Laurent Vivier
2020-03-09 15:08 ` [PULL 28/33] block/file-posix: Remove redundant statement in raw_handle_perm_lock() Laurent Vivier
2020-03-09 15:08 ` [PULL 29/33] dma/xlnx-zdma: Remove redundant statement in zdma_write_dst() Laurent Vivier
2020-03-09 15:08 ` [PULL 30/33] scsi/scsi-disk: Remove redundant statement in scsi_disk_emulate_command() Laurent Vivier
2020-03-09 15:08 ` [PULL 31/33] display/pxa2xx_lcd: Remove redundant statement in pxa2xx_palette_parse() Laurent Vivier
2020-03-09 15:08 ` [PULL 32/33] display/exynos4210_fimd: Remove redundant statement in exynos4210_fimd_update() Laurent Vivier
2020-03-09 15:08 ` [PULL 33/33] monitor/hmp-cmds: Remove redundant statement in hmp_rocker_of_dpa_groups() Laurent Vivier
2020-03-09 16:31 ` [PULL 00/33] Trivial branch patches no-reply
2020-03-09 16:44 ` Peter Maydell
2020-03-09 19:17 ` Michael S. Tsirkin
2020-03-09 19:30 ` Philippe Mathieu-Daudé
2020-03-10 8:02 ` Laurent Vivier
2020-03-10 11:45 ` Kevin Wolf
2020-03-10 12:00 ` Philippe Mathieu-Daudé
2020-03-10 12:11 ` Daniel P. Berrangé
2020-03-10 12:13 ` Kevin Wolf
2020-03-10 12:31 ` Philippe Mathieu-Daudé
2020-03-10 12:34 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).