From: Hannes Reinecke <hare@suse.de>
To: Sam Li <faithilikerun@gmail.com>, qemu-devel@nongnu.org
Cc: damien.lemoal@opensource.wdc.com,
Markus Armbruster <armbru@redhat.com>,
dmitry.fomichev@wdc.com, Stefan Hajnoczi <stefanha@redhat.com>,
Hanna Reitz <hreitz@redhat.com>,
qemu-block@nongnu.org, Eric Blake <eblake@redhat.com>,
Kevin Wolf <kwolf@redhat.com>, Fam Zheng <fam@euphon.net>
Subject: Re: [RFC v4 2/9] qemu-io: add zoned block device operations.
Date: Tue, 12 Jul 2022 08:14:52 +0200 [thread overview]
Message-ID: <0c6fb453-1050-74c9-8f4e-4771493f4c78@suse.de> (raw)
In-Reply-To: <20220712021345.8530-3-faithilikerun@gmail.com>
On 7/12/22 04:13, Sam Li wrote:
> Add zoned storage commands of the device: zone_open(zo), zone_close(zc),
> zone_reset(zs), zone_report(zp), zone_finish(zf).
>
> For example, it can be called by:
> ./build/qemu-io --image-opts driver=zoned_host_device, filename=/dev/nullb0
> -c "zone_report 0 0 1"
>
> Signed-off-by: Sam Li <faithilikerun@gmail.com>
> ---
> block/io.c | 57 ++++++++++++++++
> include/block/block-io.h | 13 ++++
> qemu-io-cmds.c | 143 +++++++++++++++++++++++++++++++++++++++
> 3 files changed, 213 insertions(+)
>
> diff --git a/block/io.c b/block/io.c
> index 1e9bf09a49..a760be0131 100644
> --- a/block/io.c
> +++ b/block/io.c
> @@ -3243,6 +3243,63 @@ out:
> return co.ret;
> }
>
> +int bdrv_co_zone_report(BlockDriverState *bs, int64_t offset,
> + int64_t *nr_zones,
> + BlockZoneDescriptor *zones)
> +{
> + BlockDriver *drv = bs->drv;
> + CoroutineIOCompletion co = {
> + .coroutine = qemu_coroutine_self(),
> + };
> + IO_CODE();
> +
> + bdrv_inc_in_flight(bs);
> + if (!drv || (!drv->bdrv_co_zone_report)) {
> + co.ret = -ENOTSUP;
> + goto out;
> + }
> +
> + if (drv->bdrv_co_zone_report) {
> + co.ret = drv->bdrv_co_zone_report(bs, offset, nr_zones, zones);
> + } else {
> + co.ret = -ENOTSUP;
> + goto out;
> + qemu_coroutine_yield();
> + }
> +
> +out:
> + bdrv_dec_in_flight(bs);
> + return co.ret;
> +}
> +
> +int bdrv_co_zone_mgmt(BlockDriverState *bs, enum zone_op op,
> + int64_t offset, int64_t len)
> +{
> + BlockDriver *drv = bs->drv;
> + CoroutineIOCompletion co = {
> + .coroutine = qemu_coroutine_self(),
> + };
> + IO_CODE();
> +
> + bdrv_inc_in_flight(bs);
> + if (!drv || (!drv->bdrv_co_zone_mgmt)) {
> + co.ret = -ENOTSUP;
> + goto out;
> + }
> +
> + if (drv->bdrv_co_zone_mgmt) {
> + co.ret = drv->bdrv_co_zone_mgmt(bs, op, offset, len);
> + } else {
> + co.ret = -ENOTSUP;
> + goto out;
> + qemu_coroutine_yield();
> + }
> +
> +out:
> + bdrv_dec_in_flight(bs);
> + return co.ret;
> +}
> +
> void *qemu_blockalign(BlockDriverState *bs, size_t size)
> {
> IO_CODE();
> diff --git a/include/block/block-io.h b/include/block/block-io.h
> index 053a27141a..a0ae140452 100644
> --- a/include/block/block-io.h
> +++ b/include/block/block-io.h
> @@ -80,6 +80,13 @@ int bdrv_co_ioctl(BlockDriverState *bs, int req, void *buf);
> /* Ensure contents are flushed to disk. */
> int coroutine_fn bdrv_co_flush(BlockDriverState *bs);
>
> +/* Report zone information of zone block device. */
> +int coroutine_fn bdrv_co_zone_report(BlockDriverState *bs, int64_t offset,
> + int64_t *nr_zones,
> + BlockZoneDescriptor *zones);
> +int coroutine_fn bdrv_co_zone_mgmt(BlockDriverState *bs, zone_op op,
> + int64_t offset, int64_t len);
> +
> int bdrv_co_pdiscard(BdrvChild *child, int64_t offset, int64_t bytes);
> bool bdrv_can_write_zeroes_with_unmap(BlockDriverState *bs);
> int bdrv_block_status(BlockDriverState *bs, int64_t offset,
> @@ -289,6 +296,12 @@ bdrv_readv_vmstate(BlockDriverState *bs, QEMUIOVector *qiov, int64_t pos);
> int generated_co_wrapper
> bdrv_writev_vmstate(BlockDriverState *bs, QEMUIOVector *qiov, int64_t pos);
>
> +int generated_co_wrapper
> +blk_zone_report(BlockBackend *blk, int64_t offset, int64_t *nr_zones,
> + BlockZoneDescriptor *zones);
> +int generated_co_wrapper
> +blk_zone_mgmt(BlockBackend *blk, enum zone_op op, int64_t offset, int64_t len);
> +
> /**
> * bdrv_parent_drained_begin_single:
> *
> diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c
> index 2f0d8ac25a..a88fa322d2 100644
> --- a/qemu-io-cmds.c
> +++ b/qemu-io-cmds.c
> @@ -1706,6 +1706,144 @@ static const cmdinfo_t flush_cmd = {
> .oneline = "flush all in-core file state to disk",
> };
>
> +static int zone_report_f(BlockBackend *blk, int argc, char **argv)
> +{
> + int ret;
> + int64_t offset, nr_zones;
> +
> + ++optind;
> + offset = cvtnum(argv[optind]);
> + ++optind;
> + nr_zones = cvtnum(argv[optind]);
> +
> + g_autofree BlockZoneDescriptor *zones = NULL;
> + zones = g_new(BlockZoneDescriptor, nr_zones);
> + ret = blk_zone_report(blk, offset, &nr_zones, zones);
> + if (ret < 0) {
> + printf("zone report failed: %s\n", strerror(-ret));
> + } else {
> + for (int i = 0; i < nr_zones; ++i) {
> + printf("start: 0x%" PRIx64 ", len 0x%" PRIx64 ", "
> + "cap"" 0x%" PRIx64 ",wptr 0x%" PRIx64 ", "
> + "zcond:%u, [type: %u]\n",
> + zones[i].start, zones[i].length, zones[i].cap, zones[i].wp,
> + zones[i].cond, zones[i].type);
> + }
> + }
> + return ret;
> +}
> +
> +static const cmdinfo_t zone_report_cmd = {
> + .name = "zone_report",
> + .altname = "zp",
> + .cfunc = zone_report_f,
> + .argmin = 2,
> + .argmax = 2,
> + .args = "offset number",
> + .oneline = "report zone information",
> +};
> +
'zp' is a bit odd; I'd rather go with 'zrp'.
Otherwise:
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew
Myers, Andrew McDonald, Martje Boudien Moerman
next prev parent reply other threads:[~2022-07-12 6:24 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 2:13 [RFC v4 0/9] Add support for zoned device Sam Li
2022-07-12 2:13 ` [RFC v4 1/9] block: add block layer APIs resembling Linux ZonedBlockDevice ioctls Sam Li
2022-07-12 6:10 ` Hannes Reinecke
2022-07-12 6:17 ` Sam Li
2022-07-12 7:35 ` Damien Le Moal
2022-07-13 0:54 ` Sam Li
2022-07-12 15:49 ` Stefan Hajnoczi
2022-07-12 22:12 ` Damien Le Moal
2022-07-13 6:22 ` Stefan Hajnoczi
2022-07-13 0:51 ` Sam Li
2022-07-13 6:19 ` Stefan Hajnoczi
2022-07-12 2:13 ` [RFC v4 2/9] qemu-io: add zoned block device operations Sam Li
2022-07-12 6:14 ` Hannes Reinecke [this message]
2022-07-12 7:44 ` Damien Le Moal
2022-07-27 14:13 ` Stefan Hajnoczi
2022-07-28 1:57 ` Damien Le Moal
2022-07-12 2:13 ` [RFC v4 3/9] file-posix: introduce get_sysfs_long_val for a block queue of sysfs attribute Sam Li
2022-07-12 6:16 ` Hannes Reinecke
2022-07-12 7:37 ` Damien Le Moal
2022-07-12 2:13 ` [RFC v4 4/9] file-posix: introduce get_sysfs_str_val for device zoned model Sam Li
2022-07-12 6:17 ` Hannes Reinecke
2022-07-12 6:35 ` Damien Le Moal
2022-07-12 7:42 ` Damien Le Moal
2022-07-12 2:13 ` [RFC v4 5/9] qemu-iotests: test new zone operations Sam Li
2022-07-27 14:34 ` Stefan Hajnoczi
2022-07-27 14:59 ` Ming Lei
2022-07-27 15:12 ` Stefan Hajnoczi
2022-07-12 2:13 ` [RFC v4 6/9] raw-format: add " Sam Li
2022-07-27 14:39 ` Stefan Hajnoczi
2022-07-12 2:13 ` [RFC v4 7/9] config: add check to block layer Sam Li
2022-07-27 14:50 ` Stefan Hajnoczi
2022-07-12 2:13 ` [RFC v4 8/9] include: add support for zoned block devices Sam Li
2022-07-27 14:52 ` Stefan Hajnoczi
2022-07-12 2:13 ` [RFC v4 9/9] qapi: add support for zoned host device Sam Li
2022-07-12 7:48 ` Damien Le Moal
2022-07-27 14:53 ` Stefan Hajnoczi
2022-07-12 5:47 ` [RFC v4 0/9] Add support for zoned device Markus Armbruster
2022-07-12 5:59 ` Sam Li
2022-07-18 10:53 ` Markus Armbruster
2022-07-27 14:55 ` Stefan Hajnoczi
2022-07-27 15:06 ` Stefan Hajnoczi
2022-07-27 15:14 ` Sam Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c6fb453-1050-74c9-8f4e-4771493f4c78@suse.de \
--to=hare@suse.de \
--cc=armbru@redhat.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=dmitry.fomichev@wdc.com \
--cc=eblake@redhat.com \
--cc=faithilikerun@gmail.com \
--cc=fam@euphon.net \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).