From: Stefan Hajnoczi <stefanha@redhat.com>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: Sam Li <faithilikerun@gmail.com>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
dmitry.fomichev@wdc.com, Hanna Reitz <hreitz@redhat.com>,
qemu-block@nongnu.org, Eric Blake <eblake@redhat.com>,
Kevin Wolf <kwolf@redhat.com>, Fam Zheng <fam@euphon.net>,
hare@suse.de
Subject: Re: [RFC v4 1/9] block: add block layer APIs resembling Linux ZonedBlockDevice ioctls.
Date: Wed, 13 Jul 2022 07:22:41 +0100 [thread overview]
Message-ID: <Ys5ksZ4eix87DEL8@stefanha-x1.localdomain> (raw)
In-Reply-To: <0effd311-26e1-3c93-3bae-0de00945a86d@opensource.wdc.com>
[-- Attachment #1: Type: text/plain, Size: 853 bytes --]
On Wed, Jul 13, 2022 at 07:12:17AM +0900, Damien Le Moal wrote:
> On 7/13/22 00:49, Stefan Hajnoczi wrote:
> > On Tue, Jul 12, 2022 at 10:13:37AM +0800, Sam Li wrote:
> >> @@ -1801,6 +1809,130 @@ static off_t copy_file_range(int in_fd, off_t *in_off, int out_fd,
> >> }
> >> #endif
> >>
> >
> > Are the functions below within #ifdef __linux__?
>
> We need more than that: linux AND blkzoned.h header present (meaning a
> recent kernel). So the ifdef should be "#if defined(CONFIG_BLKZONED)" or
> something like it, with CONFIG_BLKZONED defined for linux AND
> /usr/include/linux/blkzoned.h present.
Okay. Try adding the following to meson.build:
config_host_data.set('HAVE_LINUX_BLKZONED_H', cc.has_header('linux/blkzoned.h'))
Then:
#ifdef HAVE_LINUX_BLKZONED_H
...
#endif /* HAVE_LINUX_BLKZONED_H */
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-07-13 6:27 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 2:13 [RFC v4 0/9] Add support for zoned device Sam Li
2022-07-12 2:13 ` [RFC v4 1/9] block: add block layer APIs resembling Linux ZonedBlockDevice ioctls Sam Li
2022-07-12 6:10 ` Hannes Reinecke
2022-07-12 6:17 ` Sam Li
2022-07-12 7:35 ` Damien Le Moal
2022-07-13 0:54 ` Sam Li
2022-07-12 15:49 ` Stefan Hajnoczi
2022-07-12 22:12 ` Damien Le Moal
2022-07-13 6:22 ` Stefan Hajnoczi [this message]
2022-07-13 0:51 ` Sam Li
2022-07-13 6:19 ` Stefan Hajnoczi
2022-07-12 2:13 ` [RFC v4 2/9] qemu-io: add zoned block device operations Sam Li
2022-07-12 6:14 ` Hannes Reinecke
2022-07-12 7:44 ` Damien Le Moal
2022-07-27 14:13 ` Stefan Hajnoczi
2022-07-28 1:57 ` Damien Le Moal
2022-07-12 2:13 ` [RFC v4 3/9] file-posix: introduce get_sysfs_long_val for a block queue of sysfs attribute Sam Li
2022-07-12 6:16 ` Hannes Reinecke
2022-07-12 7:37 ` Damien Le Moal
2022-07-12 2:13 ` [RFC v4 4/9] file-posix: introduce get_sysfs_str_val for device zoned model Sam Li
2022-07-12 6:17 ` Hannes Reinecke
2022-07-12 6:35 ` Damien Le Moal
2022-07-12 7:42 ` Damien Le Moal
2022-07-12 2:13 ` [RFC v4 5/9] qemu-iotests: test new zone operations Sam Li
2022-07-27 14:34 ` Stefan Hajnoczi
2022-07-27 14:59 ` Ming Lei
2022-07-27 15:12 ` Stefan Hajnoczi
2022-07-12 2:13 ` [RFC v4 6/9] raw-format: add " Sam Li
2022-07-27 14:39 ` Stefan Hajnoczi
2022-07-12 2:13 ` [RFC v4 7/9] config: add check to block layer Sam Li
2022-07-27 14:50 ` Stefan Hajnoczi
2022-07-12 2:13 ` [RFC v4 8/9] include: add support for zoned block devices Sam Li
2022-07-27 14:52 ` Stefan Hajnoczi
2022-07-12 2:13 ` [RFC v4 9/9] qapi: add support for zoned host device Sam Li
2022-07-12 7:48 ` Damien Le Moal
2022-07-27 14:53 ` Stefan Hajnoczi
2022-07-12 5:47 ` [RFC v4 0/9] Add support for zoned device Markus Armbruster
2022-07-12 5:59 ` Sam Li
2022-07-18 10:53 ` Markus Armbruster
2022-07-27 14:55 ` Stefan Hajnoczi
2022-07-27 15:06 ` Stefan Hajnoczi
2022-07-27 15:14 ` Sam Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ys5ksZ4eix87DEL8@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=armbru@redhat.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=dmitry.fomichev@wdc.com \
--cc=eblake@redhat.com \
--cc=faithilikerun@gmail.com \
--cc=fam@euphon.net \
--cc=hare@suse.de \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).