From: Thomas Huth <thuth@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
libvir-list@redhat.com, Paolo Bonzini <pbonzini@redhat.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] virtio-blk: deprecate SCSI passthrough
Date: Sat, 14 Dec 2019 13:21:51 +0100 [thread overview]
Message-ID: <0d2e25dc-ff7a-e133-433a-faac5d6a45d2@redhat.com> (raw)
In-Reply-To: <20191213144626.1208237-1-stefanha@redhat.com>
On 13/12/2019 15.46, Stefan Hajnoczi wrote:
> The Linux virtio_blk.ko guest driver is removing legacy SCSI passthrough
> support. Deprecate this feature in QEMU too.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> qemu-deprecated.texi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi
> index 4b4b7425ac..ef94d497da 100644
> --- a/qemu-deprecated.texi
> +++ b/qemu-deprecated.texi
> @@ -285,6 +285,17 @@ spec you can use the ``-cpu rv64gcsu,priv_spec=v1.9.1`` command line argument.
>
> @section Device options
>
> +@subsection Emulated device options
> +
> +@subsubsection -device virtio-blk,scsi=on|off (since 5.0.0)
> +
> +The virtio-blk SCSI passthrough feature is a legacy VIRTIO feature. VIRTIO 1.0
> +and later do not support it because the virtio-scsi device was introduced for
> +full SCSI support. Use virtio-scsi instead when SCSI passthrough is required.
> +
> +Note this also applies to ``-device virtio-blk-pci,scsi=on|off'', which is an
> +alias.
... and "-device virtio-blk-ccw,scsi=on|off". With that added:
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2019-12-14 12:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 14:46 [PATCH] virtio-blk: deprecate SCSI passthrough Stefan Hajnoczi
2019-12-13 14:56 ` Paolo Bonzini
2019-12-13 15:07 ` [libvirt] " Peter Krempa
2019-12-13 15:10 ` Daniel P. Berrangé
2019-12-13 15:25 ` Paolo Bonzini
2019-12-13 14:56 ` Christoph Hellwig
2019-12-14 12:21 ` Thomas Huth [this message]
2019-12-17 10:38 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d2e25dc-ff7a-e133-433a-faac5d6a45d2@redhat.com \
--to=thuth@redhat.com \
--cc=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=libvir-list@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).