From: Peter Krempa <pkrempa@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
libvir-list@redhat.com, qemu-devel@nongnu.org,
Stefan Hajnoczi <stefanha@redhat.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [libvirt] [PATCH] virtio-blk: deprecate SCSI passthrough
Date: Fri, 13 Dec 2019 16:07:06 +0100 [thread overview]
Message-ID: <20191213150706.GS2441258@angien.pipo.sk> (raw)
In-Reply-To: <a14facd1-731e-f1cd-2476-1bd676da1e7d@redhat.com>
On Fri, Dec 13, 2019 at 15:56:08 +0100, Paolo Bonzini wrote:
> On 13/12/19 15:46, Stefan Hajnoczi wrote:
> > The Linux virtio_blk.ko guest driver is removing legacy SCSI passthrough
> > support. Deprecate this feature in QEMU too.
> >
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> > ---
> > qemu-deprecated.texi | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi
> > index 4b4b7425ac..ef94d497da 100644
> > --- a/qemu-deprecated.texi
> > +++ b/qemu-deprecated.texi
> > @@ -285,6 +285,17 @@ spec you can use the ``-cpu rv64gcsu,priv_spec=v1.9.1`` command line argument.
> >
> > @section Device options
> >
> > +@subsection Emulated device options
> > +
> > +@subsubsection -device virtio-blk,scsi=on|off (since 5.0.0)
> > +
> > +The virtio-blk SCSI passthrough feature is a legacy VIRTIO feature. VIRTIO 1.0
> > +and later do not support it because the virtio-scsi device was introduced for
> > +full SCSI support. Use virtio-scsi instead when SCSI passthrough is required.
> > +
> > +Note this also applies to ``-device virtio-blk-pci,scsi=on|off'', which is an
> > +alias.
> > +
> > @subsection Block device options
> >
> > @subsubsection "backing": "" (since 2.12.0)
> >
>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Libvirt still allows and exposes this configuration:
<disk type='block' device='lun'>
<driver name='qemu' type='qcow2'/>
<source dev='/dev/sdfake2'/>
<target dev='vdb' bus='virtio'/>
<address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x0'/>
</disk>
which results into the following command line:
-drive file=/dev/sdfake2,format=qcow2,if=none,id=drive-virtio-disk1 \
-device virtio-blk-pci,scsi=on,bus=pci.0,addr=0x5,drive=drive-virtio-disk1,\
id=virtio-disk1
In this case I don't see any possibility how to fix it since it requires
change of controller.
I don't think that we've also added interlocks for this with VIRTIO 1.0
next prev parent reply other threads:[~2019-12-13 21:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 14:46 [PATCH] virtio-blk: deprecate SCSI passthrough Stefan Hajnoczi
2019-12-13 14:56 ` Paolo Bonzini
2019-12-13 15:07 ` Peter Krempa [this message]
2019-12-13 15:10 ` [libvirt] " Daniel P. Berrangé
2019-12-13 15:25 ` Paolo Bonzini
2019-12-13 14:56 ` Christoph Hellwig
2019-12-14 12:21 ` Thomas Huth
2019-12-17 10:38 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191213150706.GS2441258@angien.pipo.sk \
--to=pkrempa@redhat.com \
--cc=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=libvir-list@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).