qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] Fixes missing key in usb keyboard emulation
@ 2016-02-04 19:03 Daniel Serpell
  2016-02-04 19:03 ` [Qemu-devel] [PATCH] Adds keycode 86 to the hid_usage_keys translation table Daniel Serpell
  0 siblings, 1 reply; 4+ messages in thread
From: Daniel Serpell @ 2016-02-04 19:03 UTC (permalink / raw)
  To: qemu-devel; +Cc: qemu-trivial, Daniel Serpell

Hi,

This one-liner patch adds a translation entry for the key that is between
left shift and 'Z' on international keyboards, enabling its use in the
usb keyboard device emulation.

Daniel Serpell (1):
  Adds keycode 86 to the hid_usage_keys translation table.

 hw/input/hid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.7.0

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Qemu-devel] [PATCH] Adds keycode 86 to the hid_usage_keys translation table.
  2016-02-04 19:03 [Qemu-devel] [PATCH] Fixes missing key in usb keyboard emulation Daniel Serpell
@ 2016-02-04 19:03 ` Daniel Serpell
  2016-02-05  9:16   ` Gerd Hoffmann
  2016-02-11  5:48   ` Michael Tokarev
  0 siblings, 2 replies; 4+ messages in thread
From: Daniel Serpell @ 2016-02-04 19:03 UTC (permalink / raw)
  To: qemu-devel; +Cc: qemu-trivial, Daniel Serpell

This key is present in international keyboards, between left shift and
the 'Z' key, ant is described in the HID usage tables as "Keyboard
Non-US \ and |": http://www.usb.org/developers/hidpage/Hut1_12v2.pdf

This patch fixes the usb-kbd devices.

Signed-off-by: Daniel Serpell <daniel.serpell@gmail.com>
---
 hw/input/hid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/input/hid.c b/hw/input/hid.c
index a11e2bc..b41efbb 100644
--- a/hw/input/hid.c
+++ b/hw/input/hid.c
@@ -45,7 +45,7 @@ static const uint8_t hid_usage_keys[0x100] = {
     0xe2, 0x2c, 0x39, 0x3a, 0x3b, 0x3c, 0x3d, 0x3e,
     0x3f, 0x40, 0x41, 0x42, 0x43, 0x53, 0x47, 0x5f,
     0x60, 0x61, 0x56, 0x5c, 0x5d, 0x5e, 0x57, 0x59,
-    0x5a, 0x5b, 0x62, 0x63, 0x00, 0x00, 0x00, 0x44,
+    0x5a, 0x5b, 0x62, 0x63, 0x00, 0x00, 0x64, 0x44,
     0x45, 0x68, 0x69, 0x6a, 0x6b, 0x6c, 0x6d, 0x6e,
     0xe8, 0xe9, 0x71, 0x72, 0x73, 0x00, 0x00, 0x00,
     0x00, 0x00, 0x00, 0x85, 0x00, 0x00, 0x00, 0x00,
-- 
2.7.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Qemu-devel] [PATCH] Adds keycode 86 to the hid_usage_keys translation table.
  2016-02-04 19:03 ` [Qemu-devel] [PATCH] Adds keycode 86 to the hid_usage_keys translation table Daniel Serpell
@ 2016-02-05  9:16   ` Gerd Hoffmann
  2016-02-11  5:48   ` Michael Tokarev
  1 sibling, 0 replies; 4+ messages in thread
From: Gerd Hoffmann @ 2016-02-05  9:16 UTC (permalink / raw)
  To: Daniel Serpell; +Cc: qemu-trivial, qemu-devel

On Do, 2016-02-04 at 16:03 -0300, Daniel Serpell wrote:
> This key is present in international keyboards, between left shift and
> the 'Z' key, ant is described in the HID usage tables as "Keyboard
> Non-US \ and |": http://www.usb.org/developers/hidpage/Hut1_12v2.pdf
> 
> This patch fixes the usb-kbd devices.
> 
> Signed-off-by: Daniel Serpell <daniel.serpell@gmail.com>

Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Qemu-devel] [PATCH] Adds keycode 86 to the hid_usage_keys translation table.
  2016-02-04 19:03 ` [Qemu-devel] [PATCH] Adds keycode 86 to the hid_usage_keys translation table Daniel Serpell
  2016-02-05  9:16   ` Gerd Hoffmann
@ 2016-02-11  5:48   ` Michael Tokarev
  1 sibling, 0 replies; 4+ messages in thread
From: Michael Tokarev @ 2016-02-11  5:48 UTC (permalink / raw)
  To: Daniel Serpell, qemu-devel; +Cc: qemu-trivial

04.02.2016 22:03, Daniel Serpell wrote:
> This key is present in international keyboards, between left shift and
> the 'Z' key, ant is described in the HID usage tables as "Keyboard
> Non-US \ and |": http://www.usb.org/developers/hidpage/Hut1_12v2.pdf
> 
> This patch fixes the usb-kbd devices.

Applied to -trivial, thanks!

/mjt

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-02-11  5:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-04 19:03 [Qemu-devel] [PATCH] Fixes missing key in usb keyboard emulation Daniel Serpell
2016-02-04 19:03 ` [Qemu-devel] [PATCH] Adds keycode 86 to the hid_usage_keys translation table Daniel Serpell
2016-02-05  9:16   ` Gerd Hoffmann
2016-02-11  5:48   ` Michael Tokarev

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).