* [Qemu-devel] [PATCH v3 0/5] tricore: adding new instructions and fixing
@ 2019-06-24 7:03 David Brenken
2019-06-24 7:03 ` [Qemu-devel] [PATCH v3 1/5] tricore: add FTOIZ instruction David Brenken
` (7 more replies)
0 siblings, 8 replies; 11+ messages in thread
From: David Brenken @ 2019-06-24 7:03 UTC (permalink / raw)
To: qemu-devel; +Cc: kbastian, David Brenken
From: David Brenken <david.brenken@efs-auto.de>
Hello everyone,
as discussed here is the third version of the patchset.
- We finalized the implementation of QSEED according to Bastians
annotations.
- We do only sync ctx.hflags with tb->flags.
Best regards
David
Andreas Konopik (1):
tricore: add QSEED instruction
David Brenken (3):
tricore: add FTOIZ instruction
tricore: add UTOF instruction
tricore: fix RRPW_INSERT instruction
Georg Hofstetter (1):
tricore: sync ctx.hflags with tb->flags
target/tricore/fpu_helper.c | 125 ++++++++++++++++++++++++++++++++++++
target/tricore/helper.h | 3 +
target/tricore/translate.c | 13 +++-
3 files changed, 139 insertions(+), 2 deletions(-)
--
2.22.0.windows.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Qemu-devel] [PATCH v3 1/5] tricore: add FTOIZ instruction
2019-06-24 7:03 [Qemu-devel] [PATCH v3 0/5] tricore: adding new instructions and fixing David Brenken
@ 2019-06-24 7:03 ` David Brenken
2019-06-24 7:03 ` [Qemu-devel] [PATCH v3 2/5] tricore: add UTOF instruction David Brenken
` (6 subsequent siblings)
7 siblings, 0 replies; 11+ messages in thread
From: David Brenken @ 2019-06-24 7:03 UTC (permalink / raw)
To: qemu-devel
Cc: kbastian, Lars Biermanski, Georg Hofstetter, David Brenken,
Robert Rasche, Andreas Konopik
From: David Brenken <david.brenken@efs-auto.de>
Signed-off-by: Andreas Konopik <andreas.konopik@efs-auto.de>
Signed-off-by: David Brenken <david.brenken@efs-auto.de>
Signed-off-by: Georg Hofstetter <georg.hofstetter@efs-auto.de>
Signed-off-by: Robert Rasche <robert.rasche@efs-auto.de>
Signed-off-by: Lars Biermanski <lars.biermanski@efs-auto.de>
Reviewed-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
---
target/tricore/fpu_helper.c | 25 +++++++++++++++++++++++++
target/tricore/helper.h | 1 +
target/tricore/translate.c | 3 +++
3 files changed, 29 insertions(+)
diff --git a/target/tricore/fpu_helper.c b/target/tricore/fpu_helper.c
index d8a6c0d25b..f079d9e939 100644
--- a/target/tricore/fpu_helper.c
+++ b/target/tricore/fpu_helper.c
@@ -303,6 +303,31 @@ uint32_t helper_itof(CPUTriCoreState *env, uint32_t arg)
return (uint32_t)f_result;
}
+uint32_t helper_ftoiz(CPUTriCoreState *env, uint32_t arg)
+{
+ float32 f_arg = make_float32(arg);
+ uint32_t result;
+ int32_t flags;
+
+ result = float32_to_int32_round_to_zero(f_arg, &env->fp_status);
+
+ flags = f_get_excp_flags(env);
+ if (flags & float_flag_invalid) {
+ flags &= ~float_flag_inexact;
+ if (float32_is_any_nan(f_arg)) {
+ result = 0;
+ }
+ }
+
+ if (flags) {
+ f_update_psw_flags(env, flags);
+ } else {
+ env->FPU_FS = 0;
+ }
+
+ return result;
+}
+
uint32_t helper_ftouz(CPUTriCoreState *env, uint32_t arg)
{
float32 f_arg = make_float32(arg);
diff --git a/target/tricore/helper.h b/target/tricore/helper.h
index f60e81096b..16b62edf7f 100644
--- a/target/tricore/helper.h
+++ b/target/tricore/helper.h
@@ -111,6 +111,7 @@ DEF_HELPER_4(fmsub, i32, env, i32, i32, i32)
DEF_HELPER_3(fcmp, i32, env, i32, i32)
DEF_HELPER_2(ftoi, i32, env, i32)
DEF_HELPER_2(itof, i32, env, i32)
+DEF_HELPER_2(ftoiz, i32, env, i32)
DEF_HELPER_2(ftouz, i32, env, i32)
DEF_HELPER_2(updfl, void, env, i32)
/* dvinit */
diff --git a/target/tricore/translate.c b/target/tricore/translate.c
index 06c4485e55..5e1c4f54b9 100644
--- a/target/tricore/translate.c
+++ b/target/tricore/translate.c
@@ -6747,6 +6747,9 @@ static void decode_rr_divide(CPUTriCoreState *env, DisasContext *ctx)
case OPC2_32_RR_UPDFL:
gen_helper_updfl(cpu_env, cpu_gpr_d[r1]);
break;
+ case OPC2_32_RR_FTOIZ:
+ gen_helper_ftoiz(cpu_gpr_d[r3], cpu_env, cpu_gpr_d[r1]);
+ break;
default:
generate_trap(ctx, TRAPC_INSN_ERR, TIN2_IOPC);
}
--
2.22.0.windows.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Qemu-devel] [PATCH v3 2/5] tricore: add UTOF instruction
2019-06-24 7:03 [Qemu-devel] [PATCH v3 0/5] tricore: adding new instructions and fixing David Brenken
2019-06-24 7:03 ` [Qemu-devel] [PATCH v3 1/5] tricore: add FTOIZ instruction David Brenken
@ 2019-06-24 7:03 ` David Brenken
2019-06-24 7:03 ` [Qemu-devel] [PATCH v3 3/5] tricore: fix RRPW_INSERT instruction David Brenken
` (5 subsequent siblings)
7 siblings, 0 replies; 11+ messages in thread
From: David Brenken @ 2019-06-24 7:03 UTC (permalink / raw)
To: qemu-devel
Cc: kbastian, Lars Biermanski, Georg Hofstetter, David Brenken,
Robert Rasche, Andreas Konopik
From: David Brenken <david.brenken@efs-auto.de>
Signed-off-by: Andreas Konopik <andreas.konopik@efs-auto.de>
Signed-off-by: David Brenken <david.brenken@efs-auto.de>
Signed-off-by: Georg Hofstetter <georg.hofstetter@efs-auto.de>
Signed-off-by: Robert Rasche <robert.rasche@efs-auto.de>
Signed-off-by: Lars Biermanski <lars.biermanski@efs-auto.de>
Reviewed-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
---
target/tricore/fpu_helper.c | 16 ++++++++++++++++
target/tricore/helper.h | 1 +
target/tricore/translate.c | 3 +++
3 files changed, 20 insertions(+)
diff --git a/target/tricore/fpu_helper.c b/target/tricore/fpu_helper.c
index f079d9e939..432079c8e2 100644
--- a/target/tricore/fpu_helper.c
+++ b/target/tricore/fpu_helper.c
@@ -303,6 +303,22 @@ uint32_t helper_itof(CPUTriCoreState *env, uint32_t arg)
return (uint32_t)f_result;
}
+uint32_t helper_utof(CPUTriCoreState *env, uint32_t arg)
+{
+ float32 f_result;
+ uint32_t flags;
+
+ f_result = uint32_to_float32(arg, &env->fp_status);
+
+ flags = f_get_excp_flags(env);
+ if (flags) {
+ f_update_psw_flags(env, flags);
+ } else {
+ env->FPU_FS = 0;
+ }
+ return (uint32_t)f_result;
+}
+
uint32_t helper_ftoiz(CPUTriCoreState *env, uint32_t arg)
{
float32 f_arg = make_float32(arg);
diff --git a/target/tricore/helper.h b/target/tricore/helper.h
index 16b62edf7f..f1a5cb367e 100644
--- a/target/tricore/helper.h
+++ b/target/tricore/helper.h
@@ -111,6 +111,7 @@ DEF_HELPER_4(fmsub, i32, env, i32, i32, i32)
DEF_HELPER_3(fcmp, i32, env, i32, i32)
DEF_HELPER_2(ftoi, i32, env, i32)
DEF_HELPER_2(itof, i32, env, i32)
+DEF_HELPER_2(utof, i32, env, i32)
DEF_HELPER_2(ftoiz, i32, env, i32)
DEF_HELPER_2(ftouz, i32, env, i32)
DEF_HELPER_2(updfl, void, env, i32)
diff --git a/target/tricore/translate.c b/target/tricore/translate.c
index 5e1c4f54b9..bd913d71a1 100644
--- a/target/tricore/translate.c
+++ b/target/tricore/translate.c
@@ -6747,6 +6747,9 @@ static void decode_rr_divide(CPUTriCoreState *env, DisasContext *ctx)
case OPC2_32_RR_UPDFL:
gen_helper_updfl(cpu_env, cpu_gpr_d[r1]);
break;
+ case OPC2_32_RR_UTOF:
+ gen_helper_utof(cpu_gpr_d[r3], cpu_env, cpu_gpr_d[r1]);
+ break;
case OPC2_32_RR_FTOIZ:
gen_helper_ftoiz(cpu_gpr_d[r3], cpu_env, cpu_gpr_d[r1]);
break;
--
2.22.0.windows.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Qemu-devel] [PATCH v3 3/5] tricore: fix RRPW_INSERT instruction
2019-06-24 7:03 [Qemu-devel] [PATCH v3 0/5] tricore: adding new instructions and fixing David Brenken
2019-06-24 7:03 ` [Qemu-devel] [PATCH v3 1/5] tricore: add FTOIZ instruction David Brenken
2019-06-24 7:03 ` [Qemu-devel] [PATCH v3 2/5] tricore: add UTOF instruction David Brenken
@ 2019-06-24 7:03 ` David Brenken
2019-06-24 7:03 ` [Qemu-devel] [PATCH v3 4/5] tricore: sync ctx.hflags with tb->flags David Brenken
` (4 subsequent siblings)
7 siblings, 0 replies; 11+ messages in thread
From: David Brenken @ 2019-06-24 7:03 UTC (permalink / raw)
To: qemu-devel
Cc: kbastian, Lars Biermanski, Georg Hofstetter, David Brenken,
Robert Rasche, Andreas Konopik
From: David Brenken <david.brenken@efs-auto.de>
Signed-off-by: Andreas Konopik <andreas.konopik@efs-auto.de>
Signed-off-by: David Brenken <david.brenken@efs-auto.de>
Signed-off-by: Georg Hofstetter <georg.hofstetter@efs-auto.de>
Signed-off-by: Robert Rasche <robert.rasche@efs-auto.de>
Signed-off-by: Lars Biermanski <lars.biermanski@efs-auto.de>
Reviewed-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
---
target/tricore/translate.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/tricore/translate.c b/target/tricore/translate.c
index bd913d71a1..5d4febf1c0 100644
--- a/target/tricore/translate.c
+++ b/target/tricore/translate.c
@@ -7025,9 +7025,9 @@ static void decode_rrpw_extract_insert(CPUTriCoreState *env, DisasContext *ctx)
}
break;
case OPC2_32_RRPW_INSERT:
- if (pos + width <= 31) {
+ if (pos + width <= 32) {
tcg_gen_deposit_tl(cpu_gpr_d[r3], cpu_gpr_d[r1], cpu_gpr_d[r2],
- width, pos);
+ pos, width);
}
break;
default:
--
2.22.0.windows.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Qemu-devel] [PATCH v3 4/5] tricore: sync ctx.hflags with tb->flags
2019-06-24 7:03 [Qemu-devel] [PATCH v3 0/5] tricore: adding new instructions and fixing David Brenken
` (2 preceding siblings ...)
2019-06-24 7:03 ` [Qemu-devel] [PATCH v3 3/5] tricore: fix RRPW_INSERT instruction David Brenken
@ 2019-06-24 7:03 ` David Brenken
2019-06-25 10:00 ` Bastian Koppelmann
2019-06-24 7:03 ` [Qemu-devel] [PATCH v3 5/5] tricore: add QSEED instruction David Brenken
` (3 subsequent siblings)
7 siblings, 1 reply; 11+ messages in thread
From: David Brenken @ 2019-06-24 7:03 UTC (permalink / raw)
To: qemu-devel
Cc: kbastian, Lars Biermanski, Georg Hofstetter, David Brenken,
Robert Rasche, Andreas Konopik
From: Georg Hofstetter <georg.hofstetter@efs-auto.de>
Signed-off-by: Andreas Konopik <andreas.konopik@efs-auto.de>
Signed-off-by: David Brenken <david.brenken@efs-auto.de>
Signed-off-by: Georg Hofstetter <georg.hofstetter@efs-auto.de>
Signed-off-by: Robert Rasche <robert.rasche@efs-auto.de>
Signed-off-by: Lars Biermanski <lars.biermanski@efs-auto.de>
---
target/tricore/translate.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/target/tricore/translate.c b/target/tricore/translate.c
index 5d4febf1c0..c79566e56a 100644
--- a/target/tricore/translate.c
+++ b/target/tricore/translate.c
@@ -8810,6 +8810,7 @@ void gen_intermediate_code(CPUState *cs, TranslationBlock *tb, int max_insns)
ctx.singlestep_enabled = cs->singlestep_enabled;
ctx.bstate = BS_NONE;
ctx.mem_idx = cpu_mmu_index(env, false);
+ ctx.hflags = (uint32_t)tb->flags;
tcg_clear_temp_count();
gen_tb_start(tb);
--
2.22.0.windows.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Qemu-devel] [PATCH v3 5/5] tricore: add QSEED instruction
2019-06-24 7:03 [Qemu-devel] [PATCH v3 0/5] tricore: adding new instructions and fixing David Brenken
` (3 preceding siblings ...)
2019-06-24 7:03 ` [Qemu-devel] [PATCH v3 4/5] tricore: sync ctx.hflags with tb->flags David Brenken
@ 2019-06-24 7:03 ` David Brenken
2019-06-25 10:03 ` Bastian Koppelmann
2019-06-24 8:16 ` [Qemu-devel] [PATCH v3 0/5] tricore: adding new instructions and fixing no-reply
` (2 subsequent siblings)
7 siblings, 1 reply; 11+ messages in thread
From: David Brenken @ 2019-06-24 7:03 UTC (permalink / raw)
To: qemu-devel
Cc: kbastian, Lars Biermanski, Andreas Konopik, Georg Hofstetter,
David Brenken, Robert Rasche, Andreas Konopik
From: Andreas Konopik <andreas.konopik@fau.de>
Signed-off-by: Andreas Konopik <andreas.konopik@efs-auto.de>
Signed-off-by: David Brenken <david.brenken@efs-auto.de>
Signed-off-by: Georg Hofstetter <georg.hofstetter@efs-auto.de>
Signed-off-by: Robert Rasche <robert.rasche@efs-auto.de>
Signed-off-by: Lars Biermanski <lars.biermanski@efs-auto.de>
---
target/tricore/fpu_helper.c | 84 +++++++++++++++++++++++++++++++++++++
target/tricore/helper.h | 1 +
target/tricore/translate.c | 3 ++
3 files changed, 88 insertions(+)
diff --git a/target/tricore/fpu_helper.c b/target/tricore/fpu_helper.c
index 432079c8e2..0f5e1a3eb0 100644
--- a/target/tricore/fpu_helper.c
+++ b/target/tricore/fpu_helper.c
@@ -24,6 +24,7 @@
#define QUIET_NAN 0x7fc00000
#define ADD_NAN 0x7fc00001
+#define SQRT_NAN 0x7fc00004
#define DIV_NAN 0x7fc00008
#define MUL_NAN 0x7fc00002
#define FPU_FS PSW_USB_C
@@ -32,6 +33,9 @@
#define FPU_FZ PSW_USB_AV
#define FPU_FU PSW_USB_SAV
+#define float32_sqrt_nan make_float32(SQRT_NAN)
+#define float32_quiet_nan make_float32(QUIET_NAN)
+
/* we don't care about input_denormal */
static inline uint8_t f_get_excp_flags(CPUTriCoreState *env)
{
@@ -166,6 +170,86 @@ uint32_t helper_fmul(CPUTriCoreState *env, uint32_t r1, uint32_t r2)
}
+/*
+ * Target TriCore QSEED.F significand Lookup Table
+ *
+ * The QSEED.F output significand depends on the least-significant
+ * exponent bit and the 6 most-significant significand bits.
+ *
+ * IEEE 754 float datatype
+ * partitioned into Sign (S), Exponent (E) and Significand (M):
+ *
+ * S E E E E E E E E M M M M M M ...
+ * | | |
+ * +------+------+-------+-------+
+ * | |
+ * for lookup table
+ * calculating index for
+ * output E output M
+ *
+ * This lookup table was extracted by analyzing QSEED output
+ * from the real hardware
+ */
+static const uint8_t target_qseed_significand_table[128] = {
+ 253, 252, 245, 244, 239, 238, 231, 230, 225, 224, 217, 216,
+ 211, 210, 205, 204, 201, 200, 195, 194, 189, 188, 185, 184,
+ 179, 178, 175, 174, 169, 168, 165, 164, 161, 160, 157, 156,
+ 153, 152, 149, 148, 145, 144, 141, 140, 137, 136, 133, 132,
+ 131, 130, 127, 126, 123, 122, 121, 120, 117, 116, 115, 114,
+ 111, 110, 109, 108, 103, 102, 99, 98, 93, 92, 89, 88, 83,
+ 82, 79, 78, 75, 74, 71, 70, 67, 66, 63, 62, 59, 58, 55,
+ 54, 53, 52, 49, 48, 45, 44, 43, 42, 39, 38, 37, 36, 33,
+ 32, 31, 30, 27, 26, 25, 24, 23, 22, 19, 18, 17, 16, 15,
+ 14, 13, 12, 11, 10, 9, 8, 7, 6, 5, 4, 3, 2
+};
+
+uint32_t helper_qseed(CPUTriCoreState *env, uint32_t r1)
+{
+ uint32_t arg1, S, E, M, E_minus_one, m_idx;
+ uint32_t new_E, new_M, new_S, result;
+
+ arg1 = make_float32(r1);
+
+ /* fetch IEEE-754 fields S, E and the uppermost 6-bit of M */
+ S = extract32(arg1, 31, 1);
+ E = extract32(arg1, 23, 8);
+ M = extract32(arg1, 17, 6);
+
+ if (float32_is_any_nan(arg1)) {
+ result = float32_quiet_nan;
+ } else if (float32_is_zero_or_denormal(arg1)) {
+ if (float32_is_neg(arg1)) {
+ result = float32_infinity | (1 << 31);
+ } else {
+ result = float32_infinity;
+ }
+ } else if (float32_is_neg(arg1)) {
+ result = float32_sqrt_nan;
+ } else if (float32_is_infinity(arg1)) {
+ result = float32_zero;
+ } else {
+ E_minus_one = E - 1;
+ m_idx = ((E_minus_one & 1) << 6) | M;
+ new_S = S;
+ new_E = 0xBD - E_minus_one / 2;
+ new_M = target_qseed_significand_table[m_idx];
+
+ result = 0;
+ result = deposit32(result, 31, 1, new_S);
+ result = deposit32(result, 23, 8, new_E);
+ result = deposit32(result, 15, 8, new_M);
+ }
+
+ if (float32_is_signaling_nan(arg1) || result == float32_sqrt_nan) {
+ env->FPU_FI = 1 << 31;
+ env->FPU_FS = 1;
+ } else {
+ env->FPU_FS = 0;
+ }
+
+ return (uint32_t) result;
+}
+
uint32_t helper_fdiv(CPUTriCoreState *env, uint32_t r1, uint32_t r2)
{
uint32_t flags;
diff --git a/target/tricore/helper.h b/target/tricore/helper.h
index f1a5cb367e..b64780c37d 100644
--- a/target/tricore/helper.h
+++ b/target/tricore/helper.h
@@ -109,6 +109,7 @@ DEF_HELPER_3(fdiv, i32, env, i32, i32)
DEF_HELPER_4(fmadd, i32, env, i32, i32, i32)
DEF_HELPER_4(fmsub, i32, env, i32, i32, i32)
DEF_HELPER_3(fcmp, i32, env, i32, i32)
+DEF_HELPER_2(qseed, i32, env, i32)
DEF_HELPER_2(ftoi, i32, env, i32)
DEF_HELPER_2(itof, i32, env, i32)
DEF_HELPER_2(utof, i32, env, i32)
diff --git a/target/tricore/translate.c b/target/tricore/translate.c
index 5d4febf1c0..6d3f9e57b6 100644
--- a/target/tricore/translate.c
+++ b/target/tricore/translate.c
@@ -6753,6 +6753,9 @@ static void decode_rr_divide(CPUTriCoreState *env, DisasContext *ctx)
case OPC2_32_RR_FTOIZ:
gen_helper_ftoiz(cpu_gpr_d[r3], cpu_env, cpu_gpr_d[r1]);
break;
+ case OPC2_32_RR_QSEED_F:
+ gen_helper_qseed(cpu_gpr_d[r3], cpu_env, cpu_gpr_d[r1]);
+ break;
default:
generate_trap(ctx, TRAPC_INSN_ERR, TIN2_IOPC);
}
--
2.22.0.windows.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH v3 0/5] tricore: adding new instructions and fixing
2019-06-24 7:03 [Qemu-devel] [PATCH v3 0/5] tricore: adding new instructions and fixing David Brenken
` (4 preceding siblings ...)
2019-06-24 7:03 ` [Qemu-devel] [PATCH v3 5/5] tricore: add QSEED instruction David Brenken
@ 2019-06-24 8:16 ` no-reply
2019-06-24 9:05 ` no-reply
2019-06-25 10:04 ` Bastian Koppelmann
7 siblings, 0 replies; 11+ messages in thread
From: no-reply @ 2019-06-24 8:16 UTC (permalink / raw)
To: david.brenken; +Cc: kbastian, david.brenken, qemu-devel
Patchew URL: https://patchew.org/QEMU/20190624070339.4408-1-david.brenken@efs-auto.org/
Hi,
This series failed build test on s390x host. Please find the details below.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked under the git checkout with
# HEAD pointing to a commit that has the patches applied on top of "base"
# branch
set -e
CC=$HOME/bin/cc
INSTALL=$PWD/install
BUILD=$PWD/build
mkdir -p $BUILD $INSTALL
SRC=$PWD
cd $BUILD
$SRC/configure --cc=$CC --prefix=$INSTALL
make -j4
# XXX: we need reliable clean up
# make check -j4 V=1
make install
echo
echo "=== ENV ==="
env
echo
echo "=== PACKAGES ==="
rpm -qa
=== TEST SCRIPT END ===
CC unicore32-softmmu/qapi/qapi-commands.o
CC sparc-softmmu/migration/ram.o
/var/tmp/patchew-tester-tmp-hgefvkel/src/target/tricore/fpu_helper.c: In function ‘helper_qseed’:
/var/tmp/patchew-tester-tmp-hgefvkel/src/target/tricore/fpu_helper.c:243:9: error: too few arguments to function ‘float32_is_signaling_nan’
243 | if (float32_is_signaling_nan(arg1) || result == float32_sqrt_nan) {
| ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from /var/tmp/patchew-tester-tmp-hgefvkel/src/target/tricore/fpu_helper.c:23:
The full log is available at
http://patchew.org/logs/20190624070339.4408-1-david.brenken@efs-auto.org/testing.s390x/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH v3 0/5] tricore: adding new instructions and fixing
2019-06-24 7:03 [Qemu-devel] [PATCH v3 0/5] tricore: adding new instructions and fixing David Brenken
` (5 preceding siblings ...)
2019-06-24 8:16 ` [Qemu-devel] [PATCH v3 0/5] tricore: adding new instructions and fixing no-reply
@ 2019-06-24 9:05 ` no-reply
2019-06-25 10:04 ` Bastian Koppelmann
7 siblings, 0 replies; 11+ messages in thread
From: no-reply @ 2019-06-24 9:05 UTC (permalink / raw)
To: david.brenken; +Cc: kbastian, david.brenken, qemu-devel
Patchew URL: https://patchew.org/QEMU/20190624070339.4408-1-david.brenken@efs-auto.org/
Hi,
This series failed build test on s390x host. Please find the details below.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked under the git checkout with
# HEAD pointing to a commit that has the patches applied on top of "base"
# branch
set -e
CC=$HOME/bin/cc
INSTALL=$PWD/install
BUILD=$PWD/build
mkdir -p $BUILD $INSTALL
SRC=$PWD
cd $BUILD
$SRC/configure --cc=$CC --prefix=$INSTALL
make -j4
# XXX: we need reliable clean up
# make check -j4 V=1
make install
echo
echo "=== ENV ==="
env
echo
echo "=== PACKAGES ==="
rpm -qa
=== TEST SCRIPT END ===
CC tricore-softmmu/target/tricore/fpu_helper.o
CC unicore32-softmmu/hw/tpm/tpm_ppi.o
/var/tmp/patchew-tester-tmp-wtoc0zi9/src/target/tricore/fpu_helper.c: In function ‘helper_qseed’:
/var/tmp/patchew-tester-tmp-wtoc0zi9/src/target/tricore/fpu_helper.c:243:9: error: too few arguments to function ‘float32_is_signaling_nan’
243 | if (float32_is_signaling_nan(arg1) || result == float32_sqrt_nan) {
| ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from /var/tmp/patchew-tester-tmp-wtoc0zi9/src/target/tricore/fpu_helper.c:23:
The full log is available at
http://patchew.org/logs/20190624070339.4408-1-david.brenken@efs-auto.org/testing.s390x/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH v3 4/5] tricore: sync ctx.hflags with tb->flags
2019-06-24 7:03 ` [Qemu-devel] [PATCH v3 4/5] tricore: sync ctx.hflags with tb->flags David Brenken
@ 2019-06-25 10:00 ` Bastian Koppelmann
0 siblings, 0 replies; 11+ messages in thread
From: Bastian Koppelmann @ 2019-06-25 10:00 UTC (permalink / raw)
To: David Brenken, qemu-devel
Cc: Andreas Konopik, David Brenken, Robert Rasche, Georg Hofstetter,
Lars Biermanski
On 6/24/19 9:03 AM, David Brenken wrote:
> From: Georg Hofstetter <georg.hofstetter@efs-auto.de>
>
> Signed-off-by: Andreas Konopik <andreas.konopik@efs-auto.de>
> Signed-off-by: David Brenken <david.brenken@efs-auto.de>
> Signed-off-by: Georg Hofstetter <georg.hofstetter@efs-auto.de>
> Signed-off-by: Robert Rasche <robert.rasche@efs-auto.de>
> Signed-off-by: Lars Biermanski <lars.biermanski@efs-auto.de>
> ---
> target/tricore/translate.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Cheers,
Bastian
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH v3 5/5] tricore: add QSEED instruction
2019-06-24 7:03 ` [Qemu-devel] [PATCH v3 5/5] tricore: add QSEED instruction David Brenken
@ 2019-06-25 10:03 ` Bastian Koppelmann
0 siblings, 0 replies; 11+ messages in thread
From: Bastian Koppelmann @ 2019-06-25 10:03 UTC (permalink / raw)
To: David Brenken, qemu-devel
Cc: Lars Biermanski, Andreas Konopik, Georg Hofstetter,
David Brenken, Robert Rasche, Andreas Konopik
On 6/24/19 9:03 AM, David Brenken wrote:
> +
> + result = 0;
> + result = deposit32(result, 31, 1, new_S);
> + result = deposit32(result, 23, 8, new_E);
> + result = deposit32(result, 15, 8, new_M);
> + }
> +
> + if (float32_is_signaling_nan(arg1) || result == float32_sqrt_nan) {
float32_is_signaling_nan needs fp_status as an argument. I'll fix it for you this time, but please check if each patch builds before submitting them. Otherwise: Reviewed-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Cheers,
Bastian
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH v3 0/5] tricore: adding new instructions and fixing
2019-06-24 7:03 [Qemu-devel] [PATCH v3 0/5] tricore: adding new instructions and fixing David Brenken
` (6 preceding siblings ...)
2019-06-24 9:05 ` no-reply
@ 2019-06-25 10:04 ` Bastian Koppelmann
7 siblings, 0 replies; 11+ messages in thread
From: Bastian Koppelmann @ 2019-06-25 10:04 UTC (permalink / raw)
To: David Brenken, qemu-devel; +Cc: David Brenken
On 6/24/19 9:03 AM, David Brenken wrote:
> From: David Brenken <david.brenken@efs-auto.de>
>
>
> Hello everyone,
>
> as discussed here is the third version of the patchset.
> - We finalized the implementation of QSEED according to Bastians
> annotations.
> - We do only sync ctx.hflags with tb->flags.
>
> Best regards
>
> David
>
> Andreas Konopik (1):
> tricore: add QSEED instruction
>
> David Brenken (3):
> tricore: add FTOIZ instruction
> tricore: add UTOF instruction
> tricore: fix RRPW_INSERT instruction
>
> Georg Hofstetter (1):
> tricore: sync ctx.hflags with tb->flags
>
> target/tricore/fpu_helper.c | 125 ++++++++++++++++++++++++++++++++++++
> target/tricore/helper.h | 3 +
> target/tricore/translate.c | 13 +++-
> 3 files changed, 139 insertions(+), 2 deletions(-)
>
Applied to my tricore-next queue.
Cheers,
Bastian
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-06-25 10:06 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-24 7:03 [Qemu-devel] [PATCH v3 0/5] tricore: adding new instructions and fixing David Brenken
2019-06-24 7:03 ` [Qemu-devel] [PATCH v3 1/5] tricore: add FTOIZ instruction David Brenken
2019-06-24 7:03 ` [Qemu-devel] [PATCH v3 2/5] tricore: add UTOF instruction David Brenken
2019-06-24 7:03 ` [Qemu-devel] [PATCH v3 3/5] tricore: fix RRPW_INSERT instruction David Brenken
2019-06-24 7:03 ` [Qemu-devel] [PATCH v3 4/5] tricore: sync ctx.hflags with tb->flags David Brenken
2019-06-25 10:00 ` Bastian Koppelmann
2019-06-24 7:03 ` [Qemu-devel] [PATCH v3 5/5] tricore: add QSEED instruction David Brenken
2019-06-25 10:03 ` Bastian Koppelmann
2019-06-24 8:16 ` [Qemu-devel] [PATCH v3 0/5] tricore: adding new instructions and fixing no-reply
2019-06-24 9:05 ` no-reply
2019-06-25 10:04 ` Bastian Koppelmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).