* [Qemu-devel] [Bug 1840648] [NEW] qemu-4.1.0/roms/edk2/MdeModulePkg/Universal/Disk/UdfDxe/FileName.c:161: logical fault ?
@ 2019-08-19 11:44 dcb
2019-08-19 11:56 ` [Qemu-devel] [Bug 1840648] " Peter Maydell
0 siblings, 1 reply; 2+ messages in thread
From: dcb @ 2019-08-19 11:44 UTC (permalink / raw)
To: qemu-devel
Public bug reported:
qemu-4.1.0/roms/edk2/MdeModulePkg/Universal/Disk/UdfDxe/FileName.c:161:71:
warning: Logical disjunction always evaluates to true: EXPR != '\\' ||
EXPR != '\0'. [incorrectLogicOperator]
Source code is
if ((*(FileName - 1) != L'\\') && ((*(FileName + 2) != L'\\') ||
(*(FileName + 2) != L'\0'))) {
Maybe better code:
if ((*(FileName - 1) != L'\\') && ((*(FileName + 2) != L'\\') &&
(*(FileName + 2) != L'\0'))) {
** Affects: qemu
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1840648
Title:
qemu-4.1.0/roms/edk2/MdeModulePkg/Universal/Disk/UdfDxe/FileName.c:161:
logical fault ?
Status in QEMU:
New
Bug description:
qemu-4.1.0/roms/edk2/MdeModulePkg/Universal/Disk/UdfDxe/FileName.c:161:71:
warning: Logical disjunction always evaluates to true: EXPR != '\\' ||
EXPR != '\0'. [incorrectLogicOperator]
Source code is
if ((*(FileName - 1) != L'\\') && ((*(FileName + 2) != L'\\') ||
(*(FileName + 2) != L'\0'))) {
Maybe better code:
if ((*(FileName - 1) != L'\\') && ((*(FileName + 2) != L'\\') &&
(*(FileName + 2) != L'\0'))) {
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1840648/+subscriptions
^ permalink raw reply [flat|nested] 2+ messages in thread
* [Qemu-devel] [Bug 1840648] Re: qemu-4.1.0/roms/edk2/MdeModulePkg/Universal/Disk/UdfDxe/FileName.c:161: logical fault ?
2019-08-19 11:44 [Qemu-devel] [Bug 1840648] [NEW] qemu-4.1.0/roms/edk2/MdeModulePkg/Universal/Disk/UdfDxe/FileName.c:161: logical fault ? dcb
@ 2019-08-19 11:56 ` Peter Maydell
0 siblings, 0 replies; 2+ messages in thread
From: Peter Maydell @ 2019-08-19 11:56 UTC (permalink / raw)
To: qemu-devel
This isn't QEMU code -- it's just the source for third-party ROMs that
we ship with QEMU because we also ship the ROM binaries. Please report
it to the upstream project.
** Changed in: qemu
Status: New => Invalid
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1840648
Title:
qemu-4.1.0/roms/edk2/MdeModulePkg/Universal/Disk/UdfDxe/FileName.c:161:
logical fault ?
Status in QEMU:
Invalid
Bug description:
qemu-4.1.0/roms/edk2/MdeModulePkg/Universal/Disk/UdfDxe/FileName.c:161:71:
warning: Logical disjunction always evaluates to true: EXPR != '\\' ||
EXPR != '\0'. [incorrectLogicOperator]
Source code is
if ((*(FileName - 1) != L'\\') && ((*(FileName + 2) != L'\\') ||
(*(FileName + 2) != L'\0'))) {
Maybe better code:
if ((*(FileName - 1) != L'\\') && ((*(FileName + 2) != L'\\') &&
(*(FileName + 2) != L'\0'))) {
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1840648/+subscriptions
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-19 12:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-19 11:44 [Qemu-devel] [Bug 1840648] [NEW] qemu-4.1.0/roms/edk2/MdeModulePkg/Universal/Disk/UdfDxe/FileName.c:161: logical fault ? dcb
2019-08-19 11:56 ` [Qemu-devel] [Bug 1840648] " Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).