* [Qemu-devel] [Bug 1840646] [NEW] qemu-4.1.0/roms/SLOF/lib/libnet/ping.c:122: logical fault
@ 2019-08-19 11:42 dcb
2019-08-19 11:58 ` [Qemu-devel] [Bug 1840646] " Peter Maydell
2019-08-19 11:58 ` Peter Maydell
0 siblings, 2 replies; 3+ messages in thread
From: dcb @ 2019-08-19 11:42 UTC (permalink / raw)
To: qemu-devel
Public bug reported:
qemu-4.1.0/roms/SLOF/lib/libnet/ping.c:122:16: warning: Logical
conjunction always evaluates to false: alen <= 0 && alen >= sizeof(args)
- 1. [incorrectLogicOperator]
Source code is
if (alen <= 0 && alen >= sizeof(args) - 1) {
Maybe better code:
if (alen <= 0 || alen >= sizeof(args) - 1) {
** Affects: qemu
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1840646
Title:
qemu-4.1.0/roms/SLOF/lib/libnet/ping.c:122: logical fault
Status in QEMU:
New
Bug description:
qemu-4.1.0/roms/SLOF/lib/libnet/ping.c:122:16: warning: Logical
conjunction always evaluates to false: alen <= 0 && alen >=
sizeof(args) - 1. [incorrectLogicOperator]
Source code is
if (alen <= 0 && alen >= sizeof(args) - 1) {
Maybe better code:
if (alen <= 0 || alen >= sizeof(args) - 1) {
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1840646/+subscriptions
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Qemu-devel] [Bug 1840646] Re: qemu-4.1.0/roms/SLOF/lib/libnet/ping.c:122: logical fault
2019-08-19 11:42 [Qemu-devel] [Bug 1840646] [NEW] qemu-4.1.0/roms/SLOF/lib/libnet/ping.c:122: logical fault dcb
@ 2019-08-19 11:58 ` Peter Maydell
2019-08-19 11:58 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2019-08-19 11:58 UTC (permalink / raw)
To: qemu-devel
This isn't QEMU code -- it's just the source for third-party ROMs that
we ship with QEMU because we also ship the ROM binaries. Please report
it to the upstream project.
** Changed in: qemu
Status: New => Invalid
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1840646
Title:
qemu-4.1.0/roms/SLOF/lib/libnet/ping.c:122: logical fault
Status in QEMU:
Invalid
Bug description:
qemu-4.1.0/roms/SLOF/lib/libnet/ping.c:122:16: warning: Logical
conjunction always evaluates to false: alen <= 0 && alen >=
sizeof(args) - 1. [incorrectLogicOperator]
Source code is
if (alen <= 0 && alen >= sizeof(args) - 1) {
Maybe better code:
if (alen <= 0 || alen >= sizeof(args) - 1) {
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1840646/+subscriptions
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Qemu-devel] [Bug 1840646] Re: qemu-4.1.0/roms/SLOF/lib/libnet/ping.c:122: logical fault
2019-08-19 11:42 [Qemu-devel] [Bug 1840646] [NEW] qemu-4.1.0/roms/SLOF/lib/libnet/ping.c:122: logical fault dcb
2019-08-19 11:58 ` [Qemu-devel] [Bug 1840646] " Peter Maydell
@ 2019-08-19 11:58 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2019-08-19 11:58 UTC (permalink / raw)
To: qemu-devel
(Anything in a git submodule will be third-party code that's not part of
QEMU.)
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1840646
Title:
qemu-4.1.0/roms/SLOF/lib/libnet/ping.c:122: logical fault
Status in QEMU:
Invalid
Bug description:
qemu-4.1.0/roms/SLOF/lib/libnet/ping.c:122:16: warning: Logical
conjunction always evaluates to false: alen <= 0 && alen >=
sizeof(args) - 1. [incorrectLogicOperator]
Source code is
if (alen <= 0 && alen >= sizeof(args) - 1) {
Maybe better code:
if (alen <= 0 || alen >= sizeof(args) - 1) {
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1840646/+subscriptions
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-19 12:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-19 11:42 [Qemu-devel] [Bug 1840646] [NEW] qemu-4.1.0/roms/SLOF/lib/libnet/ping.c:122: logical fault dcb
2019-08-19 11:58 ` [Qemu-devel] [Bug 1840646] " Peter Maydell
2019-08-19 11:58 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).