Re: [Qemu-devel] [PULL 00/42] ppc-for-4.2 queue 20190821

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/20190821072542.23090-1-david@gibson.dropbear.id.au/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PULL 00/42] ppc-for-4.2 queue 20190821
Message-id: 20190821072542.23090-1-david@gibson.dropbear.id.au

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20190821072542.23090-1-david@gibson.dropbear.id.au -> patchew/20190821072542.23090-1-david@gibson.dropbear.id.au
Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for path 'capstone'
Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc'
Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers'
Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 'roms/SLOF'
Submodule 'roms/edk2' (https://git.qemu.org/git/edk2.git) registered for path 'roms/edk2'
Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 'roms/ipxe'
Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered for path 'roms/openbios'
Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) registered for path 'roms/openhackware'
Submodule 'roms/opensbi' (https://git.qemu.org/git/opensbi.git) registered for path 'roms/opensbi'
Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) registered for path 'roms/qemu-palcode'
Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for path 'roms/seabios'
Submodule 'roms/seabios-hppa' (https://git.qemu.org/git/seabios-hppa.git) registered for path 'roms/seabios-hppa'
Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for path 'roms/sgabios'
Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for path 'roms/skiboot'
Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for path 'roms/u-boot'
Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) registered for path 'roms/u-boot-sam460ex'
Submodule 'slirp' (https://git.qemu.org/git/libslirp.git) registered for path 'slirp'
Submodule 'tests/fp/berkeley-softfloat-3' (https://git.qemu.org/git/berkeley-softfloat-3.git) registered for path 'tests/fp/berkeley-softfloat-3'
Submodule 'tests/fp/berkeley-testfloat-3' (https://git.qemu.org/git/berkeley-testfloat-3.git) registered for path 'tests/fp/berkeley-testfloat-3'
Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) registered for path 'ui/keycodemapdb'
Cloning into 'capstone'...
Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf'
Cloning into 'dtc'...
Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536'
Cloning into 'roms/QemuMacDrivers'...
Submodule path 'roms/QemuMacDrivers': checked out '90c488d5f4a407342247b9ea869df1c2d9c8e266'
Cloning into 'roms/SLOF'...
Submodule path 'roms/SLOF': checked out 'ba1ab360eebe6338bb8d7d83a9220ccf7e213af3'
Cloning into 'roms/edk2'...
Submodule path 'roms/edk2': checked out '20d2e5a125e34fc8501026613a71549b2a1a3e54'
Submodule 'SoftFloat' (https://github.com/ucb-bar/berkeley-softfloat-3.git) registered for path 'ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3'
Submodule 'CryptoPkg/Library/OpensslLib/openssl' (https://github.com/openssl/openssl) registered for path 'CryptoPkg/Library/OpensslLib/openssl'
Cloning into 'ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3'...
Submodule path 'roms/edk2/ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037'
Cloning into 'CryptoPkg/Library/OpensslLib/openssl'...
Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl': checked out '50eaac9f3337667259de725451f201e784599687'
Submodule 'boringssl' (https://boringssl.googlesource.com/boringssl) registered for path 'boringssl'
Submodule 'krb5' (https://github.com/krb5/krb5) registered for path 'krb5'
Submodule 'pyca.cryptography' (https://github.com/pyca/cryptography.git) registered for path 'pyca-cryptography'
Cloning into 'boringssl'...
Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl/boringssl': checked out '2070f8ad9151dc8f3a73bffaa146b5e6937a583f'
Cloning into 'krb5'...
Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl/krb5': checked out 'b9ad6c49505c96a088326b62a52568e3484f2168'
Cloning into 'pyca-cryptography'...
Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl/pyca-cryptography': checked out '09403100de2f6f1cdd0d484dcb8e620f1c335c8f'
Cloning into 'roms/ipxe'...
Submodule path 'roms/ipxe': checked out 'de4565cbe76ea9f7913a01f331be3ee901bb6e17'
Cloning into 'roms/openbios'...
Submodule path 'roms/openbios': checked out 'c79e0ecb84f4f1ee3f73f521622e264edd1bf174'
Cloning into 'roms/openhackware'...
Submodule path 'roms/openhackware': checked out 'c559da7c8eec5e45ef1f67978827af6f0b9546f5'
Cloning into 'roms/opensbi'...
Submodule path 'roms/opensbi': checked out 'ce228ee0919deb9957192d723eecc8aaae2697c6'
Cloning into 'roms/qemu-palcode'...
Submodule path 'roms/qemu-palcode': checked out 'bf0e13698872450164fa7040da36a95d2d4b326f'
Cloning into 'roms/seabios'...
Submodule path 'roms/seabios': checked out 'a5cab58e9a3fb6e168aba919c5669bea406573b4'
Cloning into 'roms/seabios-hppa'...
Submodule path 'roms/seabios-hppa': checked out '0f4fe84658165e96ce35870fd19fc634e182e77b'
Cloning into 'roms/sgabios'...
Submodule path 'roms/sgabios': checked out 'cbaee52287e5f32373181cff50a00b6c4ac9015a'
Cloning into 'roms/skiboot'...
Submodule path 'roms/skiboot': checked out '261ca8e779e5138869a45f174caa49be6a274501'
Cloning into 'roms/u-boot'...
Submodule path 'roms/u-boot': checked out 'd3689267f92c5956e09cc7d1baa4700141662bff'
Cloning into 'roms/u-boot-sam460ex'...
Submodule path 'roms/u-boot-sam460ex': checked out '60b3916f33e617a815973c5a6df77055b2e3a588'
Cloning into 'slirp'...
Submodule path 'slirp': checked out '126c04acbabd7ad32c2b018fe10dfac2a3bc1210'
Cloning into 'tests/fp/berkeley-softfloat-3'...
Submodule path 'tests/fp/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037'
Cloning into 'tests/fp/berkeley-testfloat-3'...
Submodule path 'tests/fp/berkeley-testfloat-3': checked out '5a59dcec19327396a011a17fd924aed4fec416b3'
Cloning into 'ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce'
Switched to a new branch 'test'
M       roms/SLOF
54dd837 ppc: Fix emulated single to double denormalized conversions
14d703d ppc: Fix emulated INFINITY and NAN conversions
875d0fd ppc: conform to processor User's Manual for xscvdpspn
82207bc ppc: Add support for 'mffsl' instruction
af4ad8e target/ppc: Add Directed Privileged Door-bell Exception State (DPDES) SPR
1a18dd2 spapr/xive: Mask the EAS when allocating an IRQ
8f81179 spapr: Implement better workaround in spapr-vty device
8b785b8 spapr/irq: Drop spapr_irq_msi_reset()
b74b4ea spapr/pci: Free MSIs during reset
b7e1b2c spapr/pci: Consolidate de-allocation of MSIs
eb9fcda ppc: remove idle_timer logic
b8ba07f spapr: Implement ibm,suspend-me
15e6c56 i386: use machine class ->wakeup method
924f65e machine: Add wakeup method to MachineClass
24ace21 ppc/xive: Improve 'info pic' support
42ccbc3 ppc/xive: Provide silent escalation support
59c0620 ppc/xive: Provide unconditional escalation support
87d9104 ppc/xive: Provide escalation support
ea6752a ppc/xive: Provide backlog support
a4ae484 ppc/xive: Implement TM_PULL_OS_CTX special command
ee83ebc ppc/xive: use an abstract type for XiveNotifier
37517c0 pseries: Update SLOF firmware image
07a7213 spapr: initial implementation for H_TPM_COMM/spapr-tpm-proxy
7cb0a81 docs/specs: initial spec summary for Ultravisor-related hcalls
424be1f spapr: Implement H_JOIN
423838e spapr: Implement H_CONFER
92a57a6 spapr: Implement H_PROD
9ae8240 spapr: Implement dispatch tracking for tcg
893d49b ppc: fix leak in h_client_architecture_support
80c8de0 ppc: fix memory leak in spapr_dt_drc()
c609592 ppc: fix memory leak in spapr_caps_add_properties
518df27 target/ppc: Optimize emulation of vclzw instruction
2094f12 target/ppc: Optimize emulation of vclzd instruction
7038398 target/ppc: Optimize emulation of vgbbd instruction
e6510ae target/ppc: move opcode decode tables to PowerPCCPU
eed2cf3 target/ppc: Optimize emulation of vsl and vsr instructions
e97dfd1 target/ppc: Optimize emulation of lvsl and lvsr instructions
50e1c5d migration: Do not re-read the clock on pre_save in case of paused guest
dbb2b77 spapr_pci: Allow 2MiB and 16MiB IOMMU pagesizes by default
76c767f hw: add compat machines for 4.2
a63b538 spapr_iommu: Fix xlate trace to print translated address
95360a9 spapr: quantify error messages regarding capability settings

=== OUTPUT BEGIN ===
1/42 Checking commit 95360a990d28 (spapr: quantify error messages regarding capability settings)
2/42 Checking commit a63b5380c35e (spapr_iommu: Fix xlate trace to print translated address)
3/42 Checking commit 76c767fc3bee (hw: add compat machines for 4.2)
4/42 Checking commit dbb2b7783a11 (spapr_pci: Allow 2MiB and 16MiB IOMMU pagesizes by default)
5/42 Checking commit 50e1c5dcabaa (migration: Do not re-read the clock on pre_save in case of paused guest)
6/42 Checking commit e97dfd19f5f4 (target/ppc: Optimize emulation of lvsl and lvsr instructions)
7/42 Checking commit eed2cf382e58 (target/ppc: Optimize emulation of vsl and vsr instructions)
8/42 Checking commit e6510aec0e3e (target/ppc: move opcode decode tables to PowerPCCPU)
9/42 Checking commit 703839822a70 (target/ppc: Optimize emulation of vgbbd instruction)
10/42 Checking commit 2094f1269392 (target/ppc: Optimize emulation of vclzd instruction)
11/42 Checking commit 518df27684f9 (target/ppc: Optimize emulation of vclzw instruction)
12/42 Checking commit c6095924b8e2 (ppc: fix memory leak in spapr_caps_add_properties)
13/42 Checking commit 80c8de09b2df (ppc: fix memory leak in spapr_dt_drc())
14/42 Checking commit 893d49b36e4a (ppc: fix leak in h_client_architecture_support)
15/42 Checking commit 9ae82400ac01 (spapr: Implement dispatch tracking for tcg)
16/42 Checking commit 92a57a6a73c2 (spapr: Implement H_PROD)
17/42 Checking commit 423838e528bb (spapr: Implement H_CONFER)
18/42 Checking commit 424be1f65853 (spapr: Implement H_JOIN)
19/42 Checking commit 7cb0a819f560 (docs/specs: initial spec summary for Ultravisor-related hcalls)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 76 lines checked

Patch 19/42 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
20/42 Checking commit 07a72139f9d9 (spapr: initial implementation for H_TPM_COMM/spapr-tpm-proxy)
WARNING: line over 80 characters
#68: FILE: hw/ppc/spapr.c:4047:
+        error_setg(errp, "Only one TPM proxy can be specified for this machine");

WARNING: line over 80 characters
#75: FILE: hw/ppc/spapr.c:4054:
+static void spapr_tpm_proxy_unplug(HotplugHandler *hotplug_dev, DeviceState *dev)

WARNING: line over 80 characters
#132: FILE: hw/ppc/spapr_hcall.c:1966:
+static spapr_hcall_fn svm_hypercall_table[(SVM_HCALL_MAX - SVM_HCALL_BASE) / 4 + 1];

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#163: 
new file mode 100644

total: 0 errors, 4 warnings, 355 lines checked

Patch 20/42 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/42 Checking commit 37517c005b4e (pseries: Update SLOF firmware image)
22/42 Checking commit ee83ebcca358 (ppc/xive: use an abstract type for XiveNotifier)
23/42 Checking commit a4ae48469e5e (ppc/xive: Implement TM_PULL_OS_CTX special command)
24/42 Checking commit ea6752acd411 (ppc/xive: Provide backlog support)
25/42 Checking commit 87d910405de8 (ppc/xive: Provide escalation support)
26/42 Checking commit 59c06201056c (ppc/xive: Provide unconditional escalation support)
27/42 Checking commit 42ccbc3ebd3b (ppc/xive: Provide silent escalation support)
28/42 Checking commit 24ace212fd02 (ppc/xive: Improve 'info pic' support)
29/42 Checking commit 924f65e77d6d (machine: Add wakeup method to MachineClass)
30/42 Checking commit 15e6c567de33 (i386: use machine class ->wakeup method)
31/42 Checking commit b8ba07f7b2c6 (spapr: Implement ibm,suspend-me)
32/42 Checking commit eb9fcdab93e5 (ppc: remove idle_timer logic)
33/42 Checking commit b7e1b2c100aa (spapr/pci: Consolidate de-allocation of MSIs)
34/42 Checking commit b74b4eaf7046 (spapr/pci: Free MSIs during reset)
35/42 Checking commit 8b785b8968b7 (spapr/irq: Drop spapr_irq_msi_reset())
36/42 Checking commit 8f81179e22e2 (spapr: Implement better workaround in spapr-vty device)
37/42 Checking commit 1a18dd2c0829 (spapr/xive: Mask the EAS when allocating an IRQ)
38/42 Checking commit af4ad8eb2ebd (target/ppc: Add Directed Privileged Door-bell Exception State (DPDES) SPR)
39/42 Checking commit 82207bc06043 (ppc: Add support for 'mffsl' instruction)
ERROR: code indent should never use tabs
#59: FILE: disas/ppc.c:5004:
+{ "mffsl",   XRA(63,583,12), XRARB_MASK,^IPOWER9,^I{ FRT } },$

ERROR: space required after that ',' (ctx:VxV)
#59: FILE: disas/ppc.c:5004:
+{ "mffsl",   XRA(63,583,12), XRARB_MASK,       POWER9, { FRT } },
                    ^

ERROR: space required after that ',' (ctx:VxV)
#59: FILE: disas/ppc.c:5004:
+{ "mffsl",   XRA(63,583,12), XRARB_MASK,       POWER9, { FRT } },
                        ^

total: 3 errors, 0 warnings, 116 lines checked

Patch 39/42 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

40/42 Checking commit 875d0fd7004c (ppc: conform to processor User's Manual for xscvdpspn)
41/42 Checking commit 14d703db4d4e (ppc: Fix emulated INFINITY and NAN conversions)
42/42 Checking commit 54dd83778e03 (ppc: Fix emulated single to double denormalized conversions)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190821072542.23090-1-david@gibson.dropbear.id.au/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com