qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: no-reply@patchew.org
To: ysato@users.sourceforge.jp
Cc: philmd@redhat.com, qemu-devel@nongnu.org, ysato@users.sourceforge.jp
Subject: Re: [PATCH v26 00/21] Add RX archtecture support
Date: Tue, 15 Oct 2019 13:28:05 -0700 (PDT)	[thread overview]
Message-ID: <157117128422.5946.3735656740054177447@37313f22b938> (raw)
In-Reply-To: <20191014115757.51866-1-ysato@users.sourceforge.jp>

Patchew URL: https://patchew.org/QEMU/20191014115757.51866-1-ysato@users.sourceforge.jp/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v26 00/21] Add RX archtecture support
Type: series
Message-id: 20191014115757.51866-1-ysato@users.sourceforge.jp

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
505ff3c BootLinuxConsoleTest: Test the RX-Virt machine
870da65 Add rx-softmmu
fd6d0d7 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
53383c1 hw/rx: Honor -accel qtest
22e9b46 hw/rx: RX Target hardware definition
54826a9 hw/char: RX62N serial communication interface (SCI)
503ddab hw/timer: RX62N internal timer modules
3a88365 hw/intc: RX62N interrupt controller (ICUa)
1e75d01 target/rx: Dump bytes for each insn during disassembly
32a5073 target/rx: Collect all bytes during disassembly
ef8739d target/rx: Emit all disassembly in one prt()
d139491 target/rx: Use prt_ldmi for XCHG_mr disassembly
fc42ea6 target/rx: Replace operand with prt_ldmi in disassembler
f69c26a target/rx: Disassemble rx_index_addr into a string
0f7826e target/rx: RX disassembler
a8ce030 target/rx: CPU definition
958916c target/rx: TCG helper
100069d target/rx: TCG translation
ef5069b hw/registerfields.h: Add 8bit and 16bit register macros
d4ac167 qemu/bitops.h: Add extract8 and extract16
2062135 MAINTAINERS: Add RX

=== OUTPUT BEGIN ===
1/21 Checking commit 206213548587 (MAINTAINERS: Add RX)
2/21 Checking commit d4ac1671bb35 (qemu/bitops.h: Add extract8 and extract16)
3/21 Checking commit ef5069b624b4 (hw/registerfields.h: Add 8bit and 16bit register macros)
Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2484.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) };

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) / 2 };

total: 2 errors, 0 warnings, 56 lines checked

Patch 3/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/21 Checking commit 100069d81c69 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 3065 lines checked

Patch 4/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/21 Checking commit 958916cceffd (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
new file mode 100644

total: 0 errors, 1 warnings, 650 lines checked

Patch 5/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/21 Checking commit a8ce03017900 (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#32: 
new file mode 100644

total: 0 errors, 1 warnings, 588 lines checked

Patch 6/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/21 Checking commit 0f7826e600fd (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 1497 lines checked

Patch 7/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/21 Checking commit f69c26a9cf8b (target/rx: Disassemble rx_index_addr into a string)
9/21 Checking commit fc42ea6daa7f (target/rx: Replace operand with prt_ldmi in disassembler)
10/21 Checking commit d1394917d410 (target/rx: Use prt_ldmi for XCHG_mr disassembly)
11/21 Checking commit ef8739d5f3c3 (target/rx: Emit all disassembly in one prt())
12/21 Checking commit 32a5073242dd (target/rx: Collect all bytes during disassembly)
13/21 Checking commit 1e75d0171960 (target/rx: Dump bytes for each insn during disassembly)
14/21 Checking commit 3a8836534610 (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

total: 0 errors, 1 warnings, 445 lines checked

Patch 14/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/21 Checking commit 503ddab9e01b (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 845 lines checked

Patch 15/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/21 Checking commit 54826a95ab7c (hw/char: RX62N serial communication interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
new file mode 100644

total: 0 errors, 1 warnings, 401 lines checked

Patch 16/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/21 Checking commit 22e9b46fa5c7 (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29: 
new file mode 100644

total: 0 errors, 1 warnings, 480 lines checked

Patch 17/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/21 Checking commit 53383c1a8747 (hw/rx: Honor -accel qtest)
19/21 Checking commit fd6d0d7bf641 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core)
20/21 Checking commit 870da651be1c (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#59: 
new file mode 100644

total: 0 errors, 1 warnings, 74 lines checked

Patch 20/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/21 Checking commit 505ff3c7c840 (BootLinuxConsoleTest: Test the RX-Virt machine)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20191014115757.51866-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

  parent reply	other threads:[~2019-10-15 20:29 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-14 11:57 [PATCH v26 00/21] Add RX archtecture support Yoshinori Sato
2019-10-14 11:57 ` [PATCH v26 01/21] MAINTAINERS: Add RX Yoshinori Sato
2019-10-14 11:57 ` [PATCH v26 02/21] qemu/bitops.h: Add extract8 and extract16 Yoshinori Sato
2019-10-14 11:57 ` [PATCH v26 03/21] hw/registerfields.h: Add 8bit and 16bit register macros Yoshinori Sato
2019-10-14 11:57 ` [PATCH v26 04/21] target/rx: TCG translation Yoshinori Sato
2019-10-14 11:57 ` [PATCH v26 05/21] target/rx: TCG helper Yoshinori Sato
2019-10-14 11:57 ` [PATCH v26 06/21] target/rx: CPU definition Yoshinori Sato
2019-10-14 11:57 ` [PATCH v26 07/21] target/rx: RX disassembler Yoshinori Sato
2019-10-14 11:57 ` [PATCH v26 08/21] target/rx: Disassemble rx_index_addr into a string Yoshinori Sato
2019-10-14 11:57 ` [PATCH v26 09/21] target/rx: Replace operand with prt_ldmi in disassembler Yoshinori Sato
2019-10-14 11:57 ` [PATCH v26 10/21] target/rx: Use prt_ldmi for XCHG_mr disassembly Yoshinori Sato
2019-10-14 11:57 ` [PATCH v26 11/21] target/rx: Emit all disassembly in one prt() Yoshinori Sato
2019-10-14 11:57 ` [PATCH v26 12/21] target/rx: Collect all bytes during disassembly Yoshinori Sato
2019-10-14 11:57 ` [PATCH v26 13/21] target/rx: Dump bytes for each insn " Yoshinori Sato
2019-10-14 11:57 ` [PATCH v26 14/21] hw/intc: RX62N interrupt controller (ICUa) Yoshinori Sato
2019-10-14 11:57 ` [PATCH v26 15/21] hw/timer: RX62N internal timer modules Yoshinori Sato
2019-10-14 11:57 ` [PATCH v26 16/21] hw/char: RX62N serial communication interface (SCI) Yoshinori Sato
2019-10-14 11:57 ` [PATCH v26 17/21] hw/rx: RX Target hardware definition Yoshinori Sato
2019-10-14 11:57 ` [PATCH v26 18/21] hw/rx: Honor -accel qtest Yoshinori Sato
2019-10-14 11:57 ` [PATCH v26 19/21] hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core Yoshinori Sato
2019-10-14 11:57 ` [PATCH v26 20/21] Add rx-softmmu Yoshinori Sato
2019-12-13  9:29   ` Philippe Mathieu-Daudé
2019-10-14 11:57 ` [PATCH v26 21/21] BootLinuxConsoleTest: Test the RX-Virt machine Yoshinori Sato
2019-10-14 18:34 ` [PATCH v26 00/21] Add RX archtecture support no-reply
2019-10-15  6:12 ` no-reply
2019-10-15 12:08 ` no-reply
2019-10-15 20:28 ` no-reply [this message]
2019-10-24 16:31 ` Yoshinori Sato
2019-11-04 18:42 ` Philippe Mathieu-Daudé
2019-11-05 14:57   ` Yoshinori Sato
2019-12-10  9:24 ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=157117128422.5946.3735656740054177447@37313f22b938 \
    --to=no-reply@patchew.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).