From: Yoshinori Sato <ysato@users.sourceforge.jp>
To: qemu-devel@nongnu.org
Cc: philmd@redhat.com,
Richard Henderson <richard.henderson@linaro.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>
Subject: [PATCH v26 10/21] target/rx: Use prt_ldmi for XCHG_mr disassembly
Date: Mon, 14 Oct 2019 20:57:46 +0900 [thread overview]
Message-ID: <20191014115757.51866-11-ysato@users.sourceforge.jp> (raw)
In-Reply-To: <20191014115757.51866-1-ysato@users.sourceforge.jp>
From: Richard Henderson <richard.henderson@linaro.org>
Note that the ld == 3 case handled by prt_ldmi is decoded as
XCHG_rr and cannot appear here.
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Message-Id: <20190607091116.49044-21-ysato@users.sourceforge.jp>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/rx/disas.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/target/rx/disas.c b/target/rx/disas.c
index 515b365528..db10385fd0 100644
--- a/target/rx/disas.c
+++ b/target/rx/disas.c
@@ -366,13 +366,7 @@ static bool trans_XCHG_rr(DisasContext *ctx, arg_XCHG_rr *a)
/* xchg dsp[rs].<mi>,rd */
static bool trans_XCHG_mr(DisasContext *ctx, arg_XCHG_mr *a)
{
- static const char msize[][4] = {
- "b", "w", "l", "ub", "uw",
- };
- char dsp[8];
-
- rx_index_addr(ctx, dsp, a->ld, a->mi);
- prt("xchg\t%s[r%d].%s, r%d", dsp, a->rs, msize[a->mi], a->rd);
+ prt_ldmi(ctx, "xchg", a->ld, a->mi, a->rs, a->rd);
return true;
}
--
2.20.1
next prev parent reply other threads:[~2019-10-14 12:06 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 11:57 [PATCH v26 00/21] Add RX archtecture support Yoshinori Sato
2019-10-14 11:57 ` [PATCH v26 01/21] MAINTAINERS: Add RX Yoshinori Sato
2019-10-14 11:57 ` [PATCH v26 02/21] qemu/bitops.h: Add extract8 and extract16 Yoshinori Sato
2019-10-14 11:57 ` [PATCH v26 03/21] hw/registerfields.h: Add 8bit and 16bit register macros Yoshinori Sato
2019-10-14 11:57 ` [PATCH v26 04/21] target/rx: TCG translation Yoshinori Sato
2019-10-14 11:57 ` [PATCH v26 05/21] target/rx: TCG helper Yoshinori Sato
2019-10-14 11:57 ` [PATCH v26 06/21] target/rx: CPU definition Yoshinori Sato
2019-10-14 11:57 ` [PATCH v26 07/21] target/rx: RX disassembler Yoshinori Sato
2019-10-14 11:57 ` [PATCH v26 08/21] target/rx: Disassemble rx_index_addr into a string Yoshinori Sato
2019-10-14 11:57 ` [PATCH v26 09/21] target/rx: Replace operand with prt_ldmi in disassembler Yoshinori Sato
2019-10-14 11:57 ` Yoshinori Sato [this message]
2019-10-14 11:57 ` [PATCH v26 11/21] target/rx: Emit all disassembly in one prt() Yoshinori Sato
2019-10-14 11:57 ` [PATCH v26 12/21] target/rx: Collect all bytes during disassembly Yoshinori Sato
2019-10-14 11:57 ` [PATCH v26 13/21] target/rx: Dump bytes for each insn " Yoshinori Sato
2019-10-14 11:57 ` [PATCH v26 14/21] hw/intc: RX62N interrupt controller (ICUa) Yoshinori Sato
2019-10-14 11:57 ` [PATCH v26 15/21] hw/timer: RX62N internal timer modules Yoshinori Sato
2019-10-14 11:57 ` [PATCH v26 16/21] hw/char: RX62N serial communication interface (SCI) Yoshinori Sato
2019-10-14 11:57 ` [PATCH v26 17/21] hw/rx: RX Target hardware definition Yoshinori Sato
2019-10-14 11:57 ` [PATCH v26 18/21] hw/rx: Honor -accel qtest Yoshinori Sato
2019-10-14 11:57 ` [PATCH v26 19/21] hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core Yoshinori Sato
2019-10-14 11:57 ` [PATCH v26 20/21] Add rx-softmmu Yoshinori Sato
2019-12-13 9:29 ` Philippe Mathieu-Daudé
2019-10-14 11:57 ` [PATCH v26 21/21] BootLinuxConsoleTest: Test the RX-Virt machine Yoshinori Sato
2019-10-14 18:34 ` [PATCH v26 00/21] Add RX archtecture support no-reply
2019-10-15 6:12 ` no-reply
2019-10-15 12:08 ` no-reply
2019-10-15 20:28 ` no-reply
2019-10-24 16:31 ` Yoshinori Sato
2019-11-04 18:42 ` Philippe Mathieu-Daudé
2019-11-05 14:57 ` Yoshinori Sato
2019-12-10 9:24 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014115757.51866-11-ysato@users.sourceforge.jp \
--to=ysato@users.sourceforge.jp \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).