From: no-reply@patchew.org
To: pbonzini@redhat.com
Cc: qemu-devel@nongnu.org, ehabkost@redhat.com
Subject: Re: [PATCH] target/i386: add support for MSR_IA32_TSX_CTRL
Date: Wed, 20 Nov 2019 04:59:39 -0800 (PST) [thread overview]
Message-ID: <157425477840.6277.13439344416661102188@37313f22b938> (raw)
In-Reply-To: <20191120121922.6082-1-pbonzini@redhat.com>
Patchew URL: https://patchew.org/QEMU/20191120121922.6082-1-pbonzini@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH] target/i386: add support for MSR_IA32_TSX_CTRL
Type: series
Message-id: 20191120121922.6082-1-pbonzini@redhat.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Switched to a new branch 'test'
995694e target/i386: add support for MSR_IA32_TSX_CTRL
=== OUTPUT BEGIN ===
ERROR: code indent should never use tabs
#38: FILE: target/i386/cpu.h:354:
+#define ARCH_CAP_TSX_CTRL_MSR^I^I(1<<7)$
ERROR: spaces required around that '<<' (ctx:VxV)
#38: FILE: target/i386/cpu.h:354:
+#define ARCH_CAP_TSX_CTRL_MSR (1<<7)
^
ERROR: code indent should never use tabs
#40: FILE: target/i386/cpu.h:356:
+#define MSR_IA32_TSX_CTRL^I^I0x122$
total: 3 errors, 0 warnings, 101 lines checked
Commit 995694ea43f9 (target/i386: add support for MSR_IA32_TSX_CTRL) has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20191120121922.6082-1-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
next prev parent reply other threads:[~2019-11-20 13:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 12:19 [PATCH] target/i386: add support for MSR_IA32_TSX_CTRL Paolo Bonzini
2019-11-20 12:59 ` no-reply [this message]
2019-11-20 20:04 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157425477840.6277.13439344416661102188@37313f22b938 \
--to=no-reply@patchew.org \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).