From: no-reply@patchew.org
To: Bilal_Wasim@mentor.com
Cc: edgar.iglesias@gmail.com, alistair@alistair23.me,
qemu-devel@nongnu.org, qemu-arm@nongnu.org,
peter.maydell@linaro.org
Subject: Re: RE: [PATCH] Updating the GEM MAC IP to properly filter out the multicast addresses
Date: Fri, 29 Nov 2019 02:00:50 -0800 (PST) [thread overview]
Message-ID: <157502164943.26997.4420518369702620170@37313f22b938> (raw)
In-Reply-To: <2b7a42487a5d4a258062bd209a0d13fa@SVR-IES-MBX-03.mgc.mentorg.com>
Patchew URL: https://patchew.org/QEMU/2b7a42487a5d4a258062bd209a0d13fa@SVR-IES-MBX-03.mgc.mentorg.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: RE: [PATCH] Updating the GEM MAC IP to properly filter out the multicast addresses
Type: series
Message-id: 2b7a42487a5d4a258062bd209a0d13fa@SVR-IES-MBX-03.mgc.mentorg.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Switched to a new branch 'test'
da627f2 Updating the GEM MAC IP to properly filter out the multicast addresses
=== OUTPUT BEGIN ===
ERROR: line over 90 characters
#36: FILE: hw/net/cadence_gem.c:319:
+/* IEEE has specified that the most significant bit of the most significant byte be used for
WARNING: Block comments use a leading /* on a separate line
#36: FILE: hw/net/cadence_gem.c:319:
+/* IEEE has specified that the most significant bit of the most significant byte be used for
WARNING: Block comments use a trailing */ on a separate line
#38: FILE: hw/net/cadence_gem.c:321:
+ * If its a 1, that means multicast, 0 means unicast. */
total: 1 errors, 2 warnings, 54 lines checked
Commit da627f2a2cb5 (Updating the GEM MAC IP to properly filter out the multicast addresses) has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/2b7a42487a5d4a258062bd209a0d13fa@SVR-IES-MBX-03.mgc.mentorg.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
prev parent reply other threads:[~2019-11-29 10:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 15:10 [PATCH] Updating the GEM MAC IP to properly filter out the multicast addresses Wasim, Bilal
2019-11-28 15:59 ` Edgar E. Iglesias
2019-11-28 17:02 ` Wasim, Bilal
2019-11-28 17:31 ` Edgar E. Iglesias
2019-11-28 17:34 ` Wasim, Bilal
2019-11-29 8:54 ` Wasim, Bilal
2019-11-29 10:00 ` no-reply [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157502164943.26997.4420518369702620170@37313f22b938 \
--to=no-reply@patchew.org \
--cc=Bilal_Wasim@mentor.com \
--cc=alistair@alistair23.me \
--cc=edgar.iglesias@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).