* [PATCH] target/ppc: Untabify excp_helper.c
@ 2020-05-07 16:11 Greg Kurz
2020-05-07 17:58 ` Philippe Mathieu-Daudé
2020-05-07 23:33 ` David Gibson
0 siblings, 2 replies; 3+ messages in thread
From: Greg Kurz @ 2020-05-07 16:11 UTC (permalink / raw)
To: David Gibson; +Cc: qemu-ppc, qemu-devel, Nicholas Piggin
Some tabs crept in with a recent change.
Fixes: 6dc6b557913f "target/ppc: Improve syscall exception logging"
Signed-off-by: Greg Kurz <groug@kaod.org>
---
target/ppc/excp_helper.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
index 639cac38f9c3..4db3d9ed9af5 100644
--- a/target/ppc/excp_helper.c
+++ b/target/ppc/excp_helper.c
@@ -70,16 +70,16 @@ static inline void dump_syscall(CPUPPCState *env)
static inline void dump_hcall(CPUPPCState *env)
{
qemu_log_mask(CPU_LOG_INT, "hypercall r3=%016" PRIx64
- " r4=%016" PRIx64 " r5=%016" PRIx64 " r6=%016" PRIx64
- " r7=%016" PRIx64 " r8=%016" PRIx64 " r9=%016" PRIx64
- " r10=%016" PRIx64 " r11=%016" PRIx64 " r12=%016" PRIx64
+ " r4=%016" PRIx64 " r5=%016" PRIx64 " r6=%016" PRIx64
+ " r7=%016" PRIx64 " r8=%016" PRIx64 " r9=%016" PRIx64
+ " r10=%016" PRIx64 " r11=%016" PRIx64 " r12=%016" PRIx64
" nip=" TARGET_FMT_lx "\n",
ppc_dump_gpr(env, 3), ppc_dump_gpr(env, 4),
- ppc_dump_gpr(env, 5), ppc_dump_gpr(env, 6),
- ppc_dump_gpr(env, 7), ppc_dump_gpr(env, 8),
- ppc_dump_gpr(env, 9), ppc_dump_gpr(env, 10),
- ppc_dump_gpr(env, 11), ppc_dump_gpr(env, 12),
- env->nip);
+ ppc_dump_gpr(env, 5), ppc_dump_gpr(env, 6),
+ ppc_dump_gpr(env, 7), ppc_dump_gpr(env, 8),
+ ppc_dump_gpr(env, 9), ppc_dump_gpr(env, 10),
+ ppc_dump_gpr(env, 11), ppc_dump_gpr(env, 12),
+ env->nip);
}
static int powerpc_reset_wakeup(CPUState *cs, CPUPPCState *env, int excp,
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] target/ppc: Untabify excp_helper.c
2020-05-07 16:11 [PATCH] target/ppc: Untabify excp_helper.c Greg Kurz
@ 2020-05-07 17:58 ` Philippe Mathieu-Daudé
2020-05-07 23:33 ` David Gibson
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-05-07 17:58 UTC (permalink / raw)
To: Greg Kurz, David Gibson; +Cc: qemu-ppc, qemu-devel, Nicholas Piggin
On 5/7/20 6:11 PM, Greg Kurz wrote:
> Some tabs crept in with a recent change.
>
> Fixes: 6dc6b557913f "target/ppc: Improve syscall exception logging"
> Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
using `git-diff --ignore-space-change`.
> ---
> target/ppc/excp_helper.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
> index 639cac38f9c3..4db3d9ed9af5 100644
> --- a/target/ppc/excp_helper.c
> +++ b/target/ppc/excp_helper.c
> @@ -70,16 +70,16 @@ static inline void dump_syscall(CPUPPCState *env)
> static inline void dump_hcall(CPUPPCState *env)
> {
> qemu_log_mask(CPU_LOG_INT, "hypercall r3=%016" PRIx64
> - " r4=%016" PRIx64 " r5=%016" PRIx64 " r6=%016" PRIx64
> - " r7=%016" PRIx64 " r8=%016" PRIx64 " r9=%016" PRIx64
> - " r10=%016" PRIx64 " r11=%016" PRIx64 " r12=%016" PRIx64
> + " r4=%016" PRIx64 " r5=%016" PRIx64 " r6=%016" PRIx64
> + " r7=%016" PRIx64 " r8=%016" PRIx64 " r9=%016" PRIx64
> + " r10=%016" PRIx64 " r11=%016" PRIx64 " r12=%016" PRIx64
> " nip=" TARGET_FMT_lx "\n",
> ppc_dump_gpr(env, 3), ppc_dump_gpr(env, 4),
> - ppc_dump_gpr(env, 5), ppc_dump_gpr(env, 6),
> - ppc_dump_gpr(env, 7), ppc_dump_gpr(env, 8),
> - ppc_dump_gpr(env, 9), ppc_dump_gpr(env, 10),
> - ppc_dump_gpr(env, 11), ppc_dump_gpr(env, 12),
> - env->nip);
> + ppc_dump_gpr(env, 5), ppc_dump_gpr(env, 6),
> + ppc_dump_gpr(env, 7), ppc_dump_gpr(env, 8),
> + ppc_dump_gpr(env, 9), ppc_dump_gpr(env, 10),
> + ppc_dump_gpr(env, 11), ppc_dump_gpr(env, 12),
> + env->nip);
> }
>
> static int powerpc_reset_wakeup(CPUState *cs, CPUPPCState *env, int excp,
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] target/ppc: Untabify excp_helper.c
2020-05-07 16:11 [PATCH] target/ppc: Untabify excp_helper.c Greg Kurz
2020-05-07 17:58 ` Philippe Mathieu-Daudé
@ 2020-05-07 23:33 ` David Gibson
1 sibling, 0 replies; 3+ messages in thread
From: David Gibson @ 2020-05-07 23:33 UTC (permalink / raw)
To: Greg Kurz; +Cc: qemu-ppc, qemu-devel, Nicholas Piggin
[-- Attachment #1: Type: text/plain, Size: 2189 bytes --]
On Thu, May 07, 2020 at 06:11:23PM +0200, Greg Kurz wrote:
> Some tabs crept in with a recent change.
>
> Fixes: 6dc6b557913f "target/ppc: Improve syscall exception logging"
> Signed-off-by: Greg Kurz <groug@kaod.org>
Applied, thanks.
Not quite sure why my pre-commit hook didn't catch this before I sent
the PR, but there you go.
> ---
> target/ppc/excp_helper.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
> index 639cac38f9c3..4db3d9ed9af5 100644
> --- a/target/ppc/excp_helper.c
> +++ b/target/ppc/excp_helper.c
> @@ -70,16 +70,16 @@ static inline void dump_syscall(CPUPPCState *env)
> static inline void dump_hcall(CPUPPCState *env)
> {
> qemu_log_mask(CPU_LOG_INT, "hypercall r3=%016" PRIx64
> - " r4=%016" PRIx64 " r5=%016" PRIx64 " r6=%016" PRIx64
> - " r7=%016" PRIx64 " r8=%016" PRIx64 " r9=%016" PRIx64
> - " r10=%016" PRIx64 " r11=%016" PRIx64 " r12=%016" PRIx64
> + " r4=%016" PRIx64 " r5=%016" PRIx64 " r6=%016" PRIx64
> + " r7=%016" PRIx64 " r8=%016" PRIx64 " r9=%016" PRIx64
> + " r10=%016" PRIx64 " r11=%016" PRIx64 " r12=%016" PRIx64
> " nip=" TARGET_FMT_lx "\n",
> ppc_dump_gpr(env, 3), ppc_dump_gpr(env, 4),
> - ppc_dump_gpr(env, 5), ppc_dump_gpr(env, 6),
> - ppc_dump_gpr(env, 7), ppc_dump_gpr(env, 8),
> - ppc_dump_gpr(env, 9), ppc_dump_gpr(env, 10),
> - ppc_dump_gpr(env, 11), ppc_dump_gpr(env, 12),
> - env->nip);
> + ppc_dump_gpr(env, 5), ppc_dump_gpr(env, 6),
> + ppc_dump_gpr(env, 7), ppc_dump_gpr(env, 8),
> + ppc_dump_gpr(env, 9), ppc_dump_gpr(env, 10),
> + ppc_dump_gpr(env, 11), ppc_dump_gpr(env, 12),
> + env->nip);
> }
>
> static int powerpc_reset_wakeup(CPUState *cs, CPUPPCState *env, int excp,
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-07 23:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-07 16:11 [PATCH] target/ppc: Untabify excp_helper.c Greg Kurz
2020-05-07 17:58 ` Philippe Mathieu-Daudé
2020-05-07 23:33 ` David Gibson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).