* [Bug 1885720] [NEW] qemu/migration/postcopy-ram.c:387: bad return expression ?
@ 2020-06-30 12:42 dcb
2020-07-01 8:07 ` [Bug 1885720] " Thomas Huth
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: dcb @ 2020-06-30 12:42 UTC (permalink / raw)
To: qemu-devel
Public bug reported:
qemu/migration/postcopy-ram.c:387:9: style: Non-boolean value returned
from function returning bool [returnNonBoolInBooleanFunction]
Source code is
return -1;
but
bool postcopy_ram_supported_by_host(
** Affects: qemu
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1885720
Title:
qemu/migration/postcopy-ram.c:387: bad return expression ?
Status in QEMU:
New
Bug description:
qemu/migration/postcopy-ram.c:387:9: style: Non-boolean value returned
from function returning bool [returnNonBoolInBooleanFunction]
Source code is
return -1;
but
bool postcopy_ram_supported_by_host(
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1885720/+subscriptions
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug 1885720] Re: qemu/migration/postcopy-ram.c:387: bad return expression ?
2020-06-30 12:42 [Bug 1885720] [NEW] qemu/migration/postcopy-ram.c:387: bad return expression ? dcb
@ 2020-07-01 8:07 ` Thomas Huth
2020-07-01 8:38 ` Dr. David Alan Gilbert
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Thomas Huth @ 2020-07-01 8:07 UTC (permalink / raw)
To: qemu-devel
That looks like a bug, indeed!
** Changed in: qemu
Status: New => Confirmed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1885720
Title:
qemu/migration/postcopy-ram.c:387: bad return expression ?
Status in QEMU:
Confirmed
Bug description:
qemu/migration/postcopy-ram.c:387:9: style: Non-boolean value returned
from function returning bool [returnNonBoolInBooleanFunction]
Source code is
return -1;
but
bool postcopy_ram_supported_by_host(
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1885720/+subscriptions
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug 1885720] Re: qemu/migration/postcopy-ram.c:387: bad return expression ?
2020-06-30 12:42 [Bug 1885720] [NEW] qemu/migration/postcopy-ram.c:387: bad return expression ? dcb
2020-07-01 8:07 ` [Bug 1885720] " Thomas Huth
@ 2020-07-01 8:38 ` Dr. David Alan Gilbert
2020-07-01 9:47 ` Dr. David Alan Gilbert
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Dr. David Alan Gilbert @ 2020-07-01 8:38 UTC (permalink / raw)
To: qemu-devel
Yes, I think a goto out; there makes sense; nearly 5 years old that
error :-)
** Changed in: qemu
Assignee: (unassigned) => Dr. David Alan Gilbert (dgilbert-h)
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1885720
Title:
qemu/migration/postcopy-ram.c:387: bad return expression ?
Status in QEMU:
Confirmed
Bug description:
qemu/migration/postcopy-ram.c:387:9: style: Non-boolean value returned
from function returning bool [returnNonBoolInBooleanFunction]
Source code is
return -1;
but
bool postcopy_ram_supported_by_host(
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1885720/+subscriptions
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug 1885720] Re: qemu/migration/postcopy-ram.c:387: bad return expression ?
2020-06-30 12:42 [Bug 1885720] [NEW] qemu/migration/postcopy-ram.c:387: bad return expression ? dcb
2020-07-01 8:07 ` [Bug 1885720] " Thomas Huth
2020-07-01 8:38 ` Dr. David Alan Gilbert
@ 2020-07-01 9:47 ` Dr. David Alan Gilbert
2020-07-04 16:53 ` Thomas Huth
2020-08-20 14:38 ` Thomas Huth
4 siblings, 0 replies; 6+ messages in thread
From: Dr. David Alan Gilbert @ 2020-07-01 9:47 UTC (permalink / raw)
To: qemu-devel
Posted:
migration: postcopy take proper error return
** Changed in: qemu
Status: Confirmed => In Progress
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1885720
Title:
qemu/migration/postcopy-ram.c:387: bad return expression ?
Status in QEMU:
In Progress
Bug description:
qemu/migration/postcopy-ram.c:387:9: style: Non-boolean value returned
from function returning bool [returnNonBoolInBooleanFunction]
Source code is
return -1;
but
bool postcopy_ram_supported_by_host(
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1885720/+subscriptions
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug 1885720] Re: qemu/migration/postcopy-ram.c:387: bad return expression ?
2020-06-30 12:42 [Bug 1885720] [NEW] qemu/migration/postcopy-ram.c:387: bad return expression ? dcb
` (2 preceding siblings ...)
2020-07-01 9:47 ` Dr. David Alan Gilbert
@ 2020-07-04 16:53 ` Thomas Huth
2020-08-20 14:38 ` Thomas Huth
4 siblings, 0 replies; 6+ messages in thread
From: Thomas Huth @ 2020-07-04 16:53 UTC (permalink / raw)
To: qemu-devel
Fix has been merged:
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=617a32f5295ee4e
** Changed in: qemu
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1885720
Title:
qemu/migration/postcopy-ram.c:387: bad return expression ?
Status in QEMU:
Fix Committed
Bug description:
qemu/migration/postcopy-ram.c:387:9: style: Non-boolean value returned
from function returning bool [returnNonBoolInBooleanFunction]
Source code is
return -1;
but
bool postcopy_ram_supported_by_host(
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1885720/+subscriptions
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug 1885720] Re: qemu/migration/postcopy-ram.c:387: bad return expression ?
2020-06-30 12:42 [Bug 1885720] [NEW] qemu/migration/postcopy-ram.c:387: bad return expression ? dcb
` (3 preceding siblings ...)
2020-07-04 16:53 ` Thomas Huth
@ 2020-08-20 14:38 ` Thomas Huth
4 siblings, 0 replies; 6+ messages in thread
From: Thomas Huth @ 2020-08-20 14:38 UTC (permalink / raw)
To: qemu-devel
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1885720
Title:
qemu/migration/postcopy-ram.c:387: bad return expression ?
Status in QEMU:
Fix Released
Bug description:
qemu/migration/postcopy-ram.c:387:9: style: Non-boolean value returned
from function returning bool [returnNonBoolInBooleanFunction]
Source code is
return -1;
but
bool postcopy_ram_supported_by_host(
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1885720/+subscriptions
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-08-20 14:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-30 12:42 [Bug 1885720] [NEW] qemu/migration/postcopy-ram.c:387: bad return expression ? dcb
2020-07-01 8:07 ` [Bug 1885720] " Thomas Huth
2020-07-01 8:38 ` Dr. David Alan Gilbert
2020-07-01 9:47 ` Dr. David Alan Gilbert
2020-07-04 16:53 ` Thomas Huth
2020-08-20 14:38 ` Thomas Huth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).