From: no-reply@patchew.org
To: richard.henderson@linaro.org
Cc: alex.bennee@linaro.org, qemu-devel@nongnu.org
Subject: Re: [PATCH v4 00/11] capstone + disassembler patches
Date: Mon, 21 Sep 2020 17:50:42 -0700 (PDT) [thread overview]
Message-ID: <160073584167.23987.5739705917333363444@66eaa9a8a123> (raw)
In-Reply-To: <20200921174118.39352-1-richard.henderson@linaro.org>
Patchew URL: https://patchew.org/QEMU/20200921174118.39352-1-richard.henderson@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20200921174118.39352-1-richard.henderson@linaro.org
Subject: [PATCH v4 00/11] capstone + disassembler patches
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
3d764d3 disas/capstone: Add skipdata hook for s390x
04c1cfa disas: Enable capstone disassembly for s390x
93a2da5 disas: Split out capstone code to disas/capstone.c
d29736e disas: Configure capstone for aarch64 host without libvixl
f283959 disas: Cleanup plugin_disas
b3a548e disas: Use qemu/bswap.h for bfd endian loads
1b6e185 disas: Clean up CPUDebug initialization
3b1f6f9 disas: Move host asm annotations to tb_gen_code
856507e capstone: Require version 4.0 from a system library
a714c28 capstone: Update to upstream "next" branch
823a3e2 capstone: Convert Makefile bits to meson bits
=== OUTPUT BEGIN ===
1/11 Checking commit 823a3e2a9f3c (capstone: Convert Makefile bits to meson bits)
2/11 Checking commit a714c28917da (capstone: Update to upstream "next" branch)
3/11 Checking commit 856507eedce4 (capstone: Require version 4.0 from a system library)
4/11 Checking commit 3b1f6f9ca3a0 (disas: Move host asm annotations to tb_gen_code)
5/11 Checking commit 1b6e185eee3e (disas: Clean up CPUDebug initialization)
WARNING: Block comments use a trailing */ on a separate line
#73: FILE: disas.c:48:
+ an error return from {host,target}_read_memory. */
ERROR: code indent should never use tabs
#91: FILE: disas.c:58:
+^I^I^I "Address 0x%" PRIx64 " is out of bounds.\n",$
WARNING: architecture specific defines should be avoided
#203: FILE: disas.c:479:
+#if defined(_ILP32) || (__riscv_xlen == 32)
total: 1 errors, 2 warnings, 490 lines checked
Patch 5/11 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/11 Checking commit b3a548e1996e (disas: Use qemu/bswap.h for bfd endian loads)
7/11 Checking commit f2839591e583 (disas: Cleanup plugin_disas)
8/11 Checking commit d29736e11366 (disas: Configure capstone for aarch64 host without libvixl)
9/11 Checking commit 93a2da58d997 (disas: Split out capstone code to disas/capstone.c)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#309:
new file mode 100644
total: 0 errors, 1 warnings, 604 lines checked
Patch 9/11 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/11 Checking commit 04c1cfa18ca8 (disas: Enable capstone disassembly for s390x)
11/11 Checking commit 3d764d3d1e7b (disas/capstone: Add skipdata hook for s390x)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20200921174118.39352-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
prev parent reply other threads:[~2020-09-22 0:51 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 17:41 [PATCH v4 00/11] capstone + disassembler patches Richard Henderson
2020-09-21 17:41 ` [PATCH v4 01/11] capstone: Convert Makefile bits to meson bits Richard Henderson
2020-09-21 19:17 ` Alex Bennée
2020-09-21 17:41 ` [PATCH v4 02/11] capstone: Update to upstream "next" branch Richard Henderson
2020-09-21 19:18 ` Alex Bennée
2020-09-21 17:41 ` [PATCH v4 03/11] capstone: Require version 4.0 from a system library Richard Henderson
2020-09-21 19:19 ` Alex Bennée
2020-09-22 10:33 ` Philippe Mathieu-Daudé
2020-09-21 17:41 ` [PATCH v4 04/11] disas: Move host asm annotations to tb_gen_code Richard Henderson
2020-09-21 19:29 ` Alex Bennée
2020-09-21 19:53 ` Richard Henderson
2020-09-22 8:26 ` Philippe Mathieu-Daudé
2020-09-22 9:50 ` Alex Bennée
2020-09-21 17:41 ` [PATCH v4 05/11] disas: Clean up CPUDebug initialization Richard Henderson
2020-09-21 19:32 ` Alex Bennée
2020-09-21 17:41 ` [PATCH v4 06/11] disas: Use qemu/bswap.h for bfd endian loads Richard Henderson
2020-09-21 19:33 ` Alex Bennée
2020-09-21 17:41 ` [PATCH v4 07/11] disas: Cleanup plugin_disas Richard Henderson
2020-09-22 10:38 ` Alex Bennée
2020-09-21 17:41 ` [PATCH v4 08/11] disas: Configure capstone for aarch64 host without libvixl Richard Henderson
2020-09-22 10:48 ` Alex Bennée
2020-09-21 17:41 ` [PATCH v4 09/11] disas: Split out capstone code to disas/capstone.c Richard Henderson
2020-09-22 10:50 ` Alex Bennée
2020-09-21 17:41 ` [PATCH v4 10/11] disas: Enable capstone disassembly for s390x Richard Henderson
2020-09-22 10:58 ` Alex Bennée
2020-09-21 17:41 ` [PATCH v4 11/11] disas/capstone: Add skipdata hook " Richard Henderson
2020-09-22 10:59 ` Alex Bennée
2020-09-22 0:50 ` no-reply [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160073584167.23987.5739705917333363444@66eaa9a8a123 \
--to=no-reply@patchew.org \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).