* [PATCH] vhost-user: fix incorrect print type
@ 2020-10-19 13:31 Zhengui li
2020-10-19 13:37 ` no-reply
0 siblings, 1 reply; 3+ messages in thread
From: Zhengui li @ 2020-10-19 13:31 UTC (permalink / raw)
To: pbonzini, stefanha, mreitz, kwolf
Cc: xieyingtai, lizhengui, qemu-devel, qemu-block
fix incorrect print type.
---
hw/virtio/vhost-user.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
index 9c5b4f7..db563bd 100644
--- a/hw/virtio/vhost-user.c
+++ b/hw/virtio/vhost-user.c
@@ -308,7 +308,7 @@ static int vhost_user_read(struct vhost_dev *dev, VhostUserMsg *msg)
/* validate message size is sane */
if (msg->hdr.size > VHOST_USER_PAYLOAD_SIZE) {
error_report("Failed to read msg header."
- " Size %d exceeds the maximum %zu.", msg->hdr.size,
+ " Size %u exceeds the maximum %zu.", msg->hdr.size,
VHOST_USER_PAYLOAD_SIZE);
return -1;
}
@@ -319,7 +319,7 @@ static int vhost_user_read(struct vhost_dev *dev, VhostUserMsg *msg)
r = qemu_chr_fe_read_all(chr, p, size);
if (r != size) {
error_report("Failed to read msg payload."
- " Read %d instead of %d.", r, msg->hdr.size);
+ " Read %d instead of %u.", r, msg->hdr.size);
return -1;
}
}
@@ -740,7 +740,7 @@ static int send_add_regions(struct vhost_dev *dev,
*/
if (msg_reply.hdr.size != msg->hdr.size) {
error_report("%s: Unexpected size for postcopy reply "
- "%d vs %d", __func__, msg_reply.hdr.size,
+ "%u vs %u", __func__, msg_reply.hdr.size,
msg->hdr.size);
return -1;
}
@@ -905,7 +905,7 @@ static int vhost_user_set_mem_table_postcopy(struct vhost_dev *dev,
*/
if (msg_reply.hdr.size != msg.hdr.size) {
error_report("%s: Unexpected size for postcopy reply "
- "%d vs %d", __func__, msg_reply.hdr.size,
+ "%u vs %u", __func__, msg_reply.hdr.size,
msg.hdr.size);
return -1;
}
@@ -1445,7 +1445,7 @@ static void slave_read(void *opaque)
if (hdr.size > VHOST_USER_PAYLOAD_SIZE) {
error_report("Failed to read msg header."
- " Size %d exceeds the maximum %zu.", hdr.size,
+ " Size %u exceeds the maximum %zu.", hdr.size,
VHOST_USER_PAYLOAD_SIZE);
goto err;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] vhost-user: fix incorrect print type
2020-10-19 13:31 [PATCH] vhost-user: fix incorrect print type Zhengui li
@ 2020-10-19 13:37 ` no-reply
0 siblings, 0 replies; 3+ messages in thread
From: no-reply @ 2020-10-19 13:37 UTC (permalink / raw)
To: lizhengui
Cc: kwolf, xieyingtai, lizhengui, qemu-block, qemu-devel, mreitz,
stefanha, pbonzini
Patchew URL: https://patchew.org/QEMU/1603114272-25004-1-git-send-email-lizhengui@huawei.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1603114272-25004-1-git-send-email-lizhengui@huawei.com
Subject: [PATCH] vhost-user: fix incorrect print type
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/1603114225-22628-1-git-send-email-lizhengui@huawei.com -> patchew/1603114225-22628-1-git-send-email-lizhengui@huawei.com
* [new tag] patchew/1603114272-25004-1-git-send-email-lizhengui@huawei.com -> patchew/1603114272-25004-1-git-send-email-lizhengui@huawei.com
Switched to a new branch 'test'
778c5c6 vhost-user: fix incorrect print type
=== OUTPUT BEGIN ===
ERROR: Missing Signed-off-by: line(s)
total: 1 errors, 0 warnings, 40 lines checked
Commit 778c5c6502be (vhost-user: fix incorrect print type) has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/1603114272-25004-1-git-send-email-lizhengui@huawei.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] vhost-user: fix incorrect print type
@ 2020-10-19 14:22 Zhengui li
0 siblings, 0 replies; 3+ messages in thread
From: Zhengui li @ 2020-10-19 14:22 UTC (permalink / raw)
To: pbonzini, stefanha, mreitz, kwolf
Cc: xieyingtai, lizhengui, qemu-devel, qemu-block
The type of input variable is unsigned int
while the printer type is int. So fix incorrect print type.
Signed-off-by: Zhengui li <lizhengui@huawei.com>
---
hw/virtio/vhost-user.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
index 9c5b4f7..db563bd 100644
--- a/hw/virtio/vhost-user.c
+++ b/hw/virtio/vhost-user.c
@@ -308,7 +308,7 @@ static int vhost_user_read(struct vhost_dev *dev, VhostUserMsg *msg)
/* validate message size is sane */
if (msg->hdr.size > VHOST_USER_PAYLOAD_SIZE) {
error_report("Failed to read msg header."
- " Size %d exceeds the maximum %zu.", msg->hdr.size,
+ " Size %u exceeds the maximum %zu.", msg->hdr.size,
VHOST_USER_PAYLOAD_SIZE);
return -1;
}
@@ -319,7 +319,7 @@ static int vhost_user_read(struct vhost_dev *dev, VhostUserMsg *msg)
r = qemu_chr_fe_read_all(chr, p, size);
if (r != size) {
error_report("Failed to read msg payload."
- " Read %d instead of %d.", r, msg->hdr.size);
+ " Read %d instead of %u.", r, msg->hdr.size);
return -1;
}
}
@@ -740,7 +740,7 @@ static int send_add_regions(struct vhost_dev *dev,
*/
if (msg_reply.hdr.size != msg->hdr.size) {
error_report("%s: Unexpected size for postcopy reply "
- "%d vs %d", __func__, msg_reply.hdr.size,
+ "%u vs %u", __func__, msg_reply.hdr.size,
msg->hdr.size);
return -1;
}
@@ -905,7 +905,7 @@ static int vhost_user_set_mem_table_postcopy(struct vhost_dev *dev,
*/
if (msg_reply.hdr.size != msg.hdr.size) {
error_report("%s: Unexpected size for postcopy reply "
- "%d vs %d", __func__, msg_reply.hdr.size,
+ "%u vs %u", __func__, msg_reply.hdr.size,
msg.hdr.size);
return -1;
}
@@ -1445,7 +1445,7 @@ static void slave_read(void *opaque)
if (hdr.size > VHOST_USER_PAYLOAD_SIZE) {
error_report("Failed to read msg header."
- " Size %d exceeds the maximum %zu.", hdr.size,
+ " Size %u exceeds the maximum %zu.", hdr.size,
VHOST_USER_PAYLOAD_SIZE);
goto err;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-19 14:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-19 13:31 [PATCH] vhost-user: fix incorrect print type Zhengui li
2020-10-19 13:37 ` no-reply
2020-10-19 14:22 Zhengui li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).