* [PATCH] vhost-user-scsi: fix incorrect print type
@ 2020-10-19 13:30 Zhengui li
2020-10-19 13:37 ` no-reply
0 siblings, 1 reply; 3+ messages in thread
From: Zhengui li @ 2020-10-19 13:30 UTC (permalink / raw)
To: pbonzini, stefanha, mreitz, kwolf
Cc: xieyingtai, lizhengui, qemu-devel, qemu-block
fix incorrect print type.
---
contrib/vhost-user-scsi/vhost-user-scsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/vhost-user-scsi/vhost-user-scsi.c b/contrib/vhost-user-scsi/vhost-user-scsi.c
index 3c91238..1527ffd 100644
--- a/contrib/vhost-user-scsi/vhost-user-scsi.c
+++ b/contrib/vhost-user-scsi/vhost-user-scsi.c
@@ -182,7 +182,7 @@ static int handle_cmd_sync(struct iscsi_context *ctx,
task->iovector_in.niov = in_len;
}
- g_debug("Sending iscsi cmd (cdb_len=%d, dir=%d, task=%p)",
+ g_debug("Sending iscsi cmd (cdb_len=%d, dir=%u, task=%p)",
cdb_len, dir, task);
if (!iscsi_scsi_command_sync(ctx, 0, task, NULL)) {
g_warning("Error serving SCSI command");
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] vhost-user-scsi: fix incorrect print type
2020-10-19 13:30 [PATCH] vhost-user-scsi: fix incorrect print type Zhengui li
@ 2020-10-19 13:37 ` no-reply
0 siblings, 0 replies; 3+ messages in thread
From: no-reply @ 2020-10-19 13:37 UTC (permalink / raw)
To: lizhengui
Cc: kwolf, xieyingtai, lizhengui, qemu-block, qemu-devel, mreitz,
stefanha, pbonzini
Patchew URL: https://patchew.org/QEMU/1603114225-22628-1-git-send-email-lizhengui@huawei.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1603114225-22628-1-git-send-email-lizhengui@huawei.com
Subject: [PATCH] vhost-user-scsi: fix incorrect print type
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
2de1f5c vhost-user-scsi: fix incorrect print type
=== OUTPUT BEGIN ===
ERROR: Missing Signed-off-by: line(s)
total: 1 errors, 0 warnings, 8 lines checked
Commit 2de1f5c5b85d (vhost-user-scsi: fix incorrect print type) has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/1603114225-22628-1-git-send-email-lizhengui@huawei.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] vhost-user-scsi: fix incorrect print type
@ 2020-10-19 14:22 Zhengui li
0 siblings, 0 replies; 3+ messages in thread
From: Zhengui li @ 2020-10-19 14:22 UTC (permalink / raw)
To: pbonzini, stefanha, mreitz, kwolf
Cc: xieyingtai, lizhengui, qemu-devel, qemu-block
The type of input variable is unsigned int
while the printer type is int. So fix incorrect print type.
Signed-off-by: Zhengui li <lizhengui@huawei.com>
---
contrib/vhost-user-scsi/vhost-user-scsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/vhost-user-scsi/vhost-user-scsi.c b/contrib/vhost-user-scsi/vhost-user-scsi.c
index 3c91238..1527ffd 100644
--- a/contrib/vhost-user-scsi/vhost-user-scsi.c
+++ b/contrib/vhost-user-scsi/vhost-user-scsi.c
@@ -182,7 +182,7 @@ static int handle_cmd_sync(struct iscsi_context *ctx,
task->iovector_in.niov = in_len;
}
- g_debug("Sending iscsi cmd (cdb_len=%d, dir=%d, task=%p)",
+ g_debug("Sending iscsi cmd (cdb_len=%d, dir=%u, task=%p)",
cdb_len, dir, task);
if (!iscsi_scsi_command_sync(ctx, 0, task, NULL)) {
g_warning("Error serving SCSI command");
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-19 14:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-19 13:30 [PATCH] vhost-user-scsi: fix incorrect print type Zhengui li
2020-10-19 13:37 ` no-reply
2020-10-19 14:22 Zhengui li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).