* [PATCH] vfio: fix incorrect print type
@ 2020-10-19 13:32 Zhengui li
2020-10-19 13:41 ` no-reply
2020-10-19 13:47 ` Alex Williamson
0 siblings, 2 replies; 4+ messages in thread
From: Zhengui li @ 2020-10-19 13:32 UTC (permalink / raw)
To: pbonzini, stefanha, mreitz, kwolf
Cc: xieyingtai, lizhengui, qemu-devel, qemu-block
fix incorrect print type.
---
hw/vfio/common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/vfio/common.c b/hw/vfio/common.c
index 13471ae..acc3356 100644
--- a/hw/vfio/common.c
+++ b/hw/vfio/common.c
@@ -203,7 +203,7 @@ void vfio_region_write(void *opaque, hwaddr addr,
buf.qword = cpu_to_le64(data);
break;
default:
- hw_error("vfio: unsupported write size, %d bytes", size);
+ hw_error("vfio: unsupported write size, %u bytes", size);
break;
}
@@ -260,7 +260,7 @@ uint64_t vfio_region_read(void *opaque,
data = le64_to_cpu(buf.qword);
break;
default:
- hw_error("vfio: unsupported read size, %d bytes", size);
+ hw_error("vfio: unsupported read size, %u bytes", size);
break;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] vfio: fix incorrect print type
2020-10-19 13:32 [PATCH] vfio: fix incorrect print type Zhengui li
@ 2020-10-19 13:41 ` no-reply
2020-10-19 13:47 ` Alex Williamson
1 sibling, 0 replies; 4+ messages in thread
From: no-reply @ 2020-10-19 13:41 UTC (permalink / raw)
To: lizhengui
Cc: kwolf, xieyingtai, lizhengui, qemu-block, qemu-devel, mreitz,
stefanha, pbonzini
Patchew URL: https://patchew.org/QEMU/1603114337-28056-1-git-send-email-lizhengui@huawei.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1603114337-28056-1-git-send-email-lizhengui@huawei.com
Subject: [PATCH] vfio: fix incorrect print type
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
ba2a9a9..000f5b8 master -> master
* [new tag] patchew/1603114337-28056-1-git-send-email-lizhengui@huawei.com -> patchew/1603114337-28056-1-git-send-email-lizhengui@huawei.com
Switched to a new branch 'test'
c84a69c vfio: fix incorrect print type
=== OUTPUT BEGIN ===
ERROR: Missing Signed-off-by: line(s)
total: 1 errors, 0 warnings, 16 lines checked
Commit c84a69c621bd (vfio: fix incorrect print type) has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/1603114337-28056-1-git-send-email-lizhengui@huawei.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] vfio: fix incorrect print type
2020-10-19 13:32 [PATCH] vfio: fix incorrect print type Zhengui li
2020-10-19 13:41 ` no-reply
@ 2020-10-19 13:47 ` Alex Williamson
1 sibling, 0 replies; 4+ messages in thread
From: Alex Williamson @ 2020-10-19 13:47 UTC (permalink / raw)
To: Zhengui li
Cc: kwolf, xieyingtai, qemu-block, qemu-devel, mreitz, stefanha, pbonzini
On Mon, 19 Oct 2020 13:32:17 +0000
Zhengui li <lizhengui@huawei.com> wrote:
> fix incorrect print type.
Why is it incorrect, describe your change. Patches must include a
Signed-off-by to adhere to the developer's certificate of origin.
Thanks,
Alex
> ---
> hw/vfio/common.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/vfio/common.c b/hw/vfio/common.c
> index 13471ae..acc3356 100644
> --- a/hw/vfio/common.c
> +++ b/hw/vfio/common.c
> @@ -203,7 +203,7 @@ void vfio_region_write(void *opaque, hwaddr addr,
> buf.qword = cpu_to_le64(data);
> break;
> default:
> - hw_error("vfio: unsupported write size, %d bytes", size);
> + hw_error("vfio: unsupported write size, %u bytes", size);
> break;
> }
>
> @@ -260,7 +260,7 @@ uint64_t vfio_region_read(void *opaque,
> data = le64_to_cpu(buf.qword);
> break;
> default:
> - hw_error("vfio: unsupported read size, %d bytes", size);
> + hw_error("vfio: unsupported read size, %u bytes", size);
> break;
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] vfio: fix incorrect print type
@ 2020-10-19 14:23 Zhengui li
0 siblings, 0 replies; 4+ messages in thread
From: Zhengui li @ 2020-10-19 14:23 UTC (permalink / raw)
To: pbonzini, stefanha, mreitz, kwolf
Cc: xieyingtai, lizhengui, qemu-devel, qemu-block
The type of input variable is unsigned int
while the printer type is int. So fix incorrect print type.
Signed-off-by: Zhengui li <lizhengui@huawei.com>
---
hw/vfio/common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/vfio/common.c b/hw/vfio/common.c
index 13471ae..acc3356 100644
--- a/hw/vfio/common.c
+++ b/hw/vfio/common.c
@@ -203,7 +203,7 @@ void vfio_region_write(void *opaque, hwaddr addr,
buf.qword = cpu_to_le64(data);
break;
default:
- hw_error("vfio: unsupported write size, %d bytes", size);
+ hw_error("vfio: unsupported write size, %u bytes", size);
break;
}
@@ -260,7 +260,7 @@ uint64_t vfio_region_read(void *opaque,
data = le64_to_cpu(buf.qword);
break;
default:
- hw_error("vfio: unsupported read size, %d bytes", size);
+ hw_error("vfio: unsupported read size, %u bytes", size);
break;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-19 14:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-19 13:32 [PATCH] vfio: fix incorrect print type Zhengui li
2020-10-19 13:41 ` no-reply
2020-10-19 13:47 ` Alex Williamson
2020-10-19 14:23 Zhengui li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).