* [PATCH] replay: remove some dead code
@ 2020-11-05 6:10 Pavel Dovgalyuk
2020-11-05 14:03 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Pavel Dovgalyuk @ 2020-11-05 6:10 UTC (permalink / raw)
To: qemu-devel; +Cc: alex.bennee, pbonzini, pavel.dovgalyuk, philmd
This patch removes dead code in replay_continue_stop() function.
Signed-off-by: Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru>
Reported-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
replay/replay-debugging.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/replay/replay-debugging.c b/replay/replay-debugging.c
index ee9e86daa9..1d6a968406 100644
--- a/replay/replay-debugging.c
+++ b/replay/replay-debugging.c
@@ -278,7 +278,6 @@ static void replay_continue_stop(void *opaque)
replay_continue_end();
}
replay_last_snapshot = replay_get_current_icount();
- return;
} else {
/* Seek to the very first step */
replay_seek(0, replay_stop_vm_debug, &err);
@@ -286,9 +285,7 @@ static void replay_continue_stop(void *opaque)
error_free(err);
replay_continue_end();
}
- return;
}
- replay_continue_end();
}
bool replay_reverse_continue(void)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] replay: remove some dead code
2020-11-05 6:10 [PATCH] replay: remove some dead code Pavel Dovgalyuk
@ 2020-11-05 14:03 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-11-05 14:03 UTC (permalink / raw)
To: Pavel Dovgalyuk, qemu-devel; +Cc: pbonzini, alex.bennee
On 11/5/20 7:10 AM, Pavel Dovgalyuk wrote:
> This patch removes dead code in replay_continue_stop() function.
>
> Signed-off-by: Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru>
> Reported-by: Philippe Mathieu-Daudé <philmd@redhat.com>
This is actually Coverity (CID 1433220).
Fixes: cda382594b7 ("gdbstub: add reverse continue support in replay mode")
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Thanks for the fix!
> ---
> replay/replay-debugging.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/replay/replay-debugging.c b/replay/replay-debugging.c
> index ee9e86daa9..1d6a968406 100644
> --- a/replay/replay-debugging.c
> +++ b/replay/replay-debugging.c
> @@ -278,7 +278,6 @@ static void replay_continue_stop(void *opaque)
> replay_continue_end();
> }
> replay_last_snapshot = replay_get_current_icount();
> - return;
> } else {
> /* Seek to the very first step */
> replay_seek(0, replay_stop_vm_debug, &err);
> @@ -286,9 +285,7 @@ static void replay_continue_stop(void *opaque)
> error_free(err);
> replay_continue_end();
> }
> - return;
> }
> - replay_continue_end();
> }
>
> bool replay_reverse_continue(void)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-05 14:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-05 6:10 [PATCH] replay: remove some dead code Pavel Dovgalyuk
2020-11-05 14:03 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).