qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: no-reply@patchew.org
To: richard.henderson@linaro.org
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH 0/2] target/arm: Fix unaligned mte checks
Date: Thu, 1 Apr 2021 22:45:45 -0700 (PDT)	[thread overview]
Message-ID: <161734234410.1406.5525591858338700008@72b6d80f974b> (raw)
In-Reply-To: <20210402053728.265173-1-richard.henderson@linaro.org>

Patchew URL: https://patchew.org/QEMU/20210402053728.265173-1-richard.henderson@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210402053728.265173-1-richard.henderson@linaro.org
Subject: [PATCH 0/2] target/arm: Fix unaligned mte checks

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   00084ba..415fa2f  master     -> master
 - [tag update]      patchew/20210401125808.89241-1-fanwentao.0130@bytedance.com -> patchew/20210401125808.89241-1-fanwentao.0130@bytedance.com
 * [new tag]         patchew/20210402053728.265173-1-richard.henderson@linaro.org -> patchew/20210402053728.265173-1-richard.henderson@linaro.org
Switched to a new branch 'test'
7730030 target/arm: Fix unaligned mte checks
ef1ac97 target/arm: Check PAGE_WRITE_ORG for MTE writeability

=== OUTPUT BEGIN ===
1/2 Checking commit ef1ac978a003 (target/arm: Check PAGE_WRITE_ORG for MTE writeability)
WARNING: line over 80 characters
#28: FILE: target/arm/mte_helper.c:86:
+    if (!(flags & (ptr_access == MMU_DATA_STORE ? PAGE_WRITE_ORG : PAGE_READ))) {

total: 0 errors, 1 warnings, 8 lines checked

Patch 1/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/2 Checking commit 77300300fa91 (target/arm: Fix unaligned mte checks)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
ERROR: spaces required around that '*' (ctx:WxV)
#407: FILE: target/arm/sve_helper.c:4438:
+               sve_ldst1_tlb_fn *tlb_fn)
                                 ^

ERROR: spaces required around that '*' (ctx:WxV)
#517: FILE: target/arm/sve_helper.c:5063:
+               sve_ldst1_tlb_fn *tlb_fn)
                                 ^

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#787: 
new file mode 100644

total: 2 errors, 1 warnings, 719 lines checked

Patch 2/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210402053728.265173-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

      parent reply	other threads:[~2021-04-02  5:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-02  5:37 [PATCH 0/2] target/arm: Fix unaligned mte checks Richard Henderson
2021-04-02  5:37 ` [PATCH 1/2] target/arm: Check PAGE_WRITE_ORG for MTE writeability Richard Henderson
2021-04-02  5:37 ` [PATCH 2/2] target/arm: Fix unaligned mte checks Richard Henderson
2021-04-02 15:43   ` Richard Henderson
2021-04-02 18:35   ` Peter Maydell
2021-04-02 18:44     ` Richard Henderson
2021-04-02  5:45 ` no-reply [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=161734234410.1406.5525591858338700008@72b6d80f974b \
    --to=no-reply@patchew.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).