From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org
Subject: [PATCH 0/2] target/arm: Fix unaligned mte checks
Date: Thu, 1 Apr 2021 22:37:26 -0700 [thread overview]
Message-ID: <20210402053728.265173-1-richard.henderson@linaro.org> (raw)
I was incorrectly assuming that only the first byte of an MTE access
is checked against the tags. But per the ARM, unaligned accesses are
pre-decomposed into single-byte accesses. So by the time we reach the
actual MTE check in the ARM pseudocode, all accesses are aligned.
There's probably more that could be simplified here, but I did try to
keep the patch small-ish.
r~
Richare Henderson (2):
target/arm: Check PAGE_WRITE_ORG for MTE writeability
target/arm: Fix unaligned mte checks
target/arm/helper-a64.h | 3 +-
target/arm/internals.h | 13 +--
target/arm/translate-a64.h | 2 +-
target/arm/mte_helper.c | 171 ++++++++++++------------------
target/arm/sve_helper.c | 96 ++++++-----------
target/arm/translate-a64.c | 52 ++++-----
target/arm/translate-sve.c | 9 +-
tests/tcg/aarch64/mte-5.c | 44 ++++++++
tests/tcg/aarch64/Makefile.target | 2 +-
9 files changed, 179 insertions(+), 213 deletions(-)
create mode 100644 tests/tcg/aarch64/mte-5.c
--
2.25.1
next reply other threads:[~2021-04-02 5:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 5:37 Richard Henderson [this message]
2021-04-02 5:37 ` [PATCH 1/2] target/arm: Check PAGE_WRITE_ORG for MTE writeability Richard Henderson
2021-04-02 5:37 ` [PATCH 2/2] target/arm: Fix unaligned mte checks Richard Henderson
2021-04-02 15:43 ` Richard Henderson
2021-04-02 18:35 ` Peter Maydell
2021-04-02 18:44 ` Richard Henderson
2021-04-02 5:45 ` [PATCH 0/2] " no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210402053728.265173-1-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).