qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: no-reply@patchew.org
To: valeriy.vdovin@virtuozzo.com
Cc: vsementsov@virtuozzo.com, ehabkost@redhat.com,
	richard.henderson@linaro.org, qemu-devel@nongnu.org,
	armbru@redhat.com, valeriy.vdovin@virtuozzo.com, den@openvz.org,
	pbonzini@redhat.com
Subject: Re: [PATCH v6] qapi: introduce 'query-cpu-model-cpuid' action
Date: Tue, 20 Apr 2021 09:42:48 -0700 (PDT)	[thread overview]
Message-ID: <161893696658.26703.7219930353671192082@72b6d80f974b> (raw)
In-Reply-To: <20210420161940.24306-1-valeriy.vdovin@virtuozzo.com>

Patchew URL: https://patchew.org/QEMU/20210420161940.24306-1-valeriy.vdovin@virtuozzo.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210420161940.24306-1-valeriy.vdovin@virtuozzo.com
Subject: [PATCH v6] qapi: introduce 'query-cpu-model-cpuid' action

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20210420161940.24306-1-valeriy.vdovin@virtuozzo.com -> patchew/20210420161940.24306-1-valeriy.vdovin@virtuozzo.com
Switched to a new branch 'test'
9ee1fb5 qapi: introduce 'query-cpu-model-cpuid' action

=== OUTPUT BEGIN ===
ERROR: suspect code indent for conditional statements (4, 6)
#393: FILE: target/i386/cpu.c:5298:
+    if (!ms || !ms->possible_cpus) {
+      error_setg(errp, "Nothing to report");

total: 1 errors, 0 warnings, 476 lines checked

Commit 9ee1fb5a3953 (qapi: introduce 'query-cpu-model-cpuid' action) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210420161940.24306-1-valeriy.vdovin@virtuozzo.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

  reply	other threads:[~2021-04-20 16:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-20 16:19 [PATCH v6] qapi: introduce 'query-cpu-model-cpuid' action Valeriy Vdovin
2021-04-20 16:42 ` no-reply [this message]
2021-04-20 17:00 ` Vladimir Sementsov-Ogievskiy
2021-04-20 17:09 ` Eduardo Habkost
2021-04-21 17:39   ` Valeriy Vdovin
2021-04-21 20:17     ` Eduardo Habkost
2021-04-22  9:02       ` Valeriy Vdovin
2021-04-23 20:32         ` Eduardo Habkost
2021-04-22  9:41       ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=161893696658.26703.7219930353671192082@72b6d80f974b \
    --to=no-reply@patchew.org \
    --cc=armbru@redhat.com \
    --cc=den@openvz.org \
    --cc=ehabkost@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=valeriy.vdovin@virtuozzo.com \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).