QEMU-Devel Archive on lore.kernel.org
 help / color / Atom feed
* [Qemu-devel] [Bug 603872] [NEW] [Feature request] qemu-img image conversion does not show percentage
@ 2010-07-10  6:45 Коренберг Марк
  2013-05-28 13:35 ` [Qemu-devel] [Bug 603872] " Sven Dowideit
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Коренберг Марк @ 2010-07-10  6:45 UTC (permalink / raw)
  To: qemu-devel

Public bug reported:

It will be nice if qemu-img will be able to show percentage of
completition and average speed of conversion and compress ratio (if
converting to compressed qcow or qcow2)

** Affects: qemu
     Importance: Undecided
         Status: New

** Summary changed:

- [Feature reqauest] qemu-img image conversion percentage
+ [Feature request] qemu-img image conversion does not show percentage

-- 
[Feature request] qemu-img image conversion does not show percentage
https://bugs.launchpad.net/bugs/603872
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.

Status in QEMU: New

Bug description:
It will be nice if qemu-img will be able to show percentage of completition and average speed of conversion and compress ratio (if converting to compressed qcow or qcow2)

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Qemu-devel] [Bug 603872] Re: [Feature request] qemu-img image conversion does not show percentage
  2010-07-10  6:45 [Qemu-devel] [Bug 603872] [NEW] [Feature request] qemu-img image conversion does not show percentage Коренберг Марк
@ 2013-05-28 13:35 ` Sven Dowideit
  2013-11-18 15:55 ` Varad
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 6+ messages in thread
From: Sven Dowideit @ 2013-05-28 13:35 UTC (permalink / raw)
  To: qemu-devel

qemu-img convert -p does show a percentage completion (but not avg speed
or compression ratio) so this is at least partially done.

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/603872

Title:
  [Feature request] qemu-img image conversion does not show percentage

Status in QEMU:
  New

Bug description:
  It will be nice if qemu-img will be able to show percentage of
  completition and average speed of conversion and compress ratio (if
  converting to compressed qcow or qcow2)

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/603872/+subscriptions

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Qemu-devel] [Bug 603872] Re: [Feature request] qemu-img image conversion does not show percentage
  2010-07-10  6:45 [Qemu-devel] [Bug 603872] [NEW] [Feature request] qemu-img image conversion does not show percentage Коренберг Марк
  2013-05-28 13:35 ` [Qemu-devel] [Bug 603872] " Sven Dowideit
@ 2013-11-18 15:55 ` Varad
  2013-11-19  9:12   ` Stefan Hajnoczi
  2016-11-09 20:24 ` Thomas Huth
  2021-04-21  4:25 ` Thomas Huth
  3 siblings, 1 reply; 6+ messages in thread
From: Varad @ 2013-11-18 15:55 UTC (permalink / raw)
  To: qemu-devel

Incomplete patch.

Usecase: `qemu-img convert` with -p now shows the write speed.

1. I'm calculating the speed using the time taken to run the for(;;)
at qemu-img.c:1477. I figured that every time this loop runs, n1
sectors are converted, and so I calculate the write_speed
accordingly. Is this correct?

2. I have changed qemu-progress.c:qemu_progress_print() to take in a
speed parameter, thinking that it would be the best option. Should I
do it some other way instead (maybe write another function to print
just speed)?

** Patch added: "[PATCH/RFC]"
   https://bugs.launchpad.net/qemu/+bug/603872/+attachment/3911803/+files/0001-qemu-img-show-image-conversion-speed.patch

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/603872

Title:
  [Feature request] qemu-img image conversion does not show percentage

Status in QEMU:
  New

Bug description:
  It will be nice if qemu-img will be able to show percentage of
  completition and average speed of conversion and compress ratio (if
  converting to compressed qcow or qcow2)

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/603872/+subscriptions

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Qemu-devel] [Bug 603872] Re: [Feature request] qemu-img image conversion does not show percentage
  2013-11-18 15:55 ` Varad
@ 2013-11-19  9:12   ` Stefan Hajnoczi
  0 siblings, 0 replies; 6+ messages in thread
From: Stefan Hajnoczi @ 2013-11-19  9:12 UTC (permalink / raw)
  To: Bug 603872; +Cc: qemu-devel

On Mon, Nov 18, 2013 at 03:55:45PM -0000, Varad wrote:
> Incomplete patch.
> 
> Usecase: `qemu-img convert` with -p now shows the write speed.
> 
> 1. I'm calculating the speed using the time taken to run the for(;;)
> at qemu-img.c:1477. I figured that every time this loop runs, n1
> sectors are converted, and so I calculate the write_speed
> accordingly. Is this correct?
> 
> 2. I have changed qemu-progress.c:qemu_progress_print() to take in a
> speed parameter, thinking that it would be the best option. Should I
> do it some other way instead (maybe write another function to print
> just speed)?
> 
> ** Patch added: "[PATCH/RFC]"
>    https://bugs.launchpad.net/qemu/+bug/603872/+attachment/3911803/+files/0001-qemu-img-show-image-conversion-speed.patch

Patches attached on the bug tracker are not reviewed, they should be
sent to the qemu-devel mailing list instead.

If you want to link to a submitted patch from launchpad, please post a
mailing list archive link.  For example:
http://article.gmane.org/gmane.comp.emulators.qemu/242109

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Qemu-devel] [Bug 603872] Re: [Feature request] qemu-img image conversion does not show percentage
  2010-07-10  6:45 [Qemu-devel] [Bug 603872] [NEW] [Feature request] qemu-img image conversion does not show percentage Коренберг Марк
  2013-05-28 13:35 ` [Qemu-devel] [Bug 603872] " Sven Dowideit
  2013-11-18 15:55 ` Varad
@ 2016-11-09 20:24 ` Thomas Huth
  2021-04-21  4:25 ` Thomas Huth
  3 siblings, 0 replies; 6+ messages in thread
From: Thomas Huth @ 2016-11-09 20:24 UTC (permalink / raw)
  To: qemu-devel

** Changed in: qemu
   Importance: Undecided => Wishlist

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/603872

Title:
  [Feature request] qemu-img image conversion does not show percentage

Status in QEMU:
  New

Bug description:
  It will be nice if qemu-img will be able to show percentage of
  completition and average speed of conversion and compress ratio (if
  converting to compressed qcow or qcow2)

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/603872/+subscriptions

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug 603872] Re: [Feature request] qemu-img image conversion does not show percentage
  2010-07-10  6:45 [Qemu-devel] [Bug 603872] [NEW] [Feature request] qemu-img image conversion does not show percentage Коренберг Марк
                   ` (2 preceding siblings ...)
  2016-11-09 20:24 ` Thomas Huth
@ 2021-04-21  4:25 ` Thomas Huth
  3 siblings, 0 replies; 6+ messages in thread
From: Thomas Huth @ 2021-04-21  4:25 UTC (permalink / raw)
  To: qemu-devel

Progress printing had been added here:
https://gitlab.com/qemu-project/qemu/-/commit/6b837bc4a4d
So I think it should be fine to close this ticket now.

** Changed in: qemu
       Status: New => Fix Released

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/603872

Title:
  [Feature request] qemu-img image conversion does not show percentage

Status in QEMU:
  Fix Released

Bug description:
  It will be nice if qemu-img will be able to show percentage of
  completition and average speed of conversion and compress ratio (if
  converting to compressed qcow or qcow2)

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/603872/+subscriptions


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-07-10  6:45 [Qemu-devel] [Bug 603872] [NEW] [Feature request] qemu-img image conversion does not show percentage Коренберг Марк
2013-05-28 13:35 ` [Qemu-devel] [Bug 603872] " Sven Dowideit
2013-11-18 15:55 ` Varad
2013-11-19  9:12   ` Stefan Hajnoczi
2016-11-09 20:24 ` Thomas Huth
2021-04-21  4:25 ` Thomas Huth

QEMU-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/qemu-devel/0 qemu-devel/git/0.git
	git clone --mirror https://lore.kernel.org/qemu-devel/1 qemu-devel/git/1.git
	git clone --mirror https://lore.kernel.org/qemu-devel/2 qemu-devel/git/2.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 qemu-devel qemu-devel/ https://lore.kernel.org/qemu-devel \
		qemu-devel@nongnu.org
	public-inbox-index qemu-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.nongnu.qemu-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git