qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [Bug 1828608] [NEW] Chardev websocket might not support pasting more than a few chars
@ 2019-05-10 16:24 Anisse Astier
  2019-05-10 16:28 ` [Qemu-devel] [Bug 1828608] " Daniel Berrange
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Anisse Astier @ 2019-05-10 16:24 UTC (permalink / raw)
  To: qemu-devel

Public bug reported:

When sending more than 4-5 characters on the websocket serial console
(with pasting for example), the guest might not receive all of them, or
worse interpret the input as Magic SysRq keys.

This might be due to the io loop not checking the backend readiness
before calling the read function.

Attached patched fixes the problem on my system. I'm not sure it's the
proper approach, this is just to start discussion.

** Affects: qemu
     Importance: Undecided
         Status: New

** Patch added: "0001-socket-check-char-backend-readiness-before-sending-i.patch"
   https://bugs.launchpad.net/bugs/1828608/+attachment/5262964/+files/0001-socket-check-char-backend-readiness-before-sending-i.patch

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1828608

Title:
  Chardev websocket might not support pasting more than a few chars

Status in QEMU:
  New

Bug description:
  When sending more than 4-5 characters on the websocket serial console
  (with pasting for example), the guest might not receive all of them,
  or worse interpret the input as Magic SysRq keys.

  This might be due to the io loop not checking the backend readiness
  before calling the read function.

  Attached patched fixes the problem on my system. I'm not sure it's the
  proper approach, this is just to start discussion.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1828608/+subscriptions


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Qemu-devel] [Bug 1828608] Re: Chardev websocket might not support pasting more than a few chars
  2019-05-10 16:24 [Qemu-devel] [Bug 1828608] [NEW] Chardev websocket might not support pasting more than a few chars Anisse Astier
@ 2019-05-10 16:28 ` Daniel Berrange
  2019-05-13  8:16 ` Anisse Astier
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Daniel Berrange @ 2019-05-10 16:28 UTC (permalink / raw)
  To: qemu-devel

If the problem only happens with a websockets channel enabled, it
possibly a bug in the QIOChannelWebsock impl rather than the chardev

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1828608

Title:
  Chardev websocket might not support pasting more than a few chars

Status in QEMU:
  New

Bug description:
  When sending more than 4-5 characters on the websocket serial console
  (with pasting for example), the guest might not receive all of them,
  or worse interpret the input as Magic SysRq keys.

  This might be due to the io loop not checking the backend readiness
  before calling the read function.

  Attached patched fixes the problem on my system. I'm not sure it's the
  proper approach, this is just to start discussion.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1828608/+subscriptions


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Qemu-devel] [Bug 1828608] Re: Chardev websocket might not support pasting more than a few chars
  2019-05-10 16:24 [Qemu-devel] [Bug 1828608] [NEW] Chardev websocket might not support pasting more than a few chars Anisse Astier
  2019-05-10 16:28 ` [Qemu-devel] [Bug 1828608] " Daniel Berrange
@ 2019-05-13  8:16 ` Anisse Astier
  2021-04-22  6:14 ` Thomas Huth
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Anisse Astier @ 2019-05-13  8:16 UTC (permalink / raw)
  To: qemu-devel

I wrote a websocket client to help reproduce the bug without a browser:
https://github.com/anisse/websocktty

You can install it to your $GOPATH/bin (defaults to ~/go/bin) with "go
get github.com/anisse/websocktty"

I can reproduce the bug with it by simply pasting a long-enough (5 to 20
characters) string.

I could not reproduce the bug with qemu's  "-serial tcp" and netcat, so
this problem might indeed be limited to the websock channel
implementation.

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1828608

Title:
  Chardev websocket might not support pasting more than a few chars

Status in QEMU:
  New

Bug description:
  When sending more than 4-5 characters on the websocket serial console
  (with pasting for example), the guest might not receive all of them,
  or worse interpret the input as Magic SysRq keys.

  This might be due to the io loop not checking the backend readiness
  before calling the read function.

  Attached patched fixes the problem on my system. I'm not sure it's the
  proper approach, this is just to start discussion.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1828608/+subscriptions


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug 1828608] Re: Chardev websocket might not support pasting more than a few chars
  2019-05-10 16:24 [Qemu-devel] [Bug 1828608] [NEW] Chardev websocket might not support pasting more than a few chars Anisse Astier
  2019-05-10 16:28 ` [Qemu-devel] [Bug 1828608] " Daniel Berrange
  2019-05-13  8:16 ` Anisse Astier
@ 2021-04-22  6:14 ` Thomas Huth
  2021-04-30 14:51 ` Anisse Astier
  2021-05-04 19:34 ` Thomas Huth
  4 siblings, 0 replies; 6+ messages in thread
From: Thomas Huth @ 2021-04-22  6:14 UTC (permalink / raw)
  To: qemu-devel

The QEMU project is currently considering to move its bug tracking to
another system. For this we need to know which bugs are still valid
and which could be closed already. Thus we are setting older bugs to
"Incomplete" now.

If you still think this bug report here is valid, then please switch
the state back to "New" within the next 60 days, otherwise this report
will be marked as "Expired". Or please mark it as "Fix Released" if
the problem has been solved with a newer version of QEMU already.

Thank you and sorry for the inconvenience.

** Changed in: qemu
       Status: New => Incomplete

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1828608

Title:
  Chardev websocket might not support pasting more than a few chars

Status in QEMU:
  Incomplete

Bug description:
  When sending more than 4-5 characters on the websocket serial console
  (with pasting for example), the guest might not receive all of them,
  or worse interpret the input as Magic SysRq keys.

  This might be due to the io loop not checking the backend readiness
  before calling the read function.

  Attached patched fixes the problem on my system. I'm not sure it's the
  proper approach, this is just to start discussion.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1828608/+subscriptions


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug 1828608] Re: Chardev websocket might not support pasting more than a few chars
  2019-05-10 16:24 [Qemu-devel] [Bug 1828608] [NEW] Chardev websocket might not support pasting more than a few chars Anisse Astier
                   ` (2 preceding siblings ...)
  2021-04-22  6:14 ` Thomas Huth
@ 2021-04-30 14:51 ` Anisse Astier
  2021-05-04 19:34 ` Thomas Huth
  4 siblings, 0 replies; 6+ messages in thread
From: Anisse Astier @ 2021-04-30 14:51 UTC (permalink / raw)
  To: qemu-devel

The bug is still present.

** Changed in: qemu
       Status: Incomplete => New

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1828608

Title:
  Chardev websocket might not support pasting more than a few chars

Status in QEMU:
  New

Bug description:
  When sending more than 4-5 characters on the websocket serial console
  (with pasting for example), the guest might not receive all of them,
  or worse interpret the input as Magic SysRq keys.

  This might be due to the io loop not checking the backend readiness
  before calling the read function.

  Attached patched fixes the problem on my system. I'm not sure it's the
  proper approach, this is just to start discussion.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1828608/+subscriptions


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug 1828608] Re: Chardev websocket might not support pasting more than a few chars
  2019-05-10 16:24 [Qemu-devel] [Bug 1828608] [NEW] Chardev websocket might not support pasting more than a few chars Anisse Astier
                   ` (3 preceding siblings ...)
  2021-04-30 14:51 ` Anisse Astier
@ 2021-05-04 19:34 ` Thomas Huth
  4 siblings, 0 replies; 6+ messages in thread
From: Thomas Huth @ 2021-05-04 19:34 UTC (permalink / raw)
  To: qemu-devel

This is an automated cleanup. This bug report has been moved to QEMU's
new bug tracker on gitlab.com and thus gets marked as 'expired' now.
Please continue with the discussion here:

 https://gitlab.com/qemu-project/qemu/-/issues/133


** Changed in: qemu
       Status: New => Expired

** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #133
   https://gitlab.com/qemu-project/qemu/-/issues/133

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1828608

Title:
  Chardev websocket might not support pasting more than a few chars

Status in QEMU:
  Expired

Bug description:
  When sending more than 4-5 characters on the websocket serial console
  (with pasting for example), the guest might not receive all of them,
  or worse interpret the input as Magic SysRq keys.

  This might be due to the io loop not checking the backend readiness
  before calling the read function.

  Attached patched fixes the problem on my system. I'm not sure it's the
  proper approach, this is just to start discussion.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1828608/+subscriptions


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-05-04 19:42 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-10 16:24 [Qemu-devel] [Bug 1828608] [NEW] Chardev websocket might not support pasting more than a few chars Anisse Astier
2019-05-10 16:28 ` [Qemu-devel] [Bug 1828608] " Daniel Berrange
2019-05-13  8:16 ` Anisse Astier
2021-04-22  6:14 ` Thomas Huth
2021-04-30 14:51 ` Anisse Astier
2021-05-04 19:34 ` Thomas Huth

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).