* [Qemu-devel] [Bug 1843711] [NEW] qemu-xhci device should detect if libusb host supports streams
@ 2019-09-12 12:51 Anisse Astier
2021-04-22 7:32 ` [Bug 1843711] " Thomas Huth
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Anisse Astier @ 2019-09-12 12:51 UTC (permalink / raw)
To: qemu-devel
Public bug reported:
When using USB passthrough with the qemu-xhci (and nec-usb-xhci),
streams are enabled by default, but if the host xHCI controller doesn't
support them, it will trigger hard-to-debug UAS guest errors.
This should be possible to detect since the kernel returns ENOSYS (errno 38) when xhci host controller does not support streams:
libusb: error [do_streams_ioctl] streams-ioctl failed error -1 errno 38
qemu: libusb_alloc_streams: -99 [OTHER]
Maybe libusb should return a dedicated error instead of
LIBUSB_ERROR_OTHER in this case, but qemu does not handle any other
error code anyway.
Just trying to enable streams before enabling them in qemu should do it.
I don't know if it should be done in hcd-xhci.c, host-libusb.c or
elsewhere, but this would be detectable at launch instead of a static
option true/false, maybe a ternary with auto would be better.
** Affects: qemu
Importance: Undecided
Status: New
** Tags: feature-request
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1843711
Title:
qemu-xhci device should detect if libusb host supports streams
Status in QEMU:
New
Bug description:
When using USB passthrough with the qemu-xhci (and nec-usb-xhci),
streams are enabled by default, but if the host xHCI controller
doesn't support them, it will trigger hard-to-debug UAS guest errors.
This should be possible to detect since the kernel returns ENOSYS (errno 38) when xhci host controller does not support streams:
libusb: error [do_streams_ioctl] streams-ioctl failed error -1 errno 38
qemu: libusb_alloc_streams: -99 [OTHER]
Maybe libusb should return a dedicated error instead of
LIBUSB_ERROR_OTHER in this case, but qemu does not handle any other
error code anyway.
Just trying to enable streams before enabling them in qemu should do
it. I don't know if it should be done in hcd-xhci.c, host-libusb.c or
elsewhere, but this would be detectable at launch instead of a static
option true/false, maybe a ternary with auto would be better.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1843711/+subscriptions
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug 1843711] Re: qemu-xhci device should detect if libusb host supports streams
2019-09-12 12:51 [Qemu-devel] [Bug 1843711] [NEW] qemu-xhci device should detect if libusb host supports streams Anisse Astier
@ 2021-04-22 7:32 ` Thomas Huth
2021-04-30 14:51 ` Anisse Astier
2021-05-05 14:28 ` Thomas Huth
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Huth @ 2021-04-22 7:32 UTC (permalink / raw)
To: qemu-devel
The QEMU project is currently considering to move its bug tracking to
another system. For this we need to know which bugs are still valid
and which could be closed already. Thus we are setting older bugs to
"Incomplete" now.
If you still think this bug report here is valid, then please switch
the state back to "New" within the next 60 days, otherwise this report
will be marked as "Expired". Or please mark it as "Fix Released" if
the problem has been solved with a newer version of QEMU already.
Thank you and sorry for the inconvenience.
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1843711
Title:
qemu-xhci device should detect if libusb host supports streams
Status in QEMU:
Incomplete
Bug description:
When using USB passthrough with the qemu-xhci (and nec-usb-xhci),
streams are enabled by default, but if the host xHCI controller
doesn't support them, it will trigger hard-to-debug UAS guest errors.
This should be possible to detect since the kernel returns ENOSYS (errno 38) when xhci host controller does not support streams:
libusb: error [do_streams_ioctl] streams-ioctl failed error -1 errno 38
qemu: libusb_alloc_streams: -99 [OTHER]
Maybe libusb should return a dedicated error instead of
LIBUSB_ERROR_OTHER in this case, but qemu does not handle any other
error code anyway.
Just trying to enable streams before enabling them in qemu should do
it. I don't know if it should be done in hcd-xhci.c, host-libusb.c or
elsewhere, but this would be detectable at launch instead of a static
option true/false, maybe a ternary with auto would be better.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1843711/+subscriptions
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug 1843711] Re: qemu-xhci device should detect if libusb host supports streams
2019-09-12 12:51 [Qemu-devel] [Bug 1843711] [NEW] qemu-xhci device should detect if libusb host supports streams Anisse Astier
2021-04-22 7:32 ` [Bug 1843711] " Thomas Huth
@ 2021-04-30 14:51 ` Anisse Astier
2021-05-05 14:28 ` Thomas Huth
2 siblings, 0 replies; 4+ messages in thread
From: Anisse Astier @ 2021-04-30 14:51 UTC (permalink / raw)
To: qemu-devel
This is a suggestion that would really help anyone using trying to use
xhci passthrough on a platform without streams.
** Changed in: qemu
Status: Incomplete => New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1843711
Title:
qemu-xhci device should detect if libusb host supports streams
Status in QEMU:
New
Bug description:
When using USB passthrough with the qemu-xhci (and nec-usb-xhci),
streams are enabled by default, but if the host xHCI controller
doesn't support them, it will trigger hard-to-debug UAS guest errors.
This should be possible to detect since the kernel returns ENOSYS (errno 38) when xhci host controller does not support streams:
libusb: error [do_streams_ioctl] streams-ioctl failed error -1 errno 38
qemu: libusb_alloc_streams: -99 [OTHER]
Maybe libusb should return a dedicated error instead of
LIBUSB_ERROR_OTHER in this case, but qemu does not handle any other
error code anyway.
Just trying to enable streams before enabling them in qemu should do
it. I don't know if it should be done in hcd-xhci.c, host-libusb.c or
elsewhere, but this would be detectable at launch instead of a static
option true/false, maybe a ternary with auto would be better.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1843711/+subscriptions
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug 1843711] Re: qemu-xhci device should detect if libusb host supports streams
2019-09-12 12:51 [Qemu-devel] [Bug 1843711] [NEW] qemu-xhci device should detect if libusb host supports streams Anisse Astier
2021-04-22 7:32 ` [Bug 1843711] " Thomas Huth
2021-04-30 14:51 ` Anisse Astier
@ 2021-05-05 14:28 ` Thomas Huth
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Huth @ 2021-05-05 14:28 UTC (permalink / raw)
To: qemu-devel
This is an automated cleanup. This bug report has been moved to QEMU's
new bug tracker on gitlab.com and thus gets marked as 'expired' now.
Please continue with the discussion here:
https://gitlab.com/qemu-project/qemu/-/issues/182
** Changed in: qemu
Status: New => Expired
** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #182
https://gitlab.com/qemu-project/qemu/-/issues/182
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1843711
Title:
qemu-xhci device should detect if libusb host supports streams
Status in QEMU:
Expired
Bug description:
When using USB passthrough with the qemu-xhci (and nec-usb-xhci),
streams are enabled by default, but if the host xHCI controller
doesn't support them, it will trigger hard-to-debug UAS guest errors.
This should be possible to detect since the kernel returns ENOSYS (errno 38) when xhci host controller does not support streams:
libusb: error [do_streams_ioctl] streams-ioctl failed error -1 errno 38
qemu: libusb_alloc_streams: -99 [OTHER]
Maybe libusb should return a dedicated error instead of
LIBUSB_ERROR_OTHER in this case, but qemu does not handle any other
error code anyway.
Just trying to enable streams before enabling them in qemu should do
it. I don't know if it should be done in hcd-xhci.c, host-libusb.c or
elsewhere, but this would be detectable at launch instead of a static
option true/false, maybe a ternary with auto would be better.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1843711/+subscriptions
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-05 14:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-12 12:51 [Qemu-devel] [Bug 1843711] [NEW] qemu-xhci device should detect if libusb host supports streams Anisse Astier
2021-04-22 7:32 ` [Bug 1843711] " Thomas Huth
2021-04-30 14:51 ` Anisse Astier
2021-05-05 14:28 ` Thomas Huth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).