* [Qemu-devel] [PATCH] dimm: Correct type of MemoryHotplugState->base
@ 2016-01-21 1:37 David Gibson
2016-01-22 10:02 ` Igor Mammedov
0 siblings, 1 reply; 8+ messages in thread
From: David Gibson @ 2016-01-21 1:37 UTC (permalink / raw)
To: imammedo, pbonzini, ehabkost; +Cc: David Gibson, qemu-ppc, qemu-devel, bharata
The 'base' field of MemoryHotplugState is ram_addr_t, which indicates that
it exists in the abstract address space of RAM regions.
However, the actual usage of this field indicates that it is a concrete
physical address (it's passed as an offset to memory_region_add_subgregion
for example).
So, correct its type to 'hwaddr'.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
include/hw/mem/pc-dimm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/hw/mem/pc-dimm.h b/include/hw/mem/pc-dimm.h
index d83bf30..218dfb0 100644
--- a/include/hw/mem/pc-dimm.h
+++ b/include/hw/mem/pc-dimm.h
@@ -77,7 +77,7 @@ typedef struct PCDIMMDeviceClass {
* @mr: hotplug memory address space container
*/
typedef struct MemoryHotplugState {
- ram_addr_t base;
+ hwaddr base;
MemoryRegion mr;
} MemoryHotplugState;
--
2.5.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] dimm: Correct type of MemoryHotplugState->base
2016-01-21 1:37 [Qemu-devel] [PATCH] dimm: Correct type of MemoryHotplugState->base David Gibson
@ 2016-01-22 10:02 ` Igor Mammedov
2016-01-22 14:21 ` Paolo Bonzini
0 siblings, 1 reply; 8+ messages in thread
From: Igor Mammedov @ 2016-01-22 10:02 UTC (permalink / raw)
To: David Gibson; +Cc: qemu-devel, pbonzini, qemu-ppc, ehabkost, bharata
On Thu, 21 Jan 2016 12:37:51 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:
> The 'base' field of MemoryHotplugState is ram_addr_t, which indicates that
> it exists in the abstract address space of RAM regions.
>
> However, the actual usage of this field indicates that it is a concrete
> physical address (it's passed as an offset to memory_region_add_subgregion
> for example).
>
> So, correct its type to 'hwaddr'.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> include/hw/mem/pc-dimm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/mem/pc-dimm.h b/include/hw/mem/pc-dimm.h
> index d83bf30..218dfb0 100644
> --- a/include/hw/mem/pc-dimm.h
> +++ b/include/hw/mem/pc-dimm.h
> @@ -77,7 +77,7 @@ typedef struct PCDIMMDeviceClass {
> * @mr: hotplug memory address space container
> */
> typedef struct MemoryHotplugState {
> - ram_addr_t base;
> + hwaddr base;
> MemoryRegion mr;
> } MemoryHotplugState;
>
I agree with this fix but that's not the only place where
ram_addr_t needs to be replaced with hwaddr.
For example type of MachineState.[max]ram_size fields needs
to be changed as well. Because QEMU builds without CONFIG_XEN_BACKEND
on 32-bit hosts are broken since ram_addr_t is 32-bits there
while some targets assume and use it as 64-bit one.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] dimm: Correct type of MemoryHotplugState->base
2016-01-22 10:02 ` Igor Mammedov
@ 2016-01-22 14:21 ` Paolo Bonzini
2016-01-22 14:32 ` Igor Mammedov
0 siblings, 1 reply; 8+ messages in thread
From: Paolo Bonzini @ 2016-01-22 14:21 UTC (permalink / raw)
To: Igor Mammedov, David Gibson; +Cc: qemu-devel, qemu-ppc, ehabkost, bharata
On 22/01/2016 11:02, Igor Mammedov wrote:
> On Thu, 21 Jan 2016 12:37:51 +1100
> David Gibson <david@gibson.dropbear.id.au> wrote:
>
>> The 'base' field of MemoryHotplugState is ram_addr_t, which indicates that
>> it exists in the abstract address space of RAM regions.
>>
>> However, the actual usage of this field indicates that it is a concrete
>> physical address (it's passed as an offset to memory_region_add_subgregion
>> for example).
>>
>> So, correct its type to 'hwaddr'.
>>
>> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
>> ---
>> include/hw/mem/pc-dimm.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/hw/mem/pc-dimm.h b/include/hw/mem/pc-dimm.h
>> index d83bf30..218dfb0 100644
>> --- a/include/hw/mem/pc-dimm.h
>> +++ b/include/hw/mem/pc-dimm.h
>> @@ -77,7 +77,7 @@ typedef struct PCDIMMDeviceClass {
>> * @mr: hotplug memory address space container
>> */
>> typedef struct MemoryHotplugState {
>> - ram_addr_t base;
>> + hwaddr base;
>> MemoryRegion mr;
>> } MemoryHotplugState;
>>
>
> I agree with this fix but that's not the only place where
> ram_addr_t needs to be replaced with hwaddr.
> For example type of MachineState.[max]ram_size fields needs
> to be changed as well. Because QEMU builds without CONFIG_XEN_BACKEND
> on 32-bit hosts are broken since ram_addr_t is 32-bits there
> while some targets assume and use it as 64-bit one.
But on a 32-bit system without CONFIG_XEN_BACKEND you cannot allocate
more than 4G anyway, so the choice of ram_addr_t is understandable in
that case.
On the other hand, on a 32-bit system without CONFIG_XEN_BACKEND you
definitely can place 128M of hot plugged memory between say 4096MB and
4224MB.
Paolo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] dimm: Correct type of MemoryHotplugState->base
2016-01-22 14:21 ` Paolo Bonzini
@ 2016-01-22 14:32 ` Igor Mammedov
2016-02-01 2:33 ` David Gibson
0 siblings, 1 reply; 8+ messages in thread
From: Igor Mammedov @ 2016-01-22 14:32 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: bharata, qemu-ppc, qemu-devel, ehabkost, David Gibson
On Fri, 22 Jan 2016 15:21:05 +0100
Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 22/01/2016 11:02, Igor Mammedov wrote:
> > On Thu, 21 Jan 2016 12:37:51 +1100
> > David Gibson <david@gibson.dropbear.id.au> wrote:
> >
> >> The 'base' field of MemoryHotplugState is ram_addr_t, which indicates that
> >> it exists in the abstract address space of RAM regions.
> >>
> >> However, the actual usage of this field indicates that it is a concrete
> >> physical address (it's passed as an offset to memory_region_add_subgregion
> >> for example).
> >>
> >> So, correct its type to 'hwaddr'.
> >>
> >> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> >> ---
> >> include/hw/mem/pc-dimm.h | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/include/hw/mem/pc-dimm.h b/include/hw/mem/pc-dimm.h
> >> index d83bf30..218dfb0 100644
> >> --- a/include/hw/mem/pc-dimm.h
> >> +++ b/include/hw/mem/pc-dimm.h
> >> @@ -77,7 +77,7 @@ typedef struct PCDIMMDeviceClass {
> >> * @mr: hotplug memory address space container
> >> */
> >> typedef struct MemoryHotplugState {
> >> - ram_addr_t base;
> >> + hwaddr base;
> >> MemoryRegion mr;
> >> } MemoryHotplugState;
> >>
> >
> > I agree with this fix but that's not the only place where
> > ram_addr_t needs to be replaced with hwaddr.
> > For example type of MachineState.[max]ram_size fields needs
> > to be changed as well. Because QEMU builds without CONFIG_XEN_BACKEND
> > on 32-bit hosts are broken since ram_addr_t is 32-bits there
> > while some targets assume and use it as 64-bit one.
>
> But on a 32-bit system without CONFIG_XEN_BACKEND you cannot allocate
> more than 4G anyway, so the choice of ram_addr_t is understandable in
> that case.
QEMU build will probably fail with above config but if it succeeds
then maxmem will be silently truncated.
>
> On the other hand, on a 32-bit system without CONFIG_XEN_BACKEND you
> definitely can place 128M of hot plugged memory between say 4096MB and
> 4224MB.
True.
Anyway for this patch
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
>
> Paolo
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] dimm: Correct type of MemoryHotplugState->base
2016-01-22 14:32 ` Igor Mammedov
@ 2016-02-01 2:33 ` David Gibson
2016-02-02 17:37 ` Eduardo Habkost
0 siblings, 1 reply; 8+ messages in thread
From: David Gibson @ 2016-02-01 2:33 UTC (permalink / raw)
To: Igor Mammedov; +Cc: Paolo Bonzini, bharata, qemu-ppc, qemu-devel, ehabkost
[-- Attachment #1: Type: text/plain, Size: 2625 bytes --]
On Fri, Jan 22, 2016 at 03:32:52PM +0100, Igor Mammedov wrote:
> On Fri, 22 Jan 2016 15:21:05 +0100
> Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> > On 22/01/2016 11:02, Igor Mammedov wrote:
> > > On Thu, 21 Jan 2016 12:37:51 +1100
> > > David Gibson <david@gibson.dropbear.id.au> wrote:
> > >
> > >> The 'base' field of MemoryHotplugState is ram_addr_t, which indicates that
> > >> it exists in the abstract address space of RAM regions.
> > >>
> > >> However, the actual usage of this field indicates that it is a concrete
> > >> physical address (it's passed as an offset to memory_region_add_subgregion
> > >> for example).
> > >>
> > >> So, correct its type to 'hwaddr'.
> > >>
> > >> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> > >> ---
> > >> include/hw/mem/pc-dimm.h | 2 +-
> > >> 1 file changed, 1 insertion(+), 1 deletion(-)
> > >>
> > >> diff --git a/include/hw/mem/pc-dimm.h b/include/hw/mem/pc-dimm.h
> > >> index d83bf30..218dfb0 100644
> > >> --- a/include/hw/mem/pc-dimm.h
> > >> +++ b/include/hw/mem/pc-dimm.h
> > >> @@ -77,7 +77,7 @@ typedef struct PCDIMMDeviceClass {
> > >> * @mr: hotplug memory address space container
> > >> */
> > >> typedef struct MemoryHotplugState {
> > >> - ram_addr_t base;
> > >> + hwaddr base;
> > >> MemoryRegion mr;
> > >> } MemoryHotplugState;
> > >>
> > >
> > > I agree with this fix but that's not the only place where
> > > ram_addr_t needs to be replaced with hwaddr.
> > > For example type of MachineState.[max]ram_size fields needs
> > > to be changed as well. Because QEMU builds without CONFIG_XEN_BACKEND
> > > on 32-bit hosts are broken since ram_addr_t is 32-bits there
> > > while some targets assume and use it as 64-bit one.
> >
> > But on a 32-bit system without CONFIG_XEN_BACKEND you cannot allocate
> > more than 4G anyway, so the choice of ram_addr_t is understandable in
> > that case.
> QEMU build will probably fail with above config but if it succeeds
> then maxmem will be silently truncated.
>
> >
> > On the other hand, on a 32-bit system without CONFIG_XEN_BACKEND you
> > definitely can place 128M of hot plugged memory between say 4096MB and
> > 4224MB.
> True.
>
> Anyway for this patch
> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Who needs to take this patch? I'm not sure if I need to do anything
further to push it forwards.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] dimm: Correct type of MemoryHotplugState->base
2016-02-01 2:33 ` David Gibson
@ 2016-02-02 17:37 ` Eduardo Habkost
2016-02-03 5:08 ` David Gibson
0 siblings, 1 reply; 8+ messages in thread
From: Eduardo Habkost @ 2016-02-02 17:37 UTC (permalink / raw)
To: David Gibson; +Cc: Igor Mammedov, bharata, qemu-ppc, qemu-devel, Paolo Bonzini
On Mon, Feb 01, 2016 at 01:33:09PM +1100, David Gibson wrote:
> On Fri, Jan 22, 2016 at 03:32:52PM +0100, Igor Mammedov wrote:
> > On Fri, 22 Jan 2016 15:21:05 +0100
> > Paolo Bonzini <pbonzini@redhat.com> wrote:
> >
> > > On 22/01/2016 11:02, Igor Mammedov wrote:
> > > > On Thu, 21 Jan 2016 12:37:51 +1100
> > > > David Gibson <david@gibson.dropbear.id.au> wrote:
> > > >
> > > >> The 'base' field of MemoryHotplugState is ram_addr_t, which indicates that
> > > >> it exists in the abstract address space of RAM regions.
> > > >>
> > > >> However, the actual usage of this field indicates that it is a concrete
> > > >> physical address (it's passed as an offset to memory_region_add_subgregion
> > > >> for example).
> > > >>
> > > >> So, correct its type to 'hwaddr'.
> > > >>
> > > >> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> > > >> ---
> > > >> include/hw/mem/pc-dimm.h | 2 +-
> > > >> 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >>
> > > >> diff --git a/include/hw/mem/pc-dimm.h b/include/hw/mem/pc-dimm.h
> > > >> index d83bf30..218dfb0 100644
> > > >> --- a/include/hw/mem/pc-dimm.h
> > > >> +++ b/include/hw/mem/pc-dimm.h
> > > >> @@ -77,7 +77,7 @@ typedef struct PCDIMMDeviceClass {
> > > >> * @mr: hotplug memory address space container
> > > >> */
> > > >> typedef struct MemoryHotplugState {
> > > >> - ram_addr_t base;
> > > >> + hwaddr base;
> > > >> MemoryRegion mr;
> > > >> } MemoryHotplugState;
> > > >>
> > > >
> > > > I agree with this fix but that's not the only place where
> > > > ram_addr_t needs to be replaced with hwaddr.
> > > > For example type of MachineState.[max]ram_size fields needs
> > > > to be changed as well. Because QEMU builds without CONFIG_XEN_BACKEND
> > > > on 32-bit hosts are broken since ram_addr_t is 32-bits there
> > > > while some targets assume and use it as 64-bit one.
> > >
> > > But on a 32-bit system without CONFIG_XEN_BACKEND you cannot allocate
> > > more than 4G anyway, so the choice of ram_addr_t is understandable in
> > > that case.
> > QEMU build will probably fail with above config but if it succeeds
> > then maxmem will be silently truncated.
> >
> > >
> > > On the other hand, on a 32-bit system without CONFIG_XEN_BACKEND you
> > > definitely can place 128M of hot plugged memory between say 4096MB and
> > > 4224MB.
> > True.
> >
> > Anyway for this patch
> > Reviewed-by: Igor Mammedov <imammedo@redhat.com>
>
> Who needs to take this patch? I'm not sure if I need to do anything
> further to push it forwards.
Most pc-dimm changes were merged either by me or Michael. I can
merge it if I get an Acked-by from Michael.
Otherwise, Michael has my Acked-by if he wants to merge it
through his tree.
Acked-by: Eduardo Habkost <ehabkost@redhat.com>
--
Eduardo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] dimm: Correct type of MemoryHotplugState->base
2016-02-02 17:37 ` Eduardo Habkost
@ 2016-02-03 5:08 ` David Gibson
2016-02-03 18:26 ` Eduardo Habkost
0 siblings, 1 reply; 8+ messages in thread
From: David Gibson @ 2016-02-03 5:08 UTC (permalink / raw)
To: Eduardo Habkost
Cc: mst, qemu-devel, Paolo Bonzini, qemu-ppc, bharata, Igor Mammedov
[-- Attachment #1: Type: text/plain, Size: 3329 bytes --]
On Tue, Feb 02, 2016 at 03:37:12PM -0200, Eduardo Habkost wrote:
> On Mon, Feb 01, 2016 at 01:33:09PM +1100, David Gibson wrote:
> > On Fri, Jan 22, 2016 at 03:32:52PM +0100, Igor Mammedov wrote:
> > > On Fri, 22 Jan 2016 15:21:05 +0100
> > > Paolo Bonzini <pbonzini@redhat.com> wrote:
> > >
> > > > On 22/01/2016 11:02, Igor Mammedov wrote:
> > > > > On Thu, 21 Jan 2016 12:37:51 +1100
> > > > > David Gibson <david@gibson.dropbear.id.au> wrote:
> > > > >
> > > > >> The 'base' field of MemoryHotplugState is ram_addr_t, which indicates that
> > > > >> it exists in the abstract address space of RAM regions.
> > > > >>
> > > > >> However, the actual usage of this field indicates that it is a concrete
> > > > >> physical address (it's passed as an offset to memory_region_add_subgregion
> > > > >> for example).
> > > > >>
> > > > >> So, correct its type to 'hwaddr'.
> > > > >>
> > > > >> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> > > > >> ---
> > > > >> include/hw/mem/pc-dimm.h | 2 +-
> > > > >> 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >>
> > > > >> diff --git a/include/hw/mem/pc-dimm.h b/include/hw/mem/pc-dimm.h
> > > > >> index d83bf30..218dfb0 100644
> > > > >> --- a/include/hw/mem/pc-dimm.h
> > > > >> +++ b/include/hw/mem/pc-dimm.h
> > > > >> @@ -77,7 +77,7 @@ typedef struct PCDIMMDeviceClass {
> > > > >> * @mr: hotplug memory address space container
> > > > >> */
> > > > >> typedef struct MemoryHotplugState {
> > > > >> - ram_addr_t base;
> > > > >> + hwaddr base;
> > > > >> MemoryRegion mr;
> > > > >> } MemoryHotplugState;
> > > > >>
> > > > >
> > > > > I agree with this fix but that's not the only place where
> > > > > ram_addr_t needs to be replaced with hwaddr.
> > > > > For example type of MachineState.[max]ram_size fields needs
> > > > > to be changed as well. Because QEMU builds without CONFIG_XEN_BACKEND
> > > > > on 32-bit hosts are broken since ram_addr_t is 32-bits there
> > > > > while some targets assume and use it as 64-bit one.
> > > >
> > > > But on a 32-bit system without CONFIG_XEN_BACKEND you cannot allocate
> > > > more than 4G anyway, so the choice of ram_addr_t is understandable in
> > > > that case.
> > > QEMU build will probably fail with above config but if it succeeds
> > > then maxmem will be silently truncated.
> > >
> > > >
> > > > On the other hand, on a 32-bit system without CONFIG_XEN_BACKEND you
> > > > definitely can place 128M of hot plugged memory between say 4096MB and
> > > > 4224MB.
> > > True.
> > >
> > > Anyway for this patch
> > > Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> >
> > Who needs to take this patch? I'm not sure if I need to do anything
> > further to push it forwards.
>
> Most pc-dimm changes were merged either by me or Michael. I can
> merge it if I get an Acked-by from Michael.
>
> Otherwise, Michael has my Acked-by if he wants to merge it
> through his tree.
>
> Acked-by: Eduardo Habkost <ehabkost@redhat.com>
Ah, I didn't realise Michael worked in this area. Adding him to CC..
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] dimm: Correct type of MemoryHotplugState->base
2016-02-03 5:08 ` David Gibson
@ 2016-02-03 18:26 ` Eduardo Habkost
0 siblings, 0 replies; 8+ messages in thread
From: Eduardo Habkost @ 2016-02-03 18:26 UTC (permalink / raw)
To: David Gibson
Cc: mst, qemu-devel, Paolo Bonzini, qemu-ppc, bharata, Igor Mammedov
On Wed, Feb 03, 2016 at 04:08:17PM +1100, David Gibson wrote:
> On Tue, Feb 02, 2016 at 03:37:12PM -0200, Eduardo Habkost wrote:
> > On Mon, Feb 01, 2016 at 01:33:09PM +1100, David Gibson wrote:
> > > On Fri, Jan 22, 2016 at 03:32:52PM +0100, Igor Mammedov wrote:
> > > > On Fri, 22 Jan 2016 15:21:05 +0100
> > > > Paolo Bonzini <pbonzini@redhat.com> wrote:
> > > >
> > > > > On 22/01/2016 11:02, Igor Mammedov wrote:
> > > > > > On Thu, 21 Jan 2016 12:37:51 +1100
> > > > > > David Gibson <david@gibson.dropbear.id.au> wrote:
> > > > > >
> > > > > >> The 'base' field of MemoryHotplugState is ram_addr_t, which indicates that
> > > > > >> it exists in the abstract address space of RAM regions.
> > > > > >>
> > > > > >> However, the actual usage of this field indicates that it is a concrete
> > > > > >> physical address (it's passed as an offset to memory_region_add_subgregion
> > > > > >> for example).
> > > > > >>
> > > > > >> So, correct its type to 'hwaddr'.
> > > > > >>
> > > > > >> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> > > > > >> ---
> > > > > >> include/hw/mem/pc-dimm.h | 2 +-
> > > > > >> 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > > >>
> > > > > >> diff --git a/include/hw/mem/pc-dimm.h b/include/hw/mem/pc-dimm.h
> > > > > >> index d83bf30..218dfb0 100644
> > > > > >> --- a/include/hw/mem/pc-dimm.h
> > > > > >> +++ b/include/hw/mem/pc-dimm.h
> > > > > >> @@ -77,7 +77,7 @@ typedef struct PCDIMMDeviceClass {
> > > > > >> * @mr: hotplug memory address space container
> > > > > >> */
> > > > > >> typedef struct MemoryHotplugState {
> > > > > >> - ram_addr_t base;
> > > > > >> + hwaddr base;
> > > > > >> MemoryRegion mr;
> > > > > >> } MemoryHotplugState;
> > > > > >>
> > > > > >
> > > > > > I agree with this fix but that's not the only place where
> > > > > > ram_addr_t needs to be replaced with hwaddr.
> > > > > > For example type of MachineState.[max]ram_size fields needs
> > > > > > to be changed as well. Because QEMU builds without CONFIG_XEN_BACKEND
> > > > > > on 32-bit hosts are broken since ram_addr_t is 32-bits there
> > > > > > while some targets assume and use it as 64-bit one.
> > > > >
> > > > > But on a 32-bit system without CONFIG_XEN_BACKEND you cannot allocate
> > > > > more than 4G anyway, so the choice of ram_addr_t is understandable in
> > > > > that case.
> > > > QEMU build will probably fail with above config but if it succeeds
> > > > then maxmem will be silently truncated.
> > > >
> > > > >
> > > > > On the other hand, on a 32-bit system without CONFIG_XEN_BACKEND you
> > > > > definitely can place 128M of hot plugged memory between say 4096MB and
> > > > > 4224MB.
> > > > True.
> > > >
> > > > Anyway for this patch
> > > > Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> > >
> > > Who needs to take this patch? I'm not sure if I need to do anything
> > > further to push it forwards.
> >
> > Most pc-dimm changes were merged either by me or Michael. I can
> > merge it if I get an Acked-by from Michael.
> >
> > Otherwise, Michael has my Acked-by if he wants to merge it
> > through his tree.
> >
> > Acked-by: Eduardo Habkost <ehabkost@redhat.com>
>
> Ah, I didn't realise Michael worked in this area. Adding him to CC..
Ooops, I thought Michael was already on CC. He is the PC and PCI
maintainer, but he has been merging machine.c and other generic
hw/ patches recently.
I sent another message to qemu-devel today, asking people where
could be the default destination for hw/core and other generic
hw/ code that has no maintainer in MAINTAINERS.
--
Eduardo
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-02-03 18:26 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-21 1:37 [Qemu-devel] [PATCH] dimm: Correct type of MemoryHotplugState->base David Gibson
2016-01-22 10:02 ` Igor Mammedov
2016-01-22 14:21 ` Paolo Bonzini
2016-01-22 14:32 ` Igor Mammedov
2016-02-01 2:33 ` David Gibson
2016-02-02 17:37 ` Eduardo Habkost
2016-02-03 5:08 ` David Gibson
2016-02-03 18:26 ` Eduardo Habkost
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).