From: Kevin Wolf <firstname.lastname@example.org> To: Alberto Garcia <email@example.com> Cc: firstname.lastname@example.org, email@example.com, Max Reitz <firstname.lastname@example.org> Subject: Re: [Qemu-devel] [PATCH 1/3] block: Allow x-blockdev-del on a BB with a monitor-owned BDS Date: Tue, 9 Feb 2016 11:32:20 +0100 [thread overview] Message-ID: <20160209103220.GC8554@noname.redhat.com> (raw) In-Reply-To: <email@example.com> Am 08.02.2016 um 15:14 hat Alberto Garcia geschrieben: > When x-blockdev-del is performed on a BlockBackend that has inserted > media it will only succeed if the BDS doesn't have any additional > references. > > The only problem with this is that if the BDS was created separately > using blockdev-add then the backend won't be able to be destroyed > unless the BDS is ejected first. This is an unnecessary restriction. > > Now that we have a list of monitor-owned BDSs we can allow > x-blockdev-del to work in this scenario if the BDS has exactly one > extra reference and that reference is from the monitor. > > Signed-off-by: Alberto Garcia <firstname.lastname@example.org> This means that what you created with two blockdev-add commands would be destroyed with a single blockdev-del command. I think we all agreed that blockdev-add and blockdev-del should always come in pairs. Kevin
next prev parent reply other threads:[~2016-02-09 10:32 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-02-08 14:14 Alberto Garcia 2016-02-08 14:14 ` [Qemu-devel] [PATCH 2/3] iotests: Update test 139 after the changes in x-blockdev-del Alberto Garcia 2016-02-09 15:36 ` Eric Blake 2016-02-09 15:44 ` Alberto Garcia 2016-02-08 14:14 ` [Qemu-devel] [PATCH 3/3] block: Update the x-blockdev-del documentation Alberto Garcia 2016-02-09 15:38 ` Eric Blake 2016-02-09 10:32 ` Kevin Wolf [this message] 2016-02-09 10:47 ` [Qemu-devel] [PATCH 1/3] block: Allow x-blockdev-del on a BB with a monitor-owned BDS Alberto Garcia 2016-02-09 15:34 ` Eric Blake 2016-02-09 15:39 ` Alberto Garcia
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160209103220.GC8554@noname.redhat.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [Qemu-devel] [PATCH 1/3] block: Allow x-blockdev-del on a BB with a monitor-owned BDS' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).