From: "Daniel P. Berrange" <berrange@redhat.com>
To: Kashyap Chamarthy <kchamart@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v6 00/16] Implement TLS support to QEMU NBD server & client
Date: Fri, 12 Feb 2016 15:00:32 +0000 [thread overview]
Message-ID: <20160212150031.GJ24725@redhat.com> (raw)
In-Reply-To: <20160212132833.GA15761@tesla.redhat.com>
On Fri, Feb 12, 2016 at 02:28:33PM +0100, Kashyap Chamarthy wrote:
> On Wed, Feb 10, 2016 at 06:40:58PM +0000, Daniel P. Berrange wrote:
>
> [...]
>
> I've applied all the series in this patches, to yesterday's Git master,
> so I'm here:
>
> $ git describe
> pull-qcrypto-next-2016-02-02-1-378-gf9375d2
>
> > Starting a QEMU system emulator built-in NBD server
> >
> > $ qemu-system-x86_64 \
> > -qmp unix:/tmp/qmp,server \
> > -hda /home/berrange/Fedora-Server-netinst-x86_64-23.iso \
> > -object tls-creds-x509,id=tls0,dir=/home/berrange/security/qemutls,endpoint=server
>
> Instead of an ISO, I have this command-line:
>
> $QEMU \
> -display none \
> -nodefconfig \
> -nodefaults \
> -m 2048 \
> -device virtio-scsi-pci,id=scsi \
> -device virtio-serial-pci \
> -serial stdio \
> -drive file=./cirros-0.3.3.qcow2,format=qcow2,if=virtio \
> -object tls-creds-x509,id=tls0,dir=/export/security/gnutls,endpoint=server \
> -qmp unix:./qmp-sock,server
>
> > $ qmp-shell /tmp/qmp
> > (qmp) nbd-server-start addr={"host":"localhost","port":"9000"}
> > tls-creds=tls0
>
> However, this invocation seem to work for me, am I doing something wrong?
>
> $ ./qmp-shell ./qmp-sock
> Welcome to the QMP low-level shell!
> Connected to QEMU 2.5.50
>
> (QEMU) nbd-server-start addr={'host:'localhost','port':'9000'} tls-creds=tls0
> {"error": {"class": "GenericError", "desc": "Invalid parameter type for 'addr', expected: QDict"}}
> (QEMU)
Yes, my bad - I provided the wrong syntax here. it should be
(QEMU) nbd-server-start addr={"type":"inet","data":{"host":"localhost","port":"9000"}} tls-creds=tls0
{"return": {}}
(QEMU) nbd-server-add device=ide0-hd0
{"return": {}}
I've genuinely tested it this time :-)
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
next prev parent reply other threads:[~2016-02-12 15:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 18:40 [Qemu-devel] [PATCH v6 00/16] Implement TLS support to QEMU NBD server & client Daniel P. Berrange
2016-02-10 18:40 ` [Qemu-devel] [PATCH v6 01/16] qom: add helpers for UserCreatable object types Daniel P. Berrange
2016-02-11 23:13 ` Eric Blake
2016-02-10 18:41 ` [Qemu-devel] [PATCH v6 02/16] qemu-nbd: add support for --object command line arg Daniel P. Berrange
2016-02-10 18:41 ` [Qemu-devel] [PATCH v6 03/16] nbd: convert block client to use I/O channels for connection setup Daniel P. Berrange
2016-02-10 18:41 ` [Qemu-devel] [PATCH v6 04/16] nbd: convert qemu-nbd server " Daniel P. Berrange
2016-02-10 18:41 ` [Qemu-devel] [PATCH v6 05/16] nbd: convert blockdev NBD " Daniel P. Berrange
2016-02-10 18:41 ` [Qemu-devel] [PATCH v6 06/16] nbd: convert to using I/O channels for actual socket I/O Daniel P. Berrange
2016-02-10 18:41 ` [Qemu-devel] [PATCH v6 07/16] nbd: invert client logic for negotiating protocol version Daniel P. Berrange
2016-02-10 18:41 ` [Qemu-devel] [PATCH v6 08/16] nbd: make server compliant with fixed newstyle spec Daniel P. Berrange
2016-02-10 18:41 ` [Qemu-devel] [PATCH v6 09/16] nbd: make client request fixed new style if advertized Daniel P. Berrange
2016-02-10 18:41 ` [Qemu-devel] [PATCH v6 10/16] nbd: allow setting of an export name for qemu-nbd server Daniel P. Berrange
2016-02-10 18:41 ` [Qemu-devel] [PATCH v6 11/16] nbd: always query export list in fixed new style protocol Daniel P. Berrange
2016-02-10 18:41 ` [Qemu-devel] [PATCH v6 12/16] nbd: use "" as a default export name if none provided Daniel P. Berrange
2016-02-10 18:41 ` [Qemu-devel] [PATCH v6 13/16] nbd: implement TLS support in the protocol negotiation Daniel P. Berrange
2016-02-10 18:41 ` [Qemu-devel] [PATCH v6 14/16] nbd: enable use of TLS with NBD block driver Daniel P. Berrange
2016-02-10 18:41 ` [Qemu-devel] [PATCH v6 15/16] nbd: enable use of TLS with qemu-nbd server Daniel P. Berrange
2016-02-10 18:41 ` [Qemu-devel] [PATCH v6 16/16] nbd: enable use of TLS with nbd-server-start command Daniel P. Berrange
2016-02-12 13:28 ` [Qemu-devel] [PATCH v6 00/16] Implement TLS support to QEMU NBD server & client Kashyap Chamarthy
2016-02-12 15:00 ` Daniel P. Berrange [this message]
2016-02-12 16:03 ` Kashyap Chamarthy
2016-02-12 18:14 ` Kashyap Chamarthy
2016-02-16 16:18 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160212150031.GJ24725@redhat.com \
--to=berrange@redhat.com \
--cc=kchamart@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).