qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PULL 0/3] Block patches
@ 2017-02-24 17:46 Jeff Cody
  2017-02-24 17:46 ` [Qemu-devel] [PULL 1/3] block/nfs: convert to preadv / pwritev Jeff Cody
                   ` (3 more replies)
  0 siblings, 4 replies; 20+ messages in thread
From: Jeff Cody @ 2017-02-24 17:46 UTC (permalink / raw)
  To: qemu-block; +Cc: peter.maydell, jcody, qemu-devel

The following changes since commit fe8ee082db5038a05dbd8872e946049e9a9c550e:

  Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2017-02-22' into staging (2017-02-24 15:00:51 +0000)

are available in the git repository at:

  https://github.com/codyprime/qemu-kvm-jtc.git tags/block-pull-request

for you to fetch changes up to 1d393bdeae22fde2cb83c1ea719675747c85c40e:

  RBD: Add support readv,writev for rbd (2017-02-24 12:43:01 -0500)

----------------------------------------------------------------
Block patches for 2.9
----------------------------------------------------------------

Peter Lieven (2):
  block/nfs: convert to preadv / pwritev
  block/nfs: try to avoid the bounce buffer in pwritev

tianqing (1):
  RBD: Add support readv,writev for rbd

 block/nfs.c | 62 +++++++++++++++++++++++++----------------------
 block/rbd.c | 80 ++++++++++++++++++++++++++++++++++++++++++-------------------
 2 files changed, 90 insertions(+), 52 deletions(-)

-- 
2.9.3

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [Qemu-devel] [PULL 1/3] block/nfs: convert to preadv / pwritev
  2017-02-24 17:46 [Qemu-devel] [PULL 0/3] Block patches Jeff Cody
@ 2017-02-24 17:46 ` Jeff Cody
  2017-02-24 17:46 ` [Qemu-devel] [PULL 2/3] block/nfs: try to avoid the bounce buffer in pwritev Jeff Cody
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 20+ messages in thread
From: Jeff Cody @ 2017-02-24 17:46 UTC (permalink / raw)
  To: qemu-block; +Cc: peter.maydell, jcody, qemu-devel

From: Peter Lieven <pl@kamp.de>

Signed-off-by: Peter Lieven <pl@kamp.de>
Reviewed-by: Jeff Cody <jcody@redhat.com>
Message-id: 1487349541-10201-2-git-send-email-pl@kamp.de
Signed-off-by: Jeff Cody <jcody@redhat.com>
---
 block/nfs.c | 33 +++++++++++++++------------------
 1 file changed, 15 insertions(+), 18 deletions(-)

diff --git a/block/nfs.c b/block/nfs.c
index 0cf115e..c11c4c9 100644
--- a/block/nfs.c
+++ b/block/nfs.c
@@ -263,9 +263,9 @@ nfs_co_generic_cb(int ret, struct nfs_context *nfs, void *data,
                             nfs_co_generic_bh_cb, task);
 }
 
-static int coroutine_fn nfs_co_readv(BlockDriverState *bs,
-                                     int64_t sector_num, int nb_sectors,
-                                     QEMUIOVector *iov)
+static int coroutine_fn nfs_co_preadv(BlockDriverState *bs, uint64_t offset,
+                                      uint64_t bytes, QEMUIOVector *iov,
+                                      int flags)
 {
     NFSClient *client = bs->opaque;
     NFSRPC task;
@@ -274,9 +274,7 @@ static int coroutine_fn nfs_co_readv(BlockDriverState *bs,
     task.iov = iov;
 
     if (nfs_pread_async(client->context, client->fh,
-                        sector_num * BDRV_SECTOR_SIZE,
-                        nb_sectors * BDRV_SECTOR_SIZE,
-                        nfs_co_generic_cb, &task) != 0) {
+                        offset, bytes, nfs_co_generic_cb, &task) != 0) {
         return -ENOMEM;
     }
 
@@ -297,9 +295,9 @@ static int coroutine_fn nfs_co_readv(BlockDriverState *bs,
     return 0;
 }
 
-static int coroutine_fn nfs_co_writev(BlockDriverState *bs,
-                                        int64_t sector_num, int nb_sectors,
-                                        QEMUIOVector *iov)
+static int coroutine_fn nfs_co_pwritev(BlockDriverState *bs, uint64_t offset,
+                                       uint64_t bytes, QEMUIOVector *iov,
+                                       int flags)
 {
     NFSClient *client = bs->opaque;
     NFSRPC task;
@@ -307,17 +305,16 @@ static int coroutine_fn nfs_co_writev(BlockDriverState *bs,
 
     nfs_co_init_task(bs, &task);
 
-    buf = g_try_malloc(nb_sectors * BDRV_SECTOR_SIZE);
-    if (nb_sectors && buf == NULL) {
+    buf = g_try_malloc(bytes);
+    if (bytes && buf == NULL) {
         return -ENOMEM;
     }
 
-    qemu_iovec_to_buf(iov, 0, buf, nb_sectors * BDRV_SECTOR_SIZE);
+    qemu_iovec_to_buf(iov, 0, buf, bytes);
 
     if (nfs_pwrite_async(client->context, client->fh,
-                         sector_num * BDRV_SECTOR_SIZE,
-                         nb_sectors * BDRV_SECTOR_SIZE,
-                         buf, nfs_co_generic_cb, &task) != 0) {
+                         offset, bytes, buf,
+                         nfs_co_generic_cb, &task) != 0) {
         g_free(buf);
         return -ENOMEM;
     }
@@ -329,7 +326,7 @@ static int coroutine_fn nfs_co_writev(BlockDriverState *bs,
 
     g_free(buf);
 
-    if (task.ret != nb_sectors * BDRV_SECTOR_SIZE) {
+    if (task.ret != bytes) {
         return task.ret < 0 ? task.ret : -EIO;
     }
 
@@ -861,8 +858,8 @@ static BlockDriver bdrv_nfs = {
     .bdrv_create                    = nfs_file_create,
     .bdrv_reopen_prepare            = nfs_reopen_prepare,
 
-    .bdrv_co_readv                  = nfs_co_readv,
-    .bdrv_co_writev                 = nfs_co_writev,
+    .bdrv_co_preadv                 = nfs_co_preadv,
+    .bdrv_co_pwritev                = nfs_co_pwritev,
     .bdrv_co_flush_to_disk          = nfs_co_flush,
 
     .bdrv_detach_aio_context        = nfs_detach_aio_context,
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [Qemu-devel] [PULL 2/3] block/nfs: try to avoid the bounce buffer in pwritev
  2017-02-24 17:46 [Qemu-devel] [PULL 0/3] Block patches Jeff Cody
  2017-02-24 17:46 ` [Qemu-devel] [PULL 1/3] block/nfs: convert to preadv / pwritev Jeff Cody
@ 2017-02-24 17:46 ` Jeff Cody
  2017-02-24 17:47 ` [Qemu-devel] [PULL 3/3] RBD: Add support readv,writev for rbd Jeff Cody
  2017-02-26 12:26 ` [Qemu-devel] [PULL 0/3] Block patches Peter Maydell
  3 siblings, 0 replies; 20+ messages in thread
From: Jeff Cody @ 2017-02-24 17:46 UTC (permalink / raw)
  To: qemu-block; +Cc: peter.maydell, jcody, qemu-devel

From: Peter Lieven <pl@kamp.de>

if the passed qiov contains exactly one iov we can
pass the buffer directly.

Signed-off-by: Peter Lieven <pl@kamp.de>
Reviewed-by: Jeff Cody <jcody@redhat.com>
Message-id: 1487349541-10201-3-git-send-email-pl@kamp.de
Signed-off-by: Jeff Cody <jcody@redhat.com>
---
 block/nfs.c | 35 ++++++++++++++++++++++-------------
 1 file changed, 22 insertions(+), 13 deletions(-)

diff --git a/block/nfs.c b/block/nfs.c
index c11c4c9..ffb54be 100644
--- a/block/nfs.c
+++ b/block/nfs.c
@@ -302,30 +302,39 @@ static int coroutine_fn nfs_co_pwritev(BlockDriverState *bs, uint64_t offset,
     NFSClient *client = bs->opaque;
     NFSRPC task;
     char *buf = NULL;
+    bool my_buffer = false;
 
     nfs_co_init_task(bs, &task);
 
-    buf = g_try_malloc(bytes);
-    if (bytes && buf == NULL) {
-        return -ENOMEM;
+    if (iov->niov != 1) {
+        buf = g_try_malloc(bytes);
+        if (bytes && buf == NULL) {
+            return -ENOMEM;
+        }
+        qemu_iovec_to_buf(iov, 0, buf, bytes);
+        my_buffer = true;
+    } else {
+        buf = iov->iov[0].iov_base;
     }
 
-    qemu_iovec_to_buf(iov, 0, buf, bytes);
-
     if (nfs_pwrite_async(client->context, client->fh,
                          offset, bytes, buf,
                          nfs_co_generic_cb, &task) != 0) {
+        if (my_buffer) {
+            g_free(buf);
+        }
+        return -ENOMEM;
+    }
+
+    nfs_set_events(client);
+    while (!task.complete) {
+        qemu_coroutine_yield();
+    }
+
+    if (my_buffer) {
         g_free(buf);
-        return -ENOMEM;
     }
 
-    nfs_set_events(client);
-    while (!task.complete) {
-        qemu_coroutine_yield();
-    }
-
-    g_free(buf);
-
     if (task.ret != bytes) {
         return task.ret < 0 ? task.ret : -EIO;
     }
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [Qemu-devel] [PULL 3/3] RBD: Add support readv,writev for rbd
  2017-02-24 17:46 [Qemu-devel] [PULL 0/3] Block patches Jeff Cody
  2017-02-24 17:46 ` [Qemu-devel] [PULL 1/3] block/nfs: convert to preadv / pwritev Jeff Cody
  2017-02-24 17:46 ` [Qemu-devel] [PULL 2/3] block/nfs: try to avoid the bounce buffer in pwritev Jeff Cody
@ 2017-02-24 17:47 ` Jeff Cody
  2017-02-26 12:26 ` [Qemu-devel] [PULL 0/3] Block patches Peter Maydell
  3 siblings, 0 replies; 20+ messages in thread
From: Jeff Cody @ 2017-02-24 17:47 UTC (permalink / raw)
  To: qemu-block; +Cc: peter.maydell, jcody, qemu-devel

From: tianqing <tianqing@unitedstack.com>

Rbd can do readv and writev directly, so wo do not need to transform
iov to buf or vice versa any more.

Signed-off-by: tianqing <tianqing@unitedstack.com>
Reviewed-by: Jeff Cody <jcody@redhat.com>
Signed-off-by: Jeff Cody <jcody@redhat.com>
---
 block/rbd.c | 80 ++++++++++++++++++++++++++++++++++++++++++-------------------
 1 file changed, 56 insertions(+), 24 deletions(-)

diff --git a/block/rbd.c b/block/rbd.c
index a57b3e3..22e8e69 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -62,6 +62,13 @@
 #define RBD_MAX_SNAP_NAME_SIZE 128
 #define RBD_MAX_SNAPS 100
 
+/* The LIBRBD_SUPPORTS_IOVEC is defined in librbd.h */
+#ifdef LIBRBD_SUPPORTS_IOVEC
+#define LIBRBD_USE_IOVEC 1
+#else
+#define LIBRBD_USE_IOVEC 0
+#endif
+
 typedef enum {
     RBD_AIO_READ,
     RBD_AIO_WRITE,
@@ -310,6 +317,17 @@ static int qemu_rbd_set_conf(rados_t cluster, const char *conf,
     return ret;
 }
 
+static void qemu_rbd_memset(RADOSCB *rcb, int64_t offs)
+{
+    if (LIBRBD_USE_IOVEC) {
+        RBDAIOCB *acb = rcb->acb;
+        iov_memset(acb->qiov->iov, acb->qiov->niov, offs, 0,
+                   acb->qiov->size - offs);
+    } else {
+        memset(rcb->buf + offs, 0, rcb->size - offs);
+    }
+}
+
 static int qemu_rbd_create(const char *filename, QemuOpts *opts, Error **errp)
 {
     Error *local_err = NULL;
@@ -426,11 +444,11 @@ static void qemu_rbd_complete_aio(RADOSCB *rcb)
         }
     } else {
         if (r < 0) {
-            memset(rcb->buf, 0, rcb->size);
+            qemu_rbd_memset(rcb, 0);
             acb->ret = r;
             acb->error = 1;
         } else if (r < rcb->size) {
-            memset(rcb->buf + r, 0, rcb->size - r);
+            qemu_rbd_memset(rcb, r);
             if (!acb->error) {
                 acb->ret = rcb->size;
             }
@@ -441,10 +459,13 @@ static void qemu_rbd_complete_aio(RADOSCB *rcb)
 
     g_free(rcb);
 
-    if (acb->cmd == RBD_AIO_READ) {
-        qemu_iovec_from_buf(acb->qiov, 0, acb->bounce, acb->qiov->size);
+    if (!LIBRBD_USE_IOVEC) {
+        if (acb->cmd == RBD_AIO_READ) {
+            qemu_iovec_from_buf(acb->qiov, 0, acb->bounce, acb->qiov->size);
+        }
+        qemu_vfree(acb->bounce);
     }
-    qemu_vfree(acb->bounce);
+
     acb->common.cb(acb->common.opaque, (acb->ret > 0 ? 0 : acb->ret));
 
     qemu_aio_unref(acb);
@@ -655,7 +676,6 @@ static BlockAIOCB *rbd_start_aio(BlockDriverState *bs,
     RBDAIOCB *acb;
     RADOSCB *rcb = NULL;
     rbd_completion_t c;
-    char *buf;
     int r;
 
     BDRVRBDState *s = bs->opaque;
@@ -664,27 +684,29 @@ static BlockAIOCB *rbd_start_aio(BlockDriverState *bs,
     acb->cmd = cmd;
     acb->qiov = qiov;
     assert(!qiov || qiov->size == size);
-    if (cmd == RBD_AIO_DISCARD || cmd == RBD_AIO_FLUSH) {
-        acb->bounce = NULL;
-    } else {
-        acb->bounce = qemu_try_blockalign(bs, qiov->size);
-        if (acb->bounce == NULL) {
-            goto failed;
+
+    rcb = g_new(RADOSCB, 1);
+
+    if (!LIBRBD_USE_IOVEC) {
+        if (cmd == RBD_AIO_DISCARD || cmd == RBD_AIO_FLUSH) {
+            acb->bounce = NULL;
+        } else {
+            acb->bounce = qemu_try_blockalign(bs, qiov->size);
+            if (acb->bounce == NULL) {
+                goto failed;
+            }
         }
+        if (cmd == RBD_AIO_WRITE) {
+            qemu_iovec_to_buf(acb->qiov, 0, acb->bounce, qiov->size);
+        }
+        rcb->buf = acb->bounce;
     }
+
     acb->ret = 0;
     acb->error = 0;
     acb->s = s;
 
-    if (cmd == RBD_AIO_WRITE) {
-        qemu_iovec_to_buf(acb->qiov, 0, acb->bounce, qiov->size);
-    }
-
-    buf = acb->bounce;
-
-    rcb = g_new(RADOSCB, 1);
     rcb->acb = acb;
-    rcb->buf = buf;
     rcb->s = acb->s;
     rcb->size = size;
     r = rbd_aio_create_completion(rcb, (rbd_callback_t) rbd_finish_aiocb, &c);
@@ -694,10 +716,18 @@ static BlockAIOCB *rbd_start_aio(BlockDriverState *bs,
 
     switch (cmd) {
     case RBD_AIO_WRITE:
-        r = rbd_aio_write(s->image, off, size, buf, c);
+#ifdef LIBRBD_SUPPORTS_IOVEC
+            r = rbd_aio_writev(s->image, qiov->iov, qiov->niov, off, c);
+#else
+            r = rbd_aio_write(s->image, off, size, rcb->buf, c);
+#endif
         break;
     case RBD_AIO_READ:
-        r = rbd_aio_read(s->image, off, size, buf, c);
+#ifdef LIBRBD_SUPPORTS_IOVEC
+            r = rbd_aio_readv(s->image, qiov->iov, qiov->niov, off, c);
+#else
+            r = rbd_aio_read(s->image, off, size, rcb->buf, c);
+#endif
         break;
     case RBD_AIO_DISCARD:
         r = rbd_aio_discard_wrapper(s->image, off, size, c);
@@ -712,14 +742,16 @@ static BlockAIOCB *rbd_start_aio(BlockDriverState *bs,
     if (r < 0) {
         goto failed_completion;
     }
-
     return &acb->common;
 
 failed_completion:
     rbd_aio_release(c);
 failed:
     g_free(rcb);
-    qemu_vfree(acb->bounce);
+    if (!LIBRBD_USE_IOVEC) {
+        qemu_vfree(acb->bounce);
+    }
+
     qemu_aio_unref(acb);
     return NULL;
 }
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 20+ messages in thread

* Re: [Qemu-devel] [PULL 0/3] Block patches
  2017-02-24 17:46 [Qemu-devel] [PULL 0/3] Block patches Jeff Cody
                   ` (2 preceding siblings ...)
  2017-02-24 17:47 ` [Qemu-devel] [PULL 3/3] RBD: Add support readv,writev for rbd Jeff Cody
@ 2017-02-26 12:26 ` Peter Maydell
  3 siblings, 0 replies; 20+ messages in thread
From: Peter Maydell @ 2017-02-26 12:26 UTC (permalink / raw)
  To: Jeff Cody; +Cc: Qemu-block, QEMU Developers

On 24 February 2017 at 17:46, Jeff Cody <jcody@redhat.com> wrote:
> The following changes since commit fe8ee082db5038a05dbd8872e946049e9a9c550e:
>
>   Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2017-02-22' into staging (2017-02-24 15:00:51 +0000)
>
> are available in the git repository at:
>
>   https://github.com/codyprime/qemu-kvm-jtc.git tags/block-pull-request
>
> for you to fetch changes up to 1d393bdeae22fde2cb83c1ea719675747c85c40e:
>
>   RBD: Add support readv,writev for rbd (2017-02-24 12:43:01 -0500)
>
> ----------------------------------------------------------------
> Block patches for 2.9
> ----------------------------------------------------------------

Applied, thanks.

-- PMM

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [Qemu-devel] [PULL 0/3] Block patches
  2019-02-12  4:01 Stefan Hajnoczi
@ 2019-02-12 12:26 ` Peter Maydell
  0 siblings, 0 replies; 20+ messages in thread
From: Peter Maydell @ 2019-02-12 12:26 UTC (permalink / raw)
  To: Stefan Hajnoczi
  Cc: QEMU Developers, Kevin Wolf, Marcel Apfelbaum, Max Reitz,
	Paolo Bonzini, Laurent Vivier, Eduardo Habkost, Qemu-block,
	Thomas Huth, Michael S. Tsirkin

On Tue, 12 Feb 2019 at 04:01, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> The following changes since commit 22c5f446514a2a4bb0dbe1fea26713da92fc85fa:
>
>   Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190211' into staging (2019-02-11 17:04:57 +0000)
>
> are available in the Git repository at:
>
>   git://github.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 9a6719d572e99a4e79f589d0b73f7475b86f982d:
>
>   virtio-blk: cleanup using VirtIOBlock *s and VirtIODevice *vdev (2019-02-12 11:49:17 +0800)
>
> ----------------------------------------------------------------
> Pull request
>
> ----------------------------------------------------------------

Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/4.0
for any user-visible changes.

-- PMM

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [Qemu-devel] [PULL 0/3] Block patches
@ 2019-02-12  4:01 Stefan Hajnoczi
  2019-02-12 12:26 ` Peter Maydell
  0 siblings, 1 reply; 20+ messages in thread
From: Stefan Hajnoczi @ 2019-02-12  4:01 UTC (permalink / raw)
  To: qemu-devel
  Cc: Kevin Wolf, Marcel Apfelbaum, Max Reitz, Paolo Bonzini,
	Laurent Vivier, Stefan Hajnoczi, Eduardo Habkost, qemu-block,
	Thomas Huth, Peter Maydell, Michael S. Tsirkin

The following changes since commit 22c5f446514a2a4bb0dbe1fea26713da92fc85fa:

  Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190211' into staging (2019-02-11 17:04:57 +0000)

are available in the Git repository at:

  git://github.com/stefanha/qemu.git tags/block-pull-request

for you to fetch changes up to 9a6719d572e99a4e79f589d0b73f7475b86f982d:

  virtio-blk: cleanup using VirtIOBlock *s and VirtIODevice *vdev (2019-02-12 11:49:17 +0800)

----------------------------------------------------------------
Pull request

----------------------------------------------------------------

Peter Xu (1):
  iothread: fix iothread hang when stop too soon

Stefano Garzarella (1):
  virtio-blk: cleanup using VirtIOBlock *s and VirtIODevice *vdev

Vladimir Sementsov-Ogievskiy (1):
  qemugdb/coroutine: fix arch_prctl has unknown return type

 hw/block/virtio-blk.c        | 22 +++++++++-------------
 iothread.c                   |  6 +++++-
 scripts/qemugdb/coroutine.py |  2 +-
 3 files changed, 15 insertions(+), 15 deletions(-)

-- 
2.20.1

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [Qemu-devel] [PULL 0/3] Block patches
  2019-01-24 10:28 Stefan Hajnoczi
@ 2019-01-24 15:38 ` Peter Maydell
  0 siblings, 0 replies; 20+ messages in thread
From: Peter Maydell @ 2019-01-24 15:38 UTC (permalink / raw)
  To: Stefan Hajnoczi
  Cc: QEMU Developers, Stefan Weil, Qemu-block, Alberto Garcia,
	Max Reitz, Fam Zheng, Kevin Wolf

On Thu, 24 Jan 2019 at 10:29, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> The following changes since commit f6b06fcceef465de0cf2514c9f76fe0192896781:
>
>   Merge remote-tracking branch 'remotes/kraxel/tags/ui-20190121-pull-request' into staging (2019-01-23 17:57:47 +0000)
>
> are available in the Git repository at:
>
>   git://github.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 8595685986152334b1ec28c78cb0e5e855d56b54:
>
>   qemu-coroutine-sleep: drop CoSleepCB (2019-01-24 10:05:16 +0000)
>
> ----------------------------------------------------------------
> Pull request
>
> Changelog: No user-visible changes.
>
> ----------------------------------------------------------------

Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/4.0
for any user-visible changes.

-- PMM

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [Qemu-devel] [PULL 0/3] Block patches
@ 2019-01-24 10:28 Stefan Hajnoczi
  2019-01-24 15:38 ` Peter Maydell
  0 siblings, 1 reply; 20+ messages in thread
From: Stefan Hajnoczi @ 2019-01-24 10:28 UTC (permalink / raw)
  To: qemu-devel
  Cc: Stefan Weil, qemu-block, Alberto Garcia, Peter Maydell,
	Stefan Hajnoczi, Max Reitz, Fam Zheng, Kevin Wolf

The following changes since commit f6b06fcceef465de0cf2514c9f76fe0192896781:

  Merge remote-tracking branch 'remotes/kraxel/tags/ui-20190121-pull-request' into staging (2019-01-23 17:57:47 +0000)

are available in the Git repository at:

  git://github.com/stefanha/qemu.git tags/block-pull-request

for you to fetch changes up to 8595685986152334b1ec28c78cb0e5e855d56b54:

  qemu-coroutine-sleep: drop CoSleepCB (2019-01-24 10:05:16 +0000)

----------------------------------------------------------------
Pull request

Changelog: No user-visible changes.

----------------------------------------------------------------

Stefan Hajnoczi (2):
  throttle-groups: fix restart coroutine iothread race
  iotests: add 238 for throttling tgm unregister iothread segfault

Vladimir Sementsov-Ogievskiy (1):
  qemu-coroutine-sleep: drop CoSleepCB

 include/block/throttle-groups.h |  5 ++++
 block/throttle-groups.c         |  9 +++++++
 util/qemu-coroutine-sleep.c     | 27 +++++++------------
 tests/qemu-iotests/238          | 47 +++++++++++++++++++++++++++++++++
 tests/qemu-iotests/238.out      |  6 +++++
 tests/qemu-iotests/group        |  1 +
 6 files changed, 78 insertions(+), 17 deletions(-)
 create mode 100755 tests/qemu-iotests/238
 create mode 100644 tests/qemu-iotests/238.out

-- 
2.20.1

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [Qemu-devel] [PULL 0/3] Block patches
  2018-07-03  3:46 Jeff Cody
@ 2018-07-03 12:50 ` Peter Maydell
  0 siblings, 0 replies; 20+ messages in thread
From: Peter Maydell @ 2018-07-03 12:50 UTC (permalink / raw)
  To: Jeff Cody; +Cc: Qemu-block, Fam Zheng, QEMU Developers, Stefan Hajnoczi

On 3 July 2018 at 04:46, Jeff Cody <jcody@redhat.com> wrote:
> The following changes since commit ab08440a4ee09032d1a9cb22fdcab23bc7e1c656:
>
>   Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20180702' into staging (2018-07-02 17:57:46 +0100)
>
> are available in the Git repository at:
>
>   git://github.com/codyprime/qemu-kvm-jtc.git tags/block-pull-request
>
> for you to fetch changes up to 9ded4a0114968e98b41494fc035ba14f84cdf700:
>
>   backup: Use copy offloading (2018-07-02 23:23:45 -0400)
>
> ----------------------------------------------------------------
> Block backup patches
> ----------------------------------------------------------------
>
> Fam Zheng (3):
>   block: Fix parameter checking in bdrv_co_copy_range_internal
>   block: Honour BDRV_REQ_NO_SERIALISING in copy range
>   backup: Use copy offloading
>
>  block/backup.c        | 150 ++++++++++++++++++++++++++++++------------
>  block/io.c            |  35 +++++-----
>  block/trace-events    |   1 +
>  include/block/block.h |   5 +-
>  4 files changed, 132 insertions(+), 59 deletions(-)

Applied, thanks.

-- PMM

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [Qemu-devel] [PULL 0/3] Block patches
@ 2018-07-03  3:46 Jeff Cody
  2018-07-03 12:50 ` Peter Maydell
  0 siblings, 1 reply; 20+ messages in thread
From: Jeff Cody @ 2018-07-03  3:46 UTC (permalink / raw)
  To: qemu-block
  Cc: peter.maydell, Fam Zheng, qemu-devel, Jeff Cody, Stefan Hajnoczi

The following changes since commit ab08440a4ee09032d1a9cb22fdcab23bc7e1c656:

  Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20180702' into staging (2018-07-02 17:57:46 +0100)

are available in the Git repository at:

  git://github.com/codyprime/qemu-kvm-jtc.git tags/block-pull-request

for you to fetch changes up to 9ded4a0114968e98b41494fc035ba14f84cdf700:

  backup: Use copy offloading (2018-07-02 23:23:45 -0400)

----------------------------------------------------------------
Block backup patches
----------------------------------------------------------------

Fam Zheng (3):
  block: Fix parameter checking in bdrv_co_copy_range_internal
  block: Honour BDRV_REQ_NO_SERIALISING in copy range
  backup: Use copy offloading

 block/backup.c        | 150 ++++++++++++++++++++++++++++++------------
 block/io.c            |  35 +++++-----
 block/trace-events    |   1 +
 include/block/block.h |   5 +-
 4 files changed, 132 insertions(+), 59 deletions(-)

-- 
2.17.1

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [Qemu-devel] [PULL 0/3] Block patches
  2017-10-13 13:49 Stefan Hajnoczi
@ 2017-10-16 14:54 ` Peter Maydell
  0 siblings, 0 replies; 20+ messages in thread
From: Peter Maydell @ 2017-10-16 14:54 UTC (permalink / raw)
  To: Stefan Hajnoczi; +Cc: QEMU Developers

On 13 October 2017 at 14:49, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> The following changes since commit f90ea7ba7c5ae7010ee0ce062207ae42530f57d6:
>
>   Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20171012' into staging (2017-10-12 17:06:50 +0100)
>
> are available in the git repository at:
>
>   git://github.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to b867eaa17b3940760f51134e409cb0580dd3dde3:
>
>   block/throttle.c: add bdrv_co_drain_begin/end callbacks (2017-10-13 12:38:41 +0100)
>
> ----------------------------------------------------------------
>
> ----------------------------------------------------------------

Applied, thanks.

-- PMM

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [Qemu-devel] [PULL 0/3] Block patches
@ 2017-10-13 13:49 Stefan Hajnoczi
  2017-10-16 14:54 ` Peter Maydell
  0 siblings, 1 reply; 20+ messages in thread
From: Stefan Hajnoczi @ 2017-10-13 13:49 UTC (permalink / raw)
  To: qemu-devel; +Cc: Peter Maydell, Stefan Hajnoczi

The following changes since commit f90ea7ba7c5ae7010ee0ce062207ae42530f57d6:

  Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20171012' into staging (2017-10-12 17:06:50 +0100)

are available in the git repository at:

  git://github.com/stefanha/qemu.git tags/block-pull-request

for you to fetch changes up to b867eaa17b3940760f51134e409cb0580dd3dde3:

  block/throttle.c: add bdrv_co_drain_begin/end callbacks (2017-10-13 12:38:41 +0100)

----------------------------------------------------------------

----------------------------------------------------------------

Manos Pitsidianakis (3):
  block: add bdrv_co_drain_end callback
  block: rename bdrv_co_drain to bdrv_co_drain_begin
  block/throttle.c: add bdrv_co_drain_begin/end callbacks

 include/block/block_int.h | 13 ++++++++++---
 block/io.c                | 48 +++++++++++++++++++++++++++++++++--------------
 block/qed.c               |  6 +++---
 block/throttle.c          | 18 ++++++++++++++++++
 4 files changed, 65 insertions(+), 20 deletions(-)

-- 
2.13.6

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [Qemu-devel] [PULL 0/3] Block patches
  2016-11-08 18:12 Stefan Hajnoczi
@ 2016-11-09 12:44 ` Stefan Hajnoczi
  0 siblings, 0 replies; 20+ messages in thread
From: Stefan Hajnoczi @ 2016-11-09 12:44 UTC (permalink / raw)
  To: Stefan Hajnoczi; +Cc: qemu-devel, Peter Maydell

[-- Attachment #1: Type: text/plain, Size: 1373 bytes --]

On Tue, Nov 08, 2016 at 06:12:39PM +0000, Stefan Hajnoczi wrote:
> The following changes since commit 207faf24c58859f5240f66bf6decc33b87a1776e:
> 
>   Merge remote-tracking branch 'pm215/tags/pull-target-arm-20161107' into staging (2016-11-07 14:02:15 +0000)
> 
> are available in the git repository at:
> 
>   git://github.com/stefanha/qemu.git tags/block-pull-request
> 
> for you to fetch changes up to 35dd66e23ce96283723de58e10d2877ae2be4a1b:
> 
>   aio-posix: simplify aio_epoll_update (2016-11-08 17:09:14 +0000)
> 
> ----------------------------------------------------------------
> 
> ----------------------------------------------------------------
> 
> Kevin Wolf (1):
>   block: Don't mark node clean after failed flush
> 
> Paolo Bonzini (2):
>   aio-posix: avoid NULL pointer dereference in aio_epoll_update
>   aio-posix: simplify aio_epoll_update
> 
>  aio-posix.c                        | 53 +++++++++++++++++---------------------
>  block/io.c                         |  4 ++-
>  tests/qemu-iotests/026.out         | 22 ++++++++++++++++
>  tests/qemu-iotests/026.out.nocache | 22 ++++++++++++++++
>  tests/qemu-iotests/071.out         |  2 ++
>  5 files changed, 73 insertions(+), 30 deletions(-)
> 
> -- 
> 2.7.4
> 
> 

Thanks, applied to my staging tree:
https://github.com/stefanha/qemu/commits/staging

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [Qemu-devel] [PULL 0/3] Block patches
@ 2016-11-08 18:12 Stefan Hajnoczi
  2016-11-09 12:44 ` Stefan Hajnoczi
  0 siblings, 1 reply; 20+ messages in thread
From: Stefan Hajnoczi @ 2016-11-08 18:12 UTC (permalink / raw)
  To: qemu-devel; +Cc: Peter Maydell, Stefan Hajnoczi

The following changes since commit 207faf24c58859f5240f66bf6decc33b87a1776e:

  Merge remote-tracking branch 'pm215/tags/pull-target-arm-20161107' into staging (2016-11-07 14:02:15 +0000)

are available in the git repository at:

  git://github.com/stefanha/qemu.git tags/block-pull-request

for you to fetch changes up to 35dd66e23ce96283723de58e10d2877ae2be4a1b:

  aio-posix: simplify aio_epoll_update (2016-11-08 17:09:14 +0000)

----------------------------------------------------------------

----------------------------------------------------------------

Kevin Wolf (1):
  block: Don't mark node clean after failed flush

Paolo Bonzini (2):
  aio-posix: avoid NULL pointer dereference in aio_epoll_update
  aio-posix: simplify aio_epoll_update

 aio-posix.c                        | 53 +++++++++++++++++---------------------
 block/io.c                         |  4 ++-
 tests/qemu-iotests/026.out         | 22 ++++++++++++++++
 tests/qemu-iotests/026.out.nocache | 22 ++++++++++++++++
 tests/qemu-iotests/071.out         |  2 ++
 5 files changed, 73 insertions(+), 30 deletions(-)

-- 
2.7.4

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [Qemu-devel] [PULL 0/3] Block patches
  2016-04-12  8:30 Stefan Hajnoczi
@ 2016-04-12  9:44 ` Peter Maydell
  0 siblings, 0 replies; 20+ messages in thread
From: Peter Maydell @ 2016-04-12  9:44 UTC (permalink / raw)
  To: Stefan Hajnoczi; +Cc: QEMU Developers

On 12 April 2016 at 09:30, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> The following changes since commit dc1ffa66619b3661f17a309b0aa8d65d8d29583f:
>
>   Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20160411' into staging (2016-04-11 14:37:53 +0100)
>
> are available in the git repository at:
>
>   git://github.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 9ca3003df3c9882925c023c1411ab3b2041d7db5:
>
>   MAINTAINERS: Add Fam Zheng as a co-maintainer of block I/O path (2016-04-11 16:59:10 +0100)
>
> ----------------------------------------------------------------
>
> ----------------------------------------------------------------
>
> Fam Zheng (3):
>   block: Fix bdrv_drain in coroutine
>   mirror: Replace bdrv_drain(bs) with bdrv_co_drain(bs)
>   MAINTAINERS: Add Fam Zheng as a co-maintainer of block I/O path

Applied, thanks.

-- PMM

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [Qemu-devel] [PULL 0/3] Block patches
@ 2016-04-12  8:30 Stefan Hajnoczi
  2016-04-12  9:44 ` Peter Maydell
  0 siblings, 1 reply; 20+ messages in thread
From: Stefan Hajnoczi @ 2016-04-12  8:30 UTC (permalink / raw)
  To: qemu-devel; +Cc: Peter Maydell, Stefan Hajnoczi

The following changes since commit dc1ffa66619b3661f17a309b0aa8d65d8d29583f:

  Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20160411' into staging (2016-04-11 14:37:53 +0100)

are available in the git repository at:

  git://github.com/stefanha/qemu.git tags/block-pull-request

for you to fetch changes up to 9ca3003df3c9882925c023c1411ab3b2041d7db5:

  MAINTAINERS: Add Fam Zheng as a co-maintainer of block I/O path (2016-04-11 16:59:10 +0100)

----------------------------------------------------------------

----------------------------------------------------------------

Fam Zheng (3):
  block: Fix bdrv_drain in coroutine
  mirror: Replace bdrv_drain(bs) with bdrv_co_drain(bs)
  MAINTAINERS: Add Fam Zheng as a co-maintainer of block I/O path

 MAINTAINERS           |  1 +
 block/io.c            | 45 +++++++++++++++++++++++++++++++++++++++++++++
 block/mirror.c        |  2 +-
 include/block/block.h |  1 +
 4 files changed, 48 insertions(+), 1 deletion(-)

-- 
2.5.5

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [Qemu-devel] [PULL 0/3] Block patches
  2016-02-09 15:11 Stefan Hajnoczi
@ 2016-02-09 19:34 ` Peter Maydell
  0 siblings, 0 replies; 20+ messages in thread
From: Peter Maydell @ 2016-02-09 19:34 UTC (permalink / raw)
  To: Stefan Hajnoczi; +Cc: QEMU Developers

On 9 February 2016 at 15:11, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> The following changes since commit ee8e8f92a730afc17ab8be6e86df6b9a23b8ebc6:
>
>   Merge remote-tracking branch 'remotes/amit-migration/tags/migration-for-2.6-2' into staging (2016-02-05 14:20:46 +0000)
>
> are available in the git repository at:
>
>   git://github.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 9dcf8ecd9e74804aa1687e5688386001a1f3f89f:
>
>   block: add missing call to bdrv_drain_recurse (2016-02-09 13:52:26 +0000)
>
> ----------------------------------------------------------------
>
> ----------------------------------------------------------------

Applied, thanks.

-- PMM

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [Qemu-devel] [PULL 0/3] Block patches
@ 2016-02-09 15:11 Stefan Hajnoczi
  2016-02-09 19:34 ` Peter Maydell
  0 siblings, 1 reply; 20+ messages in thread
From: Stefan Hajnoczi @ 2016-02-09 15:11 UTC (permalink / raw)
  To: qemu-devel; +Cc: Peter Maydell, Stefan Hajnoczi

The following changes since commit ee8e8f92a730afc17ab8be6e86df6b9a23b8ebc6:

  Merge remote-tracking branch 'remotes/amit-migration/tags/migration-for-2.6-2' into staging (2016-02-05 14:20:46 +0000)

are available in the git repository at:

  git://github.com/stefanha/qemu.git tags/block-pull-request

for you to fetch changes up to 9dcf8ecd9e74804aa1687e5688386001a1f3f89f:

  block: add missing call to bdrv_drain_recurse (2016-02-09 13:52:26 +0000)

----------------------------------------------------------------

----------------------------------------------------------------

Fam Zheng (1):
  blockjob: Fix hang in block_job_finish_sync

Paolo Bonzini (2):
  iov: avoid memcpy for "simple" iov_from_buf/iov_to_buf
  block: add missing call to bdrv_drain_recurse

 block/io.c               |  1 +
 blockjob.c               |  6 +++++-
 include/block/blockjob.h |  5 +++++
 include/qemu/iov.h       | 34 ++++++++++++++++++++++++++++++----
 util/iov.c               |  8 ++++----
 5 files changed, 45 insertions(+), 9 deletions(-)

-- 
2.5.0

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [Qemu-devel] [PULL 0/3] Block patches
@ 2013-07-05 11:32 Stefan Hajnoczi
  0 siblings, 0 replies; 20+ messages in thread
From: Stefan Hajnoczi @ 2013-07-05 11:32 UTC (permalink / raw)
  To: qemu-devel; +Cc: Anthony Liguori, Stefan Hajnoczi

The following changes since commit ab8bf29078e0ab8347e2ff8b4e5542f7a0c751cf:

  Merge remote-tracking branch 'qemu-kvm/uq/master' into staging (2013-07-03 08:37:00 -0500)

are available in the git repository at:


  git://github.com/stefanha/qemu.git block

for you to fetch changes up to 58fda173e1156d24e5ff62361774715152188a07:

  block: fix bdrv_flush() ordering in bdrv_close() (2013-07-05 10:52:23 +0200)

----------------------------------------------------------------
Fam Zheng (2):
      vmdk: Implement .bdrv_has_zero_init
      curl: refuse to open URL from HTTP server without range support

Stefan Hajnoczi (1):
      block: fix bdrv_flush() ordering in bdrv_close()

 block.c      |  5 +++--
 block/curl.c | 24 ++++++++++++++++++------
 block/vmdk.c | 48 +++++++++++++++++++++++++++++++++---------------
 3 files changed, 54 insertions(+), 23 deletions(-)

-- 
1.8.1.4

^ permalink raw reply	[flat|nested] 20+ messages in thread

end of thread, other threads:[~2019-02-12 12:35 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-24 17:46 [Qemu-devel] [PULL 0/3] Block patches Jeff Cody
2017-02-24 17:46 ` [Qemu-devel] [PULL 1/3] block/nfs: convert to preadv / pwritev Jeff Cody
2017-02-24 17:46 ` [Qemu-devel] [PULL 2/3] block/nfs: try to avoid the bounce buffer in pwritev Jeff Cody
2017-02-24 17:47 ` [Qemu-devel] [PULL 3/3] RBD: Add support readv,writev for rbd Jeff Cody
2017-02-26 12:26 ` [Qemu-devel] [PULL 0/3] Block patches Peter Maydell
  -- strict thread matches above, loose matches on Subject: below --
2019-02-12  4:01 Stefan Hajnoczi
2019-02-12 12:26 ` Peter Maydell
2019-01-24 10:28 Stefan Hajnoczi
2019-01-24 15:38 ` Peter Maydell
2018-07-03  3:46 Jeff Cody
2018-07-03 12:50 ` Peter Maydell
2017-10-13 13:49 Stefan Hajnoczi
2017-10-16 14:54 ` Peter Maydell
2016-11-08 18:12 Stefan Hajnoczi
2016-11-09 12:44 ` Stefan Hajnoczi
2016-04-12  8:30 Stefan Hajnoczi
2016-04-12  9:44 ` Peter Maydell
2016-02-09 15:11 Stefan Hajnoczi
2016-02-09 19:34 ` Peter Maydell
2013-07-05 11:32 Stefan Hajnoczi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).