* [Qemu-devel] [PATCH v4] numa: improve cpu hotplug error message with a wrong node-id
@ 2019-05-29 16:07 Laurent Vivier
2019-05-30 9:00 ` Igor Mammedov
2019-05-31 19:49 ` Eduardo Habkost
0 siblings, 2 replies; 3+ messages in thread
From: Laurent Vivier @ 2019-05-29 16:07 UTC (permalink / raw)
To: qemu-devel
Cc: Peter Maydell, Eduardo Habkost, qemu-arm, qemu-ppc,
Igor Mammedov, David Gibson
On pseries, core-ids are strongly binded to a node-id by the command
line option. If an user tries to add a CPU to the wrong node, he has
an error but it is not really helpful:
qemu-system-ppc64 ... -smp 1,maxcpus=64,cores=1,threads=1,sockets=1 \
-numa node,nodeid=0 -numa node,nodeid=1 ...
(qemu) device_add power9_v2.0-spapr-cpu-core,core-id=30,node-id=1
Error: node-id=1 must match numa node specified with -numa option
This patch improves this error message by giving to the user the good
node-id to use with the core-id he's providing
Error: invalid node-id, must be 0
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
Notes:
v4: simplify the message
v3: only add the topology to the existing message
As suggested by Igor replace
Error: core-id 30 can only be plugged into node-id 0
by
Error: node-id=1 must match numa node specified with -numa option 'node-id 0'
v2: display full topology in the error message
numa.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/numa.c b/numa.c
index 3875e1efda3a..955ec0c830db 100644
--- a/numa.c
+++ b/numa.c
@@ -470,8 +470,8 @@ void numa_cpu_pre_plug(const CPUArchId *slot, DeviceState *dev, Error **errp)
"node-id", errp);
}
} else if (node_id != slot->props.node_id) {
- error_setg(errp, "node-id=%d must match numa node specified "
- "with -numa option", node_id);
+ error_setg(errp, "invalid node-id, must be %"PRId64,
+ slot->props.node_id);
}
}
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v4] numa: improve cpu hotplug error message with a wrong node-id
2019-05-29 16:07 [Qemu-devel] [PATCH v4] numa: improve cpu hotplug error message with a wrong node-id Laurent Vivier
@ 2019-05-30 9:00 ` Igor Mammedov
2019-05-31 19:49 ` Eduardo Habkost
1 sibling, 0 replies; 3+ messages in thread
From: Igor Mammedov @ 2019-05-30 9:00 UTC (permalink / raw)
To: Laurent Vivier
Cc: Peter Maydell, Eduardo Habkost, qemu-devel, qemu-arm, qemu-ppc,
David Gibson
On Wed, 29 May 2019 18:07:47 +0200
Laurent Vivier <lvivier@redhat.com> wrote:
> On pseries, core-ids are strongly binded to a node-id by the command
> line option. If an user tries to add a CPU to the wrong node, he has
> an error but it is not really helpful:
>
> qemu-system-ppc64 ... -smp 1,maxcpus=64,cores=1,threads=1,sockets=1 \
> -numa node,nodeid=0 -numa node,nodeid=1 ...
>
> (qemu) device_add power9_v2.0-spapr-cpu-core,core-id=30,node-id=1
> Error: node-id=1 must match numa node specified with -numa option
>
> This patch improves this error message by giving to the user the good
> node-id to use with the core-id he's providing
>
> Error: invalid node-id, must be 0
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
>
> Notes:
> v4: simplify the message
>
> v3: only add the topology to the existing message
> As suggested by Igor replace
> Error: core-id 30 can only be plugged into node-id 0
> by
> Error: node-id=1 must match numa node specified with -numa option 'node-id 0'
>
> v2: display full topology in the error message
>
> numa.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/numa.c b/numa.c
> index 3875e1efda3a..955ec0c830db 100644
> --- a/numa.c
> +++ b/numa.c
> @@ -470,8 +470,8 @@ void numa_cpu_pre_plug(const CPUArchId *slot, DeviceState *dev, Error **errp)
> "node-id", errp);
> }
> } else if (node_id != slot->props.node_id) {
> - error_setg(errp, "node-id=%d must match numa node specified "
> - "with -numa option", node_id);
> + error_setg(errp, "invalid node-id, must be %"PRId64,
> + slot->props.node_id);
> }
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v4] numa: improve cpu hotplug error message with a wrong node-id
2019-05-29 16:07 [Qemu-devel] [PATCH v4] numa: improve cpu hotplug error message with a wrong node-id Laurent Vivier
2019-05-30 9:00 ` Igor Mammedov
@ 2019-05-31 19:49 ` Eduardo Habkost
1 sibling, 0 replies; 3+ messages in thread
From: Eduardo Habkost @ 2019-05-31 19:49 UTC (permalink / raw)
To: Laurent Vivier
Cc: Peter Maydell, qemu-devel, qemu-arm, qemu-ppc, Igor Mammedov,
David Gibson
On Wed, May 29, 2019 at 06:07:47PM +0200, Laurent Vivier wrote:
> On pseries, core-ids are strongly binded to a node-id by the command
> line option. If an user tries to add a CPU to the wrong node, he has
> an error but it is not really helpful:
>
> qemu-system-ppc64 ... -smp 1,maxcpus=64,cores=1,threads=1,sockets=1 \
> -numa node,nodeid=0 -numa node,nodeid=1 ...
>
> (qemu) device_add power9_v2.0-spapr-cpu-core,core-id=30,node-id=1
> Error: node-id=1 must match numa node specified with -numa option
>
> This patch improves this error message by giving to the user the good
> node-id to use with the core-id he's providing
>
> Error: invalid node-id, must be 0
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Queued, thanks.
--
Eduardo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-31 19:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-29 16:07 [Qemu-devel] [PATCH v4] numa: improve cpu hotplug error message with a wrong node-id Laurent Vivier
2019-05-30 9:00 ` Igor Mammedov
2019-05-31 19:49 ` Eduardo Habkost
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).