* [Qemu-devel] [PATCH] tcg: Fix typos in helper_gvec_sar{8,32,64}v
@ 2019-06-07 18:30 Richard Henderson
2019-06-11 7:40 ` [Qemu-devel] [PATCH] tcg: Fix typos in helper_gvec_sar{8, 32, 64}v Laurent Vivier
0 siblings, 1 reply; 2+ messages in thread
From: Richard Henderson @ 2019-06-07 18:30 UTC (permalink / raw)
To: qemu-devel; +Cc: lvivier
The loop is written with scalars, not vectors.
Use the correct type when incrementing.
Fixes: 5ee5c14cacd
Reported-by: Laurent Vivier <lvivier@redhat.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
accel/tcg/tcg-runtime-gvec.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/accel/tcg/tcg-runtime-gvec.c b/accel/tcg/tcg-runtime-gvec.c
index 3b6052fe97..51cb29ca79 100644
--- a/accel/tcg/tcg-runtime-gvec.c
+++ b/accel/tcg/tcg-runtime-gvec.c
@@ -874,7 +874,7 @@ void HELPER(gvec_sar8v)(void *d, void *a, void *b, uint32_t desc)
intptr_t oprsz = simd_oprsz(desc);
intptr_t i;
- for (i = 0; i < oprsz; i += sizeof(vec8)) {
+ for (i = 0; i < oprsz; i += sizeof(int8_t)) {
uint8_t sh = *(uint8_t *)(b + i) & 7;
*(int8_t *)(d + i) = *(int8_t *)(a + i) >> sh;
}
@@ -898,7 +898,7 @@ void HELPER(gvec_sar32v)(void *d, void *a, void *b, uint32_t desc)
intptr_t oprsz = simd_oprsz(desc);
intptr_t i;
- for (i = 0; i < oprsz; i += sizeof(vec32)) {
+ for (i = 0; i < oprsz; i += sizeof(int32_t)) {
uint8_t sh = *(uint32_t *)(b + i) & 31;
*(int32_t *)(d + i) = *(int32_t *)(a + i) >> sh;
}
@@ -910,7 +910,7 @@ void HELPER(gvec_sar64v)(void *d, void *a, void *b, uint32_t desc)
intptr_t oprsz = simd_oprsz(desc);
intptr_t i;
- for (i = 0; i < oprsz; i += sizeof(vec64)) {
+ for (i = 0; i < oprsz; i += sizeof(int64_t)) {
uint8_t sh = *(uint64_t *)(b + i) & 63;
*(int64_t *)(d + i) = *(int64_t *)(a + i) >> sh;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] tcg: Fix typos in helper_gvec_sar{8, 32, 64}v
2019-06-07 18:30 [Qemu-devel] [PATCH] tcg: Fix typos in helper_gvec_sar{8,32,64}v Richard Henderson
@ 2019-06-11 7:40 ` Laurent Vivier
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Vivier @ 2019-06-11 7:40 UTC (permalink / raw)
To: Richard Henderson, qemu-devel
On 07/06/2019 20:30, Richard Henderson wrote:
> The loop is written with scalars, not vectors.
> Use the correct type when incrementing.
>
> Fixes: 5ee5c14cacd
> Reported-by: Laurent Vivier <lvivier@redhat.com>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> accel/tcg/tcg-runtime-gvec.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/accel/tcg/tcg-runtime-gvec.c b/accel/tcg/tcg-runtime-gvec.c
> index 3b6052fe97..51cb29ca79 100644
> --- a/accel/tcg/tcg-runtime-gvec.c
> +++ b/accel/tcg/tcg-runtime-gvec.c
> @@ -874,7 +874,7 @@ void HELPER(gvec_sar8v)(void *d, void *a, void *b, uint32_t desc)
> intptr_t oprsz = simd_oprsz(desc);
> intptr_t i;
>
> - for (i = 0; i < oprsz; i += sizeof(vec8)) {
> + for (i = 0; i < oprsz; i += sizeof(int8_t)) {
> uint8_t sh = *(uint8_t *)(b + i) & 7;
> *(int8_t *)(d + i) = *(int8_t *)(a + i) >> sh;
> }
> @@ -898,7 +898,7 @@ void HELPER(gvec_sar32v)(void *d, void *a, void *b, uint32_t desc)
> intptr_t oprsz = simd_oprsz(desc);
> intptr_t i;
>
> - for (i = 0; i < oprsz; i += sizeof(vec32)) {
> + for (i = 0; i < oprsz; i += sizeof(int32_t)) {
> uint8_t sh = *(uint32_t *)(b + i) & 31;
> *(int32_t *)(d + i) = *(int32_t *)(a + i) >> sh;
> }
> @@ -910,7 +910,7 @@ void HELPER(gvec_sar64v)(void *d, void *a, void *b, uint32_t desc)
> intptr_t oprsz = simd_oprsz(desc);
> intptr_t i;
>
> - for (i = 0; i < oprsz; i += sizeof(vec64)) {
> + for (i = 0; i < oprsz; i += sizeof(int64_t)) {
> uint8_t sh = *(uint64_t *)(b + i) & 63;
> *(int64_t *)(d + i) = *(int64_t *)(a + i) >> sh;
> }
>
Tested-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-11 7:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-07 18:30 [Qemu-devel] [PATCH] tcg: Fix typos in helper_gvec_sar{8,32,64}v Richard Henderson
2019-06-11 7:40 ` [Qemu-devel] [PATCH] tcg: Fix typos in helper_gvec_sar{8, 32, 64}v Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).