* [Qemu-devel] [PATCH] vfio-common.h: Remove inaccurate comment
@ 2019-06-21 22:01 Fabiano Rosas
2019-06-23 3:09 ` David Gibson
0 siblings, 1 reply; 2+ messages in thread
From: Fabiano Rosas @ 2019-06-21 22:01 UTC (permalink / raw)
To: qemu-devel; +Cc: Alexey Kardashevskiy, Alex Williamson, David Gibson
This is a left-over from "f4ec5e26ed vfio: Add host side DMA window
capabilities", which added support to more than one DMA window.
Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com>
---
include/hw/vfio/vfio-common.h | 5 -----
1 file changed, 5 deletions(-)
diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/vfio-common.h
index a88b69b675..9107bd41c0 100644
--- a/include/hw/vfio/vfio-common.h
+++ b/include/hw/vfio/vfio-common.h
@@ -74,11 +74,6 @@ typedef struct VFIOContainer {
int error;
bool initialized;
unsigned long pgsizes;
- /*
- * This assumes the host IOMMU can support only a single
- * contiguous IOVA window. We may need to generalize that in
- * future
- */
QLIST_HEAD(, VFIOGuestIOMMU) giommu_list;
QLIST_HEAD(, VFIOHostDMAWindow) hostwin_list;
QLIST_HEAD(, VFIOGroup) group_list;
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] vfio-common.h: Remove inaccurate comment
2019-06-21 22:01 [Qemu-devel] [PATCH] vfio-common.h: Remove inaccurate comment Fabiano Rosas
@ 2019-06-23 3:09 ` David Gibson
0 siblings, 0 replies; 2+ messages in thread
From: David Gibson @ 2019-06-23 3:09 UTC (permalink / raw)
To: Fabiano Rosas; +Cc: Alexey Kardashevskiy, Alex Williamson, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 1254 bytes --]
On Fri, Jun 21, 2019 at 07:01:20PM -0300, Fabiano Rosas wrote:
> This is a left-over from "f4ec5e26ed vfio: Add host side DMA window
> capabilities", which added support to more than one DMA window.
>
> Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> include/hw/vfio/vfio-common.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/vfio-common.h
> index a88b69b675..9107bd41c0 100644
> --- a/include/hw/vfio/vfio-common.h
> +++ b/include/hw/vfio/vfio-common.h
> @@ -74,11 +74,6 @@ typedef struct VFIOContainer {
> int error;
> bool initialized;
> unsigned long pgsizes;
> - /*
> - * This assumes the host IOMMU can support only a single
> - * contiguous IOVA window. We may need to generalize that in
> - * future
> - */
> QLIST_HEAD(, VFIOGuestIOMMU) giommu_list;
> QLIST_HEAD(, VFIOHostDMAWindow) hostwin_list;
> QLIST_HEAD(, VFIOGroup) group_list;
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-23 10:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-21 22:01 [Qemu-devel] [PATCH] vfio-common.h: Remove inaccurate comment Fabiano Rosas
2019-06-23 3:09 ` David Gibson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).