From: Sam Eiderman <shmuel.eiderman@oracle.com>
To: kwolf@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org,
mreitz@redhat.com, seabios@seabios.org, kraxel@redhat.com,
kevin@koconnor.net
Cc: liran.alon@oracle.com, shmuel.eiderman@oracle.com,
karl.heubaum@oracle.com, arbel.moshe@oracle.com
Subject: [Qemu-devel] [QEMU] [PATCH v5 2/8] block: Support providing LCHS from user
Date: Wed, 26 Jun 2019 15:39:42 +0300 [thread overview]
Message-ID: <20190626123948.10199-3-shmuel.eiderman@oracle.com> (raw)
In-Reply-To: <20190626123948.10199-1-shmuel.eiderman@oracle.com>
Add logical geometry variables to BlockConf.
A user can now supply "lcyls", "lheads" & "lsecs" for any HD device
that supports CHS ("cyls", "heads", "secs").
These devices include:
* ide-hd
* scsi-hd
* virtio-blk-pci
In future commits we will use the provided LCHS and pass it to the BIOS
through fw_cfg to be supplied using INT13 routines.
Reviewed-by: Karl Heubaum <karl.heubaum@oracle.com>
Reviewed-by: Arbel Moshe <arbel.moshe@oracle.com>
Signed-off-by: Sam Eiderman <shmuel.eiderman@oracle.com>
---
include/hw/block/block.h | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/include/hw/block/block.h b/include/hw/block/block.h
index fd55a30bca..d7246f3862 100644
--- a/include/hw/block/block.h
+++ b/include/hw/block/block.h
@@ -26,6 +26,7 @@ typedef struct BlockConf {
uint32_t discard_granularity;
/* geometry, not all devices use this */
uint32_t cyls, heads, secs;
+ uint32_t lcyls, lheads, lsecs;
OnOffAuto wce;
bool share_rw;
BlockdevOnError rerror;
@@ -65,7 +66,10 @@ static inline unsigned int get_physical_block_exp(BlockConf *conf)
#define DEFINE_BLOCK_CHS_PROPERTIES(_state, _conf) \
DEFINE_PROP_UINT32("cyls", _state, _conf.cyls, 0), \
DEFINE_PROP_UINT32("heads", _state, _conf.heads, 0), \
- DEFINE_PROP_UINT32("secs", _state, _conf.secs, 0)
+ DEFINE_PROP_UINT32("secs", _state, _conf.secs, 0), \
+ DEFINE_PROP_UINT32("lcyls", _state, _conf.lcyls, 0), \
+ DEFINE_PROP_UINT32("lheads", _state, _conf.lheads, 0), \
+ DEFINE_PROP_UINT32("lsecs", _state, _conf.lsecs, 0)
#define DEFINE_BLOCK_ERROR_PROPERTIES(_state, _conf) \
DEFINE_PROP_BLOCKDEV_ON_ERROR("rerror", _state, _conf.rerror, \
--
2.13.3
next prev parent reply other threads:[~2019-06-26 12:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 12:39 [Qemu-devel] [QEMU] [PATCH v5 0/8] Add Qemu to SeaBIOS LCHS interface Sam Eiderman
2019-06-26 12:39 ` [Qemu-devel] [QEMU] [PATCH v5 1/8] block: Refactor macros - fix tabbing Sam Eiderman
2019-06-26 12:39 ` Sam Eiderman [this message]
2019-06-26 12:39 ` [Qemu-devel] [QEMU] [PATCH v5 3/8] bootdevice: Add interface to gather LCHS Sam Eiderman
2019-08-13 18:51 ` Max Reitz
2019-08-22 15:13 ` Sam Eiderman via Qemu-devel
2019-06-26 12:39 ` [Qemu-devel] [QEMU] [PATCH v5 4/8] scsi: Propagate unrealize() callback to scsi-hd Sam Eiderman
2019-08-13 19:06 ` Max Reitz
2019-08-25 13:35 ` Sam Eiderman via Qemu-devel
2019-06-26 12:39 ` [Qemu-devel] [QEMU] [PATCH v5 5/8] bootdevice: Gather LCHS from all relevant devices Sam Eiderman
2019-08-13 19:05 ` Max Reitz
2019-08-25 13:38 ` Sam Eiderman via Qemu-devel
2019-06-26 12:39 ` [Qemu-devel] [QEMU] [PATCH v5 6/8] bootdevice: Refactor get_boot_devices_list Sam Eiderman
2019-06-26 12:39 ` [Qemu-devel] [QEMU] [PATCH v5 7/8] bootdevice: FW_CFG interface for LCHS values Sam Eiderman
2019-06-26 12:39 ` [Qemu-devel] [QEMU] [PATCH v5 8/8] hd-geo-test: Add tests for lchs override Sam Eiderman
2019-07-01 7:41 ` [Qemu-devel] [QEMU] [PATCH v5 0/8] Add Qemu to SeaBIOS LCHS interface Gerd Hoffmann
2019-07-08 17:30 ` Sam Eiderman
2019-07-17 19:03 ` Sam Eiderman
2019-07-17 19:46 ` Kevin Wolf
2019-07-19 10:10 ` Sam Eiderman
2019-07-25 0:47 ` [Qemu-devel] [Qemu-block] " John Snow
2019-07-25 0:50 ` John Snow
2019-07-25 19:42 ` Laszlo Ersek
2019-07-30 11:35 ` Gerd Hoffmann
2019-08-13 19:35 ` [Qemu-devel] " Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190626123948.10199-3-shmuel.eiderman@oracle.com \
--to=shmuel.eiderman@oracle.com \
--cc=arbel.moshe@oracle.com \
--cc=karl.heubaum@oracle.com \
--cc=kevin@koconnor.net \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=liran.alon@oracle.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).